From: Karel Zak <kzak@redhat.com>
To: Stanislav Brabec <sbrabec@suse.cz>
Cc: Lubomir Rintel <lkundrak@v3.sk>, util-linux@vger.kernel.org
Subject: Re: [PATCH v2] agetty: don't put the VC into canonical mode
Date: Mon, 22 Oct 2018 11:23:08 +0200 [thread overview]
Message-ID: <20181022092308.elz37l65mciouoce@ws.net.home> (raw)
In-Reply-To: <b7a4fca3-6ee1-f81d-7db1-0c069cd4e56b@suse.cz>
On Fri, Oct 19, 2018 at 10:08:17PM +0200, Stanislav Brabec wrote:
> This code implements both echo and Backspace processing!
:-) I guess it's the original serial line code...
> Note that the patch works even with less aggressive
> + tp->c_lflag &= ~(ICANON | ECHO | ECHOE | ECHOK | ECHOKE);
> I am not sure whether setting c_lflag to 0 is completely safe.
"It's aggressive" was my first feeling from the patch -- but it seems
there is nothing else in lflags relevant for Linux and agetty and for
serial line we do the same.
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
Thanks guys! I have applied the patch to master branch -- it's not
invasive patch ant it seems important enough for v2.33.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2018-10-22 9:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 6:41 [PATCH v2] agetty: don't put the VC into canonical mode Lubomir Rintel
2018-10-16 7:40 ` Karel Zak
2018-10-18 19:25 ` Stanislav Brabec
2018-10-19 7:53 ` Karel Zak
2018-10-19 6:09 ` Lubomir Rintel
2018-10-19 13:08 ` Stanislav Brabec
2018-10-19 13:48 ` Lubomir Rintel
2018-10-19 20:08 ` Stanislav Brabec
2018-10-22 9:23 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022092308.elz37l65mciouoce@ws.net.home \
--to=kzak@redhat.com \
--cc=lkundrak@v3.sk \
--cc=sbrabec@suse.cz \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.