PSU initialization code on zynqmp platforms

PSU initialization code on zynqmp platforms

[Graeme Smecher]

Hi Michal,

(Well, that's embarassing. Sending again with a useful subject.)

I'm bringing up u-boot on a custom zynqmp platform. For the PSU 
initialization, I can start with the psu_init_gpl.[ch] files embedded in 
the .xsa generated by Vivado. However, these are pretty flawed [1, 2].

What is your workflow for generating and maintaining the in-tree 
psu_init_gpl files you maintain? Are these files cleaned up and 
maintained by hand?

If your workflow is functional, I will happily emulate it instead - even 
if it means straying from Vivado's configuration GUI.

best,
Graeme

1: https://lists.denx.de/pipermail/u-boot/2021-February/439394.html
2: https://support.xilinx.com/s/feed/0D52E00006kuRAMSA2

Re: PSU initialization code on zynqmp platforms

[Michal Simek]

Hi,

On 12/6/22 02:01, Graeme Smecher wrote:
> Hi Michal,
> 
> (Well, that's embarassing. Sending again with a useful subject.)
> 
> I'm bringing up u-boot on a custom zynqmp platform. For the PSU initialization, 
> I can start with the psu_init_gpl.[ch] files embedded in the .xsa generated by 
> Vivado. However, these are pretty flawed [1, 2].
> 
> What is your workflow for generating and maintaining the in-tree psu_init_gpl 
> files you maintain? Are these files cleaned up and maintained by hand?
> 
> If your workflow is functional, I will happily emulate it instead - even if it 
> means straying from Vivado's configuration GUI.

I am just copy psu init files from xsa and copy it somewhere and then run
./tools/zynqmp_psu_init_minimize.sh to minimize it. And then commit and small 
manual cleanups to resolved issues reported by checkpatch.

Thanks,
Michal

Re: PSU initialization code on zynqmp platforms

[Graeme Smecher]

Hi Michal,

On 2022-12-06 02:50, Michal Simek wrote:
> Hi,
> 
> On 12/6/22 02:01, Graeme Smecher wrote:
>> Hi Michal,
>>
>> (Well, that's embarassing. Sending again with a useful subject.)
>>
>> I'm bringing up u-boot on a custom zynqmp platform. For the PSU 
>> initialization, I can start with the psu_init_gpl.[ch] files embedded 
>> in the .xsa generated by Vivado. However, these are pretty flawed [1, 2].
>>
>> What is your workflow for generating and maintaining the in-tree 
>> psu_init_gpl files you maintain? Are these files cleaned up and 
>> maintained by hand?
>>
>> If your workflow is functional, I will happily emulate it instead - 
>> even if it means straying from Vivado's configuration GUI.
> 
> I am just copy psu init files from xsa and copy it somewhere and then run
> ./tools/zynqmp_psu_init_minimize.sh to minimize it. And then commit and 
> small manual cleanups to resolved issues reported by checkpatch.

Thanks - that script is exactly what I needed to plug the gap between 
Vivado and what's in-tree.

best,
Graeme