* [Buildroot] [PATCH] package/{python-}protobuf: bump to version 21.3
@ 2022-07-21 10:47 Michael Nosthoff via buildroot
2022-07-22 22:33 ` Arnout Vandecappelle
2022-07-25 21:22 ` Julien Olivain
0 siblings, 2 replies; 6+ messages in thread
From: Michael Nosthoff via buildroot @ 2022-07-21 10:47 UTC (permalink / raw)
To: buildroot; +Cc: Thomas Petazzoni, Matt Weber, Asaf Kahlon
protobuf changed its versioning scheme [1]. The Release version is now only
the Minor.Patch version of the language specific version.
C++ stays on version 3, but python got bumped to 4. So the handling in the .mk
files changed to reflect that.
[1] https://developers.google.com/protocol-buffers/docs/news/2022-05-06
Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
---
package/protobuf/protobuf.hash | 2 +-
package/protobuf/protobuf.mk | 6 ++++--
package/python-protobuf/python-protobuf.hash | 2 +-
package/python-protobuf/python-protobuf.mk | 3 ++-
4 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/package/protobuf/protobuf.hash b/package/protobuf/protobuf.hash
index f37b2dee40..1006fd3d64 100644
--- a/package/protobuf/protobuf.hash
+++ b/package/protobuf/protobuf.hash
@@ -1,3 +1,3 @@
# Locally calculated
sha256 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d LICENSE
-sha256 dddd73664306d7d895a95e1cf18925b31b52785e468727e4635b45edae5166f9 protobuf-cpp-3.20.1.tar.gz
+sha256 c98a4f17ed57e9e4dafc4a52e76ee012f9a6a13750488b20b4c370a3eb1561fc protobuf-cpp-3.21.3.tar.gz
diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
index c4c33ba7da..5c08421bbc 100644
--- a/package/protobuf/protobuf.mk
+++ b/package/protobuf/protobuf.mk
@@ -7,9 +7,11 @@
# When bumping this package, make sure to also verify if the
# python-protobuf package still works and to update its hash,
# as they share the same version/site variables.
-PROTOBUF_VERSION = 3.20.1
+PROTOBUF_VERSION_MAJOR = 3
+PROTOBUF_VERSION_MINOR = 21.3
+PROTOBUF_VERSION = ${PROTOBUF_VERSION_MAJOR}.${PROTOBUF_VERSION_MINOR}
PROTOBUF_SOURCE = protobuf-cpp-$(PROTOBUF_VERSION).tar.gz
-PROTOBUF_SITE = https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION)
+PROTOBUF_SITE = https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION_MINOR)
PROTOBUF_LICENSE = BSD-3-Clause
PROTOBUF_LICENSE_FILES = LICENSE
PROTOBUF_CPE_ID_VENDOR = google
diff --git a/package/python-protobuf/python-protobuf.hash b/package/python-protobuf/python-protobuf.hash
index ddfa48b491..06ec32c5b5 100644
--- a/package/python-protobuf/python-protobuf.hash
+++ b/package/python-protobuf/python-protobuf.hash
@@ -1,3 +1,3 @@
# Locally calculated
-sha256 d3449b4df32ca155f8cd71051db916b2bf74cc925760e269c0acf09b48ec1cb8 protobuf-python-3.20.1.tar.gz
+sha256 ab5cda843c1fa2a34c5cdd30b65ae8bd148d8063e7f1b2bfe7daf23e763b0ff2 protobuf-python-4.21.3.tar.gz
sha256 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d LICENSE
diff --git a/package/python-protobuf/python-protobuf.mk b/package/python-protobuf/python-protobuf.mk
index b91ba49339..8c21779faf 100644
--- a/package/python-protobuf/python-protobuf.mk
+++ b/package/python-protobuf/python-protobuf.mk
@@ -4,7 +4,8 @@
#
################################################################################
-PYTHON_PROTOBUF_VERSION = $(PROTOBUF_VERSION)
+PYTHON_PROTOBUF_VERSION_MAJOR = 4
+PYTHON_PROTOBUF_VERSION = $(PYTHON_PROTOBUF_VERSION_MAJOR).$(PROTOBUF_VERSION_MINOR)
PYTHON_PROTOBUF_SOURCE = protobuf-python-$(PYTHON_PROTOBUF_VERSION).tar.gz
PYTHON_PROTOBUF_SITE = $(PROTOBUF_SITE)
PYTHON_PROTOBUF_LICENSE = BSD-3-Clause
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/{python-}protobuf: bump to version 21.3
2022-07-21 10:47 [Buildroot] [PATCH] package/{python-}protobuf: bump to version 21.3 Michael Nosthoff via buildroot
@ 2022-07-22 22:33 ` Arnout Vandecappelle
2022-07-24 10:17 ` Michael Nosthoff via buildroot
2022-07-25 21:22 ` Julien Olivain
1 sibling, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2022-07-22 22:33 UTC (permalink / raw)
To: Michael Nosthoff, buildroot; +Cc: Asaf Kahlon, Matt Weber, Thomas Petazzoni
On 21/07/2022 12:47, Michael Nosthoff via buildroot wrote:
> protobuf changed its versioning scheme [1]. The Release version is now only
> the Minor.Patch version of the language specific version.
>
> C++ stays on version 3, but python got bumped to 4. So the handling in the .mk
> files changed to reflect that.
I think that the crazy stuff that was done upstream warrants a bit more
consideration on our side...
They are basically trying to encode two separate things in the version number:
- the version of protobuf itself (i.e. the protocol definition) - this is 21.3;
- the version of the language-specific API - this is 3 for all languages, except
for python where it was bumped to 4 because it has breaking changes in the 21.0
release.
First remark: due to this breaking change, I expect that an update of ola (our
only in-tree consumer of python-protobuf) may be needed as well.
The version of the language-specific API is basically just there to to
indicate breaking changes. In the context of Buildroot, I think it's the protoc
version which is more relevant.
Then there's release-monitoring. For protobuf, it says 21.3. For
python-protobuf, we have a mapping to the same protobuf package [1].
>
> [1] https://developers.google.com/protocol-buffers/docs/news/2022-05-06
>
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> ---
> package/protobuf/protobuf.hash | 2 +-
> package/protobuf/protobuf.mk | 6 ++++--
> package/python-protobuf/python-protobuf.hash | 2 +-
> package/python-protobuf/python-protobuf.mk | 3 ++-
> 4 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/package/protobuf/protobuf.hash b/package/protobuf/protobuf.hash
> index f37b2dee40..1006fd3d64 100644
> --- a/package/protobuf/protobuf.hash
> +++ b/package/protobuf/protobuf.hash
> @@ -1,3 +1,3 @@
> # Locally calculated
> sha256 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d LICENSE
> -sha256 dddd73664306d7d895a95e1cf18925b31b52785e468727e4635b45edae5166f9 protobuf-cpp-3.20.1.tar.gz
> +sha256 c98a4f17ed57e9e4dafc4a52e76ee012f9a6a13750488b20b4c370a3eb1561fc protobuf-cpp-3.21.3.tar.gz
> diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
> index c4c33ba7da..5c08421bbc 100644
> --- a/package/protobuf/protobuf.mk
> +++ b/package/protobuf/protobuf.mk
> @@ -7,9 +7,11 @@
> # When bumping this package, make sure to also verify if the
> # python-protobuf package still works and to update its hash,
> # as they share the same version/site variables.
> -PROTOBUF_VERSION = 3.20.1
> +PROTOBUF_VERSION_MAJOR = 3
> +PROTOBUF_VERSION_MINOR = 21.3
> +PROTOBUF_VERSION = ${PROTOBUF_VERSION_MAJOR}.${PROTOBUF_VERSION_MINOR}
So I think we should set PROTOBUF_VERSION = 21.3.
> PROTOBUF_SOURCE = protobuf-cpp-$(PROTOBUF_VERSION).tar.gz
And change this into
PROTOBUF_SOURCE = protobuf-cpp-3.$(PROTOBUF_VERSION).tar.gz
Note that I don't think it's useful to create a separate variable for the 3.
part. This is the only place where it is going to be used, and even if it would
be the same for python-protobuf, it's better to have it explicit in each binding
instead of in a shared variable.
Regards,
Arnout
[1] https://release-monitoring.org/project/3715/
> -PROTOBUF_SITE = https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION)
> +PROTOBUF_SITE = https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION_MINOR)
> PROTOBUF_LICENSE = BSD-3-Clause
> PROTOBUF_LICENSE_FILES = LICENSE
> PROTOBUF_CPE_ID_VENDOR = google
> diff --git a/package/python-protobuf/python-protobuf.hash b/package/python-protobuf/python-protobuf.hash
> index ddfa48b491..06ec32c5b5 100644
> --- a/package/python-protobuf/python-protobuf.hash
> +++ b/package/python-protobuf/python-protobuf.hash
> @@ -1,3 +1,3 @@
> # Locally calculated
> -sha256 d3449b4df32ca155f8cd71051db916b2bf74cc925760e269c0acf09b48ec1cb8 protobuf-python-3.20.1.tar.gz
> +sha256 ab5cda843c1fa2a34c5cdd30b65ae8bd148d8063e7f1b2bfe7daf23e763b0ff2 protobuf-python-4.21.3.tar.gz
> sha256 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d LICENSE
> diff --git a/package/python-protobuf/python-protobuf.mk b/package/python-protobuf/python-protobuf.mk
> index b91ba49339..8c21779faf 100644
> --- a/package/python-protobuf/python-protobuf.mk
> +++ b/package/python-protobuf/python-protobuf.mk
> @@ -4,7 +4,8 @@
> #
> ################################################################################
>
> -PYTHON_PROTOBUF_VERSION = $(PROTOBUF_VERSION)
> +PYTHON_PROTOBUF_VERSION_MAJOR = 4
> +PYTHON_PROTOBUF_VERSION = $(PYTHON_PROTOBUF_VERSION_MAJOR).$(PROTOBUF_VERSION_MINOR)
> PYTHON_PROTOBUF_SOURCE = protobuf-python-$(PYTHON_PROTOBUF_VERSION).tar.gz
> PYTHON_PROTOBUF_SITE = $(PROTOBUF_SITE)
> PYTHON_PROTOBUF_LICENSE = BSD-3-Clause
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/{python-}protobuf: bump to version 21.3
2022-07-22 22:33 ` Arnout Vandecappelle
@ 2022-07-24 10:17 ` Michael Nosthoff via buildroot
2022-07-24 10:40 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Michael Nosthoff via buildroot @ 2022-07-24 10:17 UTC (permalink / raw)
To: Arnout Vandecappelle, Julien Olivain
Cc: Asaf Kahlon, Matt Weber, Thomas Petazzoni, buildroot
Hi Arnoud,
hi Julien,
(julien, i added you as the ola maintainer as this patch might break it)
On Saturday, July 23, 2022 00:33 CEST, Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
> On 21/07/2022 12:47, Michael Nosthoff via buildroot wrote:
> > protobuf changed its versioning scheme [1]. The Release version is now only
> > the Minor.Patch version of the language specific version.
> >
> > C++ stays on version 3, but python got bumped to 4. So the handling in the .mk
> > files changed to reflect that.
>
> I think that the crazy stuff that was done upstream warrants a bit more
> consideration on our side...
>
> They are basically trying to encode two separate things in the version number:
>
> - the version of protobuf itself (i.e. the protocol definition) - this is 21.3;
>
> - the version of the language-specific API - this is 3 for all languages, except
> for python where it was bumped to 4 because it has breaking changes in the 21.0
> release.
>
> First remark: due to this breaking change, I expect that an update of ola (our
> only in-tree consumer of python-protobuf) may be needed as well.
The "breaking changes" according to
https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates
don't actually sound "too breaking" to me.
I tried compiling ola with the bumped version. But it is beyond my knowledge how to test this.
@Julien could you check if this version bump of python-protobuf affects ola?
>
> The version of the language-specific API is basically just there to to
> indicate breaking changes. In the context of Buildroot, I think it's the protoc
> version which is more relevant.
>
> Then there's release-monitoring. For protobuf, it says 21.3. For
> python-protobuf, we have a mapping to the same protobuf package [1].
>
I'm not quite sure what you mean here. should we got with
PYTHON_PROTOBUF_VERSION = 4.x.x or do the same as with the cpp version and
just add -4. to the SOURCE?
Where do I see the release-monitoring mapping?
>
>
> >
> > [1] https://developers.google.com/protocol-buffers/docs/news/2022-05-06
> >
> > Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> > ---
> > package/protobuf/protobuf.hash | 2 +-
> > package/protobuf/protobuf.mk | 6 ++++--
> > package/python-protobuf/python-protobuf.hash | 2 +-
> > package/python-protobuf/python-protobuf.mk | 3 ++-
> > 4 files changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/package/protobuf/protobuf.hash b/package/protobuf/protobuf.hash
> > index f37b2dee40..1006fd3d64 100644
> > --- a/package/protobuf/protobuf.hash
> > +++ b/package/protobuf/protobuf.hash
> > @@ -1,3 +1,3 @@
> > # Locally calculated
> > sha256 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d LICENSE
> > -sha256 dddd73664306d7d895a95e1cf18925b31b52785e468727e4635b45edae5166f9 protobuf-cpp-3.20.1.tar.gz
> > +sha256 c98a4f17ed57e9e4dafc4a52e76ee012f9a6a13750488b20b4c370a3eb1561fc protobuf-cpp-3.21.3.tar.gz
> > diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
> > index c4c33ba7da..5c08421bbc 100644
> > --- a/package/protobuf/protobuf.mk
> > +++ b/package/protobuf/protobuf.mk
> > @@ -7,9 +7,11 @@
> > # When bumping this package, make sure to also verify if the
> > # python-protobuf package still works and to update its hash,
> > # as they share the same version/site variables.
> > -PROTOBUF_VERSION = 3.20.1
>
> > +PROTOBUF_VERSION_MAJOR = 3
> > +PROTOBUF_VERSION_MINOR = 21.3
> > +PROTOBUF_VERSION = ${PROTOBUF_VERSION_MAJOR}.${PROTOBUF_VERSION_MINOR}
>
> So I think we should set PROTOBUF_VERSION = 21.3.
>
>
> > PROTOBUF_SOURCE = protobuf-cpp-$(PROTOBUF_VERSION).tar.gz
>
> And change this into
> PROTOBUF_SOURCE = protobuf-cpp-3.$(PROTOBUF_VERSION).tar.gz
>
> Note that I don't think it's useful to create a separate variable for the 3.
> part. This is the only place where it is going to be used, and even if it would
> be the same for python-protobuf, it's better to have it explicit in each binding
> instead of in a shared variable.
I'll send a v2 doing that.
>
> Regards,
> Arnout
>
> [1] https://release-monitoring.org/project/3715/
>
> > -PROTOBUF_SITE = https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION)
> > +PROTOBUF_SITE = https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION_MINOR)
> > PROTOBUF_LICENSE = BSD-3-Clause
> > PROTOBUF_LICENSE_FILES = LICENSE
> > PROTOBUF_CPE_ID_VENDOR = google
> > diff --git a/package/python-protobuf/python-protobuf.hash b/package/python-protobuf/python-protobuf.hash
> > index ddfa48b491..06ec32c5b5 100644
> > --- a/package/python-protobuf/python-protobuf.hash
> > +++ b/package/python-protobuf/python-protobuf.hash
> > @@ -1,3 +1,3 @@
> > # Locally calculated
> > -sha256 d3449b4df32ca155f8cd71051db916b2bf74cc925760e269c0acf09b48ec1cb8 protobuf-python-3.20.1.tar.gz
> > +sha256 ab5cda843c1fa2a34c5cdd30b65ae8bd148d8063e7f1b2bfe7daf23e763b0ff2 protobuf-python-4.21.3.tar.gz
> > sha256 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d LICENSE
> > diff --git a/package/python-protobuf/python-protobuf.mk b/package/python-protobuf/python-protobuf.mk
> > index b91ba49339..8c21779faf 100644
> > --- a/package/python-protobuf/python-protobuf.mk
> > +++ b/package/python-protobuf/python-protobuf.mk
> > @@ -4,7 +4,8 @@
> > #
> > ################################################################################
> >
> > -PYTHON_PROTOBUF_VERSION = $(PROTOBUF_VERSION)
> > +PYTHON_PROTOBUF_VERSION_MAJOR = 4
> > +PYTHON_PROTOBUF_VERSION = $(PYTHON_PROTOBUF_VERSION_MAJOR).$(PROTOBUF_VERSION_MINOR)
> > PYTHON_PROTOBUF_SOURCE = protobuf-python-$(PYTHON_PROTOBUF_VERSION).tar.gz
> > PYTHON_PROTOBUF_SITE = $(PROTOBUF_SITE)
> > PYTHON_PROTOBUF_LICENSE = BSD-3-Clause
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/{python-}protobuf: bump to version 21.3
2022-07-24 10:17 ` Michael Nosthoff via buildroot
@ 2022-07-24 10:40 ` Arnout Vandecappelle
0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2022-07-24 10:40 UTC (permalink / raw)
To: Michael Nosthoff, Julien Olivain
Cc: Asaf Kahlon, Matt Weber, Thomas Petazzoni, buildroot
On 24/07/2022 12:17, Michael Nosthoff wrote:
> Hi Arnoud,
> hi Julien,
>
> (julien, i added you as the ola maintainer as this patch might break it)
>
> On Saturday, July 23, 2022 00:33 CEST, Arnout Vandecappelle <arnout@mind.be> wrote:
>
>>
>>
>> On 21/07/2022 12:47, Michael Nosthoff via buildroot wrote:
>>> protobuf changed its versioning scheme [1]. The Release version is now only
>>> the Minor.Patch version of the language specific version.
>>>
>>> C++ stays on version 3, but python got bumped to 4. So the handling in the .mk
>>> files changed to reflect that.
>>
>> I think that the crazy stuff that was done upstream warrants a bit more
>> consideration on our side...
>>
>> They are basically trying to encode two separate things in the version number:
>>
>> - the version of protobuf itself (i.e. the protocol definition) - this is 21.3;
>>
>> - the version of the language-specific API - this is 3 for all languages, except
>> for python where it was bumped to 4 because it has breaking changes in the 21.0
>> release.
>>
>> First remark: due to this breaking change, I expect that an update of ola (our
>> only in-tree consumer of python-protobuf) may be needed as well.
>
> The "breaking changes" according to
> https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates
> don't actually sound "too breaking" to me.
>
> I tried compiling ola with the bumped version. But it is beyond my knowledge how to test this.
> @Julien could you check if this version bump of python-protobuf affects ola?
A runtime test for ola would be nice!
>
>>
>> The version of the language-specific API is basically just there to to
>> indicate breaking changes. In the context of Buildroot, I think it's the protoc
>> version which is more relevant.
>>
>> Then there's release-monitoring. For protobuf, it says 21.3. For
>> python-protobuf, we have a mapping to the same protobuf package [1].
>>
> I'm not quite sure what you mean here. should we got with
> PYTHON_PROTOBUF_VERSION = 4.x.x or do the same as with the cpp version and
> just add -4. to the SOURCE?
Yes, that's what I meant, prepend the 4. in the SOURCE definition.
> Where do I see the release-monitoring mapping?
The URL that I referred to before:
[snip]
>> [1] https://release-monitoring.org/project/3715/
Regards,
Arnout
>>
>>> -PROTOBUF_SITE = https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION)
>>> +PROTOBUF_SITE = https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION_MINOR)
>>> PROTOBUF_LICENSE = BSD-3-Clause
>>> PROTOBUF_LICENSE_FILES = LICENSE
>>> PROTOBUF_CPE_ID_VENDOR = google
>>> diff --git a/package/python-protobuf/python-protobuf.hash b/package/python-protobuf/python-protobuf.hash
>>> index ddfa48b491..06ec32c5b5 100644
>>> --- a/package/python-protobuf/python-protobuf.hash
>>> +++ b/package/python-protobuf/python-protobuf.hash
>>> @@ -1,3 +1,3 @@
>>> # Locally calculated
>>> -sha256 d3449b4df32ca155f8cd71051db916b2bf74cc925760e269c0acf09b48ec1cb8 protobuf-python-3.20.1.tar.gz
>>> +sha256 ab5cda843c1fa2a34c5cdd30b65ae8bd148d8063e7f1b2bfe7daf23e763b0ff2 protobuf-python-4.21.3.tar.gz
>>> sha256 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d LICENSE
>>> diff --git a/package/python-protobuf/python-protobuf.mk b/package/python-protobuf/python-protobuf.mk
>>> index b91ba49339..8c21779faf 100644
>>> --- a/package/python-protobuf/python-protobuf.mk
>>> +++ b/package/python-protobuf/python-protobuf.mk
>>> @@ -4,7 +4,8 @@
>>> #
>>> ################################################################################
>>>
>>> -PYTHON_PROTOBUF_VERSION = $(PROTOBUF_VERSION)
>>> +PYTHON_PROTOBUF_VERSION_MAJOR = 4
>>> +PYTHON_PROTOBUF_VERSION = $(PYTHON_PROTOBUF_VERSION_MAJOR).$(PROTOBUF_VERSION_MINOR)
>>> PYTHON_PROTOBUF_SOURCE = protobuf-python-$(PYTHON_PROTOBUF_VERSION).tar.gz
>>> PYTHON_PROTOBUF_SITE = $(PROTOBUF_SITE)
>>> PYTHON_PROTOBUF_LICENSE = BSD-3-Clause
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/{python-}protobuf: bump to version 21.3
2022-07-21 10:47 [Buildroot] [PATCH] package/{python-}protobuf: bump to version 21.3 Michael Nosthoff via buildroot
2022-07-22 22:33 ` Arnout Vandecappelle
@ 2022-07-25 21:22 ` Julien Olivain
2022-07-27 7:08 ` Michael Nosthoff via buildroot
1 sibling, 1 reply; 6+ messages in thread
From: Julien Olivain @ 2022-07-25 21:22 UTC (permalink / raw)
To: Michael Nosthoff; +Cc: Asaf Kahlon, Matt Weber, Thomas Petazzoni, buildroot
Hi Michael, All,
I successfully runtime-tested this patch in qemu_aarch64_virt_defconfig
with
ola client commands and Python3 RDM discovery. I'll try to make a
runtime
test for this.
On 21/07/2022 12:47, Michael Nosthoff via buildroot wrote:
> protobuf changed its versioning scheme [1]. The Release version is now
> only
> the Minor.Patch version of the language specific version.
>
> C++ stays on version 3, but python got bumped to 4. So the handling in
> the .mk
> files changed to reflect that.
>
> [1] https://developers.google.com/protocol-buffers/docs/news/2022-05-06
>
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
Tested-by: Julien Olivain <ju.o@free.fr>
> ---
> package/protobuf/protobuf.hash | 2 +-
> package/protobuf/protobuf.mk | 6 ++++--
> package/python-protobuf/python-protobuf.hash | 2 +-
> package/python-protobuf/python-protobuf.mk | 3 ++-
> 4 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/package/protobuf/protobuf.hash
> b/package/protobuf/protobuf.hash
> index f37b2dee40..1006fd3d64 100644
> --- a/package/protobuf/protobuf.hash
> +++ b/package/protobuf/protobuf.hash
> @@ -1,3 +1,3 @@
> # Locally calculated
> sha256
> 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d
> LICENSE
> -sha256
> dddd73664306d7d895a95e1cf18925b31b52785e468727e4635b45edae5166f9
> protobuf-cpp-3.20.1.tar.gz
> +sha256
> c98a4f17ed57e9e4dafc4a52e76ee012f9a6a13750488b20b4c370a3eb1561fc
> protobuf-cpp-3.21.3.tar.gz
> diff --git a/package/protobuf/protobuf.mk
> b/package/protobuf/protobuf.mk
> index c4c33ba7da..5c08421bbc 100644
> --- a/package/protobuf/protobuf.mk
> +++ b/package/protobuf/protobuf.mk
> @@ -7,9 +7,11 @@
> # When bumping this package, make sure to also verify if the
> # python-protobuf package still works and to update its hash,
> # as they share the same version/site variables.
> -PROTOBUF_VERSION = 3.20.1
> +PROTOBUF_VERSION_MAJOR = 3
> +PROTOBUF_VERSION_MINOR = 21.3
> +PROTOBUF_VERSION = ${PROTOBUF_VERSION_MAJOR}.${PROTOBUF_VERSION_MINOR}
> PROTOBUF_SOURCE = protobuf-cpp-$(PROTOBUF_VERSION).tar.gz
> -PROTOBUF_SITE =
> https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION)
> +PROTOBUF_SITE =
> https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION_MINOR)
> PROTOBUF_LICENSE = BSD-3-Clause
> PROTOBUF_LICENSE_FILES = LICENSE
> PROTOBUF_CPE_ID_VENDOR = google
> diff --git a/package/python-protobuf/python-protobuf.hash
> b/package/python-protobuf/python-protobuf.hash
> index ddfa48b491..06ec32c5b5 100644
> --- a/package/python-protobuf/python-protobuf.hash
> +++ b/package/python-protobuf/python-protobuf.hash
> @@ -1,3 +1,3 @@
> # Locally calculated
> -sha256
> d3449b4df32ca155f8cd71051db916b2bf74cc925760e269c0acf09b48ec1cb8
> protobuf-python-3.20.1.tar.gz
> +sha256
> ab5cda843c1fa2a34c5cdd30b65ae8bd148d8063e7f1b2bfe7daf23e763b0ff2
> protobuf-python-4.21.3.tar.gz
> sha256
> 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d
> LICENSE
> diff --git a/package/python-protobuf/python-protobuf.mk
> b/package/python-protobuf/python-protobuf.mk
> index b91ba49339..8c21779faf 100644
> --- a/package/python-protobuf/python-protobuf.mk
> +++ b/package/python-protobuf/python-protobuf.mk
> @@ -4,7 +4,8 @@
> #
>
> ################################################################################
>
> -PYTHON_PROTOBUF_VERSION = $(PROTOBUF_VERSION)
> +PYTHON_PROTOBUF_VERSION_MAJOR = 4
> +PYTHON_PROTOBUF_VERSION =
> $(PYTHON_PROTOBUF_VERSION_MAJOR).$(PROTOBUF_VERSION_MINOR)
> PYTHON_PROTOBUF_SOURCE =
> protobuf-python-$(PYTHON_PROTOBUF_VERSION).tar.gz
> PYTHON_PROTOBUF_SITE = $(PROTOBUF_SITE)
> PYTHON_PROTOBUF_LICENSE = BSD-3-Clause
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Best regards,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/{python-}protobuf: bump to version 21.3
2022-07-25 21:22 ` Julien Olivain
@ 2022-07-27 7:08 ` Michael Nosthoff via buildroot
0 siblings, 0 replies; 6+ messages in thread
From: Michael Nosthoff via buildroot @ 2022-07-27 7:08 UTC (permalink / raw)
To: Julien Olivain; +Cc: Asaf Kahlon, Matt Weber, Thomas Petazzoni, buildroot
Hi Julien,
On Monday, July 25, 2022 23:22 CEST, Julien Olivain <ju.o@free.fr> wrote:
>
> Hi Michael, All,
>
> I successfully runtime-tested this patch in qemu_aarch64_virt_defconfig
> with
> ola client commands and Python3 RDM discovery. I'll try to make a
> runtime
> test for this.
>
> On 21/07/2022 12:47, Michael Nosthoff via buildroot wrote:
> > protobuf changed its versioning scheme [1]. The Release version is now
> > only
> > the Minor.Patch version of the language specific version.
> >
> > C++ stays on version 3, but python got bumped to 4. So the handling in
> > the .mk
> > files changed to reflect that.
> >
> > [1] https://developers.google.com/protocol-buffers/docs/news/2022-05-06
> >
> > Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
>
> Tested-by: Julien Olivain <ju.o@free.fr>
great, thank you.
I'll add your tag to the v2.
Regards,
Michael
>
> > ---
> > package/protobuf/protobuf.hash | 2 +-
> > package/protobuf/protobuf.mk | 6 ++++--
> > package/python-protobuf/python-protobuf.hash | 2 +-
> > package/python-protobuf/python-protobuf.mk | 3 ++-
> > 4 files changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/package/protobuf/protobuf.hash
> > b/package/protobuf/protobuf.hash
> > index f37b2dee40..1006fd3d64 100644
> > --- a/package/protobuf/protobuf.hash
> > +++ b/package/protobuf/protobuf.hash
> > @@ -1,3 +1,3 @@
> > # Locally calculated
> > sha256
> > 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d
> > LICENSE
> > -sha256
> > dddd73664306d7d895a95e1cf18925b31b52785e468727e4635b45edae5166f9
> > protobuf-cpp-3.20.1.tar.gz
> > +sha256
> > c98a4f17ed57e9e4dafc4a52e76ee012f9a6a13750488b20b4c370a3eb1561fc
> > protobuf-cpp-3.21.3.tar.gz
> > diff --git a/package/protobuf/protobuf.mk
> > b/package/protobuf/protobuf.mk
> > index c4c33ba7da..5c08421bbc 100644
> > --- a/package/protobuf/protobuf.mk
> > +++ b/package/protobuf/protobuf.mk
> > @@ -7,9 +7,11 @@
> > # When bumping this package, make sure to also verify if the
> > # python-protobuf package still works and to update its hash,
> > # as they share the same version/site variables.
> > -PROTOBUF_VERSION = 3.20.1
> > +PROTOBUF_VERSION_MAJOR = 3
> > +PROTOBUF_VERSION_MINOR = 21.3
> > +PROTOBUF_VERSION = ${PROTOBUF_VERSION_MAJOR}.${PROTOBUF_VERSION_MINOR}
> > PROTOBUF_SOURCE = protobuf-cpp-$(PROTOBUF_VERSION).tar.gz
> > -PROTOBUF_SITE =
> > https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION)
> > +PROTOBUF_SITE =
> > https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION_MINOR)
> > PROTOBUF_LICENSE = BSD-3-Clause
> > PROTOBUF_LICENSE_FILES = LICENSE
> > PROTOBUF_CPE_ID_VENDOR = google
> > diff --git a/package/python-protobuf/python-protobuf.hash
> > b/package/python-protobuf/python-protobuf.hash
> > index ddfa48b491..06ec32c5b5 100644
> > --- a/package/python-protobuf/python-protobuf.hash
> > +++ b/package/python-protobuf/python-protobuf.hash
> > @@ -1,3 +1,3 @@
> > # Locally calculated
> > -sha256
> > d3449b4df32ca155f8cd71051db916b2bf74cc925760e269c0acf09b48ec1cb8
> > protobuf-python-3.20.1.tar.gz
> > +sha256
> > ab5cda843c1fa2a34c5cdd30b65ae8bd148d8063e7f1b2bfe7daf23e763b0ff2
> > protobuf-python-4.21.3.tar.gz
> > sha256
> > 6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d
> > LICENSE
> > diff --git a/package/python-protobuf/python-protobuf.mk
> > b/package/python-protobuf/python-protobuf.mk
> > index b91ba49339..8c21779faf 100644
> > --- a/package/python-protobuf/python-protobuf.mk
> > +++ b/package/python-protobuf/python-protobuf.mk
> > @@ -4,7 +4,8 @@
> > #
> >
> > ################################################################################
> >
> > -PYTHON_PROTOBUF_VERSION = $(PROTOBUF_VERSION)
> > +PYTHON_PROTOBUF_VERSION_MAJOR = 4
> > +PYTHON_PROTOBUF_VERSION =
> > $(PYTHON_PROTOBUF_VERSION_MAJOR).$(PROTOBUF_VERSION_MINOR)
> > PYTHON_PROTOBUF_SOURCE =
> > protobuf-python-$(PYTHON_PROTOBUF_VERSION).tar.gz
> > PYTHON_PROTOBUF_SITE = $(PROTOBUF_SITE)
> > PYTHON_PROTOBUF_LICENSE = BSD-3-Clause
> > --
> > 2.25.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> Best regards,
>
> Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-27 7:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-21 10:47 [Buildroot] [PATCH] package/{python-}protobuf: bump to version 21.3 Michael Nosthoff via buildroot
2022-07-22 22:33 ` Arnout Vandecappelle
2022-07-24 10:17 ` Michael Nosthoff via buildroot
2022-07-24 10:40 ` Arnout Vandecappelle
2022-07-25 21:22 ` Julien Olivain
2022-07-27 7:08 ` Michael Nosthoff via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.