From: Alex Belits <abelits@marvell.com> To: "nitesh@redhat.com" <nitesh@redhat.com>, "frederic@kernel.org" <frederic@kernel.org> Cc: Prasun Kapoor <pkapoor@marvell.com>, "linux-api@vger.kernel.org" <linux-api@vger.kernel.org>, "davem@davemloft.net" <davem@davemloft.net>, "trix@redhat.com" <trix@redhat.com>, "mingo@kernel.org" <mingo@kernel.org>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "rostedt@goodmis.org" <rostedt@goodmis.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "peterx@redhat.com" <peterx@redhat.com>, "tglx@linutronix.de" <tglx@linutronix.de>, "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>, "mtosatti@redhat.com" <mtosatti@redhat.com>, "will@kernel.org" <will@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>, "leon@sidebranch.com" <leon@sidebranch.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "pauld@redhat.com" <pauld@redhat.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org> Subject: [PATCH v5 1/9] task_isolation: vmstat: add quiet_vmstat_sync function Date: Mon, 23 Nov 2020 17:56:01 +0000 [thread overview] Message-ID: <0e07e5bf6f65dc89d263683c81b4a19bcc6d4b60.camel@marvell.com> (raw) In-Reply-To: <8d887e59ca713726f4fcb25a316e1e932b02823e.camel@marvell.com> From: Chris Metcalf <cmetcalf@mellanox.com> In commit f01f17d3705b ("mm, vmstat: make quiet_vmstat lighter") the quiet_vmstat() function became asynchronous, in the sense that the vmstat work was still scheduled to run on the core when the function returned. For task isolation, we need a synchronous version of the function that guarantees that the vmstat worker will not run on the core on return from the function. Add a quiet_vmstat_sync() function with that semantic. Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com> Signed-off-by: Alex Belits <abelits@marvell.com> --- include/linux/vmstat.h | 2 ++ mm/vmstat.c | 9 +++++++++ 2 files changed, 11 insertions(+) diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h index 322dcbfcc933..300ce6648923 100644 --- a/include/linux/vmstat.h +++ b/include/linux/vmstat.h @@ -284,6 +284,7 @@ extern void __dec_zone_state(struct zone *, enum zone_stat_item); extern void __dec_node_state(struct pglist_data *, enum node_stat_item); void quiet_vmstat(void); +void quiet_vmstat_sync(void); void cpu_vm_stats_fold(int cpu); void refresh_zone_stat_thresholds(void); @@ -391,6 +392,7 @@ static inline void __dec_node_page_state(struct page *page, static inline void refresh_zone_stat_thresholds(void) { } static inline void cpu_vm_stats_fold(int cpu) { } static inline void quiet_vmstat(void) { } +static inline void quiet_vmstat_sync(void) { } static inline void drain_zonestat(struct zone *zone, struct per_cpu_pageset *pset) { } diff --git a/mm/vmstat.c b/mm/vmstat.c index 698bc0bc18d1..43999caf47a4 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1936,6 +1936,15 @@ void quiet_vmstat(void) refresh_cpu_vm_stats(false); } +/* + * Synchronously quiet vmstat so the work is guaranteed not to run on return. + */ +void quiet_vmstat_sync(void) +{ + cancel_delayed_work_sync(this_cpu_ptr(&vmstat_work)); + refresh_cpu_vm_stats(false); +} + /* * Shepherd worker thread that checks the * differentials of processors that have their worker -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Alex Belits <abelits@marvell.com> To: "nitesh@redhat.com" <nitesh@redhat.com>, "frederic@kernel.org" <frederic@kernel.org> Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>, "pauld@redhat.com" <pauld@redhat.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "peterz@infradead.org" <peterz@infradead.org>, Prasun Kapoor <pkapoor@marvell.com>, "mtosatti@redhat.com" <mtosatti@redhat.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "rostedt@goodmis.org" <rostedt@goodmis.org>, "davem@davemloft.net" <davem@davemloft.net>, "leon@sidebranch.com" <leon@sidebranch.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "peterx@redhat.com" <peterx@redhat.com>, "trix@redhat.com" <trix@redhat.com>, "tglx@linutronix.de" <tglx@linutronix.de>, "linux-api@vger.kernel.org" <linux-api@vger.kernel.org>, "will@kernel.org" <will@kernel.org>, "mingo@kernel.org" <mingo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: [PATCH v5 1/9] task_isolation: vmstat: add quiet_vmstat_sync function Date: Mon, 23 Nov 2020 17:56:01 +0000 [thread overview] Message-ID: <0e07e5bf6f65dc89d263683c81b4a19bcc6d4b60.camel@marvell.com> (raw) In-Reply-To: <8d887e59ca713726f4fcb25a316e1e932b02823e.camel@marvell.com> From: Chris Metcalf <cmetcalf@mellanox.com> In commit f01f17d3705b ("mm, vmstat: make quiet_vmstat lighter") the quiet_vmstat() function became asynchronous, in the sense that the vmstat work was still scheduled to run on the core when the function returned. For task isolation, we need a synchronous version of the function that guarantees that the vmstat worker will not run on the core on return from the function. Add a quiet_vmstat_sync() function with that semantic. Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com> Signed-off-by: Alex Belits <abelits@marvell.com> --- include/linux/vmstat.h | 2 ++ mm/vmstat.c | 9 +++++++++ 2 files changed, 11 insertions(+) diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h index 322dcbfcc933..300ce6648923 100644 --- a/include/linux/vmstat.h +++ b/include/linux/vmstat.h @@ -284,6 +284,7 @@ extern void __dec_zone_state(struct zone *, enum zone_stat_item); extern void __dec_node_state(struct pglist_data *, enum node_stat_item); void quiet_vmstat(void); +void quiet_vmstat_sync(void); void cpu_vm_stats_fold(int cpu); void refresh_zone_stat_thresholds(void); @@ -391,6 +392,7 @@ static inline void __dec_node_page_state(struct page *page, static inline void refresh_zone_stat_thresholds(void) { } static inline void cpu_vm_stats_fold(int cpu) { } static inline void quiet_vmstat(void) { } +static inline void quiet_vmstat_sync(void) { } static inline void drain_zonestat(struct zone *zone, struct per_cpu_pageset *pset) { } diff --git a/mm/vmstat.c b/mm/vmstat.c index 698bc0bc18d1..43999caf47a4 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1936,6 +1936,15 @@ void quiet_vmstat(void) refresh_cpu_vm_stats(false); } +/* + * Synchronously quiet vmstat so the work is guaranteed not to run on return. + */ +void quiet_vmstat_sync(void) +{ + cancel_delayed_work_sync(this_cpu_ptr(&vmstat_work)); + refresh_cpu_vm_stats(false); +} + /* * Shepherd worker thread that checks the * differentials of processors that have their worker -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-23 17:56 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-23 17:42 [PATCH v5 0/9] "Task_isolation" mode Alex Belits 2020-11-23 17:42 ` Alex Belits 2020-11-23 17:56 ` Alex Belits [this message] 2020-11-23 17:56 ` [PATCH v5 1/9] task_isolation: vmstat: add quiet_vmstat_sync function Alex Belits 2020-11-23 21:48 ` Thomas Gleixner 2020-11-23 21:48 ` Thomas Gleixner 2020-11-23 17:56 ` [PATCH v5 2/9] task_isolation: vmstat: add vmstat_idle function Alex Belits 2020-11-23 17:56 ` Alex Belits 2020-11-23 21:49 ` Thomas Gleixner 2020-11-23 21:49 ` Thomas Gleixner 2020-11-23 17:56 ` [PATCH v5 3/9] task_isolation: userspace hard isolation from kernel Alex Belits 2020-11-23 17:56 ` Alex Belits 2020-11-23 22:01 ` Thomas Gleixner 2020-11-23 22:01 ` Thomas Gleixner 2020-11-23 17:57 ` [PATCH v5 4/9] task_isolation: Add task isolation hooks to arch-independent code Alex Belits 2020-11-23 17:57 ` Alex Belits 2020-11-23 22:31 ` Thomas Gleixner 2020-11-23 22:31 ` Thomas Gleixner 2020-11-23 17:57 ` [PATCH v5 5/9] task_isolation: Add driver-specific hooks Alex Belits 2020-11-23 17:57 ` Alex Belits 2020-12-02 14:18 ` Mark Rutland 2020-12-02 14:18 ` Mark Rutland 2020-12-04 0:43 ` [EXT] " Alex Belits 2020-12-04 0:43 ` Alex Belits 2020-11-23 17:58 ` [PATCH v5 6/9] task_isolation: arch/arm64: enable task isolation functionality Alex Belits 2020-11-23 17:58 ` Alex Belits 2020-12-02 13:59 ` Mark Rutland 2020-12-02 13:59 ` Mark Rutland 2020-12-04 0:37 ` [EXT] " Alex Belits 2020-12-04 0:37 ` Alex Belits 2020-12-07 11:57 ` Mark Rutland 2020-12-07 11:57 ` Mark Rutland 2020-11-23 17:58 ` [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu() Alex Belits 2020-11-23 17:58 ` Alex Belits 2020-11-23 22:13 ` Frederic Weisbecker 2020-11-23 22:13 ` Frederic Weisbecker 2020-11-23 22:35 ` Alex Belits 2020-11-23 22:35 ` Alex Belits 2020-11-23 22:36 ` Thomas Gleixner 2020-11-23 22:36 ` Thomas Gleixner 2020-12-02 14:20 ` Mark Rutland 2020-12-02 14:20 ` Mark Rutland 2020-12-04 0:54 ` [EXT] " Alex Belits 2020-12-04 0:54 ` Alex Belits 2020-12-07 11:58 ` Mark Rutland 2020-12-07 11:58 ` Mark Rutland 2020-11-23 17:58 ` [PATCH v5 8/9] task_isolation: ringbuffer: don't interrupt CPUs running isolated tasks on buffer resize Alex Belits 2020-11-23 17:58 ` Alex Belits 2020-11-23 17:58 ` [PATCH v5 9/9] task_isolation: kick_all_cpus_sync: don't kick isolated cpus Alex Belits 2020-11-23 17:58 ` Alex Belits 2020-11-23 22:29 ` Frederic Weisbecker 2020-11-23 22:29 ` Frederic Weisbecker 2020-11-23 22:39 ` [EXT] " Alex Belits 2020-11-23 22:39 ` Alex Belits 2020-11-23 23:21 ` Frederic Weisbecker 2020-11-23 23:21 ` Frederic Weisbecker 2020-11-25 3:20 ` Alex Belits 2020-11-25 3:20 ` Alex Belits 2021-01-22 15:00 ` Marcelo Tosatti 2021-01-22 15:00 ` Marcelo Tosatti 2020-11-24 16:36 ` [PATCH v5 0/9] "Task_isolation" mode Tom Rix 2020-11-24 16:36 ` Tom Rix 2020-11-24 17:40 ` [EXT] " Alex Belits 2020-11-24 17:40 ` Alex Belits 2020-12-02 14:02 ` Mark Rutland 2020-12-02 14:02 ` Mark Rutland 2020-12-04 0:39 ` Alex Belits 2020-12-04 0:39 ` Alex Belits 2020-12-05 20:40 ` Pavel Machek 2020-12-05 20:40 ` Pavel Machek 2020-12-05 23:25 ` Thomas Gleixner 2020-12-05 23:25 ` Thomas Gleixner 2020-12-11 18:08 ` Yury Norov 2020-12-11 18:08 ` Yury Norov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0e07e5bf6f65dc89d263683c81b4a19bcc6d4b60.camel@marvell.com \ --to=abelits@marvell.com \ --cc=catalin.marinas@arm.com \ --cc=davem@davemloft.net \ --cc=frederic@kernel.org \ --cc=leon@sidebranch.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=mtosatti@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=nitesh@redhat.com \ --cc=pauld@redhat.com \ --cc=peterx@redhat.com \ --cc=peterz@infradead.org \ --cc=pkapoor@marvell.com \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=trix@redhat.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.