From: Scott Schafer <schaferjscott@gmail.com> To: gregkh@linuxfoundation.org Cc: Scott Schafer <schaferjscott@gmail.com>, Manish Chopra <manishc@marvell.com>, GR-Linux-NIC-Dev@marvell.com, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 07/23] staging: qlge: Fix WARNING: quoted string split across lines Date: Wed, 11 Dec 2019 12:12:36 -0600 [thread overview] Message-ID: <0e1f9c5182a909bfe534f7f2d6f93c3e65862d48.1576086080.git.schaferjscott@gmail.com> (raw) In-Reply-To: <cover.1576086080.git.schaferjscott@gmail.com> Fix WARNING: quoted string split across lines in the following files: qlge_dbg.c qlge_main.c Signed-off-by: Scott Schafer <schaferjscott@gmail.com> --- drivers/staging/qlge/qlge_dbg.c | 19 +++++++++---------- drivers/staging/qlge/qlge_main.c | 13 ++++++------- 2 files changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index 6b740a712943..1d4de39a2a70 100644 --- a/drivers/staging/qlge/qlge_dbg.c +++ b/drivers/staging/qlge/qlge_dbg.c @@ -1331,16 +1331,15 @@ void ql_mpi_core_to_log(struct work_struct *work) "Core is dumping to log file!\n"); for (i = 0; i < count; i += 8) { - pr_err("%.08x: %.08x %.08x %.08x %.08x %.08x " - "%.08x %.08x %.08x\n", i, - tmp[i + 0], - tmp[i + 1], - tmp[i + 2], - tmp[i + 3], - tmp[i + 4], - tmp[i + 5], - tmp[i + 6], - tmp[i + 7]); + pr_err("%.08x: %.08x %.08x %.08x %.08x %.08x %.08x %.08x %.08x\n", i, + tmp[i + 0], + tmp[i + 1], + tmp[i + 2], + tmp[i + 3], + tmp[i + 4], + tmp[i + 5], + tmp[i + 6], + tmp[i + 7]); msleep(5); } } diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index f5cc235e9854..a103d491bbb1 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -2095,9 +2095,9 @@ static void ql_process_chip_ae_intr(struct ql_adapter *qdev, break; case PCI_ERR_ANON_BUF_RD: - netdev_err(qdev->ndev, "PCI error occurred when reading " - "anonymous buffers from rx_ring %d.\n", - ib_ae_rsp->q_id); + netdev_err(qdev->ndev, + "PCI error occurred when reading anonymous buffers from rx_ring %d.\n", + ib_ae_rsp->q_id); ql_queue_asic_error(qdev); break; @@ -2428,8 +2428,8 @@ static irqreturn_t qlge_isr(int irq, void *dev_id) ql_queue_asic_error(qdev); netdev_err(qdev->ndev, "Got fatal error, STS = %x.\n", var); var = ql_read32(qdev, ERR_STS); - netdev_err(qdev->ndev, "Resetting chip. " - "Error Status Register = 0x%x\n", var); + netdev_err(qdev->ndev, "Resetting chip. Error Status Register = 0x%x\n", + var); return IRQ_HANDLED; } @@ -3749,8 +3749,7 @@ static void ql_display_dev_info(struct net_device *ndev) struct ql_adapter *qdev = netdev_priv(ndev); netif_info(qdev, probe, qdev->ndev, - "Function #%d, Port %d, NIC Roll %d, NIC Rev = %d, " - "XG Roll = %d, XG Rev = %d.\n", + "Function #%d, Port %d, NIC Roll %d, NIC Rev = %d, XG Roll = %d, XG Rev = %d.\n", qdev->func, qdev->port, qdev->chip_rev_id & 0x0000000f, -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Scott Schafer <schaferjscott@gmail.com> To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, GR-Linux-NIC-Dev@marvell.com, Manish Chopra <manishc@marvell.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Scott Schafer <schaferjscott@gmail.com> Subject: [PATCH v2 07/23] staging: qlge: Fix WARNING: quoted string split across lines Date: Wed, 11 Dec 2019 12:12:36 -0600 [thread overview] Message-ID: <0e1f9c5182a909bfe534f7f2d6f93c3e65862d48.1576086080.git.schaferjscott@gmail.com> (raw) In-Reply-To: <cover.1576086080.git.schaferjscott@gmail.com> Fix WARNING: quoted string split across lines in the following files: qlge_dbg.c qlge_main.c Signed-off-by: Scott Schafer <schaferjscott@gmail.com> --- drivers/staging/qlge/qlge_dbg.c | 19 +++++++++---------- drivers/staging/qlge/qlge_main.c | 13 ++++++------- 2 files changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index 6b740a712943..1d4de39a2a70 100644 --- a/drivers/staging/qlge/qlge_dbg.c +++ b/drivers/staging/qlge/qlge_dbg.c @@ -1331,16 +1331,15 @@ void ql_mpi_core_to_log(struct work_struct *work) "Core is dumping to log file!\n"); for (i = 0; i < count; i += 8) { - pr_err("%.08x: %.08x %.08x %.08x %.08x %.08x " - "%.08x %.08x %.08x\n", i, - tmp[i + 0], - tmp[i + 1], - tmp[i + 2], - tmp[i + 3], - tmp[i + 4], - tmp[i + 5], - tmp[i + 6], - tmp[i + 7]); + pr_err("%.08x: %.08x %.08x %.08x %.08x %.08x %.08x %.08x %.08x\n", i, + tmp[i + 0], + tmp[i + 1], + tmp[i + 2], + tmp[i + 3], + tmp[i + 4], + tmp[i + 5], + tmp[i + 6], + tmp[i + 7]); msleep(5); } } diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index f5cc235e9854..a103d491bbb1 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -2095,9 +2095,9 @@ static void ql_process_chip_ae_intr(struct ql_adapter *qdev, break; case PCI_ERR_ANON_BUF_RD: - netdev_err(qdev->ndev, "PCI error occurred when reading " - "anonymous buffers from rx_ring %d.\n", - ib_ae_rsp->q_id); + netdev_err(qdev->ndev, + "PCI error occurred when reading anonymous buffers from rx_ring %d.\n", + ib_ae_rsp->q_id); ql_queue_asic_error(qdev); break; @@ -2428,8 +2428,8 @@ static irqreturn_t qlge_isr(int irq, void *dev_id) ql_queue_asic_error(qdev); netdev_err(qdev->ndev, "Got fatal error, STS = %x.\n", var); var = ql_read32(qdev, ERR_STS); - netdev_err(qdev->ndev, "Resetting chip. " - "Error Status Register = 0x%x\n", var); + netdev_err(qdev->ndev, "Resetting chip. Error Status Register = 0x%x\n", + var); return IRQ_HANDLED; } @@ -3749,8 +3749,7 @@ static void ql_display_dev_info(struct net_device *ndev) struct ql_adapter *qdev = netdev_priv(ndev); netif_info(qdev, probe, qdev->ndev, - "Function #%d, Port %d, NIC Roll %d, NIC Rev = %d, " - "XG Roll = %d, XG Rev = %d.\n", + "Function #%d, Port %d, NIC Roll %d, NIC Rev = %d, XG Roll = %d, XG Rev = %d.\n", qdev->func, qdev->port, qdev->chip_rev_id & 0x0000000f, -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-12-11 18:17 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-11 18:12 [PATCH v2 00/23] V2: Break up from one patch to multiple Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 01/23] staging: qlge: Fix CHECK extra blank lines in many files Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 02/23] staging: qlge: Fix CHECK: Alignment should match open parenthesis Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 03/23] staging:qlge: Fix WARNING: Missing a blank line after declarations Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-17 12:36 ` [PATCH v2 03/23] staging: qlge: " Greg KH 2019-12-17 12:36 ` Greg KH 2019-12-11 18:12 ` [PATCH v2 04/23] " Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-17 12:37 ` Greg KH 2019-12-17 12:37 ` Greg KH 2019-12-11 18:12 ` [PATCH v2 05/23] staging: qlge: Fix CHECK: Blank lines aren't necessary before a close brace '}' Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 06/23] staging: qlge: Fix CHECK: Blank lines aren't necessary after an open brace '{' Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` Scott Schafer [this message] 2019-12-11 18:12 ` [PATCH v2 07/23] staging: qlge: Fix WARNING: quoted string split across lines Scott Schafer 2019-12-11 18:12 ` [PATCH v2 08/23] staging: qlge: Fix CHECK: Unnecessary parentheses around mpi_coredump->mpi_global_header Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 09/23] staging: qlge: Fix CHECK: No space is necessary after a cast Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 10/23] staging: qlge: Fix CHECK: blank line after function/struct/union/enum declarations Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-12 12:12 ` Dan Carpenter 2019-12-12 12:12 ` Dan Carpenter 2019-12-12 15:02 ` Scott Schafer 2019-12-12 15:02 ` Scott Schafer 2019-12-12 16:03 ` Greg KH 2019-12-12 16:03 ` Greg KH 2019-12-12 16:31 ` Dan Carpenter 2019-12-12 16:31 ` Dan Carpenter 2019-12-12 19:25 ` David Miller 2019-12-12 19:25 ` David Miller 2019-12-11 18:12 ` [PATCH v2 12/23] staging: qlge: Fix WARNING: please, no space before tabs in qlge.h Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 13/23] staging: qlge: Fix CHECK: spaces preferred around that (ctx:VxV) Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 14/23] staging: qlge: Fix WARNING: Unnecessary space before function pointer arguments Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 15/23] staging: qlge: Fix WARNING: please, no spaces at the start of a line Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 16/23] staging: qlge: Fix WARNING: Block comments use a trailing */ on a separate line Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 17/23] staging: qlge: Fix WARNING: else is not generally useful after a break or return Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 18/23] staging: qlge: Fix CHECK: Prefer using the BIT macro Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 19/23] staging: qlge: Fix WARNING: msleep < 20ms can sleep for up to 20ms Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 20/23] staging: qlge: Fix CHECK: usleep_range is preferred over udelay Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-12 10:45 ` Sergei Shtylyov 2019-12-12 10:45 ` Sergei Shtylyov 2019-12-12 11:00 ` Scott Schafer 2019-12-12 11:00 ` Scott Schafer 2019-12-12 11:12 ` Dan Carpenter 2019-12-12 11:12 ` Dan Carpenter 2019-12-12 11:07 ` Dan Carpenter 2019-12-12 11:07 ` Dan Carpenter 2019-12-11 18:12 ` [PATCH v2 21/23] staging: qlge: Fix WARNING: suspect code indent for conditional statements Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 22/23] staging: qlge: Fix CHECK: Unbalanced braces around else statement Scott Schafer 2019-12-11 18:12 ` Scott Schafer 2019-12-11 18:12 ` [PATCH v2 23/23] staging: qlge: Fix WARNING: Avoid multiple line dereference Scott Schafer 2019-12-11 18:12 ` Scott Schafer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0e1f9c5182a909bfe534f7f2d6f93c3e65862d48.1576086080.git.schaferjscott@gmail.com \ --to=schaferjscott@gmail.com \ --cc=GR-Linux-NIC-Dev@marvell.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=manishc@marvell.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.