[PATCH] docker: include bison in debian-tricore-cross

[PATCH] docker: include bison in debian-tricore-cross

[Paolo Bonzini]

Binutils sometimes fail to build if bison is not installed:

  /bin/sh ./ylwrap `test -f arparse.y || echo ./`arparse.y y.tab.c arparse.c y.tab.h arparse.h y.output arparse.output --  -d
  ./ylwrap: 109: ./ylwrap: -d: not found

(the correct invocation of ylwrap would have "bison -d" after the double
dash).  Work around by installing it in the container.

Cc: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/docker/dockerfiles/debian-tricore-cross.docker | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker b/tests/docker/dockerfiles/debian-tricore-cross.docker
index d8df2c6117..3f6b55562c 100644
--- a/tests/docker/dockerfiles/debian-tricore-cross.docker
+++ b/tests/docker/dockerfiles/debian-tricore-cross.docker
@@ -16,6 +16,7 @@ MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>
 RUN apt update && \
     DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \
     DEBIAN_FRONTEND=noninteractive eatmydata apt install -yy \
+       bison \
        bzip2 \
        ca-certificates \
        ccache \
-- 
2.33.1

Re: [PATCH] docker: include bison in debian-tricore-cross

[Philippe Mathieu-Daudé]

On 12/21/21 12:16, Paolo Bonzini wrote:
> Binutils sometimes fail to build if bison is not installed:
> 
>   /bin/sh ./ylwrap `test -f arparse.y || echo ./`arparse.y y.tab.c arparse.c y.tab.h arparse.h y.output arparse.output --  -d
>   ./ylwrap: 109: ./ylwrap: -d: not found
> 
> (the correct invocation of ylwrap would have "bison -d" after the double
> dash).  Work around by installing it in the container.
> 
> Cc: Alex Bennée <alex.bennee@linaro.org>

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/596
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/docker/dockerfiles/debian-tricore-cross.docker | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker b/tests/docker/dockerfiles/debian-tricore-cross.docker
> index d8df2c6117..3f6b55562c 100644
> --- a/tests/docker/dockerfiles/debian-tricore-cross.docker
> +++ b/tests/docker/dockerfiles/debian-tricore-cross.docker
> @@ -16,6 +16,7 @@ MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>
>  RUN apt update && \
>      DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \
>      DEBIAN_FRONTEND=noninteractive eatmydata apt install -yy \
> +       bison \
>         bzip2 \
>         ca-certificates \
>         ccache \

Re: [PATCH] docker: include bison in debian-tricore-cross

[Richard Henderson]

On 12/21/21 3:16 AM, Paolo Bonzini wrote:
> Binutils sometimes fail to build if bison is not installed:
> 
>    /bin/sh ./ylwrap `test -f arparse.y || echo ./`arparse.y y.tab.c arparse.c y.tab.h arparse.h y.output arparse.output --  -d
>    ./ylwrap: 109: ./ylwrap: -d: not found
> 
> (the correct invocation of ylwrap would have "bison -d" after the double
> dash).  Work around by installing it in the container.
> 
> Cc: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH] docker: include bison in debian-tricore-cross

[Alex Bennée]

Paolo Bonzini <pbonzini@redhat.com> writes:

> Binutils sometimes fail to build if bison is not installed:
>
>   /bin/sh ./ylwrap `test -f arparse.y || echo ./`arparse.y y.tab.c arparse.c y.tab.h arparse.h y.output arparse.output --  -d
>   ./ylwrap: 109: ./ylwrap: -d: not found
>
> (the correct invocation of ylwrap would have "bison -d" after the double
> dash).  Work around by installing it in the container.
>
> Cc: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Queued to testing/next, thanks.

-- 
Alex Bennée