All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geliang Tang <geliangtang@gmail.com>
To: mptcp@lists.linux.dev
Cc: Geliang Tang <geliangtang@gmail.com>
Subject: [MPTCP][PATCH v2 mptcp-next 3/5] Squash to "mptcp: add a new sysctl checksum_enabled"
Date: Thu,  6 May 2021 15:48:44 +0800	[thread overview]
Message-ID: <0e4f818d6894959b07da34e2d190ec2a7aaba51e.1620286893.git.geliangtang@gmail.com> (raw)
In-Reply-To: <093b409c7678032f8639402cf9f13025d2c65965.1620286893.git.geliangtang@gmail.com>

Update this patch as Florian suggested in the "MP_CAPABLE C flag" series.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 Documentation/networking/mptcp-sysctl.rst | 2 +-
 net/mptcp/ctrl.c                          | 8 +++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/networking/mptcp-sysctl.rst b/Documentation/networking/mptcp-sysctl.rst
index 901fa3e4650f..ee06fd782465 100644
--- a/Documentation/networking/mptcp-sysctl.rst
+++ b/Documentation/networking/mptcp-sysctl.rst
@@ -25,7 +25,7 @@ add_addr_timeout - INTEGER (seconds)
 
 	Default: 120
 
-checksum_enabled - INTEGER
+checksum_enabled - BOOLEAN
 	Control whether DSS checksum can be enabled.
 
 	DSS checksum can be enabled if the value is nonzero. This is a
diff --git a/net/mptcp/ctrl.c b/net/mptcp/ctrl.c
index 014752c481d0..b5ff77dae503 100644
--- a/net/mptcp/ctrl.c
+++ b/net/mptcp/ctrl.c
@@ -23,7 +23,7 @@ struct mptcp_pernet {
 
 	u8 mptcp_enabled;
 	unsigned int add_addr_timeout;
-	int checksum_enabled;
+	u8 checksum_enabled;
 };
 
 static struct mptcp_pernet *mptcp_get_pernet(struct net *net)
@@ -74,9 +74,11 @@ static struct ctl_table mptcp_sysctl_table[] = {
 	},
 	{
 		.procname = "checksum_enabled",
-		.maxlen = sizeof(int),
+		.maxlen = sizeof(u8),
 		.mode = 0644,
-		.proc_handler = proc_dointvec,
+		.proc_handler = proc_dou8vec_minmax,
+		.extra1       = SYSCTL_ZERO,
+		.extra2       = SYSCTL_ONE
 	},
 	{}
 };
-- 
2.31.1


  reply	other threads:[~2021-05-06  7:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06  7:48 [MPTCP][PATCH v2 mptcp-next 0/5] data checksum support cleanups Geliang Tang
2021-05-06  7:48 ` [MPTCP][PATCH v2 mptcp-next 1/5] Squash to "mptcp: add csum_reqd in mptcp_out_options" Geliang Tang
2021-05-06  7:48   ` [MPTCP][PATCH v2 mptcp-next 2/5] Squash to "mptcp: add the mib for data checksum" Geliang Tang
2021-05-06  7:48     ` Geliang Tang [this message]
2021-05-06  7:48       ` [MPTCP][PATCH v2 mptcp-next 4/5] mptcp: dump csum fields in mptcp_dump_mpext Geliang Tang
2021-05-06  7:48         ` [MPTCP][PATCH v2 mptcp-next 5/5] Squash to "selftests: mptcp: enable checksum in mptcp_join.sh" Geliang Tang
2021-05-06 13:08         ` [MPTCP][PATCH v2 mptcp-next 4/5] mptcp: dump csum fields in mptcp_dump_mpext Paolo Abeni
2021-05-07  2:50     ` [MPTCP][PATCH v2 mptcp-next 2/5] Squash to "mptcp: add the mib for data checksum" Geliang Tang
2021-05-07  8:07       ` Matthieu Baerts
2021-05-06 13:09 ` [MPTCP][PATCH v2 mptcp-next 0/5] data checksum support cleanups Paolo Abeni
2021-05-06 14:28 ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e4f818d6894959b07da34e2d190ec2a7aaba51e.1620286893.git.geliangtang@gmail.com \
    --to=geliangtang@gmail.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.