Re: [MPTCP][PATCH v2 mptcp-next 0/5] data checksum support cleanups

[Paolo Abeni <pabeni@redhat.com>]

On Thu, 2021-05-06 at 15:48 +0800, Geliang Tang wrote:
> v2:
>  - add two new squash-to patches to rename the mib DSSCSUMERR to
>    DATACSUMERR.
> 
> Please insert patch 4 (mptcp: dump csum fields in mptcp_dump_mpext) between the
> commits "mptcp: add a new sysctl checksum_enabled" and "selftests: mptcp: 
> enable checksum in mptcp_connect.sh".
> 
> Geliang Tang (5):
>   Squash to "mptcp: add csum_reqd in mptcp_out_options"
>   Squash to "mptcp: add the mib for data checksum"
>   Squash to "mptcp: add a new sysctl checksum_enabled"
>   mptcp: dump csum fields in mptcp_dump_mpext
>   Squash to "selftests: mptcp: enable checksum in mptcp_join.sh"
> 
>  Documentation/networking/mptcp-sysctl.rst       |  2 +-
>  include/net/mptcp.h                             |  4 ++--
>  include/trace/events/mptcp.h                    | 17 +++++++++++------
>  net/mptcp/ctrl.c                                |  8 +++++---
>  net/mptcp/mib.c                                 |  2 +-
>  net/mptcp/mib.h                                 |  2 +-
>  net/mptcp/subflow.c                             |  2 +-
>  tools/testing/selftests/net/mptcp/mptcp_join.sh |  4 ++--
>  8 files changed, 24 insertions(+), 17 deletions(-)
> 

I had a very minor comment on patch 4/5, but I think this can be merged
as is and ev. squash an additional change later, if needed/there is
agreement.

Cheers,

Paolo