From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> To: John Garry <john.garry@huawei.com>, <joro@8bytes.org>, <will@kernel.org>, <dwmw2@infradead.org>, <baolu.lu@linux.intel.com>, <robin.murphy@arm.com> Cc: <linux-kernel@vger.kernel.org>, <iommu@lists.linux-foundation.org>, <linuxarm@huawei.com>, <chenxiang66@hisilicon.com> Subject: Re: [PATCH v10 1/3] iommu: Enhance IOMMU default DMA mode build options Date: Fri, 4 Jun 2021 10:54:30 +0800 [thread overview] Message-ID: <0e54ff0f-c668-354e-1ec8-7536c701d3a8@huawei.com> (raw) In-Reply-To: <1622728715-209296-2-git-send-email-john.garry@huawei.com> On 2021/6/3 21:58, John Garry wrote: > From: Zhen Lei <thunder.leizhen@huawei.com> > > First, add build options IOMMU_DEFAULT_{LAZY|STRICT}, so that we have the > opportunity to set {lazy|strict} mode as default at build time. Then put > the two config options in an choice, as they are mutually-exclusive. > > [jpg: Make choice between strict and lazy only (and not passthrough)] > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > Signed-off-by: John Garry <john.garry@huawei.com> > --- > drivers/iommu/Kconfig | 34 ++++++++++++++++++++++++++++++++++ > drivers/iommu/iommu.c | 3 ++- > 2 files changed, 36 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index 1f111b399bca..12ef90256df8 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -90,6 +90,40 @@ config IOMMU_DEFAULT_PASSTHROUGH > > If unsure, say N here. > > +choice > + prompt "IOMMU default DMA mode" > + depends on IOMMU_API config INTEL_IOMMU depends on PCI_MSI && ACPI && (X86 || IA64) config AMD_IOMMU depends on X86_64 && PCI && ACPI && HAVE_CMPXCHG_DOUBLE config ARM_SMMU_V3 depends on ARM64 "depends on ARM_SMMU_V3 || INTEL_IOMMU || AMD_IOMMU" may need to be added, because it doesn't work on other platforms. or "depends on X86 || IA64 || X86_64 || ARM64" > + > + default IOMMU_DEFAULT_STRICT > + help > + This option allows an IOMMU DMA mode to be chosen at build time, to > + override the default DMA mode of each ARCH, removing the need to > + pass in kernel parameters through command line. It is still possible > + to provide ARCH-specific or common boot options to override this > + option. > + > + If unsure, keep the default. > + > +config IOMMU_DEFAULT_LAZY > + bool "lazy" > + help > + Support lazy mode, where for every IOMMU DMA unmap operation, the > + flush operation of IOTLB and the free operation of IOVA are deferred. > + They are only guaranteed to be done before the related IOVA will be > + reused. > + > +config IOMMU_DEFAULT_STRICT > + bool "strict" > + help > + For every IOMMU DMA unmap operation, the flush operation of IOTLB and > + the free operation of IOVA are guaranteed to be done in the unmap > + function. > + > + This mode is safer than the two above, but it maybe slower in some > + high performace scenarios. > + > +endchoice > + > config OF_IOMMU > def_bool y > depends on OF && IOMMU_API > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 966426a96520..177b0dafc535 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -29,7 +29,8 @@ static struct kset *iommu_group_kset; > static DEFINE_IDA(iommu_group_ida); > > static unsigned int iommu_def_domain_type __read_mostly; > -static bool iommu_dma_strict __read_mostly = true; > +static bool iommu_dma_strict __read_mostly = > + IS_ENABLED(CONFIG_IOMMU_DEFAULT_STRICT); Currently, a maximum of 100 columns are allowed in a row. > static u32 iommu_cmd_line __read_mostly; > > struct iommu_group { >
WARNING: multiple messages have this Message-ID (diff)
From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> To: John Garry <john.garry@huawei.com>, <joro@8bytes.org>, <will@kernel.org>, <dwmw2@infradead.org>, <baolu.lu@linux.intel.com>, <robin.murphy@arm.com> Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH v10 1/3] iommu: Enhance IOMMU default DMA mode build options Date: Fri, 4 Jun 2021 10:54:30 +0800 [thread overview] Message-ID: <0e54ff0f-c668-354e-1ec8-7536c701d3a8@huawei.com> (raw) In-Reply-To: <1622728715-209296-2-git-send-email-john.garry@huawei.com> On 2021/6/3 21:58, John Garry wrote: > From: Zhen Lei <thunder.leizhen@huawei.com> > > First, add build options IOMMU_DEFAULT_{LAZY|STRICT}, so that we have the > opportunity to set {lazy|strict} mode as default at build time. Then put > the two config options in an choice, as they are mutually-exclusive. > > [jpg: Make choice between strict and lazy only (and not passthrough)] > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > Signed-off-by: John Garry <john.garry@huawei.com> > --- > drivers/iommu/Kconfig | 34 ++++++++++++++++++++++++++++++++++ > drivers/iommu/iommu.c | 3 ++- > 2 files changed, 36 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index 1f111b399bca..12ef90256df8 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -90,6 +90,40 @@ config IOMMU_DEFAULT_PASSTHROUGH > > If unsure, say N here. > > +choice > + prompt "IOMMU default DMA mode" > + depends on IOMMU_API config INTEL_IOMMU depends on PCI_MSI && ACPI && (X86 || IA64) config AMD_IOMMU depends on X86_64 && PCI && ACPI && HAVE_CMPXCHG_DOUBLE config ARM_SMMU_V3 depends on ARM64 "depends on ARM_SMMU_V3 || INTEL_IOMMU || AMD_IOMMU" may need to be added, because it doesn't work on other platforms. or "depends on X86 || IA64 || X86_64 || ARM64" > + > + default IOMMU_DEFAULT_STRICT > + help > + This option allows an IOMMU DMA mode to be chosen at build time, to > + override the default DMA mode of each ARCH, removing the need to > + pass in kernel parameters through command line. It is still possible > + to provide ARCH-specific or common boot options to override this > + option. > + > + If unsure, keep the default. > + > +config IOMMU_DEFAULT_LAZY > + bool "lazy" > + help > + Support lazy mode, where for every IOMMU DMA unmap operation, the > + flush operation of IOTLB and the free operation of IOVA are deferred. > + They are only guaranteed to be done before the related IOVA will be > + reused. > + > +config IOMMU_DEFAULT_STRICT > + bool "strict" > + help > + For every IOMMU DMA unmap operation, the flush operation of IOTLB and > + the free operation of IOVA are guaranteed to be done in the unmap > + function. > + > + This mode is safer than the two above, but it maybe slower in some > + high performace scenarios. > + > +endchoice > + > config OF_IOMMU > def_bool y > depends on OF && IOMMU_API > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 966426a96520..177b0dafc535 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -29,7 +29,8 @@ static struct kset *iommu_group_kset; > static DEFINE_IDA(iommu_group_ida); > > static unsigned int iommu_def_domain_type __read_mostly; > -static bool iommu_dma_strict __read_mostly = true; > +static bool iommu_dma_strict __read_mostly = > + IS_ENABLED(CONFIG_IOMMU_DEFAULT_STRICT); Currently, a maximum of 100 columns are allowed in a row. > static u32 iommu_cmd_line __read_mostly; > > struct iommu_group { > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-06-04 2:54 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-03 13:58 [PATCH v10 0/3] Enhance IOMMU default DMA mode build options John Garry 2021-06-03 13:58 ` John Garry 2021-06-03 13:58 ` [PATCH v10 1/3] iommu: " John Garry 2021-06-03 13:58 ` John Garry 2021-06-03 17:00 ` Randy Dunlap 2021-06-03 17:00 ` Randy Dunlap 2021-06-03 17:04 ` John Garry 2021-06-03 17:04 ` John Garry 2021-06-04 2:54 ` Leizhen (ThunderTown) [this message] 2021-06-04 2:54 ` Leizhen (ThunderTown) 2021-06-04 8:19 ` John Garry 2021-06-04 8:19 ` John Garry 2021-06-03 13:58 ` [PATCH v10 2/3] iommu/vt-d: Add support for " John Garry 2021-06-03 13:58 ` John Garry 2021-06-03 13:58 ` [PATCH v10 3/3] iommu/amd: " John Garry 2021-06-03 13:58 ` John Garry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0e54ff0f-c668-354e-1ec8-7536c701d3a8@huawei.com \ --to=thunder.leizhen@huawei.com \ --cc=baolu.lu@linux.intel.com \ --cc=chenxiang66@hisilicon.com \ --cc=dwmw2@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=john.garry@huawei.com \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=robin.murphy@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.