[PATCH V2] drm/plane-helper: Add the missing declaration of drm_atomic_state

[PATCH V2] drm/plane-helper: Add the missing declaration of drm_atomic_state

[Ma Jun]

Add the missing declaration of struct drm_atomic_state to fix the
compile error below:

error: 'struct drm_atomic_state' declared inside parameter
list will not be visible outside of this definition or declaration [-Werror]

Signed-off-by: Ma Jun <majun@amd.com>
---
 include/drm/drm_plane_helper.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h
index b00ad36cf5b6..90156e13ac11 100644
--- a/include/drm/drm_plane_helper.h
+++ b/include/drm/drm_plane_helper.h
@@ -26,6 +26,7 @@
 
 #include <linux/types.h>
 
+struct drm_atomic_state;
 struct drm_crtc;
 struct drm_framebuffer;
 struct drm_modeset_acquire_ctx;
-- 
2.25.1

[PATCH V2] drm/plane-helper: Add the missing declaration of drm_atomic_state

[Ma Jun]

Add the missing declaration of struct drm_atomic_state to fix the
compile error below:

error: 'struct drm_atomic_state' declared inside parameter
list will not be visible outside of this definition or declaration [-Werror]

Signed-off-by: Ma Jun <majun@amd.com>
---
 include/drm/drm_plane_helper.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h
index b00ad36cf5b6..90156e13ac11 100644
--- a/include/drm/drm_plane_helper.h
+++ b/include/drm/drm_plane_helper.h
@@ -26,6 +26,7 @@
 
 #include <linux/types.h>
 
+struct drm_atomic_state;
 struct drm_crtc;
 struct drm_framebuffer;
 struct drm_modeset_acquire_ctx;
-- 
2.25.1

Re: [PATCH V2] drm/plane-helper: Add the missing declaration of drm_atomic_state

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 1088 bytes --]

Hi

Am 16.12.22 um 04:05 schrieb Ma Jun:
> Add the missing declaration of struct drm_atomic_state to fix the
> compile error below:
> 
> error: 'struct drm_atomic_state' declared inside parameter
> list will not be visible outside of this definition or declaration [-Werror]
> 
> Signed-off-by: Ma Jun <majun@amd.com>

Thanks. I added a Fixes tag and merged the patch into drm-misc-fixes.

Best regards
Thomas

> ---
>   include/drm/drm_plane_helper.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h
> index b00ad36cf5b6..90156e13ac11 100644
> --- a/include/drm/drm_plane_helper.h
> +++ b/include/drm/drm_plane_helper.h
> @@ -26,6 +26,7 @@
>   
>   #include <linux/types.h>
>   
> +struct drm_atomic_state;
>   struct drm_crtc;
>   struct drm_framebuffer;
>   struct drm_modeset_acquire_ctx;

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]