All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepak Rawat <drawat.floss@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org, linux-hyperv@vger.kernel.org
Cc: Dexuan Cui <decui@microsoft.com>,
	Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH v4 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device
Date: Tue, 18 May 2021 07:10:19 -0700	[thread overview]
Message-ID: <0e61f1a6c099a4eea6d51fe31de8c0870a70a70c.camel@gmail.com> (raw)
In-Reply-To: <3c7966c8-8985-e5f1-464c-90bc6544dc74@suse.de>

> > +
> > +static struct pci_driver hyperv_pci_driver = {
> > +       .name =         KBUILD_MODNAME,
> > +       .id_table =     hyperv_pci_tbl,
> > +       .probe =        hyperv_pci_probe,
> > +       .remove =       hyperv_pci_remove,
> > +};
> 
> The PCI code doesn't do anything. Do you need this for gen1 to work 
> corretly. If so, there should at least be a short comment. Why don't
> you 
> call hyperv_setup_gen1() in the PCI probe function?
> 
> 

Thank you very much Thomas for the review. Yes, this is needed for gen1
to work. Regarding why hyperv_setup_gen1() is not called from PCI
probe, this is to maintain consistency with hyperv_fb and also
hv_driver probe method is called irrespective of gen1 or gen2. I will
add a comment explaining this.

Deepak


  reply	other threads:[~2021-05-18 14:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 11:59 [PATCH v4 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device Deepak Rawat
2021-05-17 11:59 ` Deepak Rawat
2021-05-17 11:59 ` [PATCH v4 2/3] drm/hyperv: Handle feature change message from device Deepak Rawat
2021-05-17 11:59   ` Deepak Rawat
2021-05-17 13:51   ` Thomas Zimmermann
2021-05-17 11:59 ` [PATCH v4 3/3] MAINTAINERS: Add maintainer for hyperv video device Deepak Rawat
2021-05-17 11:59   ` Deepak Rawat
2021-05-17 12:11   ` Deepak Rawat
2021-05-17 17:25   ` Wei Liu
2021-05-17 17:25     ` Wei Liu
2021-05-18  4:45     ` Deepak Rawat
2021-05-18  4:45       ` Deepak Rawat
2021-05-17 13:50 ` [PATCH v4 1/3] drm/hyperv: Add DRM driver for hyperv synthetic " Thomas Zimmermann
2021-05-18 14:10   ` Deepak Rawat [this message]
2021-05-18 14:10     ` Deepak Rawat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e61f1a6c099a4eea6d51fe31de8c0870a70a70c.camel@gmail.com \
    --to=drawat.floss@gmail.com \
    --cc=decui@microsoft.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.