* [PATCH] leds: gpio: Drop unneeded manual of_node assignment
@ 2018-12-07 10:10 Krzysztof Kozlowski
2018-12-07 11:24 ` Rafał Miłecki
2018-12-08 18:02 ` Jacek Anaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2018-12-07 10:10 UTC (permalink / raw)
To: Rafał Miłecki, Jacek Anaszewski, Pavel Machek,
linux-leds, linux-kernel
Cc: Krzysztof Kozlowski
This reverts the main change of commit bff23714bc36 ("leds: leds-gpio:
Set of_node for created LED devices") because of_node assignment is
handled by core since commit 7ea79ae86c28 ("leds: gpio: use OF variant
of LED registering function"). Basically the code was overwriting the
of_node with same value.
No functional change expected.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/leds/leds-gpio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index 45e012093865..998f2ff6914d 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -190,7 +190,6 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
fwnode_handle_put(child);
return ERR_PTR(ret);
}
- led_dat->cdev.dev->of_node = np;
priv->num_leds++;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: gpio: Drop unneeded manual of_node assignment
2018-12-07 10:10 [PATCH] leds: gpio: Drop unneeded manual of_node assignment Krzysztof Kozlowski
@ 2018-12-07 11:24 ` Rafał Miłecki
2018-12-08 18:02 ` Jacek Anaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Rafał Miłecki @ 2018-12-07 11:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Jacek Anaszewski, Pavel Machek, linux-leds, linux-kernel
On 2018-12-07 11:10, Krzysztof Kozlowski wrote:
> This reverts the main change of commit bff23714bc36 ("leds: leds-gpio:
> Set of_node for created LED devices") because of_node assignment is
> handled by core since commit 7ea79ae86c28 ("leds: gpio: use OF variant
> of LED registering function"). Basically the code was overwriting the
> of_node with same value.
>
> No functional change expected.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Thanks!
Tested-by: Rafał Miłecki <rafal@milecki.pl>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: gpio: Drop unneeded manual of_node assignment
2018-12-07 10:10 [PATCH] leds: gpio: Drop unneeded manual of_node assignment Krzysztof Kozlowski
2018-12-07 11:24 ` Rafał Miłecki
@ 2018-12-08 18:02 ` Jacek Anaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Jacek Anaszewski @ 2018-12-08 18:02 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rafał Miłecki, Pavel Machek,
linux-leds, linux-kernel
Hi Krzysztof,
Thank you for the patch.
On 12/7/18 11:10 AM, Krzysztof Kozlowski wrote:
> This reverts the main change of commit bff23714bc36 ("leds: leds-gpio:
> Set of_node for created LED devices") because of_node assignment is
> handled by core since commit 7ea79ae86c28 ("leds: gpio: use OF variant
> of LED registering function"). Basically the code was overwriting the
> of_node with same value.
>
> No functional change expected.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/leds/leds-gpio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index 45e012093865..998f2ff6914d 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -190,7 +190,6 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
> fwnode_handle_put(child);
> return ERR_PTR(ret);
> }
> - led_dat->cdev.dev->of_node = np;
> priv->num_leds++;
> }
>
>
Applied.
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-08 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-07 10:10 [PATCH] leds: gpio: Drop unneeded manual of_node assignment Krzysztof Kozlowski
2018-12-07 11:24 ` Rafał Miłecki
2018-12-08 18:02 ` Jacek Anaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.