* [Qemu-devel] [PATCH] Makefile: Fix "make clean" in "unconfigured" source directory
@ 2019-07-09 14:38 Markus Armbruster
2019-07-09 14:39 ` Christian Borntraeger
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Markus Armbruster @ 2019-07-09 14:38 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, borntraeger
Recent commit "Makefile: Reuse all's recursion machinery for clean and
install" broke targets clean and distclean in the source directory
before running configure:
$ make clean
LD recurse-clean.mo
cc: fatal error: no input files
compilation terminated.
make: *** [rules.mak:118: recurse-clean.mo] Error 1
Root cause is missing .PHONY. Fix that.
Fixes: 1338a4b72659ce08eacb9de0205fe16202a22d9c
Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index c63de4e36c..1fcbaed62c 100644
--- a/Makefile
+++ b/Makefile
@@ -518,6 +518,7 @@ ROM_DIRS_RULES=$(foreach t, all clean, $(addsuffix /$(t), $(ROM_DIRS)))
$(ROM_DIRS_RULES):
$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" CFLAGS="$(filter -O% -g%,$(CFLAGS))" $(notdir $@),)
+.PHONY: recurse-all recurse-clean recurse-install
recurse-all: $(addsuffix /all, $(TARGET_DIRS) $(ROM_DIRS))
recurse-clean: $(addsuffix /clean, $(TARGET_DIRS) $(ROM_DIRS))
recurse-install: $(addsuffix /install, $(TARGET_DIRS))
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: Fix "make clean" in "unconfigured" source directory
2019-07-09 14:38 [Qemu-devel] [PATCH] Makefile: Fix "make clean" in "unconfigured" source directory Markus Armbruster
@ 2019-07-09 14:39 ` Christian Borntraeger
2019-07-09 15:02 ` Philippe Mathieu-Daudé
2019-07-09 15:39 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Christian Borntraeger @ 2019-07-09 14:39 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: peter.maydell
On 09.07.19 16:38, Markus Armbruster wrote:
> Recent commit "Makefile: Reuse all's recursion machinery for clean and
> install" broke targets clean and distclean in the source directory
> before running configure:
>
> $ make clean
> LD recurse-clean.mo
> cc: fatal error: no input files
> compilation terminated.
> make: *** [rules.mak:118: recurse-clean.mo] Error 1
>
> Root cause is missing .PHONY. Fix that.
>
> Fixes: 1338a4b72659ce08eacb9de0205fe16202a22d9c
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index c63de4e36c..1fcbaed62c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -518,6 +518,7 @@ ROM_DIRS_RULES=$(foreach t, all clean, $(addsuffix /$(t), $(ROM_DIRS)))
> $(ROM_DIRS_RULES):
> $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" CFLAGS="$(filter -O% -g%,$(CFLAGS))" $(notdir $@),)
>
> +.PHONY: recurse-all recurse-clean recurse-install
> recurse-all: $(addsuffix /all, $(TARGET_DIRS) $(ROM_DIRS))
> recurse-clean: $(addsuffix /clean, $(TARGET_DIRS) $(ROM_DIRS))
> recurse-install: $(addsuffix /install, $(TARGET_DIRS))
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: Fix "make clean" in "unconfigured" source directory
2019-07-09 14:38 [Qemu-devel] [PATCH] Makefile: Fix "make clean" in "unconfigured" source directory Markus Armbruster
2019-07-09 14:39 ` Christian Borntraeger
@ 2019-07-09 15:02 ` Philippe Mathieu-Daudé
2019-07-09 15:39 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-07-09 15:02 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: peter.maydell, borntraeger
On 7/9/19 4:38 PM, Markus Armbruster wrote:
> Recent commit "Makefile: Reuse all's recursion machinery for clean and
> install" broke targets clean and distclean in the source directory
> before running configure:
>
> $ make clean
> LD recurse-clean.mo
> cc: fatal error: no input files
> compilation terminated.
> make: *** [rules.mak:118: recurse-clean.mo] Error 1
>
> Root cause is missing .PHONY. Fix that.
>
> Fixes: 1338a4b72659ce08eacb9de0205fe16202a22d9c
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index c63de4e36c..1fcbaed62c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -518,6 +518,7 @@ ROM_DIRS_RULES=$(foreach t, all clean, $(addsuffix /$(t), $(ROM_DIRS)))
> $(ROM_DIRS_RULES):
> $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" TARGET_DIR="$(dir $@)" CFLAGS="$(filter -O% -g%,$(CFLAGS))" $(notdir $@),)
>
> +.PHONY: recurse-all recurse-clean recurse-install
> recurse-all: $(addsuffix /all, $(TARGET_DIRS) $(ROM_DIRS))
> recurse-clean: $(addsuffix /clean, $(TARGET_DIRS) $(ROM_DIRS))
> recurse-install: $(addsuffix /install, $(TARGET_DIRS))
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: Fix "make clean" in "unconfigured" source directory
2019-07-09 14:38 [Qemu-devel] [PATCH] Makefile: Fix "make clean" in "unconfigured" source directory Markus Armbruster
2019-07-09 14:39 ` Christian Borntraeger
2019-07-09 15:02 ` Philippe Mathieu-Daudé
@ 2019-07-09 15:39 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2019-07-09 15:39 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Christian Borntraeger, QEMU Developers
On Tue, 9 Jul 2019 at 15:38, Markus Armbruster <armbru@redhat.com> wrote:
>
> Recent commit "Makefile: Reuse all's recursion machinery for clean and
> install" broke targets clean and distclean in the source directory
> before running configure:
>
> $ make clean
> LD recurse-clean.mo
> cc: fatal error: no input files
> compilation terminated.
> make: *** [rules.mak:118: recurse-clean.mo] Error 1
>
> Root cause is missing .PHONY. Fix that.
>
> Fixes: 1338a4b72659ce08eacb9de0205fe16202a22d9c
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Applied to master, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-09 15:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-09 14:38 [Qemu-devel] [PATCH] Makefile: Fix "make clean" in "unconfigured" source directory Markus Armbruster
2019-07-09 14:39 ` Christian Borntraeger
2019-07-09 15:02 ` Philippe Mathieu-Daudé
2019-07-09 15:39 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.