All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Tudor.Ambarus@microchip.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com
Subject: Re: [PATCH v4 2/4] mtd: spi-nor: implement OTP support for Winbond and similar flashes
Date: Mon, 15 Mar 2021 11:43:32 +0100	[thread overview]
Message-ID: <0ef810128e33f581d05ee394893e683d@walle.cc> (raw)
In-Reply-To: <5f820284-8c48-e111-c46d-f53bb5ed17cb@microchip.com>

Am 2021-03-15 09:31, schrieb Tudor.Ambarus@microchip.com:
> On 3/6/21 2:05 AM, Michael Walle wrote:
>> +       nor->dirmap.rdesc = NULL;
> 
> why can't we use dirmap?

Dirmap is used if the controller supports (transparent)
memory mapped access, right?

As you see I'm not familiar with that, nor does my
controller has support for it, well at least the driver,
the controller supports it actually.

But it also seems like how the flash is accessed is
set up in

   spi_nor_probe()
     spi_nor_create_read_dirmap()

And because the read opcode has to be changed, that isn't
possible.

Plese correct me if I'm wrong.

-michael

WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: Tudor.Ambarus@microchip.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com
Subject: Re: [PATCH v4 2/4] mtd: spi-nor: implement OTP support for Winbond and similar flashes
Date: Mon, 15 Mar 2021 11:43:32 +0100	[thread overview]
Message-ID: <0ef810128e33f581d05ee394893e683d@walle.cc> (raw)
In-Reply-To: <5f820284-8c48-e111-c46d-f53bb5ed17cb@microchip.com>

Am 2021-03-15 09:31, schrieb Tudor.Ambarus@microchip.com:
> On 3/6/21 2:05 AM, Michael Walle wrote:
>> +       nor->dirmap.rdesc = NULL;
> 
> why can't we use dirmap?

Dirmap is used if the controller supports (transparent)
memory mapped access, right?

As you see I'm not familiar with that, nor does my
controller has support for it, well at least the driver,
the controller supports it actually.

But it also seems like how the flash is accessed is
set up in

   spi_nor_probe()
     spi_nor_create_read_dirmap()

And because the read opcode has to be changed, that isn't
possible.

Plese correct me if I'm wrong.

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-03-15 10:44 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06  0:05 [PATCH v4 0/4] mtd: spi-nor: OTP support Michael Walle
2021-03-06  0:05 ` Michael Walle
2021-03-06  0:05 ` [PATCH v4 1/4] mtd: spi-nor: add " Michael Walle
2021-03-06  0:05   ` Michael Walle
2021-03-15  7:28   ` Tudor.Ambarus
2021-03-15  7:28     ` Tudor.Ambarus
2021-03-15  9:23     ` Michael Walle
2021-03-15  9:23       ` Michael Walle
2021-03-15  9:39       ` Tudor.Ambarus
2021-03-15  9:39         ` Tudor.Ambarus
2021-03-15  9:44         ` Tudor.Ambarus
2021-03-15  9:44           ` Tudor.Ambarus
2021-03-15 10:01           ` Michael Walle
2021-03-15 10:01             ` Michael Walle
2021-03-06  0:05 ` [PATCH v4 2/4] mtd: spi-nor: implement OTP support for Winbond and similar flashes Michael Walle
2021-03-06  0:05   ` Michael Walle
2021-03-15  8:20   ` Tudor.Ambarus
2021-03-15  8:20     ` Tudor.Ambarus
2021-03-15 10:29     ` Michael Walle
2021-03-15 10:29       ` Michael Walle
2021-03-15  8:31   ` Tudor.Ambarus
2021-03-15  8:31     ` Tudor.Ambarus
2021-03-15 10:43     ` Michael Walle [this message]
2021-03-15 10:43       ` Michael Walle
2021-03-06  0:05 ` [PATCH v4 3/4] mtd: spi-nor: winbond: add OTP support to w25q32fw/jw Michael Walle
2021-03-06  0:05   ` Michael Walle
2021-03-15  8:26   ` Tudor.Ambarus
2021-03-15  8:26     ` Tudor.Ambarus
2021-03-15  9:26     ` Michael Walle
2021-03-15  9:26       ` Michael Walle
2021-03-15  9:34       ` Tudor.Ambarus
2021-03-15  9:34         ` Tudor.Ambarus
2021-03-06  0:05 ` [PATCH v4 4/4] mtd: spi-nor: implement OTP erase for Winbond and similar flashes Michael Walle
2021-03-06  0:05   ` Michael Walle
2021-03-06  0:20   ` Michael Walle
2021-03-06  0:20     ` Michael Walle
2021-03-07  8:48   ` kernel test robot
2021-03-07  8:48     ` kernel test robot
2021-03-07  8:48     ` kernel test robot
2021-03-15  8:42   ` Tudor.Ambarus
2021-03-15  8:42     ` Tudor.Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ef810128e33f581d05ee394893e683d@walle.cc \
    --to=michael@walle.cc \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.