From: David Laight <David.Laight@ACULAB.COM>
To: 'Chen Huang' <chenhuang5@huawei.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Nathan Lynch <nathanl@linux.ibm.com>,
"Andrew Donnellan" <ajd@linux.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
"Andrew Morton" <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Jens Axboe <axboe@kernel.dk>,
Yang Yingliang <yangyingliang@huawei.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>
Subject: RE: [PATCH -next 2/3] xen: balloon: Replaced simple_strtoull() with kstrtoull()
Date: Thu, 27 May 2021 14:10:21 +0000 [thread overview]
Message-ID: <0f03f9b9ff41460db2935e077f7f80c7@AcuMS.aculab.com> (raw)
In-Reply-To: <20210526092020.554341-2-chenhuang5@huawei.com>
From: Chen Huang
> Sent: 26 May 2021 10:20
>
> The simple_strtoull() function is deprecated in some situation, since
> it does not check for the range overflow, use kstrtoull() instead.
>
...
> - target_bytes = simple_strtoull(buf, &endchar, 0) * 1024;
> + ret = kstrtoull(buf, 0, &target_bytes);
> + if (ret)
> + return ret;
> + target_bytes *= 1024;
I'd have thought it was more important to check *endchar
than overflow.
If you are worried about overflow you need a range check
before the multiply.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: 'Chen Huang' <chenhuang5@huawei.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Nathan Lynch <nathanl@linux.ibm.com>,
"Andrew Donnellan" <ajd@linux.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
"Andrew Morton" <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Jens Axboe <axboe@kernel.dk>,
Yang Yingliang <yangyingliang@huawei.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>
Subject: Re: [Ocfs2-devel] [PATCH -next 2/3] xen: balloon: Replaced simple_strtoull() with kstrtoull()
Date: Thu, 27 May 2021 14:10:21 +0000 [thread overview]
Message-ID: <0f03f9b9ff41460db2935e077f7f80c7@AcuMS.aculab.com> (raw)
In-Reply-To: <20210526092020.554341-2-chenhuang5@huawei.com>
From: Chen Huang
> Sent: 26 May 2021 10:20
>
> The simple_strtoull() function is deprecated in some situation, since
> it does not check for the range overflow, use kstrtoull() instead.
>
...
> - target_bytes = simple_strtoull(buf, &endchar, 0) * 1024;
> + ret = kstrtoull(buf, 0, &target_bytes);
> + if (ret)
> + return ret;
> + target_bytes *= 1024;
I'd have thought it was more important to check *endchar
than overflow.
If you are worried about overflow you need a range check
before the multiply.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: 'Chen Huang' <chenhuang5@huawei.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Nathan Lynch <nathanl@linux.ibm.com>,
"Andrew Donnellan" <ajd@linux.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
"Andrew Morton" <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Jens Axboe <axboe@kernel.dk>,
Yang Yingliang <yangyingliang@huawei.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>
Subject: RE: [PATCH -next 2/3] xen: balloon: Replaced simple_strtoull() with kstrtoull()
Date: Thu, 27 May 2021 14:10:21 +0000 [thread overview]
Message-ID: <0f03f9b9ff41460db2935e077f7f80c7@AcuMS.aculab.com> (raw)
In-Reply-To: <20210526092020.554341-2-chenhuang5@huawei.com>
From: Chen Huang
> Sent: 26 May 2021 10:20
>
> The simple_strtoull() function is deprecated in some situation, since
> it does not check for the range overflow, use kstrtoull() instead.
>
...
> - target_bytes = simple_strtoull(buf, &endchar, 0) * 1024;
> + ret = kstrtoull(buf, 0, &target_bytes);
> + if (ret)
> + return ret;
> + target_bytes *= 1024;
I'd have thought it was more important to check *endchar
than overflow.
If you are worried about overflow you need a range check
before the multiply.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-05-27 14:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 9:20 [PATCH -next 1/3] powerpc/rtas: Replaced simple_strtoull() with kstrtoull() Chen Huang
2021-05-26 9:20 ` Chen Huang
2021-05-26 9:20 ` [Ocfs2-devel] " Chen Huang
2021-05-26 9:20 ` [PATCH -next 2/3] xen: balloon: " Chen Huang
2021-05-26 9:20 ` Chen Huang
2021-05-26 9:20 ` [Ocfs2-devel] " Chen Huang
2021-05-27 14:10 ` David Laight [this message]
2021-05-27 14:10 ` David Laight
2021-05-27 14:10 ` [Ocfs2-devel] " David Laight
2021-05-27 14:37 ` Dan Carpenter
2021-05-27 14:37 ` Dan Carpenter
2021-05-27 14:37 ` [Ocfs2-devel] " Dan Carpenter
2021-05-26 9:20 ` [PATCH -next 3/3] ocfs2: " Chen Huang
2021-05-26 9:20 ` Chen Huang
2021-05-26 9:20 ` [Ocfs2-devel] " Chen Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f03f9b9ff41460db2935e077f7f80c7@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=aik@ozlabs.ru \
--cc=ajd@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=boris.ostrovsky@oracle.com \
--cc=chenhuang5@huawei.com \
--cc=dan.carpenter@oracle.com \
--cc=jgross@suse.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark@fasheh.com \
--cc=masahiroy@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nathanl@linux.ibm.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.