All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data
@ 2020-02-24 23:21 ` Suman Anna
  0 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2020-02-24 23:21 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Tero Kristo, Roger Quadros, linux-omap, linux-arm-kernel, Suman Anna

Hi Tony,

The following patches drop the hwmod data for PRUSS on AM33xx and AM437x
SoCs, and for the IPU and DSP processors on OMAP4 SoC. Patches are based
on 5.6-rc1. Please consider these for the 5.7 merge window.

I will be submitting another series tomorrow to add the ti-sysc support
for PRUSS. Nevertheless, the PRUSS hwmods will not be used going forward
and can be dropped independently.

The IPU and DSP hwmods were never added for OMAP5 and DRA7xx/AM57xx SoCs,
and the MMU data was already dropped for 5.6-rc1, as it has all been
converted to ti-sysc and omap-prm. The DT nodes for these will follow
for the next merge window once the current OMAP remoteproc DT support
is accepted [1].

regards
Suman

[1] https://patchwork.kernel.org/cover/11396049/


Suman Anna (3):
  ARM: OMAP2+: Drop hwmod data for am3 and am4 PRUSS
  ARM: OMAP2+: Drop legacy platform data for OMAP4 DSP
  ARM: OMAP4: hwmod_data: Remove OMAP4 IPU hwmod data

 arch/arm/boot/dts/omap4.dtsi                  |   1 -
 .../omap_hwmod_33xx_43xx_common_data.h        |   2 -
 .../omap_hwmod_33xx_43xx_interconnect_data.c  |   8 --
 .../omap_hwmod_33xx_43xx_ipblock_data.c       |  33 -----
 arch/arm/mach-omap2/omap_hwmod_33xx_data.c    |  10 --
 arch/arm/mach-omap2/omap_hwmod_43xx_data.c    |   9 --
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c    | 127 ------------------
 7 files changed, 190 deletions(-)

-- 
2.23.0


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data
@ 2020-02-24 23:21 ` Suman Anna
  0 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2020-02-24 23:21 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Tero Kristo, linux-omap, Suman Anna, linux-arm-kernel, Roger Quadros

Hi Tony,

The following patches drop the hwmod data for PRUSS on AM33xx and AM437x
SoCs, and for the IPU and DSP processors on OMAP4 SoC. Patches are based
on 5.6-rc1. Please consider these for the 5.7 merge window.

I will be submitting another series tomorrow to add the ti-sysc support
for PRUSS. Nevertheless, the PRUSS hwmods will not be used going forward
and can be dropped independently.

The IPU and DSP hwmods were never added for OMAP5 and DRA7xx/AM57xx SoCs,
and the MMU data was already dropped for 5.6-rc1, as it has all been
converted to ti-sysc and omap-prm. The DT nodes for these will follow
for the next merge window once the current OMAP remoteproc DT support
is accepted [1].

regards
Suman

[1] https://patchwork.kernel.org/cover/11396049/


Suman Anna (3):
  ARM: OMAP2+: Drop hwmod data for am3 and am4 PRUSS
  ARM: OMAP2+: Drop legacy platform data for OMAP4 DSP
  ARM: OMAP4: hwmod_data: Remove OMAP4 IPU hwmod data

 arch/arm/boot/dts/omap4.dtsi                  |   1 -
 .../omap_hwmod_33xx_43xx_common_data.h        |   2 -
 .../omap_hwmod_33xx_43xx_interconnect_data.c  |   8 --
 .../omap_hwmod_33xx_43xx_ipblock_data.c       |  33 -----
 arch/arm/mach-omap2/omap_hwmod_33xx_data.c    |  10 --
 arch/arm/mach-omap2/omap_hwmod_43xx_data.c    |   9 --
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c    | 127 ------------------
 7 files changed, 190 deletions(-)

-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 1/3] ARM: OMAP2+: Drop hwmod data for am3 and am4 PRUSS
  2020-02-24 23:21 ` Suman Anna
@ 2020-02-24 23:21   ` Suman Anna
  -1 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2020-02-24 23:21 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Tero Kristo, Roger Quadros, linux-omap, linux-arm-kernel, Suman Anna

The PRUSS hwmod is currently not used in DT, and the new DTS
nodes shall be added using the ti-sysc infrastructure and the
omap-prm reset driver. Drop the legacy hwmod data for the
PRUSS module on both the AM33xx and AM437x family of SoCs.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 .../omap_hwmod_33xx_43xx_common_data.h        |  2 --
 .../omap_hwmod_33xx_43xx_interconnect_data.c  |  8 -----
 .../omap_hwmod_33xx_43xx_ipblock_data.c       | 33 -------------------
 arch/arm/mach-omap2/omap_hwmod_33xx_data.c    | 10 ------
 arch/arm/mach-omap2/omap_hwmod_43xx_data.c    |  9 -----
 5 files changed, 62 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_common_data.h b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_common_data.h
index 5ef76fe3f33d..75aabbf5ff22 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_common_data.h
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_common_data.h
@@ -24,7 +24,6 @@ extern struct omap_hwmod_ocp_if am33xx_l3_s__l4_wkup;
 extern struct omap_hwmod_ocp_if am33xx_l3_main__l3_instr;
 extern struct omap_hwmod_ocp_if am33xx_mpu__prcm;
 extern struct omap_hwmod_ocp_if am33xx_l3_s__l3_main;
-extern struct omap_hwmod_ocp_if am33xx_pruss__l3_main;
 extern struct omap_hwmod_ocp_if am33xx_gfx__l3_main;
 extern struct omap_hwmod_ocp_if am33xx_l3_main__gfx;
 extern struct omap_hwmod_ocp_if am33xx_l4_wkup__rtc;
@@ -42,7 +41,6 @@ extern struct omap_hwmod am33xx_l3_instr_hwmod;
 extern struct omap_hwmod am33xx_l4_ls_hwmod;
 extern struct omap_hwmod am33xx_l4_wkup_hwmod;
 extern struct omap_hwmod am33xx_mpu_hwmod;
-extern struct omap_hwmod am33xx_pruss_hwmod;
 extern struct omap_hwmod am33xx_gfx_hwmod;
 extern struct omap_hwmod am33xx_prcm_hwmod;
 extern struct omap_hwmod am33xx_ocmcram_hwmod;
diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_interconnect_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_interconnect_data.c
index ac7d5bb1a02f..4731946ee2ab 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_interconnect_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_interconnect_data.c
@@ -74,14 +74,6 @@ struct omap_hwmod_ocp_if am33xx_l3_s__l3_main = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* pru-icss -> l3 main */
-struct omap_hwmod_ocp_if am33xx_pruss__l3_main = {
-	.master		= &am33xx_pruss_hwmod,
-	.slave		= &am33xx_l3_main_hwmod,
-	.clk		= "l3_gclk",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* gfx -> l3 main */
 struct omap_hwmod_ocp_if am33xx_gfx__l3_main = {
 	.master		= &am33xx_gfx_hwmod,
diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c
index 78ec1bc8e3a1..dc2a684d375d 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c
@@ -133,34 +133,6 @@ struct omap_hwmod_class am33xx_wkup_m3_hwmod_class = {
 	.name		= "wkup_m3",
 };
 
-/*
- * 'pru-icss' class
- * Programmable Real-Time Unit and Industrial Communication Subsystem
- */
-static struct omap_hwmod_class am33xx_pruss_hwmod_class = {
-	.name	= "pruss",
-};
-
-static struct omap_hwmod_rst_info am33xx_pruss_resets[] = {
-	{ .name = "pruss", .rst_shift = 1 },
-};
-
-/* pru-icss */
-/* Pseudo hwmod for reset control purpose only */
-struct omap_hwmod am33xx_pruss_hwmod = {
-	.name		= "pruss",
-	.class		= &am33xx_pruss_hwmod_class,
-	.clkdm_name	= "pruss_ocp_clkdm",
-	.main_clk	= "pruss_ocp_gclk",
-	.prcm		= {
-		.omap4	= {
-			.modulemode	= MODULEMODE_SWCTRL,
-		},
-	},
-	.rst_lines	= am33xx_pruss_resets,
-	.rst_lines_cnt	= ARRAY_SIZE(am33xx_pruss_resets),
-};
-
 /* gfx */
 /* Pseudo hwmod for reset control purpose only */
 static struct omap_hwmod_class am33xx_gfx_hwmod_class = {
@@ -486,7 +458,6 @@ static void omap_hwmod_am33xx_clkctrl(void)
 	CLKCTRL(am33xx_tptc1_hwmod, AM33XX_CM_PER_TPTC1_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_tptc2_hwmod, AM33XX_CM_PER_TPTC2_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_gfx_hwmod, AM33XX_CM_GFX_GFX_CLKCTRL_OFFSET);
-	CLKCTRL(am33xx_pruss_hwmod, AM33XX_CM_PER_PRUSS_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_mpu_hwmod , AM33XX_CM_MPU_MPU_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_l3_instr_hwmod , AM33XX_CM_PER_L3_INSTR_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_ocmcram_hwmod , AM33XX_CM_PER_OCMCRAM_CLKCTRL_OFFSET);
@@ -494,7 +465,6 @@ static void omap_hwmod_am33xx_clkctrl(void)
 
 static void omap_hwmod_am33xx_rst(void)
 {
-	RSTCTRL(am33xx_pruss_hwmod, AM33XX_RM_PER_RSTCTRL_OFFSET);
 	RSTCTRL(am33xx_gfx_hwmod, AM33XX_RM_GFX_RSTCTRL_OFFSET);
 	RSTST(am33xx_gfx_hwmod, AM33XX_RM_GFX_RSTST_OFFSET);
 }
@@ -523,7 +493,6 @@ static void omap_hwmod_am43xx_clkctrl(void)
 	CLKCTRL(am33xx_tptc1_hwmod, AM43XX_CM_PER_TPTC1_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_tptc2_hwmod, AM43XX_CM_PER_TPTC2_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_gfx_hwmod, AM43XX_CM_GFX_GFX_CLKCTRL_OFFSET);
-	CLKCTRL(am33xx_pruss_hwmod, AM43XX_CM_PER_PRUSS_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_mpu_hwmod , AM43XX_CM_MPU_MPU_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_l3_instr_hwmod , AM43XX_CM_PER_L3_INSTR_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_ocmcram_hwmod , AM43XX_CM_PER_OCMCRAM_CLKCTRL_OFFSET);
@@ -531,9 +500,7 @@ static void omap_hwmod_am43xx_clkctrl(void)
 
 static void omap_hwmod_am43xx_rst(void)
 {
-	RSTCTRL(am33xx_pruss_hwmod, AM43XX_RM_PER_RSTCTRL_OFFSET);
 	RSTCTRL(am33xx_gfx_hwmod, AM43XX_RM_GFX_RSTCTRL_OFFSET);
-	RSTST(am33xx_pruss_hwmod, AM43XX_RM_PER_RSTST_OFFSET);
 	RSTST(am33xx_gfx_hwmod, AM43XX_RM_GFX_RSTST_OFFSET);
 }
 
diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
index f1ea8c604595..1c258616b9a9 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
@@ -233,14 +233,6 @@ static struct omap_hwmod_ocp_if am33xx_l4_wkup__wkup_m3 = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* l4 hs -> pru-icss */
-static struct omap_hwmod_ocp_if am33xx_l4_hs__pruss = {
-	.master		= &am33xx_l4_hs_hwmod,
-	.slave		= &am33xx_pruss_hwmod,
-	.clk		= "dpll_core_m4_ck",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* l3_main -> debugss */
 static struct omap_hwmod_ocp_if am33xx_l3_main__debugss = {
 	.master		= &am33xx_l3_main_hwmod,
@@ -292,7 +284,6 @@ static struct omap_hwmod_ocp_if *am33xx_hwmod_ocp_ifs[] __initdata = {
 	&am33xx_l3_main__l3_instr,
 	&am33xx_l3_main__gfx,
 	&am33xx_l3_s__l3_main,
-	&am33xx_pruss__l3_main,
 	&am33xx_wkup_m3__l4_wkup,
 	&am33xx_gfx__l3_main,
 	&am33xx_l3_main__debugss,
@@ -302,7 +293,6 @@ static struct omap_hwmod_ocp_if *am33xx_hwmod_ocp_ifs[] __initdata = {
 	&am33xx_l4_wkup__smartreflex1,
 	&am33xx_l4_wkup__timer1,
 	&am33xx_l4_wkup__rtc,
-	&am33xx_l4_hs__pruss,
 	&am33xx_l4_ls__timer2,
 	&am33xx_l3_main__tpcc,
 	&am33xx_l3_s__gpmc,
diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
index d0867dbd788e..e939dde4a5fe 100644
--- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
@@ -254,13 +254,6 @@ static struct omap_hwmod_ocp_if am43xx_l4_wkup__wkup_m3 = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-static struct omap_hwmod_ocp_if am43xx_l3_main__pruss = {
-	.master		= &am33xx_l3_main_hwmod,
-	.slave		= &am33xx_pruss_hwmod,
-	.clk		= "dpll_core_m4_ck",
-	.user		= OCP_USER_MPU,
-};
-
 static struct omap_hwmod_ocp_if am43xx_l4_wkup__smartreflex0 = {
 	.master		= &am33xx_l4_wkup_hwmod,
 	.slave		= &am33xx_smartreflex0_hwmod,
@@ -340,7 +333,6 @@ static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_rfbi = {
 
 static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = {
 	&am33xx_l4_wkup__synctimer,
-	&am43xx_l3_main__pruss,
 	&am33xx_mpu__l3_main,
 	&am33xx_mpu__prcm,
 	&am33xx_l3_s__l4_ls,
@@ -351,7 +343,6 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = {
 	&am33xx_l3_main__gfx,
 	&am33xx_l3_s__l3_main,
 	&am43xx_l3_main__emif,
-	&am33xx_pruss__l3_main,
 	&am43xx_wkup_m3__l4_wkup,
 	&am33xx_gfx__l3_main,
 	&am43xx_l4_wkup__wkup_m3,
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 1/3] ARM: OMAP2+: Drop hwmod data for am3 and am4 PRUSS
@ 2020-02-24 23:21   ` Suman Anna
  0 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2020-02-24 23:21 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Tero Kristo, linux-omap, Suman Anna, linux-arm-kernel, Roger Quadros

The PRUSS hwmod is currently not used in DT, and the new DTS
nodes shall be added using the ti-sysc infrastructure and the
omap-prm reset driver. Drop the legacy hwmod data for the
PRUSS module on both the AM33xx and AM437x family of SoCs.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 .../omap_hwmod_33xx_43xx_common_data.h        |  2 --
 .../omap_hwmod_33xx_43xx_interconnect_data.c  |  8 -----
 .../omap_hwmod_33xx_43xx_ipblock_data.c       | 33 -------------------
 arch/arm/mach-omap2/omap_hwmod_33xx_data.c    | 10 ------
 arch/arm/mach-omap2/omap_hwmod_43xx_data.c    |  9 -----
 5 files changed, 62 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_common_data.h b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_common_data.h
index 5ef76fe3f33d..75aabbf5ff22 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_common_data.h
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_common_data.h
@@ -24,7 +24,6 @@ extern struct omap_hwmod_ocp_if am33xx_l3_s__l4_wkup;
 extern struct omap_hwmod_ocp_if am33xx_l3_main__l3_instr;
 extern struct omap_hwmod_ocp_if am33xx_mpu__prcm;
 extern struct omap_hwmod_ocp_if am33xx_l3_s__l3_main;
-extern struct omap_hwmod_ocp_if am33xx_pruss__l3_main;
 extern struct omap_hwmod_ocp_if am33xx_gfx__l3_main;
 extern struct omap_hwmod_ocp_if am33xx_l3_main__gfx;
 extern struct omap_hwmod_ocp_if am33xx_l4_wkup__rtc;
@@ -42,7 +41,6 @@ extern struct omap_hwmod am33xx_l3_instr_hwmod;
 extern struct omap_hwmod am33xx_l4_ls_hwmod;
 extern struct omap_hwmod am33xx_l4_wkup_hwmod;
 extern struct omap_hwmod am33xx_mpu_hwmod;
-extern struct omap_hwmod am33xx_pruss_hwmod;
 extern struct omap_hwmod am33xx_gfx_hwmod;
 extern struct omap_hwmod am33xx_prcm_hwmod;
 extern struct omap_hwmod am33xx_ocmcram_hwmod;
diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_interconnect_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_interconnect_data.c
index ac7d5bb1a02f..4731946ee2ab 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_interconnect_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_interconnect_data.c
@@ -74,14 +74,6 @@ struct omap_hwmod_ocp_if am33xx_l3_s__l3_main = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* pru-icss -> l3 main */
-struct omap_hwmod_ocp_if am33xx_pruss__l3_main = {
-	.master		= &am33xx_pruss_hwmod,
-	.slave		= &am33xx_l3_main_hwmod,
-	.clk		= "l3_gclk",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* gfx -> l3 main */
 struct omap_hwmod_ocp_if am33xx_gfx__l3_main = {
 	.master		= &am33xx_gfx_hwmod,
diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c
index 78ec1bc8e3a1..dc2a684d375d 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c
@@ -133,34 +133,6 @@ struct omap_hwmod_class am33xx_wkup_m3_hwmod_class = {
 	.name		= "wkup_m3",
 };
 
-/*
- * 'pru-icss' class
- * Programmable Real-Time Unit and Industrial Communication Subsystem
- */
-static struct omap_hwmod_class am33xx_pruss_hwmod_class = {
-	.name	= "pruss",
-};
-
-static struct omap_hwmod_rst_info am33xx_pruss_resets[] = {
-	{ .name = "pruss", .rst_shift = 1 },
-};
-
-/* pru-icss */
-/* Pseudo hwmod for reset control purpose only */
-struct omap_hwmod am33xx_pruss_hwmod = {
-	.name		= "pruss",
-	.class		= &am33xx_pruss_hwmod_class,
-	.clkdm_name	= "pruss_ocp_clkdm",
-	.main_clk	= "pruss_ocp_gclk",
-	.prcm		= {
-		.omap4	= {
-			.modulemode	= MODULEMODE_SWCTRL,
-		},
-	},
-	.rst_lines	= am33xx_pruss_resets,
-	.rst_lines_cnt	= ARRAY_SIZE(am33xx_pruss_resets),
-};
-
 /* gfx */
 /* Pseudo hwmod for reset control purpose only */
 static struct omap_hwmod_class am33xx_gfx_hwmod_class = {
@@ -486,7 +458,6 @@ static void omap_hwmod_am33xx_clkctrl(void)
 	CLKCTRL(am33xx_tptc1_hwmod, AM33XX_CM_PER_TPTC1_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_tptc2_hwmod, AM33XX_CM_PER_TPTC2_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_gfx_hwmod, AM33XX_CM_GFX_GFX_CLKCTRL_OFFSET);
-	CLKCTRL(am33xx_pruss_hwmod, AM33XX_CM_PER_PRUSS_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_mpu_hwmod , AM33XX_CM_MPU_MPU_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_l3_instr_hwmod , AM33XX_CM_PER_L3_INSTR_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_ocmcram_hwmod , AM33XX_CM_PER_OCMCRAM_CLKCTRL_OFFSET);
@@ -494,7 +465,6 @@ static void omap_hwmod_am33xx_clkctrl(void)
 
 static void omap_hwmod_am33xx_rst(void)
 {
-	RSTCTRL(am33xx_pruss_hwmod, AM33XX_RM_PER_RSTCTRL_OFFSET);
 	RSTCTRL(am33xx_gfx_hwmod, AM33XX_RM_GFX_RSTCTRL_OFFSET);
 	RSTST(am33xx_gfx_hwmod, AM33XX_RM_GFX_RSTST_OFFSET);
 }
@@ -523,7 +493,6 @@ static void omap_hwmod_am43xx_clkctrl(void)
 	CLKCTRL(am33xx_tptc1_hwmod, AM43XX_CM_PER_TPTC1_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_tptc2_hwmod, AM43XX_CM_PER_TPTC2_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_gfx_hwmod, AM43XX_CM_GFX_GFX_CLKCTRL_OFFSET);
-	CLKCTRL(am33xx_pruss_hwmod, AM43XX_CM_PER_PRUSS_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_mpu_hwmod , AM43XX_CM_MPU_MPU_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_l3_instr_hwmod , AM43XX_CM_PER_L3_INSTR_CLKCTRL_OFFSET);
 	CLKCTRL(am33xx_ocmcram_hwmod , AM43XX_CM_PER_OCMCRAM_CLKCTRL_OFFSET);
@@ -531,9 +500,7 @@ static void omap_hwmod_am43xx_clkctrl(void)
 
 static void omap_hwmod_am43xx_rst(void)
 {
-	RSTCTRL(am33xx_pruss_hwmod, AM43XX_RM_PER_RSTCTRL_OFFSET);
 	RSTCTRL(am33xx_gfx_hwmod, AM43XX_RM_GFX_RSTCTRL_OFFSET);
-	RSTST(am33xx_pruss_hwmod, AM43XX_RM_PER_RSTST_OFFSET);
 	RSTST(am33xx_gfx_hwmod, AM43XX_RM_GFX_RSTST_OFFSET);
 }
 
diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
index f1ea8c604595..1c258616b9a9 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
@@ -233,14 +233,6 @@ static struct omap_hwmod_ocp_if am33xx_l4_wkup__wkup_m3 = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* l4 hs -> pru-icss */
-static struct omap_hwmod_ocp_if am33xx_l4_hs__pruss = {
-	.master		= &am33xx_l4_hs_hwmod,
-	.slave		= &am33xx_pruss_hwmod,
-	.clk		= "dpll_core_m4_ck",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* l3_main -> debugss */
 static struct omap_hwmod_ocp_if am33xx_l3_main__debugss = {
 	.master		= &am33xx_l3_main_hwmod,
@@ -292,7 +284,6 @@ static struct omap_hwmod_ocp_if *am33xx_hwmod_ocp_ifs[] __initdata = {
 	&am33xx_l3_main__l3_instr,
 	&am33xx_l3_main__gfx,
 	&am33xx_l3_s__l3_main,
-	&am33xx_pruss__l3_main,
 	&am33xx_wkup_m3__l4_wkup,
 	&am33xx_gfx__l3_main,
 	&am33xx_l3_main__debugss,
@@ -302,7 +293,6 @@ static struct omap_hwmod_ocp_if *am33xx_hwmod_ocp_ifs[] __initdata = {
 	&am33xx_l4_wkup__smartreflex1,
 	&am33xx_l4_wkup__timer1,
 	&am33xx_l4_wkup__rtc,
-	&am33xx_l4_hs__pruss,
 	&am33xx_l4_ls__timer2,
 	&am33xx_l3_main__tpcc,
 	&am33xx_l3_s__gpmc,
diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
index d0867dbd788e..e939dde4a5fe 100644
--- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
@@ -254,13 +254,6 @@ static struct omap_hwmod_ocp_if am43xx_l4_wkup__wkup_m3 = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-static struct omap_hwmod_ocp_if am43xx_l3_main__pruss = {
-	.master		= &am33xx_l3_main_hwmod,
-	.slave		= &am33xx_pruss_hwmod,
-	.clk		= "dpll_core_m4_ck",
-	.user		= OCP_USER_MPU,
-};
-
 static struct omap_hwmod_ocp_if am43xx_l4_wkup__smartreflex0 = {
 	.master		= &am33xx_l4_wkup_hwmod,
 	.slave		= &am33xx_smartreflex0_hwmod,
@@ -340,7 +333,6 @@ static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_rfbi = {
 
 static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = {
 	&am33xx_l4_wkup__synctimer,
-	&am43xx_l3_main__pruss,
 	&am33xx_mpu__l3_main,
 	&am33xx_mpu__prcm,
 	&am33xx_l3_s__l4_ls,
@@ -351,7 +343,6 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = {
 	&am33xx_l3_main__gfx,
 	&am33xx_l3_s__l3_main,
 	&am43xx_l3_main__emif,
-	&am33xx_pruss__l3_main,
 	&am43xx_wkup_m3__l4_wkup,
 	&am33xx_gfx__l3_main,
 	&am43xx_l4_wkup__wkup_m3,
-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 2/3] ARM: OMAP2+: Drop legacy platform data for OMAP4 DSP
  2020-02-24 23:21 ` Suman Anna
@ 2020-02-24 23:21   ` Suman Anna
  -1 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2020-02-24 23:21 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Tero Kristo, Roger Quadros, linux-omap, linux-arm-kernel, Suman Anna

The OMAP4 DSP hwmod is used in DT, but the DT node is not
probing any real driver. The DSP device-tree node shall be
updated as per the new OMAP remoteproc bindings with the
underneath MMU device relying on the ti-sysc infrastructure.

Drop the legacy hwmod data for the DSP device along with the
custom ti,hwmods property. They have to be dropped together
since the early platform data init code is based on the custom
ti,hwmods property.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/boot/dts/omap4.dtsi               |  1 -
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 76 ----------------------
 2 files changed, 77 deletions(-)

diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 9a87440d0b9d..48b97f818a68 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -108,7 +108,6 @@
 
 		dsp {
 			compatible = "ti,omap3-c64";
-			ti,hwmods = "dsp";
 		};
 
 		iva {
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index b7c51ea8c9a6..1d4359a43cab 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -355,37 +355,6 @@ static struct omap_hwmod omap44xx_debugss_hwmod = {
 	},
 };
 
-/*
- * 'dsp' class
- * dsp sub-system
- */
-
-static struct omap_hwmod_class omap44xx_dsp_hwmod_class = {
-	.name	= "dsp",
-};
-
-/* dsp */
-static struct omap_hwmod_rst_info omap44xx_dsp_resets[] = {
-	{ .name = "dsp", .rst_shift = 0 },
-};
-
-static struct omap_hwmod omap44xx_dsp_hwmod = {
-	.name		= "dsp",
-	.class		= &omap44xx_dsp_hwmod_class,
-	.clkdm_name	= "tesla_clkdm",
-	.rst_lines	= omap44xx_dsp_resets,
-	.rst_lines_cnt	= ARRAY_SIZE(omap44xx_dsp_resets),
-	.main_clk	= "dpll_iva_m4x2_ck",
-	.prcm = {
-		.omap4 = {
-			.clkctrl_offs = OMAP4_CM_TESLA_TESLA_CLKCTRL_OFFSET,
-			.rstctrl_offs = OMAP4_RM_TESLA_RSTCTRL_OFFSET,
-			.context_offs = OMAP4_RM_TESLA_TESLA_CONTEXT_OFFSET,
-			.modulemode   = MODULEMODE_HWCTRL,
-		},
-	},
-};
-
 /*
  * 'dss' class
  * display sub-system
@@ -1236,14 +1205,6 @@ static struct omap_hwmod_ocp_if omap44xx_ocp_wp_noc__l3_instr = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* dsp -> l3_main_1 */
-static struct omap_hwmod_ocp_if omap44xx_dsp__l3_main_1 = {
-	.master		= &omap44xx_dsp_hwmod,
-	.slave		= &omap44xx_l3_main_1_hwmod,
-	.clk		= "l3_div_ck",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* dss -> l3_main_1 */
 static struct omap_hwmod_ocp_if omap44xx_dss__l3_main_1 = {
 	.master		= &omap44xx_dss_hwmod,
@@ -1364,14 +1325,6 @@ static struct omap_hwmod_ocp_if omap44xx_l4_cfg__l3_main_3 = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* dsp -> l4_abe */
-static struct omap_hwmod_ocp_if omap44xx_dsp__l4_abe = {
-	.master		= &omap44xx_dsp_hwmod,
-	.slave		= &omap44xx_l4_abe_hwmod,
-	.clk		= "ocp_abe_iclk",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* l3_main_1 -> l4_abe */
 static struct omap_hwmod_ocp_if omap44xx_l3_main_1__l4_abe = {
 	.master		= &omap44xx_l3_main_1_hwmod,
@@ -1476,30 +1429,6 @@ static struct omap_hwmod_ocp_if omap44xx_l3_instr__debugss = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* dsp -> iva */
-static struct omap_hwmod_ocp_if omap44xx_dsp__iva = {
-	.master		= &omap44xx_dsp_hwmod,
-	.slave		= &omap44xx_iva_hwmod,
-	.clk		= "dpll_iva_m5x2_ck",
-	.user		= OCP_USER_DSP,
-};
-
-/* dsp -> sl2if */
-static struct omap_hwmod_ocp_if __maybe_unused omap44xx_dsp__sl2if = {
-	.master		= &omap44xx_dsp_hwmod,
-	.slave		= &omap44xx_sl2if_hwmod,
-	.clk		= "dpll_iva_m5x2_ck",
-	.user		= OCP_USER_DSP,
-};
-
-/* l4_cfg -> dsp */
-static struct omap_hwmod_ocp_if omap44xx_l4_cfg__dsp = {
-	.master		= &omap44xx_l4_cfg_hwmod,
-	.slave		= &omap44xx_dsp_hwmod,
-	.clk		= "l4_div_ck",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* l3_main_2 -> dss */
 static struct omap_hwmod_ocp_if omap44xx_l3_main_2__dss = {
 	.master		= &omap44xx_l3_main_2_hwmod,
@@ -1762,7 +1691,6 @@ static struct omap_hwmod_ocp_if *omap44xx_hwmod_ocp_ifs[] __initdata = {
 	&omap44xx_iva__l3_instr,
 	&omap44xx_l3_main_3__l3_instr,
 	&omap44xx_ocp_wp_noc__l3_instr,
-	&omap44xx_dsp__l3_main_1,
 	&omap44xx_dss__l3_main_1,
 	&omap44xx_l3_main_2__l3_main_1,
 	&omap44xx_l4_cfg__l3_main_1,
@@ -1778,7 +1706,6 @@ static struct omap_hwmod_ocp_if *omap44xx_hwmod_ocp_ifs[] __initdata = {
 	&omap44xx_l3_main_1__l3_main_3,
 	&omap44xx_l3_main_2__l3_main_3,
 	&omap44xx_l4_cfg__l3_main_3,
-	&omap44xx_dsp__l4_abe,
 	&omap44xx_l3_main_1__l4_abe,
 	&omap44xx_mpu__l4_abe,
 	&omap44xx_l3_main_1__l4_cfg,
@@ -1792,9 +1719,6 @@ static struct omap_hwmod_ocp_if *omap44xx_hwmod_ocp_ifs[] __initdata = {
 	&omap44xx_l4_wkup__ctrl_module_wkup,
 	&omap44xx_l4_wkup__ctrl_module_pad_wkup,
 	&omap44xx_l3_instr__debugss,
-	&omap44xx_dsp__iva,
-	/* &omap44xx_dsp__sl2if, */
-	&omap44xx_l4_cfg__dsp,
 	&omap44xx_l3_main_2__dss,
 	&omap44xx_l4_per__dss,
 	&omap44xx_l3_main_2__dss_dispc,
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 2/3] ARM: OMAP2+: Drop legacy platform data for OMAP4 DSP
@ 2020-02-24 23:21   ` Suman Anna
  0 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2020-02-24 23:21 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Tero Kristo, linux-omap, Suman Anna, linux-arm-kernel, Roger Quadros

The OMAP4 DSP hwmod is used in DT, but the DT node is not
probing any real driver. The DSP device-tree node shall be
updated as per the new OMAP remoteproc bindings with the
underneath MMU device relying on the ti-sysc infrastructure.

Drop the legacy hwmod data for the DSP device along with the
custom ti,hwmods property. They have to be dropped together
since the early platform data init code is based on the custom
ti,hwmods property.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/boot/dts/omap4.dtsi               |  1 -
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 76 ----------------------
 2 files changed, 77 deletions(-)

diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 9a87440d0b9d..48b97f818a68 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -108,7 +108,6 @@
 
 		dsp {
 			compatible = "ti,omap3-c64";
-			ti,hwmods = "dsp";
 		};
 
 		iva {
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index b7c51ea8c9a6..1d4359a43cab 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -355,37 +355,6 @@ static struct omap_hwmod omap44xx_debugss_hwmod = {
 	},
 };
 
-/*
- * 'dsp' class
- * dsp sub-system
- */
-
-static struct omap_hwmod_class omap44xx_dsp_hwmod_class = {
-	.name	= "dsp",
-};
-
-/* dsp */
-static struct omap_hwmod_rst_info omap44xx_dsp_resets[] = {
-	{ .name = "dsp", .rst_shift = 0 },
-};
-
-static struct omap_hwmod omap44xx_dsp_hwmod = {
-	.name		= "dsp",
-	.class		= &omap44xx_dsp_hwmod_class,
-	.clkdm_name	= "tesla_clkdm",
-	.rst_lines	= omap44xx_dsp_resets,
-	.rst_lines_cnt	= ARRAY_SIZE(omap44xx_dsp_resets),
-	.main_clk	= "dpll_iva_m4x2_ck",
-	.prcm = {
-		.omap4 = {
-			.clkctrl_offs = OMAP4_CM_TESLA_TESLA_CLKCTRL_OFFSET,
-			.rstctrl_offs = OMAP4_RM_TESLA_RSTCTRL_OFFSET,
-			.context_offs = OMAP4_RM_TESLA_TESLA_CONTEXT_OFFSET,
-			.modulemode   = MODULEMODE_HWCTRL,
-		},
-	},
-};
-
 /*
  * 'dss' class
  * display sub-system
@@ -1236,14 +1205,6 @@ static struct omap_hwmod_ocp_if omap44xx_ocp_wp_noc__l3_instr = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* dsp -> l3_main_1 */
-static struct omap_hwmod_ocp_if omap44xx_dsp__l3_main_1 = {
-	.master		= &omap44xx_dsp_hwmod,
-	.slave		= &omap44xx_l3_main_1_hwmod,
-	.clk		= "l3_div_ck",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* dss -> l3_main_1 */
 static struct omap_hwmod_ocp_if omap44xx_dss__l3_main_1 = {
 	.master		= &omap44xx_dss_hwmod,
@@ -1364,14 +1325,6 @@ static struct omap_hwmod_ocp_if omap44xx_l4_cfg__l3_main_3 = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* dsp -> l4_abe */
-static struct omap_hwmod_ocp_if omap44xx_dsp__l4_abe = {
-	.master		= &omap44xx_dsp_hwmod,
-	.slave		= &omap44xx_l4_abe_hwmod,
-	.clk		= "ocp_abe_iclk",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* l3_main_1 -> l4_abe */
 static struct omap_hwmod_ocp_if omap44xx_l3_main_1__l4_abe = {
 	.master		= &omap44xx_l3_main_1_hwmod,
@@ -1476,30 +1429,6 @@ static struct omap_hwmod_ocp_if omap44xx_l3_instr__debugss = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* dsp -> iva */
-static struct omap_hwmod_ocp_if omap44xx_dsp__iva = {
-	.master		= &omap44xx_dsp_hwmod,
-	.slave		= &omap44xx_iva_hwmod,
-	.clk		= "dpll_iva_m5x2_ck",
-	.user		= OCP_USER_DSP,
-};
-
-/* dsp -> sl2if */
-static struct omap_hwmod_ocp_if __maybe_unused omap44xx_dsp__sl2if = {
-	.master		= &omap44xx_dsp_hwmod,
-	.slave		= &omap44xx_sl2if_hwmod,
-	.clk		= "dpll_iva_m5x2_ck",
-	.user		= OCP_USER_DSP,
-};
-
-/* l4_cfg -> dsp */
-static struct omap_hwmod_ocp_if omap44xx_l4_cfg__dsp = {
-	.master		= &omap44xx_l4_cfg_hwmod,
-	.slave		= &omap44xx_dsp_hwmod,
-	.clk		= "l4_div_ck",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* l3_main_2 -> dss */
 static struct omap_hwmod_ocp_if omap44xx_l3_main_2__dss = {
 	.master		= &omap44xx_l3_main_2_hwmod,
@@ -1762,7 +1691,6 @@ static struct omap_hwmod_ocp_if *omap44xx_hwmod_ocp_ifs[] __initdata = {
 	&omap44xx_iva__l3_instr,
 	&omap44xx_l3_main_3__l3_instr,
 	&omap44xx_ocp_wp_noc__l3_instr,
-	&omap44xx_dsp__l3_main_1,
 	&omap44xx_dss__l3_main_1,
 	&omap44xx_l3_main_2__l3_main_1,
 	&omap44xx_l4_cfg__l3_main_1,
@@ -1778,7 +1706,6 @@ static struct omap_hwmod_ocp_if *omap44xx_hwmod_ocp_ifs[] __initdata = {
 	&omap44xx_l3_main_1__l3_main_3,
 	&omap44xx_l3_main_2__l3_main_3,
 	&omap44xx_l4_cfg__l3_main_3,
-	&omap44xx_dsp__l4_abe,
 	&omap44xx_l3_main_1__l4_abe,
 	&omap44xx_mpu__l4_abe,
 	&omap44xx_l3_main_1__l4_cfg,
@@ -1792,9 +1719,6 @@ static struct omap_hwmod_ocp_if *omap44xx_hwmod_ocp_ifs[] __initdata = {
 	&omap44xx_l4_wkup__ctrl_module_wkup,
 	&omap44xx_l4_wkup__ctrl_module_pad_wkup,
 	&omap44xx_l3_instr__debugss,
-	&omap44xx_dsp__iva,
-	/* &omap44xx_dsp__sl2if, */
-	&omap44xx_l4_cfg__dsp,
 	&omap44xx_l3_main_2__dss,
 	&omap44xx_l4_per__dss,
 	&omap44xx_l3_main_2__dss_dispc,
-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 3/3] ARM: OMAP4: hwmod_data: Remove OMAP4 IPU hwmod data
  2020-02-24 23:21 ` Suman Anna
@ 2020-02-24 23:21   ` Suman Anna
  -1 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2020-02-24 23:21 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Tero Kristo, Roger Quadros, linux-omap, linux-arm-kernel, Suman Anna

The OMAP4 IPU hwmod is currently not used in DT, and the new DTS
node shall be added as per the new OMAP remoteproc bindings with
the underneath MMU device relying on the ti-sysc infrastructure.
Drop the legacy hwmod data for OMAP4 IPU as this will not be used
going forward.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 51 ----------------------
 1 file changed, 51 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 1d4359a43cab..a616ddf8fb52 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -706,39 +706,6 @@ static struct omap_hwmod omap44xx_gpmc_hwmod = {
 	},
 };
 
-
-/*
- * 'ipu' class
- * imaging processor unit
- */
-
-static struct omap_hwmod_class omap44xx_ipu_hwmod_class = {
-	.name	= "ipu",
-};
-
-/* ipu */
-static struct omap_hwmod_rst_info omap44xx_ipu_resets[] = {
-	{ .name = "cpu0", .rst_shift = 0 },
-	{ .name = "cpu1", .rst_shift = 1 },
-};
-
-static struct omap_hwmod omap44xx_ipu_hwmod = {
-	.name		= "ipu",
-	.class		= &omap44xx_ipu_hwmod_class,
-	.clkdm_name	= "ducati_clkdm",
-	.rst_lines	= omap44xx_ipu_resets,
-	.rst_lines_cnt	= ARRAY_SIZE(omap44xx_ipu_resets),
-	.main_clk	= "ducati_clk_mux_ck",
-	.prcm = {
-		.omap4 = {
-			.clkctrl_offs = OMAP4_CM_DUCATI_DUCATI_CLKCTRL_OFFSET,
-			.rstctrl_offs = OMAP4_RM_DUCATI_RSTCTRL_OFFSET,
-			.context_offs = OMAP4_RM_DUCATI_DUCATI_CONTEXT_OFFSET,
-			.modulemode   = MODULEMODE_HWCTRL,
-		},
-	},
-};
-
 /*
  * 'iss' class
  * external images sensor pixel data processor
@@ -1245,14 +1212,6 @@ static struct omap_hwmod_ocp_if omap44xx_debugss__l3_main_2 = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* ipu -> l3_main_2 */
-static struct omap_hwmod_ocp_if omap44xx_ipu__l3_main_2 = {
-	.master		= &omap44xx_ipu_hwmod,
-	.slave		= &omap44xx_l3_main_2_hwmod,
-	.clk		= "l3_div_ck",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* iss -> l3_main_2 */
 static struct omap_hwmod_ocp_if omap44xx_iss__l3_main_2 = {
 	.master		= &omap44xx_iss_hwmod,
@@ -1549,14 +1508,6 @@ static struct omap_hwmod_ocp_if omap44xx_l3_main_2__gpmc = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* l3_main_2 -> ipu */
-static struct omap_hwmod_ocp_if omap44xx_l3_main_2__ipu = {
-	.master		= &omap44xx_l3_main_2_hwmod,
-	.slave		= &omap44xx_ipu_hwmod,
-	.clk		= "l3_div_ck",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* l3_main_2 -> iss */
 static struct omap_hwmod_ocp_if omap44xx_l3_main_2__iss = {
 	.master		= &omap44xx_l3_main_2_hwmod,
@@ -1696,7 +1647,6 @@ static struct omap_hwmod_ocp_if *omap44xx_hwmod_ocp_ifs[] __initdata = {
 	&omap44xx_l4_cfg__l3_main_1,
 	&omap44xx_mpu__l3_main_1,
 	&omap44xx_debugss__l3_main_2,
-	&omap44xx_ipu__l3_main_2,
 	&omap44xx_iss__l3_main_2,
 	&omap44xx_iva__l3_main_2,
 	&omap44xx_l3_main_1__l3_main_2,
@@ -1734,7 +1684,6 @@ static struct omap_hwmod_ocp_if *omap44xx_hwmod_ocp_ifs[] __initdata = {
 	&omap44xx_l3_main_2__dss_venc,
 	&omap44xx_l4_per__dss_venc,
 	&omap44xx_l3_main_2__gpmc,
-	&omap44xx_l3_main_2__ipu,
 	&omap44xx_l3_main_2__iss,
 	/* &omap44xx_iva__sl2if, */
 	&omap44xx_l3_main_2__iva,
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 3/3] ARM: OMAP4: hwmod_data: Remove OMAP4 IPU hwmod data
@ 2020-02-24 23:21   ` Suman Anna
  0 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2020-02-24 23:21 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Tero Kristo, linux-omap, Suman Anna, linux-arm-kernel, Roger Quadros

The OMAP4 IPU hwmod is currently not used in DT, and the new DTS
node shall be added as per the new OMAP remoteproc bindings with
the underneath MMU device relying on the ti-sysc infrastructure.
Drop the legacy hwmod data for OMAP4 IPU as this will not be used
going forward.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 51 ----------------------
 1 file changed, 51 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 1d4359a43cab..a616ddf8fb52 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -706,39 +706,6 @@ static struct omap_hwmod omap44xx_gpmc_hwmod = {
 	},
 };
 
-
-/*
- * 'ipu' class
- * imaging processor unit
- */
-
-static struct omap_hwmod_class omap44xx_ipu_hwmod_class = {
-	.name	= "ipu",
-};
-
-/* ipu */
-static struct omap_hwmod_rst_info omap44xx_ipu_resets[] = {
-	{ .name = "cpu0", .rst_shift = 0 },
-	{ .name = "cpu1", .rst_shift = 1 },
-};
-
-static struct omap_hwmod omap44xx_ipu_hwmod = {
-	.name		= "ipu",
-	.class		= &omap44xx_ipu_hwmod_class,
-	.clkdm_name	= "ducati_clkdm",
-	.rst_lines	= omap44xx_ipu_resets,
-	.rst_lines_cnt	= ARRAY_SIZE(omap44xx_ipu_resets),
-	.main_clk	= "ducati_clk_mux_ck",
-	.prcm = {
-		.omap4 = {
-			.clkctrl_offs = OMAP4_CM_DUCATI_DUCATI_CLKCTRL_OFFSET,
-			.rstctrl_offs = OMAP4_RM_DUCATI_RSTCTRL_OFFSET,
-			.context_offs = OMAP4_RM_DUCATI_DUCATI_CONTEXT_OFFSET,
-			.modulemode   = MODULEMODE_HWCTRL,
-		},
-	},
-};
-
 /*
  * 'iss' class
  * external images sensor pixel data processor
@@ -1245,14 +1212,6 @@ static struct omap_hwmod_ocp_if omap44xx_debugss__l3_main_2 = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* ipu -> l3_main_2 */
-static struct omap_hwmod_ocp_if omap44xx_ipu__l3_main_2 = {
-	.master		= &omap44xx_ipu_hwmod,
-	.slave		= &omap44xx_l3_main_2_hwmod,
-	.clk		= "l3_div_ck",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* iss -> l3_main_2 */
 static struct omap_hwmod_ocp_if omap44xx_iss__l3_main_2 = {
 	.master		= &omap44xx_iss_hwmod,
@@ -1549,14 +1508,6 @@ static struct omap_hwmod_ocp_if omap44xx_l3_main_2__gpmc = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
-/* l3_main_2 -> ipu */
-static struct omap_hwmod_ocp_if omap44xx_l3_main_2__ipu = {
-	.master		= &omap44xx_l3_main_2_hwmod,
-	.slave		= &omap44xx_ipu_hwmod,
-	.clk		= "l3_div_ck",
-	.user		= OCP_USER_MPU | OCP_USER_SDMA,
-};
-
 /* l3_main_2 -> iss */
 static struct omap_hwmod_ocp_if omap44xx_l3_main_2__iss = {
 	.master		= &omap44xx_l3_main_2_hwmod,
@@ -1696,7 +1647,6 @@ static struct omap_hwmod_ocp_if *omap44xx_hwmod_ocp_ifs[] __initdata = {
 	&omap44xx_l4_cfg__l3_main_1,
 	&omap44xx_mpu__l3_main_1,
 	&omap44xx_debugss__l3_main_2,
-	&omap44xx_ipu__l3_main_2,
 	&omap44xx_iss__l3_main_2,
 	&omap44xx_iva__l3_main_2,
 	&omap44xx_l3_main_1__l3_main_2,
@@ -1734,7 +1684,6 @@ static struct omap_hwmod_ocp_if *omap44xx_hwmod_ocp_ifs[] __initdata = {
 	&omap44xx_l3_main_2__dss_venc,
 	&omap44xx_l4_per__dss_venc,
 	&omap44xx_l3_main_2__gpmc,
-	&omap44xx_l3_main_2__ipu,
 	&omap44xx_l3_main_2__iss,
 	/* &omap44xx_iva__sl2if, */
 	&omap44xx_l3_main_2__iva,
-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data
  2020-02-24 23:21 ` Suman Anna
@ 2020-02-26 18:26   ` Tony Lindgren
  -1 siblings, 0 replies; 18+ messages in thread
From: Tony Lindgren @ 2020-02-26 18:26 UTC (permalink / raw)
  To: Suman Anna; +Cc: Tero Kristo, Roger Quadros, linux-omap, linux-arm-kernel

* Suman Anna <s-anna@ti.com> [200224 15:22]:
> Hi Tony,
> 
> The following patches drop the hwmod data for PRUSS on AM33xx and AM437x
> SoCs, and for the IPU and DSP processors on OMAP4 SoC. Patches are based
> on 5.6-rc1. Please consider these for the 5.7 merge window.
> 
> I will be submitting another series tomorrow to add the ti-sysc support
> for PRUSS. Nevertheless, the PRUSS hwmods will not be used going forward
> and can be dropped independently.
> 
> The IPU and DSP hwmods were never added for OMAP5 and DRA7xx/AM57xx SoCs,
> and the MMU data was already dropped for 5.6-rc1, as it has all been
> converted to ti-sysc and omap-prm. The DT nodes for these will follow
> for the next merge window once the current OMAP remoteproc DT support
> is accepted [1].

Well we still need the hwmod data until dts data is in place to reset
and idle these modules. So I'll wait with this set until we have the
dts changes in place.

Regards,

Tony

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data
@ 2020-02-26 18:26   ` Tony Lindgren
  0 siblings, 0 replies; 18+ messages in thread
From: Tony Lindgren @ 2020-02-26 18:26 UTC (permalink / raw)
  To: Suman Anna; +Cc: Tero Kristo, linux-omap, linux-arm-kernel, Roger Quadros

* Suman Anna <s-anna@ti.com> [200224 15:22]:
> Hi Tony,
> 
> The following patches drop the hwmod data for PRUSS on AM33xx and AM437x
> SoCs, and for the IPU and DSP processors on OMAP4 SoC. Patches are based
> on 5.6-rc1. Please consider these for the 5.7 merge window.
> 
> I will be submitting another series tomorrow to add the ti-sysc support
> for PRUSS. Nevertheless, the PRUSS hwmods will not be used going forward
> and can be dropped independently.
> 
> The IPU and DSP hwmods were never added for OMAP5 and DRA7xx/AM57xx SoCs,
> and the MMU data was already dropped for 5.6-rc1, as it has all been
> converted to ti-sysc and omap-prm. The DT nodes for these will follow
> for the next merge window once the current OMAP remoteproc DT support
> is accepted [1].

Well we still need the hwmod data until dts data is in place to reset
and idle these modules. So I'll wait with this set until we have the
dts changes in place.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data
  2020-02-26 18:26   ` Tony Lindgren
@ 2020-02-26 20:30     ` Suman Anna
  -1 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2020-02-26 20:30 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: Tero Kristo, Roger Quadros, linux-omap, linux-arm-kernel

On 2/26/20 12:26 PM, Tony Lindgren wrote:
> * Suman Anna <s-anna@ti.com> [200224 15:22]:
>> Hi Tony,
>>
>> The following patches drop the hwmod data for PRUSS on AM33xx and AM437x
>> SoCs, and for the IPU and DSP processors on OMAP4 SoC. Patches are based
>> on 5.6-rc1. Please consider these for the 5.7 merge window.
>>
>> I will be submitting another series tomorrow to add the ti-sysc support
>> for PRUSS. Nevertheless, the PRUSS hwmods will not be used going forward
>> and can be dropped independently.
>>
>> The IPU and DSP hwmods were never added for OMAP5 and DRA7xx/AM57xx SoCs,
>> and the MMU data was already dropped for 5.6-rc1, as it has all been
>> converted to ti-sysc and omap-prm. The DT nodes for these will follow
>> for the next merge window once the current OMAP remoteproc DT support
>> is accepted [1].
> 
> Well we still need the hwmod data until dts data is in place to reset
> and idle these modules. So I'll wait with this set until we have the
> dts changes in place.

Not really, you cannot just idle these processors devices by themselves
without the cores running. The hwmod code actually keeps these in the
default reset asserted state itself, so no harm done in dropping the
data. The remoteproc bindings are acked, so for next merge window, we
can post the dts nodes once those get merged.

regards
Suman


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data
@ 2020-02-26 20:30     ` Suman Anna
  0 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2020-02-26 20:30 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: Tero Kristo, linux-omap, linux-arm-kernel, Roger Quadros

On 2/26/20 12:26 PM, Tony Lindgren wrote:
> * Suman Anna <s-anna@ti.com> [200224 15:22]:
>> Hi Tony,
>>
>> The following patches drop the hwmod data for PRUSS on AM33xx and AM437x
>> SoCs, and for the IPU and DSP processors on OMAP4 SoC. Patches are based
>> on 5.6-rc1. Please consider these for the 5.7 merge window.
>>
>> I will be submitting another series tomorrow to add the ti-sysc support
>> for PRUSS. Nevertheless, the PRUSS hwmods will not be used going forward
>> and can be dropped independently.
>>
>> The IPU and DSP hwmods were never added for OMAP5 and DRA7xx/AM57xx SoCs,
>> and the MMU data was already dropped for 5.6-rc1, as it has all been
>> converted to ti-sysc and omap-prm. The DT nodes for these will follow
>> for the next merge window once the current OMAP remoteproc DT support
>> is accepted [1].
> 
> Well we still need the hwmod data until dts data is in place to reset
> and idle these modules. So I'll wait with this set until we have the
> dts changes in place.

Not really, you cannot just idle these processors devices by themselves
without the cores running. The hwmod code actually keeps these in the
default reset asserted state itself, so no harm done in dropping the
data. The remoteproc bindings are acked, so for next merge window, we
can post the dts nodes once those get merged.

regards
Suman


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data
  2020-02-26 20:30     ` Suman Anna
@ 2020-02-27  1:27       ` Tony Lindgren
  -1 siblings, 0 replies; 18+ messages in thread
From: Tony Lindgren @ 2020-02-27  1:27 UTC (permalink / raw)
  To: Suman Anna; +Cc: Tero Kristo, Roger Quadros, linux-omap, linux-arm-kernel

* Suman Anna <s-anna@ti.com> [200226 20:31]:
> On 2/26/20 12:26 PM, Tony Lindgren wrote:
> > * Suman Anna <s-anna@ti.com> [200224 15:22]:
> >> Hi Tony,
> >>
> >> The following patches drop the hwmod data for PRUSS on AM33xx and AM437x
> >> SoCs, and for the IPU and DSP processors on OMAP4 SoC. Patches are based
> >> on 5.6-rc1. Please consider these for the 5.7 merge window.
> >>
> >> I will be submitting another series tomorrow to add the ti-sysc support
> >> for PRUSS. Nevertheless, the PRUSS hwmods will not be used going forward
> >> and can be dropped independently.
> >>
> >> The IPU and DSP hwmods were never added for OMAP5 and DRA7xx/AM57xx SoCs,
> >> and the MMU data was already dropped for 5.6-rc1, as it has all been
> >> converted to ti-sysc and omap-prm. The DT nodes for these will follow
> >> for the next merge window once the current OMAP remoteproc DT support
> >> is accepted [1].
> > 
> > Well we still need the hwmod data until dts data is in place to reset
> > and idle these modules. So I'll wait with this set until we have the
> > dts changes in place.
> 
> Not really, you cannot just idle these processors devices by themselves
> without the cores running. The hwmod code actually keeps these in the
> default reset asserted state itself, so no harm done in dropping the
> data. The remoteproc bindings are acked, so for next merge window, we
> can post the dts nodes once those get merged.

OK if they are in reset from the bootloader.. I'll try to check.

Regards,

Tony

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data
@ 2020-02-27  1:27       ` Tony Lindgren
  0 siblings, 0 replies; 18+ messages in thread
From: Tony Lindgren @ 2020-02-27  1:27 UTC (permalink / raw)
  To: Suman Anna; +Cc: Tero Kristo, linux-omap, linux-arm-kernel, Roger Quadros

* Suman Anna <s-anna@ti.com> [200226 20:31]:
> On 2/26/20 12:26 PM, Tony Lindgren wrote:
> > * Suman Anna <s-anna@ti.com> [200224 15:22]:
> >> Hi Tony,
> >>
> >> The following patches drop the hwmod data for PRUSS on AM33xx and AM437x
> >> SoCs, and for the IPU and DSP processors on OMAP4 SoC. Patches are based
> >> on 5.6-rc1. Please consider these for the 5.7 merge window.
> >>
> >> I will be submitting another series tomorrow to add the ti-sysc support
> >> for PRUSS. Nevertheless, the PRUSS hwmods will not be used going forward
> >> and can be dropped independently.
> >>
> >> The IPU and DSP hwmods were never added for OMAP5 and DRA7xx/AM57xx SoCs,
> >> and the MMU data was already dropped for 5.6-rc1, as it has all been
> >> converted to ti-sysc and omap-prm. The DT nodes for these will follow
> >> for the next merge window once the current OMAP remoteproc DT support
> >> is accepted [1].
> > 
> > Well we still need the hwmod data until dts data is in place to reset
> > and idle these modules. So I'll wait with this set until we have the
> > dts changes in place.
> 
> Not really, you cannot just idle these processors devices by themselves
> without the cores running. The hwmod code actually keeps these in the
> default reset asserted state itself, so no harm done in dropping the
> data. The remoteproc bindings are acked, so for next merge window, we
> can post the dts nodes once those get merged.

OK if they are in reset from the bootloader.. I'll try to check.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data
  2020-02-27  1:27       ` Tony Lindgren
@ 2020-02-27 17:40         ` Suman Anna
  -1 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2020-02-27 17:40 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: Tero Kristo, Roger Quadros, linux-omap, linux-arm-kernel

On 2/26/20 7:27 PM, Tony Lindgren wrote:
> * Suman Anna <s-anna@ti.com> [200226 20:31]:
>> On 2/26/20 12:26 PM, Tony Lindgren wrote:
>>> * Suman Anna <s-anna@ti.com> [200224 15:22]:
>>>> Hi Tony,
>>>>
>>>> The following patches drop the hwmod data for PRUSS on AM33xx and AM437x
>>>> SoCs, and for the IPU and DSP processors on OMAP4 SoC. Patches are based
>>>> on 5.6-rc1. Please consider these for the 5.7 merge window.
>>>>
>>>> I will be submitting another series tomorrow to add the ti-sysc support
>>>> for PRUSS. Nevertheless, the PRUSS hwmods will not be used going forward
>>>> and can be dropped independently.
>>>>
>>>> The IPU and DSP hwmods were never added for OMAP5 and DRA7xx/AM57xx SoCs,
>>>> and the MMU data was already dropped for 5.6-rc1, as it has all been
>>>> converted to ti-sysc and omap-prm. The DT nodes for these will follow
>>>> for the next merge window once the current OMAP remoteproc DT support
>>>> is accepted [1].
>>>
>>> Well we still need the hwmod data until dts data is in place to reset
>>> and idle these modules. So I'll wait with this set until we have the
>>> dts changes in place.
>>
>> Not really, you cannot just idle these processors devices by themselves
>> without the cores running. The hwmod code actually keeps these in the
>> default reset asserted state itself, so no harm done in dropping the
>> data. The remoteproc bindings are acked, so for next merge window, we
>> can post the dts nodes once those get merged.
> 
> OK if they are in reset from the bootloader.. I'll try to check.

OK thanks. FWIW, we have never added the hwmods for IPUs and DSPs on
OMAP5 and DRA7xx/AM57xx, and most of them are pseudo hwmods anyway for
reset purposes, and do not get exercised until the remoteproc driver
would have specifically requested for them.

regards
Suman

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data
@ 2020-02-27 17:40         ` Suman Anna
  0 siblings, 0 replies; 18+ messages in thread
From: Suman Anna @ 2020-02-27 17:40 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: Tero Kristo, linux-omap, linux-arm-kernel, Roger Quadros

On 2/26/20 7:27 PM, Tony Lindgren wrote:
> * Suman Anna <s-anna@ti.com> [200226 20:31]:
>> On 2/26/20 12:26 PM, Tony Lindgren wrote:
>>> * Suman Anna <s-anna@ti.com> [200224 15:22]:
>>>> Hi Tony,
>>>>
>>>> The following patches drop the hwmod data for PRUSS on AM33xx and AM437x
>>>> SoCs, and for the IPU and DSP processors on OMAP4 SoC. Patches are based
>>>> on 5.6-rc1. Please consider these for the 5.7 merge window.
>>>>
>>>> I will be submitting another series tomorrow to add the ti-sysc support
>>>> for PRUSS. Nevertheless, the PRUSS hwmods will not be used going forward
>>>> and can be dropped independently.
>>>>
>>>> The IPU and DSP hwmods were never added for OMAP5 and DRA7xx/AM57xx SoCs,
>>>> and the MMU data was already dropped for 5.6-rc1, as it has all been
>>>> converted to ti-sysc and omap-prm. The DT nodes for these will follow
>>>> for the next merge window once the current OMAP remoteproc DT support
>>>> is accepted [1].
>>>
>>> Well we still need the hwmod data until dts data is in place to reset
>>> and idle these modules. So I'll wait with this set until we have the
>>> dts changes in place.
>>
>> Not really, you cannot just idle these processors devices by themselves
>> without the cores running. The hwmod code actually keeps these in the
>> default reset asserted state itself, so no harm done in dropping the
>> data. The remoteproc bindings are acked, so for next merge window, we
>> can post the dts nodes once those get merged.
> 
> OK if they are in reset from the bootloader.. I'll try to check.

OK thanks. FWIW, we have never added the hwmods for IPUs and DSPs on
OMAP5 and DRA7xx/AM57xx, and most of them are pseudo hwmods anyway for
reset purposes, and do not get exercised until the remoteproc driver
would have specifically requested for them.

regards
Suman

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data
  2020-02-27 17:40         ` Suman Anna
@ 2020-02-27 18:03           ` Tony Lindgren
  -1 siblings, 0 replies; 18+ messages in thread
From: Tony Lindgren @ 2020-02-27 18:03 UTC (permalink / raw)
  To: Suman Anna; +Cc: Tero Kristo, Roger Quadros, linux-omap, linux-arm-kernel

* Suman Anna <s-anna@ti.com> [200227 17:40]:
> On 2/26/20 7:27 PM, Tony Lindgren wrote:
> > * Suman Anna <s-anna@ti.com> [200226 20:31]:
> >> On 2/26/20 12:26 PM, Tony Lindgren wrote:
> >>> * Suman Anna <s-anna@ti.com> [200224 15:22]:
> >>>> Hi Tony,
> >>>>
> >>>> The following patches drop the hwmod data for PRUSS on AM33xx and AM437x
> >>>> SoCs, and for the IPU and DSP processors on OMAP4 SoC. Patches are based
> >>>> on 5.6-rc1. Please consider these for the 5.7 merge window.
> >>>>
> >>>> I will be submitting another series tomorrow to add the ti-sysc support
> >>>> for PRUSS. Nevertheless, the PRUSS hwmods will not be used going forward
> >>>> and can be dropped independently.
> >>>>
> >>>> The IPU and DSP hwmods were never added for OMAP5 and DRA7xx/AM57xx SoCs,
> >>>> and the MMU data was already dropped for 5.6-rc1, as it has all been
> >>>> converted to ti-sysc and omap-prm. The DT nodes for these will follow
> >>>> for the next merge window once the current OMAP remoteproc DT support
> >>>> is accepted [1].
> >>>
> >>> Well we still need the hwmod data until dts data is in place to reset
> >>> and idle these modules. So I'll wait with this set until we have the
> >>> dts changes in place.
> >>
> >> Not really, you cannot just idle these processors devices by themselves
> >> without the cores running. The hwmod code actually keeps these in the
> >> default reset asserted state itself, so no harm done in dropping the
> >> data. The remoteproc bindings are acked, so for next merge window, we
> >> can post the dts nodes once those get merged.
> > 
> > OK if they are in reset from the bootloader.. I'll try to check.
> 
> OK thanks. FWIW, we have never added the hwmods for IPUs and DSPs on
> OMAP5 and DRA7xx/AM57xx, and most of them are pseudo hwmods anyway for
> reset purposes, and do not get exercised until the remoteproc driver
> would have specifically requested for them.

OK yeah and for omap4 they seem to be in reset like you said.
Applying these into omap-for-v5.7/accelerators thanks.

Tony

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data
@ 2020-02-27 18:03           ` Tony Lindgren
  0 siblings, 0 replies; 18+ messages in thread
From: Tony Lindgren @ 2020-02-27 18:03 UTC (permalink / raw)
  To: Suman Anna; +Cc: Tero Kristo, linux-omap, linux-arm-kernel, Roger Quadros

* Suman Anna <s-anna@ti.com> [200227 17:40]:
> On 2/26/20 7:27 PM, Tony Lindgren wrote:
> > * Suman Anna <s-anna@ti.com> [200226 20:31]:
> >> On 2/26/20 12:26 PM, Tony Lindgren wrote:
> >>> * Suman Anna <s-anna@ti.com> [200224 15:22]:
> >>>> Hi Tony,
> >>>>
> >>>> The following patches drop the hwmod data for PRUSS on AM33xx and AM437x
> >>>> SoCs, and for the IPU and DSP processors on OMAP4 SoC. Patches are based
> >>>> on 5.6-rc1. Please consider these for the 5.7 merge window.
> >>>>
> >>>> I will be submitting another series tomorrow to add the ti-sysc support
> >>>> for PRUSS. Nevertheless, the PRUSS hwmods will not be used going forward
> >>>> and can be dropped independently.
> >>>>
> >>>> The IPU and DSP hwmods were never added for OMAP5 and DRA7xx/AM57xx SoCs,
> >>>> and the MMU data was already dropped for 5.6-rc1, as it has all been
> >>>> converted to ti-sysc and omap-prm. The DT nodes for these will follow
> >>>> for the next merge window once the current OMAP remoteproc DT support
> >>>> is accepted [1].
> >>>
> >>> Well we still need the hwmod data until dts data is in place to reset
> >>> and idle these modules. So I'll wait with this set until we have the
> >>> dts changes in place.
> >>
> >> Not really, you cannot just idle these processors devices by themselves
> >> without the cores running. The hwmod code actually keeps these in the
> >> default reset asserted state itself, so no harm done in dropping the
> >> data. The remoteproc bindings are acked, so for next merge window, we
> >> can post the dts nodes once those get merged.
> > 
> > OK if they are in reset from the bootloader.. I'll try to check.
> 
> OK thanks. FWIW, we have never added the hwmods for IPUs and DSPs on
> OMAP5 and DRA7xx/AM57xx, and most of them are pseudo hwmods anyway for
> reset purposes, and do not get exercised until the remoteproc driver
> would have specifically requested for them.

OK yeah and for omap4 they seem to be in reset like you said.
Applying these into omap-for-v5.7/accelerators thanks.

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2020-02-27 18:03 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-24 23:21 [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP hwmod data Suman Anna
2020-02-24 23:21 ` Suman Anna
2020-02-24 23:21 ` [PATCH 1/3] ARM: OMAP2+: Drop hwmod data for am3 and am4 PRUSS Suman Anna
2020-02-24 23:21   ` Suman Anna
2020-02-24 23:21 ` [PATCH 2/3] ARM: OMAP2+: Drop legacy platform data for OMAP4 DSP Suman Anna
2020-02-24 23:21   ` Suman Anna
2020-02-24 23:21 ` [PATCH 3/3] ARM: OMAP4: hwmod_data: Remove OMAP4 IPU hwmod data Suman Anna
2020-02-24 23:21   ` Suman Anna
2020-02-26 18:26 ` [PATCH 0/3] Drop PRUSS and OMAP4 IPU/DSP " Tony Lindgren
2020-02-26 18:26   ` Tony Lindgren
2020-02-26 20:30   ` Suman Anna
2020-02-26 20:30     ` Suman Anna
2020-02-27  1:27     ` Tony Lindgren
2020-02-27  1:27       ` Tony Lindgren
2020-02-27 17:40       ` Suman Anna
2020-02-27 17:40         ` Suman Anna
2020-02-27 18:03         ` Tony Lindgren
2020-02-27 18:03           ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.