* [PATCH] gpu: host1x: select CONFIG_SYNC_FILE
@ 2021-07-23 9:14 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2021-07-23 9:14 UTC (permalink / raw)
To: Thierry Reding, Mikko Perttunen
Cc: Arnd Bergmann, dri-devel, linux-tegra, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
With the addition of the DMA fence, the host1x driver now fails to
build without the sync_file helper:
arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function `host1x_fence_create_fd':
fence.c:(.text+0x624): undefined reference to `sync_file_create'
Fixes: ad0529424def ("gpu: host1x: Add DMA fence implementation")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/host1x/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
index 6dab94adf25e..6f7ea1720a39 100644
--- a/drivers/gpu/host1x/Kconfig
+++ b/drivers/gpu/host1x/Kconfig
@@ -3,6 +3,7 @@ config TEGRA_HOST1X
tristate "NVIDIA Tegra host1x driver"
depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
select IOMMU_IOVA
+ select SYNC_FILE
help
Driver for the NVIDIA Tegra host1x hardware.
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] gpu: host1x: select CONFIG_SYNC_FILE
@ 2021-07-23 9:14 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2021-07-23 9:14 UTC (permalink / raw)
To: Thierry Reding, Mikko Perttunen
Cc: linux-tegra, dri-devel, Arnd Bergmann, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
With the addition of the DMA fence, the host1x driver now fails to
build without the sync_file helper:
arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function `host1x_fence_create_fd':
fence.c:(.text+0x624): undefined reference to `sync_file_create'
Fixes: ad0529424def ("gpu: host1x: Add DMA fence implementation")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/host1x/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
index 6dab94adf25e..6f7ea1720a39 100644
--- a/drivers/gpu/host1x/Kconfig
+++ b/drivers/gpu/host1x/Kconfig
@@ -3,6 +3,7 @@ config TEGRA_HOST1X
tristate "NVIDIA Tegra host1x driver"
depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
select IOMMU_IOVA
+ select SYNC_FILE
help
Driver for the NVIDIA Tegra host1x hardware.
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] gpu: host1x: select CONFIG_SYNC_FILE
2021-07-23 9:14 ` Arnd Bergmann
@ 2021-07-23 9:17 ` Mikko Perttunen
-1 siblings, 0 replies; 6+ messages in thread
From: Mikko Perttunen @ 2021-07-23 9:17 UTC (permalink / raw)
To: Arnd Bergmann, Thierry Reding, Mikko Perttunen
Cc: Arnd Bergmann, dri-devel, linux-tegra, linux-kernel
Hi Arnd,
I think the best fix for this is to just remove that function -- it is
currently not used anywhere. I posted a patch to do that, but Thierry is
currently on vacation so it hasn't been picked up yet.
thanks,
Mikko
On 7/23/21 12:14 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With the addition of the DMA fence, the host1x driver now fails to
> build without the sync_file helper:
>
> arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function `host1x_fence_create_fd':
> fence.c:(.text+0x624): undefined reference to `sync_file_create'
>
> Fixes: ad0529424def ("gpu: host1x: Add DMA fence implementation")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/host1x/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> index 6dab94adf25e..6f7ea1720a39 100644
> --- a/drivers/gpu/host1x/Kconfig
> +++ b/drivers/gpu/host1x/Kconfig
> @@ -3,6 +3,7 @@ config TEGRA_HOST1X
> tristate "NVIDIA Tegra host1x driver"
> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> select IOMMU_IOVA
> + select SYNC_FILE
> help
> Driver for the NVIDIA Tegra host1x hardware.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpu: host1x: select CONFIG_SYNC_FILE
@ 2021-07-23 9:17 ` Mikko Perttunen
0 siblings, 0 replies; 6+ messages in thread
From: Mikko Perttunen @ 2021-07-23 9:17 UTC (permalink / raw)
To: Arnd Bergmann, Thierry Reding, Mikko Perttunen
Cc: linux-tegra, dri-devel, Arnd Bergmann, linux-kernel
Hi Arnd,
I think the best fix for this is to just remove that function -- it is
currently not used anywhere. I posted a patch to do that, but Thierry is
currently on vacation so it hasn't been picked up yet.
thanks,
Mikko
On 7/23/21 12:14 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With the addition of the DMA fence, the host1x driver now fails to
> build without the sync_file helper:
>
> arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function `host1x_fence_create_fd':
> fence.c:(.text+0x624): undefined reference to `sync_file_create'
>
> Fixes: ad0529424def ("gpu: host1x: Add DMA fence implementation")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/host1x/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> index 6dab94adf25e..6f7ea1720a39 100644
> --- a/drivers/gpu/host1x/Kconfig
> +++ b/drivers/gpu/host1x/Kconfig
> @@ -3,6 +3,7 @@ config TEGRA_HOST1X
> tristate "NVIDIA Tegra host1x driver"
> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> select IOMMU_IOVA
> + select SYNC_FILE
> help
> Driver for the NVIDIA Tegra host1x hardware.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpu: host1x: select CONFIG_SYNC_FILE
2021-07-23 9:17 ` Mikko Perttunen
@ 2021-07-23 9:18 ` Mikko Perttunen
-1 siblings, 0 replies; 6+ messages in thread
From: Mikko Perttunen @ 2021-07-23 9:18 UTC (permalink / raw)
To: Arnd Bergmann, Thierry Reding, Mikko Perttunen
Cc: Arnd Bergmann, dri-devel, linux-tegra, linux-kernel
On 7/23/21 12:17 PM, Mikko Perttunen wrote:
> Hi Arnd,
>
> I think the best fix for this is to just remove that function -- it is
> currently not used anywhere. I posted a patch to do that, but Thierry is
> currently on vacation so it hasn't been picked up yet.
.. and sorry for the top post ..
Mikko
>
> thanks,
> Mikko
>
> On 7/23/21 12:14 PM, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> With the addition of the DMA fence, the host1x driver now fails to
>> build without the sync_file helper:
>>
>> arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function
>> `host1x_fence_create_fd':
>> fence.c:(.text+0x624): undefined reference to `sync_file_create'
>>
>> Fixes: ad0529424def ("gpu: host1x: Add DMA fence implementation")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/gpu/host1x/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
>> index 6dab94adf25e..6f7ea1720a39 100644
>> --- a/drivers/gpu/host1x/Kconfig
>> +++ b/drivers/gpu/host1x/Kconfig
>> @@ -3,6 +3,7 @@ config TEGRA_HOST1X
>> tristate "NVIDIA Tegra host1x driver"
>> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>> select IOMMU_IOVA
>> + select SYNC_FILE
>> help
>> Driver for the NVIDIA Tegra host1x hardware.
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpu: host1x: select CONFIG_SYNC_FILE
@ 2021-07-23 9:18 ` Mikko Perttunen
0 siblings, 0 replies; 6+ messages in thread
From: Mikko Perttunen @ 2021-07-23 9:18 UTC (permalink / raw)
To: Arnd Bergmann, Thierry Reding, Mikko Perttunen
Cc: linux-tegra, dri-devel, Arnd Bergmann, linux-kernel
On 7/23/21 12:17 PM, Mikko Perttunen wrote:
> Hi Arnd,
>
> I think the best fix for this is to just remove that function -- it is
> currently not used anywhere. I posted a patch to do that, but Thierry is
> currently on vacation so it hasn't been picked up yet.
.. and sorry for the top post ..
Mikko
>
> thanks,
> Mikko
>
> On 7/23/21 12:14 PM, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> With the addition of the DMA fence, the host1x driver now fails to
>> build without the sync_file helper:
>>
>> arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function
>> `host1x_fence_create_fd':
>> fence.c:(.text+0x624): undefined reference to `sync_file_create'
>>
>> Fixes: ad0529424def ("gpu: host1x: Add DMA fence implementation")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/gpu/host1x/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
>> index 6dab94adf25e..6f7ea1720a39 100644
>> --- a/drivers/gpu/host1x/Kconfig
>> +++ b/drivers/gpu/host1x/Kconfig
>> @@ -3,6 +3,7 @@ config TEGRA_HOST1X
>> tristate "NVIDIA Tegra host1x driver"
>> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>> select IOMMU_IOVA
>> + select SYNC_FILE
>> help
>> Driver for the NVIDIA Tegra host1x hardware.
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-23 9:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-23 9:14 [PATCH] gpu: host1x: select CONFIG_SYNC_FILE Arnd Bergmann
2021-07-23 9:14 ` Arnd Bergmann
2021-07-23 9:17 ` Mikko Perttunen
2021-07-23 9:17 ` Mikko Perttunen
2021-07-23 9:18 ` Mikko Perttunen
2021-07-23 9:18 ` Mikko Perttunen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.