From: "Tangnianyao (ICT)" <tangnianyao@huawei.com> To: <kvm@vger.kernel.org>, <kvmarm@lists.cs.columbia.edu>, <linux-kernel@vger.kernel.org>, Linuxarm <linuxarm@huawei.com> Cc: <guoheyi@huawei.com>, <wanghaibin.wang@huawei.com> Subject: [RFC] Question about enable doorbell irq and halt_poll process Date: Tue, 19 Mar 2019 21:25:47 +0800 [thread overview] Message-ID: <0fb3c9ba-8428-ea6c-2973-952624f601cc@huawei.com> (raw) Hi, all Using gicv4, when guest is waiting for irq, it sends wfi and traps to kvm. When vlpi is forwarded to PE after its_vpe_deschedule, before halt_poll in kvm_vcpu_block, halt_poll may increase latency for this vlpi getting to guest. In halt_poll process, it checks if there's pending irq for vcpu using pending_last. However, doorbell is not enable at this moment and vlpi or doorbell can not set pending_last true, to stop halt_poll. It will run until halt_poll time ends, if there's no other physical irq coming in the meantime. And then vcpu is scheduled out. This pending vlpi has to wait for vcpu getting schedule in next time. Should we enable doorbell before halt_poll process ?
WARNING: multiple messages have this Message-ID (diff)
From: "Tangnianyao (ICT)" <tangnianyao@huawei.com> To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Linuxarm <linuxarm@huawei.com> Cc: guoheyi@huawei.com, wanghaibin.wang@huawei.com Subject: [RFC] Question about enable doorbell irq and halt_poll process Date: Tue, 19 Mar 2019 21:25:47 +0800 [thread overview] Message-ID: <0fb3c9ba-8428-ea6c-2973-952624f601cc@huawei.com> (raw) Hi, all Using gicv4, when guest is waiting for irq, it sends wfi and traps to kvm. When vlpi is forwarded to PE after its_vpe_deschedule, before halt_poll in kvm_vcpu_block, halt_poll may increase latency for this vlpi getting to guest. In halt_poll process, it checks if there's pending irq for vcpu using pending_last. However, doorbell is not enable at this moment and vlpi or doorbell can not set pending_last true, to stop halt_poll. It will run until halt_poll time ends, if there's no other physical irq coming in the meantime. And then vcpu is scheduled out. This pending vlpi has to wait for vcpu getting schedule in next time. Should we enable doorbell before halt_poll process ?
next reply other threads:[~2019-03-19 13:26 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-19 13:25 Tangnianyao (ICT) [this message] 2019-03-19 13:25 ` [RFC] Question about enable doorbell irq and halt_poll process Tangnianyao (ICT) 2019-03-20 14:31 ` Heyi Guo 2019-03-20 14:31 ` Heyi Guo 2019-03-20 17:02 ` Marc Zyngier 2019-03-20 17:02 ` Marc Zyngier [not found] ` <5df934fd-06d5-55f2-68a5-6f4985e4ac1b@huawei.com> [not found] ` <86zhpc66jl.wl-marc.zyngier@arm.com> 2019-04-04 10:07 ` Tangnianyao (ICT) 2019-04-04 10:07 ` Tangnianyao (ICT) 2019-04-04 10:59 ` Marc Zyngier 2019-04-04 10:59 ` Marc Zyngier 2019-04-23 7:44 ` Tangnianyao (ICT) 2019-04-23 7:44 ` Tangnianyao (ICT) 2019-04-23 7:44 ` Tangnianyao (ICT) 2019-04-23 10:00 ` Marc Zyngier 2019-04-23 10:00 ` Marc Zyngier 2019-04-23 10:00 ` Marc Zyngier 2019-04-29 2:29 ` Tangnianyao (ICT) 2019-04-29 2:29 ` Tangnianyao (ICT) 2019-04-29 2:29 ` Tangnianyao (ICT) 2019-05-14 9:02 ` Tangnianyao (ICT) 2019-05-14 9:02 ` Tangnianyao (ICT)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0fb3c9ba-8428-ea6c-2973-952624f601cc@huawei.com \ --to=tangnianyao@huawei.com \ --cc=guoheyi@huawei.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=wanghaibin.wang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.