[PATCH] ALSA: usb-audio: Add registration quirk for JBL Quantum 600

[PATCH] ALSA: usb-audio: Add registration quirk for JBL Quantum 600

[Alexander Tsoy]

Apparently JBL Quantum 600 has multiple hardware revisions. Apply
registration quirk to another device id as well.

Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
---
 sound/usb/quirks.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index e7accd87e063..326d1b0ea5e6 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1899,6 +1899,7 @@ static const struct registration_quirk registration_quirks[] = {
 	REG_QUIRK_ENTRY(0x0951, 0x16ea, 2),	/* Kingston HyperX Cloud Flight S */
 	REG_QUIRK_ENTRY(0x0ecb, 0x1f46, 2),	/* JBL Quantum 600 */
 	REG_QUIRK_ENTRY(0x0ecb, 0x2039, 2),	/* JBL Quantum 400 */
+	REG_QUIRK_ENTRY(0x0ecb, 0x203c, 2),	/* JBL Quantum 600 */
 	REG_QUIRK_ENTRY(0x0ecb, 0x203e, 2),	/* JBL Quantum 800 */
 	{ 0 }					/* terminator */
 };
-- 
2.31.1

Re: [PATCH] ALSA: usb-audio: Add registration quirk for JBL Quantum 600

[Jean-Paul Argudo]

Hi Alexander, 

Le mardi 27 juillet 2021 à 12:33 +0300, Alexander Tsoy a écrit :
> Apparently JBL Quantum 600 has multiple hardware revisions. Apply
> registration quirk to another device id as well.
> 
> Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
> ---
>  sound/usb/quirks.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index e7accd87e063..326d1b0ea5e6 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -1899,6 +1899,7 @@ static const struct registration_quirk
> registration_quirks[] = {
>         REG_QUIRK_ENTRY(0x0951, 0x16ea, 2),     /* Kingston HyperX
> Cloud Flight S */
>         REG_QUIRK_ENTRY(0x0ecb, 0x1f46, 2),     /* JBL Quantum 600 */
>         REG_QUIRK_ENTRY(0x0ecb, 0x2039, 2),     /* JBL Quantum 400 */
> +       REG_QUIRK_ENTRY(0x0ecb, 0x203c, 2),     /* JBL Quantum 600 */


Thanks! 

Thank you to Takashi Iwai also, who helped me a lot!

Just wondering how you could possibly "find" all devices id for those
JBL headsets? I mean if the 600 has multiple hardware revisions, is it
possible the 400 and 800 series too? 


Thanks again,


>         REG_QUIRK_ENTRY(0x0ecb, 0x203e, 2),     /* JBL Quantum 800 */
>         { 0 }                                   /* terminator */
>  };

-- 
Jean-Paul

Re: [PATCH] ALSA: usb-audio: Add registration quirk for JBL Quantum 600

[Alexander Tsoy]

В Вт, 27/07/2021 в 11:54 +0200, Jean-Paul Argudo пишет:
> Hi Alexander, 
> 
> Le mardi 27 juillet 2021 à 12:33 +0300, Alexander Tsoy a écrit :
> > Apparently JBL Quantum 600 has multiple hardware revisions. Apply
> > registration quirk to another device id as well.
> > 
> > Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
> > ---
> >  sound/usb/quirks.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> > index e7accd87e063..326d1b0ea5e6 100644
> > --- a/sound/usb/quirks.c
> > +++ b/sound/usb/quirks.c
> > @@ -1899,6 +1899,7 @@ static const struct registration_quirk
> > registration_quirks[] = {
> >         REG_QUIRK_ENTRY(0x0951, 0x16ea, 2),     /* Kingston HyperX
> > Cloud Flight S */
> >         REG_QUIRK_ENTRY(0x0ecb, 0x1f46, 2),     /* JBL Quantum 600 */
> >         REG_QUIRK_ENTRY(0x0ecb, 0x2039, 2),     /* JBL Quantum 400 */
> > +       REG_QUIRK_ENTRY(0x0ecb, 0x203c, 2),     /* JBL Quantum 600 */
> 
> 
> Thanks! 
> 
> Thank you to Takashi Iwai also, who helped me a lot!
> 
> Just wondering how you could possibly "find" all devices id for those
> JBL headsets? I mean if the 600 has multiple hardware revisions, is it
> possible the 400 and 800 series too? 

We can only rely on bug reports and public databases I guess. The
current list is gathered from multiple sources:
https://bugzilla.kernel.org/show_bug.cgi?id=212669
https://www.spinics.net/lists/alsa-devel/msg129070.html
https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/998
https://github.com/linuxhw/LsUSB/

> 
> 
> Thanks again,
> 
> 
> >         REG_QUIRK_ENTRY(0x0ecb, 0x203e, 2),     /* JBL Quantum 800 */
> >         { 0 }                                   /* terminator */
> >  };
> 

Re: [PATCH] ALSA: usb-audio: Add registration quirk for JBL Quantum 600

[Takashi Iwai]

On Tue, 27 Jul 2021 11:33:26 +0200,
Alexander Tsoy wrote:
> 
> Apparently JBL Quantum 600 has multiple hardware revisions. Apply
> registration quirk to another device id as well.
> 
> Signed-off-by: Alexander Tsoy <alexander@tsoy.me>

Thanks, applied.


Takashi