From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org, gustavoars@kernel.org, robh@kernel.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr> Subject: [PATCH 2/2] powerpc: Save a few lines of code Date: Fri, 23 Apr 2021 16:40:48 +0200 [thread overview] Message-ID: <0ff6235a4e2d497e146ce401fa2df71449d290b6.1619188632.git.christophe.jaillet@wanadoo.fr> (raw) In-Reply-To: <f2186955f310494f10990b5c402ada164d7834b8.1619188632.git.christophe.jaillet@wanadoo.fr> 'arch/powerpc/platforms/powermac/feature.c' triggers many checkpatch.pl warnings. The code looks old and not very active, so fixing them all does not make so much sense and will hide some 'git blame' information. So only apply a few fixes that save a few lines of code. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- arch/powerpc/platforms/powermac/feature.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c index e612222f7d2e..155e8586692e 100644 --- a/arch/powerpc/platforms/powermac/feature.c +++ b/arch/powerpc/platforms/powermac/feature.c @@ -83,8 +83,7 @@ struct macio_chip *macio_find(struct device_node *child, int type) } EXPORT_SYMBOL_GPL(macio_find); -static const char *macio_names[] = -{ +static const char *macio_names[] = { "Unknown", "Grand Central", "OHare", @@ -119,8 +118,7 @@ struct feature_table_entry { feature_call function; }; -struct pmac_mb_def -{ +struct pmac_mb_def { const char* model_string; const char* model_name; int model_id; @@ -301,11 +299,10 @@ static long ohare_sleep_state(struct device_node *node, long param, long value) if ((pmac_mb.board_flags & PMAC_MB_CAN_SLEEP) == 0) return -EPERM; - if (value == 1) { + if (value == 1) MACIO_BIC(OHARE_FCR, OH_IOBUS_ENABLE); - } else if (value == 0) { + else if (value == 0) MACIO_BIS(OHARE_FCR, OH_IOBUS_ENABLE); - } return 0; } @@ -2992,7 +2989,6 @@ void pmac_register_agp_pm(struct pci_dev *bridge, if (bridge != pmac_agp_bridge) return; pmac_agp_suspend = pmac_agp_resume = NULL; - return; } EXPORT_SYMBOL(pmac_register_agp_pm); -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org, gustavoars@kernel.org, robh@kernel.org Cc: kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] powerpc: Save a few lines of code Date: Fri, 23 Apr 2021 16:40:48 +0200 [thread overview] Message-ID: <0ff6235a4e2d497e146ce401fa2df71449d290b6.1619188632.git.christophe.jaillet@wanadoo.fr> (raw) In-Reply-To: <f2186955f310494f10990b5c402ada164d7834b8.1619188632.git.christophe.jaillet@wanadoo.fr> 'arch/powerpc/platforms/powermac/feature.c' triggers many checkpatch.pl warnings. The code looks old and not very active, so fixing them all does not make so much sense and will hide some 'git blame' information. So only apply a few fixes that save a few lines of code. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- arch/powerpc/platforms/powermac/feature.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c index e612222f7d2e..155e8586692e 100644 --- a/arch/powerpc/platforms/powermac/feature.c +++ b/arch/powerpc/platforms/powermac/feature.c @@ -83,8 +83,7 @@ struct macio_chip *macio_find(struct device_node *child, int type) } EXPORT_SYMBOL_GPL(macio_find); -static const char *macio_names[] = -{ +static const char *macio_names[] = { "Unknown", "Grand Central", "OHare", @@ -119,8 +118,7 @@ struct feature_table_entry { feature_call function; }; -struct pmac_mb_def -{ +struct pmac_mb_def { const char* model_string; const char* model_name; int model_id; @@ -301,11 +299,10 @@ static long ohare_sleep_state(struct device_node *node, long param, long value) if ((pmac_mb.board_flags & PMAC_MB_CAN_SLEEP) == 0) return -EPERM; - if (value == 1) { + if (value == 1) MACIO_BIC(OHARE_FCR, OH_IOBUS_ENABLE); - } else if (value == 0) { + else if (value == 0) MACIO_BIS(OHARE_FCR, OH_IOBUS_ENABLE); - } return 0; } @@ -2992,7 +2989,6 @@ void pmac_register_agp_pm(struct pci_dev *bridge, if (bridge != pmac_agp_bridge) return; pmac_agp_suspend = pmac_agp_resume = NULL; - return; } EXPORT_SYMBOL(pmac_register_agp_pm); -- 2.27.0
next prev parent reply other threads:[~2021-04-23 14:40 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-23 14:40 [PATCH 1/2] powerpc: Fix a memory leak in error handling paths Christophe JAILLET 2021-04-23 14:40 ` Christophe JAILLET 2021-04-23 14:40 ` Christophe JAILLET [this message] 2021-04-23 14:40 ` [PATCH 2/2] powerpc: Save a few lines of code Christophe JAILLET 2021-04-23 14:55 ` [PATCH 1/2] powerpc: Fix a memory leak in error handling paths Rob Herring 2021-04-23 14:55 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0ff6235a4e2d497e146ce401fa2df71449d290b6.1619188632.git.christophe.jaillet@wanadoo.fr \ --to=christophe.jaillet@wanadoo.fr \ --cc=benh@kernel.crashing.org \ --cc=gustavoars@kernel.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.