* [PATCH 1/2] nvme: expose hostnqn via sysfs for fabrics controllers
@ 2020-02-08 0:21 Sagi Grimberg
2020-02-08 0:21 ` [PATCH 2/2] nvme: expose hostid " Sagi Grimberg
2020-02-08 0:44 ` [PATCH 1/2] nvme: expose hostnqn " Keith Busch
0 siblings, 2 replies; 4+ messages in thread
From: Sagi Grimberg @ 2020-02-08 0:21 UTC (permalink / raw)
To: linux-nvme, Keith Busch; +Cc: Christoph Hellwig
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
---
drivers/nvme/host/core.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 5dc32b72e7fa..29a4f14360fa 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3242,6 +3242,16 @@ static ssize_t nvme_sysfs_show_subsysnqn(struct device *dev,
}
static DEVICE_ATTR(subsysnqn, S_IRUGO, nvme_sysfs_show_subsysnqn, NULL);
+static ssize_t nvme_sysfs_show_hostnqn(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct nvme_ctrl *ctrl = dev_get_drvdata(dev);
+
+ return snprintf(buf, PAGE_SIZE, "%s\n", ctrl->opts->host->nqn);
+}
+static DEVICE_ATTR(hostnqn, S_IRUGO, nvme_sysfs_show_hostnqn, NULL);
+
static ssize_t nvme_sysfs_show_address(struct device *dev,
struct device_attribute *attr,
char *buf)
@@ -3267,6 +3277,7 @@ static struct attribute *nvme_dev_attrs[] = {
&dev_attr_numa_node.attr,
&dev_attr_queue_count.attr,
&dev_attr_sqsize.attr,
+ &dev_attr_hostnqn.attr,
NULL
};
@@ -3280,6 +3291,8 @@ static umode_t nvme_dev_attrs_are_visible(struct kobject *kobj,
return 0;
if (a == &dev_attr_address.attr && !ctrl->ops->get_address)
return 0;
+ if (a == &dev_attr_hostnqn.attr && (!ctrl->opts))
+ return 0;
return a->mode;
}
--
2.20.1
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] nvme: expose hostid via sysfs for fabrics controllers
2020-02-08 0:21 [PATCH 1/2] nvme: expose hostnqn via sysfs for fabrics controllers Sagi Grimberg
@ 2020-02-08 0:21 ` Sagi Grimberg
2020-02-08 0:44 ` [PATCH 1/2] nvme: expose hostnqn " Keith Busch
1 sibling, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2020-02-08 0:21 UTC (permalink / raw)
To: linux-nvme, Keith Busch; +Cc: Christoph Hellwig
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
---
drivers/nvme/host/core.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 29a4f14360fa..c2aba7d700ff 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3252,6 +3252,16 @@ static ssize_t nvme_sysfs_show_hostnqn(struct device *dev,
}
static DEVICE_ATTR(hostnqn, S_IRUGO, nvme_sysfs_show_hostnqn, NULL);
+static ssize_t nvme_sysfs_show_hostid(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct nvme_ctrl *ctrl = dev_get_drvdata(dev);
+
+ return snprintf(buf, PAGE_SIZE, "%pU\n", &ctrl->opts->host->id);
+}
+static DEVICE_ATTR(hostid, S_IRUGO, nvme_sysfs_show_hostid, NULL);
+
static ssize_t nvme_sysfs_show_address(struct device *dev,
struct device_attribute *attr,
char *buf)
@@ -3278,6 +3288,7 @@ static struct attribute *nvme_dev_attrs[] = {
&dev_attr_queue_count.attr,
&dev_attr_sqsize.attr,
&dev_attr_hostnqn.attr,
+ &dev_attr_hostid.attr,
NULL
};
@@ -3293,6 +3304,8 @@ static umode_t nvme_dev_attrs_are_visible(struct kobject *kobj,
return 0;
if (a == &dev_attr_hostnqn.attr && (!ctrl->opts))
return 0;
+ if (a == &dev_attr_hostid.attr && (!ctrl->opts))
+ return 0;
return a->mode;
}
--
2.20.1
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] nvme: expose hostnqn via sysfs for fabrics controllers
2020-02-08 0:21 [PATCH 1/2] nvme: expose hostnqn via sysfs for fabrics controllers Sagi Grimberg
2020-02-08 0:21 ` [PATCH 2/2] nvme: expose hostid " Sagi Grimberg
@ 2020-02-08 0:44 ` Keith Busch
2020-02-08 1:05 ` Sagi Grimberg
1 sibling, 1 reply; 4+ messages in thread
From: Keith Busch @ 2020-02-08 0:44 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: Christoph Hellwig, linux-nvme
On Fri, Feb 07, 2020 at 04:21:10PM -0800, Sagi Grimberg wrote:
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
The code looks fine, but could you say more in the change log why this
is needed now?
> +static ssize_t nvme_sysfs_show_hostnqn(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{
> + struct nvme_ctrl *ctrl = dev_get_drvdata(dev);
> +
> + return snprintf(buf, PAGE_SIZE, "%s\n", ctrl->opts->host->nqn);
> +}
> +static DEVICE_ATTR(hostnqn, S_IRUGO, nvme_sysfs_show_hostnqn, NULL);
> +
> static ssize_t nvme_sysfs_show_address(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> @@ -3267,6 +3277,7 @@ static struct attribute *nvme_dev_attrs[] = {
> &dev_attr_numa_node.attr,
> &dev_attr_queue_count.attr,
> &dev_attr_sqsize.attr,
> + &dev_attr_hostnqn.attr,
> NULL
> };
>
> @@ -3280,6 +3291,8 @@ static umode_t nvme_dev_attrs_are_visible(struct kobject *kobj,
> return 0;
> if (a == &dev_attr_address.attr && !ctrl->ops->get_address)
> return 0;
> + if (a == &dev_attr_hostnqn.attr && (!ctrl->opts))
> + return 0;
>
> return a->mode;
> }
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] nvme: expose hostnqn via sysfs for fabrics controllers
2020-02-08 0:44 ` [PATCH 1/2] nvme: expose hostnqn " Keith Busch
@ 2020-02-08 1:05 ` Sagi Grimberg
0 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2020-02-08 1:05 UTC (permalink / raw)
To: Keith Busch; +Cc: Christoph Hellwig, linux-nvme
>> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
>
> The code looks fine, but could you say more in the change log why this
> is needed now?
Well, its useful information to have, but I can add a few words on why
that is.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-08 1:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-08 0:21 [PATCH 1/2] nvme: expose hostnqn via sysfs for fabrics controllers Sagi Grimberg
2020-02-08 0:21 ` [PATCH 2/2] nvme: expose hostid " Sagi Grimberg
2020-02-08 0:44 ` [PATCH 1/2] nvme: expose hostnqn " Keith Busch
2020-02-08 1:05 ` Sagi Grimberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.