[MPTCP] Re: [PATCH v3] mptcp: Basic single-subflow DATA_FIN

[MPTCP] Re: [PATCH v3] mptcp: Basic single-subflow DATA_FIN

[Peter Krystad]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]


Hi Matt -

On Tue, 2019-11-26 at 10:07 +0100, Matthieu Baerts wrote:
> Hi Mat, Paolo,
> 
> On 25/11/2019 18:00, Paolo Abeni wrote:
> > On Fri, 2019-11-22 at 15:01 -0800, Mat Martineau wrote:
> > > Send a DATA_FIN along with any subflow TCP FIN flag when the MPTCP
> > > socket is closing or shutting down writes.
> > > 
> > > Signed-off-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
> > 
> > The patch LGTM, thanks!
> 
> Thank you for the new version and the review!
> 
> Where can I apply it? I would like to apply it just before the 
> introduction of the kselftests but please tell me if it is better to 
> squash it / apply it somewhere else.

Mat is out this week. I've checked that the changes to options.c and
protocol.c can be squashed to 'Write MPTCP DSS headers to outgoing data
packets' and the changes to subflow.c squash to 'Implement MPTCP receive
path'.

Peter.



> Cheers,
> Matt

[MPTCP] Re: [PATCH v3] mptcp: Basic single-subflow DATA_FIN

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]

Hi Mat, Paolo, Peter,

On 27/11/2019 04:39, Peter Krystad wrote:
> 
> Hi Matt -
> 
> On Tue, 2019-11-26 at 10:07 +0100, Matthieu Baerts wrote:
>> Hi Mat, Paolo,
>>
>> On 25/11/2019 18:00, Paolo Abeni wrote:
>>> On Fri, 2019-11-22 at 15:01 -0800, Mat Martineau wrote:
>>>> Send a DATA_FIN along with any subflow TCP FIN flag when the MPTCP
>>>> socket is closing or shutting down writes.
>>>>
>>>> Signed-off-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
>>>
>>> The patch LGTM, thanks!
>>
>> Thank you for the new version and the review!
>>
>> Where can I apply it? I would like to apply it just before the
>> introduction of the kselftests but please tell me if it is better to
>> squash it / apply it somewhere else.
> 
> Mat is out this week. I've checked that the changes to options.c and
> protocol.c can be squashed to 'Write MPTCP DSS headers to outgoing data
> packets' and the changes to subflow.c squash to 'Implement MPTCP receive
> path'.

Thank you again for the patch, the reviews and the instructions!

Sorry for the delay. I feel bad because I was suspecting conflicts with 
other commits of the series but there was no conflict at all!

- 825f10f90667: "squashed" in "mptcp: Write MPTCP DSS headers to 
outgoing data packets"
- 7a9b711a86ee: "squashed" in "mptcp: Implement MPTCP receive path"
- bcf60b29e527..b887804d061e: result

Each commit still compiles and tests are still passing!

Hopefully tomorrow, I can apply MPTCPv1 patches and all others waiting 
to be applied :)

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: [PATCH v3] mptcp: Basic single-subflow DATA_FIN

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 763 bytes --]

Hi Mat, Paolo,

On 25/11/2019 18:00, Paolo Abeni wrote:
> On Fri, 2019-11-22 at 15:01 -0800, Mat Martineau wrote:
>> Send a DATA_FIN along with any subflow TCP FIN flag when the MPTCP
>> socket is closing or shutting down writes.
>>
>> Signed-off-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
> 
> The patch LGTM, thanks!

Thank you for the new version and the review!

Where can I apply it? I would like to apply it just before the 
introduction of the kselftests but please tell me if it is better to 
squash it / apply it somewhere else.

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

[MPTCP] Re: [PATCH v3] mptcp: Basic single-subflow DATA_FIN

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

On Fri, 2019-11-22 at 15:01 -0800, Mat Martineau wrote:
> Send a DATA_FIN along with any subflow TCP FIN flag when the MPTCP
> socket is closing or shutting down writes.
> 
> Signed-off-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>

The patch LGTM, thanks!

Paolo