All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] msi: remove return code for msi_init()
Date: Wed, 31 May 2017 04:28:47 -0400 (EDT)	[thread overview]
Message-ID: <1013114653.3661277.1496219327691.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170531082651.GJ14845@pxdev.xzpeter.org>


> Ok before I move on let's see whether this is what we want...
> 
> - firstly, find all machine types:
> 
>   pxdev:qemu [edu-fix]# grep -R ".parent = TYPE_MACHINE" * | wc
>      49     196    2269
> 
>   so now we have 49 kinds of machines.
> 
> - rename msi_nonbroken into msi_broken, then:
> 
>   - x86/arm/spapr/s390 machines are the only ones that don't need to
>     set msi_broken since they support MSI and have msi_nonbroken set,
>     either in board init function or in irq chip init function
> 
>   - for all the rest of the machines, I should add "msi_broken" in its
>     machine init() function.
> 
> Is this really what we want?

No, for now I'd rather just go and remove msi_nonbroken.  When someone
reports a bug, we can add back "msi_broken".

Paolo

  reply	other threads:[~2017-05-31  8:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 13:14 [Qemu-devel] [PATCH] msi: remove return code for msi_init() Peter Xu
2017-05-29  6:08 ` Peter Xu
2017-05-29  9:42   ` Markus Armbruster
2017-05-29 10:13     ` Peter Xu
2017-05-29 12:16       ` Markus Armbruster
2017-05-30  9:16         ` Paolo Bonzini
2017-05-30 14:28           ` Markus Armbruster
2017-05-30 14:29             ` Paolo Bonzini
2017-05-31  7:03               ` Peter Xu
2017-05-31  7:40                 ` Paolo Bonzini
2017-05-31  8:26                   ` Peter Xu
2017-05-31  8:28                     ` Paolo Bonzini [this message]
2017-05-31  8:55                       ` Peter Xu
2017-06-01  8:27                       ` Marcel Apfelbaum
2017-06-01 14:23                         ` Paolo Bonzini
2017-06-01 19:22                           ` Aurelien Jarno
2017-06-01 22:06                             ` Paul Burton
2017-06-02  4:18                               ` Peter Xu
2017-06-02  7:47                                 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1013114653.3661277.1496219327691.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.