All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Xu <peterx@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] msi: remove return code for msi_init()
Date: Tue, 30 May 2017 16:29:57 +0200	[thread overview]
Message-ID: <6a6a91cc-7ea1-2b45-a4bd-31aa3cfef917@redhat.com> (raw)
In-Reply-To: <87h902l8qd.fsf@dusky.pond.sub.org>



On 30/05/2017 16:28, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
>>> Note that a board that doesn't support MSI can take MSI-capable devices
>>> just fine.  Only the broken boards can't.
>>>
>>> Obviously, broken boards should be fixed.  Once they all are, we can
>>> (and should!) remove msi_nonbroken.
>>
>> That only works if we know what the broken boards are.
> 
> Yes.
> 
>> Right now, all boards that do not support MSI hide the capability, which
>> is wrong.
> 
> Agreed.
> 
>>            I'd prefer to remove msi_nonbroken completely if we don't
>> know where the problem is.
> 
> So you're proposing to (1) remove msi_nonbroken, (2) see which boards
> burst into flames, and (3) fix them, or perhaps add a less wrong stop
> gap msi_broken just for them?

Yes, adding back msi_broken is one "git revert" away.

Of course, this means the edu memory leak should be fixed in a separate
small patch.

Thanks,

Paolo

  reply	other threads:[~2017-05-30 14:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 13:14 [Qemu-devel] [PATCH] msi: remove return code for msi_init() Peter Xu
2017-05-29  6:08 ` Peter Xu
2017-05-29  9:42   ` Markus Armbruster
2017-05-29 10:13     ` Peter Xu
2017-05-29 12:16       ` Markus Armbruster
2017-05-30  9:16         ` Paolo Bonzini
2017-05-30 14:28           ` Markus Armbruster
2017-05-30 14:29             ` Paolo Bonzini [this message]
2017-05-31  7:03               ` Peter Xu
2017-05-31  7:40                 ` Paolo Bonzini
2017-05-31  8:26                   ` Peter Xu
2017-05-31  8:28                     ` Paolo Bonzini
2017-05-31  8:55                       ` Peter Xu
2017-06-01  8:27                       ` Marcel Apfelbaum
2017-06-01 14:23                         ` Paolo Bonzini
2017-06-01 19:22                           ` Aurelien Jarno
2017-06-01 22:06                             ` Paul Burton
2017-06-02  4:18                               ` Peter Xu
2017-06-02  7:47                                 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a6a91cc-7ea1-2b45-a4bd-31aa3cfef917@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.