* [PATCH] xen/drivers: char: Match #if DEBUG_TRACE_DUMP and #endif comment
@ 2019-03-19 23:19 Julien Grall
2019-03-20 7:01 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2019-03-19 23:19 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Julien Grall, Jan Beulich
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
xen/drivers/char/console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index f41b689847..61695d967e 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -1320,7 +1320,7 @@ static int __init debugtrace_init(void)
}
__initcall(debugtrace_init);
-#endif /* !NDEBUG */
+#endif /* !DEBUG_TRACE_DUMP */
/*
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/drivers: char: Match #if DEBUG_TRACE_DUMP and #endif comment
2019-03-19 23:19 [PATCH] xen/drivers: char: Match #if DEBUG_TRACE_DUMP and #endif comment Julien Grall
@ 2019-03-20 7:01 ` Jan Beulich
2019-03-21 18:44 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2019-03-20 7:01 UTC (permalink / raw)
To: julien.grall
Cc: sstabellini, wei.liu2, konrad.wilk, George.Dunlap,
andrew.cooper3, ian.jackson, tim, xen-devel
>>> Julien Grall <julien.grall@arm.com> 03/20/19 12:19 AM >>>
>--- a/xen/drivers/char/console.c
>+++ b/xen/drivers/char/console.c
>@@ -1320,7 +1320,7 @@ static int __init debugtrace_init(void)
>}
>__initcall(debugtrace_init);
>
>-#endif /* !NDEBUG */
>+#endif /* !DEBUG_TRACE_DUMP */
But it's CONFIG_DEBUG_TRACE now, isn't it? With this adjusted
Acked-by: Jan Beulich <jbeulich@suse.com>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/drivers: char: Match #if DEBUG_TRACE_DUMP and #endif comment
2019-03-20 7:01 ` Jan Beulich
@ 2019-03-21 18:44 ` Julien Grall
0 siblings, 0 replies; 3+ messages in thread
From: Julien Grall @ 2019-03-21 18:44 UTC (permalink / raw)
To: Jan Beulich
Cc: sstabellini, wei.liu2, konrad.wilk, George.Dunlap,
andrew.cooper3, ian.jackson, tim, xen-devel
Hi,
On 3/20/19 7:01 AM, Jan Beulich wrote:
>>>> Julien Grall <julien.grall@arm.com> 03/20/19 12:19 AM >>>
>> --- a/xen/drivers/char/console.c
>> +++ b/xen/drivers/char/console.c
>> @@ -1320,7 +1320,7 @@ static int __init debugtrace_init(void)
>> }
>> __initcall(debugtrace_init);
> >
>> -#endif /* !NDEBUG */
>> +#endif /* !DEBUG_TRACE_DUMP */
>
> But it's CONFIG_DEBUG_TRACE now, isn't it? With this adjusted
Hmm yes. I wrote this patch a few weeks ago and didn't check properly
staging.
> Acked-by: Jan Beulich <jbeulich@suse.com>
Thank you! I have updated the patch and committed.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-21 18:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 23:19 [PATCH] xen/drivers: char: Match #if DEBUG_TRACE_DUMP and #endif comment Julien Grall
2019-03-20 7:01 ` Jan Beulich
2019-03-21 18:44 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.