All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Nick Terrell <nickrterrell@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org,
	squashfs-devel@lists.sourceforge.net,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, "Kernel Team" <Kernel-team@fb.com>,
	"Nick Terrell" <terrelln@fb.com>, "Chris Mason" <clm@fb.com>,
	"Petr Malat" <oss@malat.biz>, "Johannes Weiner" <jweiner@fb.com>,
	"Niket Agarwal" <niketa@fb.com>, "Yann Collet" <cyan@fb.com>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"David Sterba" <dsterba@suse.cz>,
	"Oleksandr Natalenko" <oleksandr@natalenko.name>,
	"Felix Handte" <felixh@fb.com>,
	"Eric Biggers" <ebiggers@kernel.org>
Subject: Re: [GIT PULL][PATCH v10 0/4] Update to zstd-1.4.10
Date: Tue, 27 Apr 2021 15:09:59 -0700	[thread overview]
Message-ID: <10397ef2-119d-b065-2e82-cac1d800dfd0@infradead.org> (raw)
In-Reply-To: <20210426234621.870684-1-nickrterrell@gmail.com>

On 4/26/21 4:46 PM, Nick Terrell wrote:
> From: Nick Terrell <terrelln@fb.com>
> 
> Please pull from
> 
>   git@github.com:terrelln/linux.git tags/v10-zstd-1.4.10
> 
> to get these changes. Alternatively the patchset is included.
> 
> This patchset lists me as the maintainer for zstd and upgrades the zstd library
> to the latest upstream release. The current zstd version in the kernel is a
> modified version of upstream zstd-1.3.1. At the time it was integrated, zstd
> wasn't ready to be used in the kernel as-is. But, it is now possible to use
> upstream zstd directly in the kernel.

Hi Nick,

Several of the source (.c, .h) files use comments blocks that
begin with "/**", which means "this is the beginning of a kernel-doc
comment" when in the kernel source tree. However, they are not in
kernel-doc format.

During the automatic generation from upstream zstd, please find a way
to change /** to /*.

This does need to slow down the acceptance of this patch series IMO.


thanks.
-- 
~Randy


WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Nick Terrell <nickrterrell@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>
Cc: squashfs-devel@lists.sourceforge.net,
	"Eric Biggers" <ebiggers@kernel.org>,
	"Johannes Weiner" <jweiner@fb.com>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Yann Collet" <cyan@fb.com>, "David Sterba" <dsterba@suse.cz>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	"Petr Malat" <oss@malat.biz>, "Chris Mason" <clm@fb.com>,
	"Nick Terrell" <terrelln@fb.com>,
	linux-crypto@vger.kernel.org, "Felix Handte" <felixh@fb.com>,
	"Oleksandr Natalenko" <oleksandr@natalenko.name>,
	"Kernel Team" <Kernel-team@fb.com>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Niket Agarwal" <niketa@fb.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [GIT PULL][PATCH v10 0/4] Update to zstd-1.4.10
Date: Tue, 27 Apr 2021 15:09:59 -0700	[thread overview]
Message-ID: <10397ef2-119d-b065-2e82-cac1d800dfd0@infradead.org> (raw)
In-Reply-To: <20210426234621.870684-1-nickrterrell@gmail.com>

On 4/26/21 4:46 PM, Nick Terrell wrote:
> From: Nick Terrell <terrelln@fb.com>
> 
> Please pull from
> 
>   git@github.com:terrelln/linux.git tags/v10-zstd-1.4.10
> 
> to get these changes. Alternatively the patchset is included.
> 
> This patchset lists me as the maintainer for zstd and upgrades the zstd library
> to the latest upstream release. The current zstd version in the kernel is a
> modified version of upstream zstd-1.3.1. At the time it was integrated, zstd
> wasn't ready to be used in the kernel as-is. But, it is now possible to use
> upstream zstd directly in the kernel.

Hi Nick,

Several of the source (.c, .h) files use comments blocks that
begin with "/**", which means "this is the beginning of a kernel-doc
comment" when in the kernel source tree. However, they are not in
kernel-doc format.

During the automatic generation from upstream zstd, please find a way
to change /** to /*.

This does need to slow down the acceptance of this patch series IMO.


thanks.
-- 
~Randy



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2021-04-27 22:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 23:46 [GIT PULL][PATCH v10 0/4] Update to zstd-1.4.10 Nick Terrell
2021-04-26 23:46 ` [f2fs-dev] " Nick Terrell
2021-04-26 23:46 ` [PATCH v10 1/4] lib: zstd: Add kernel-specific API Nick Terrell
2021-04-26 23:46   ` [f2fs-dev] " Nick Terrell
2021-04-26 23:46 ` [PATCH v10 2/4] lib: zstd: Add decompress_sources.h for decompress_unzstd Nick Terrell
2021-04-26 23:46   ` [f2fs-dev] " Nick Terrell
2021-04-26 23:46 ` [PATCH v10 3/4] lib: zstd: Upgrade to latest upstream zstd version 1.4.10 Nick Terrell
2021-04-26 23:46   ` [f2fs-dev] " Nick Terrell
2021-04-27  3:57   ` kernel test robot
2021-04-27  3:57     ` kernel test robot
2021-04-26 23:46 ` [PATCH v10 4/4] MAINTAINERS: Add maintainer entry for zstd Nick Terrell
2021-04-26 23:46   ` [f2fs-dev] " Nick Terrell
2021-04-27  6:26 ` [GIT PULL][PATCH v10 0/4] Update to zstd-1.4.10 Oleksandr Natalenko
2021-04-27  6:26   ` [f2fs-dev] " Oleksandr Natalenko via Linux-f2fs-devel
2021-04-27 22:09 ` Randy Dunlap [this message]
2021-04-27 22:09   ` Randy Dunlap
2021-04-27 23:39   ` Nick Terrell
2021-04-27 23:39     ` [f2fs-dev] " Nick Terrell via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10397ef2-119d-b065-2e82-cac1d800dfd0@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=Kernel-team@fb.com \
    --cc=clm@fb.com \
    --cc=cyan@fb.com \
    --cc=dsterba@suse.cz \
    --cc=ebiggers@kernel.org \
    --cc=felixh@fb.com \
    --cc=hch@infradead.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jweiner@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=nickrterrell@gmail.com \
    --cc=niketa@fb.com \
    --cc=oleksandr@natalenko.name \
    --cc=oss@malat.biz \
    --cc=squashfs-devel@lists.sourceforge.net \
    --cc=terrelln@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.