All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Haverkamp <haver@linux.vnet.ibm.com>
To: Geliang Tang <geliangtang@gmail.com>
Cc: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] GenWQE: drop duplicate headers
Date: Thu, 24 Nov 2016 13:51:57 +0100	[thread overview]
Message-ID: <103A7FE0-12A9-4C9D-AAEF-43E84A100868@linux.vnet.ibm.com> (raw)
In-Reply-To: <5bf35d8273cb0b4bcdad3f4018c593a157ac6a22.1479905566.git.geliangtang@gmail.com>

Hi Geliang,


> On 23 Nov 2016, at 15:24, Geliang Tang <geliangtang@gmail.com> wrote:
> 
> Drop duplicate headers module.h and delay.h.
> 
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> drivers/misc/genwqe/card_base.c  | 1 -
> drivers/misc/genwqe/card_ddcb.c  | 1 -
> drivers/misc/genwqe/card_utils.c | 1 -
> 3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
> index 6c1f49a..b6f2edf 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -34,7 +34,6 @@
> #include <linux/wait.h>
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
> -#include <linux/module.h>
> #include <linux/notifier.h>
> #include <linux/device.h>
> #include <linux/log2.h>
> diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c
> index ddfeefe..332a0d1 100644
> --- a/drivers/misc/genwqe/card_ddcb.c
> +++ b/drivers/misc/genwqe/card_ddcb.c
> @@ -34,7 +34,6 @@
> #include <linux/string.h>
> #include <linux/dma-mapping.h>
> #include <linux/delay.h>
> -#include <linux/module.h>
> #include <linux/interrupt.h>
> #include <linux/crc-itu-t.h>
> 
> diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
> index 147b830..a1859e5 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -36,7 +36,6 @@
> #include <linux/ctype.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/delay.h>
> #include <asm/pgtable.h>
> 
> #include "genwqe_driver.h"
> -- 
> 2.9.3
> 

thanks for the simplification. Did you find those by manual inspection, or did you use a tool?

Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>

  reply	other threads:[~2016-11-28  8:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 14:24 [PATCH] dwc_eth_qos: drop duplicate headers Geliang Tang
2016-11-23 14:24 ` [PATCH] GenWQE: " Geliang Tang
2016-11-24 12:51   ` Frank Haverkamp [this message]
2016-11-28 14:15     ` [PATCH] " Geliang Tang
2016-11-28 14:15       ` [PATCH v2] " Geliang Tang
2016-12-14  8:20       ` [PATCH] [PATCH] " Frank Haverkamp
2016-11-23 14:24 ` [PATCH] PNP: drop duplicate header pci.h Geliang Tang
2016-11-25 21:14 ` [PATCH] dwc_eth_qos: drop duplicate headers David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=103A7FE0-12A9-4C9D-AAEF-43E84A100868@linux.vnet.ibm.com \
    --to=haver@linux.vnet.ibm.com \
    --cc=geliangtang@gmail.com \
    --cc=krisman@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.