From: Rodrigo Freire <rfreire@redhat.com> To: Brian Norris <computersforpeace@gmail.com> Cc: "Jörn Engel" <joern@logfs.org>, linux-mtd@lists.infradead.org, "Felix Fietkau" <nbd@openwrt.org>, dwmw2@infradead.org, linux-kernel@vger.kernel.org, "Herton Krzesinski" <hkrzesin@redhat.com> Subject: Re: [PATCH V2] mtd: block2mtd: Present block2mtd timely on boot time Date: Wed, 11 Feb 2015 10:09:45 -0500 (EST) [thread overview] Message-ID: <1041042635.11106996.1423667385477.JavaMail.zimbra@redhat.com> (raw) In-Reply-To: <1754439525.4551871.1417008736061.JavaMail.zimbra@redhat.com> From: "Brian Norris" <computersforpeace@gmail.com> Sent: Wednesday, November 26, 2014 1:33:04 AM Subject: Re: [PATCH V2] mtd: block2mtd: Present block2mtd timely on boot time > On Sun, Nov 09, 2014 at 07:18:05AM -0500, Rodrigo Freire wrote: > > > From: "Brian Norris" <computersforpeace@gmail.com> > > > Sent: Wednesday, November 5, 2014 6:23:03 PM > > > > > This still seems like a bad idea (using a block device + block2mtd + > > > JFFS2). Why are you doing this? See comments here: > > > http://www.linux-mtd.infradead.org/faq/jffs2.html#L_hdd_jffs2 > > > > As Felix stated on a previous message to the thread, I am using JFFS2 over > > block2mtd where regular filesystems failed to do so well. There are several > > [1] threads pointing this issue, and JFFS2 over block2mtd works like a > > charm > > on more harsh scenarios. > [...] > > [1] - http://bit.ly/1smGvwa > OK, so there are definitely problems with cheap SD card power cut > tolerance. That's not news. But that doesn't mean block2mtd + JFFS2 is a > good solution. In fact, when I add 'jffs2' to your Google search query > of 'raspberry pi corrupt sd card', the only mentions I see are those who > agree that this is not the right choice. > But anyway, we can look at supporting block2mtd (since you provided the > patches), even if we don't agree how it should be used. And in fact, I > might argue there are no good (production) uses for block2mtd, so I > suppose I don't have much stake in it :) Hi there Brian, This patchset primarily aims to fix a block2mtd behavior, and not introduce new features (well, the device name and a timeout option are indeed new options, but they're actually enhancements). block2mtd already exists, works nicely as boot root device on several architectures, but fails on BCM2835 arch. Our patchset only aims to get it fixed. We just want to block2mtd work on BCM2835 the way it works on different architectures. So, this is a fix. As a side note, WRT the SD card corruption; it also happens on good quality SD cards too. The main culprit for the corruption is bad mains / power supply issues / abrupt poweroff. And there's also the wear leveling... Thanks for the thorough review. Looking forward for the ACK ;-) My best regards, - RF.
WARNING: multiple messages have this Message-ID (diff)
From: Rodrigo Freire <rfreire@redhat.com> To: Brian Norris <computersforpeace@gmail.com> Cc: "Felix Fietkau" <nbd@openwrt.org>, "Jörn Engel" <joern@logfs.org>, "Herton Krzesinski" <hkrzesin@redhat.com>, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, dwmw2@infradead.org Subject: Re: [PATCH V2] mtd: block2mtd: Present block2mtd timely on boot time Date: Wed, 11 Feb 2015 10:09:45 -0500 (EST) [thread overview] Message-ID: <1041042635.11106996.1423667385477.JavaMail.zimbra@redhat.com> (raw) In-Reply-To: <1754439525.4551871.1417008736061.JavaMail.zimbra@redhat.com> From: "Brian Norris" <computersforpeace@gmail.com> Sent: Wednesday, November 26, 2014 1:33:04 AM Subject: Re: [PATCH V2] mtd: block2mtd: Present block2mtd timely on boot time > On Sun, Nov 09, 2014 at 07:18:05AM -0500, Rodrigo Freire wrote: > > > From: "Brian Norris" <computersforpeace@gmail.com> > > > Sent: Wednesday, November 5, 2014 6:23:03 PM > > > > > This still seems like a bad idea (using a block device + block2mtd + > > > JFFS2). Why are you doing this? See comments here: > > > http://www.linux-mtd.infradead.org/faq/jffs2.html#L_hdd_jffs2 > > > > As Felix stated on a previous message to the thread, I am using JFFS2 over > > block2mtd where regular filesystems failed to do so well. There are several > > [1] threads pointing this issue, and JFFS2 over block2mtd works like a > > charm > > on more harsh scenarios. > [...] > > [1] - http://bit.ly/1smGvwa > OK, so there are definitely problems with cheap SD card power cut > tolerance. That's not news. But that doesn't mean block2mtd + JFFS2 is a > good solution. In fact, when I add 'jffs2' to your Google search query > of 'raspberry pi corrupt sd card', the only mentions I see are those who > agree that this is not the right choice. > But anyway, we can look at supporting block2mtd (since you provided the > patches), even if we don't agree how it should be used. And in fact, I > might argue there are no good (production) uses for block2mtd, so I > suppose I don't have much stake in it :) Hi there Brian, This patchset primarily aims to fix a block2mtd behavior, and not introduce new features (well, the device name and a timeout option are indeed new options, but they're actually enhancements). block2mtd already exists, works nicely as boot root device on several architectures, but fails on BCM2835 arch. Our patchset only aims to get it fixed. We just want to block2mtd work on BCM2835 the way it works on different architectures. So, this is a fix. As a side note, WRT the SD card corruption; it also happens on good quality SD cards too. The main culprit for the corruption is bad mains / power supply issues / abrupt poweroff. And there's also the wear leveling... Thanks for the thorough review. Looking forward for the ACK ;-) My best regards, - RF.
next prev parent reply other threads:[~2015-02-11 15:10 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <371358190.34795877.1410204429882.JavaMail.zimbra@redhat.com> 2014-09-08 20:04 ` [PATCH] block2mtd: mtd: Present block2mtd timely on boot time Rodrigo Freire 2014-09-09 17:02 ` Jörn Engel 2014-09-09 17:02 ` Jörn Engel 2014-09-17 20:18 ` Rodrigo Freire 2014-09-17 20:18 ` Rodrigo Freire 2014-09-17 20:28 ` [PATCH V2] mtd: block2mtd: " Rodrigo Freire 2014-09-17 20:28 ` Rodrigo Freire 2014-09-17 21:21 ` Ezequiel Garcia 2014-09-17 21:21 ` Ezequiel Garcia 2014-09-17 21:41 ` Rodrigo Freire 2014-09-17 21:41 ` Rodrigo Freire 2014-10-09 15:07 ` [RESEND PATCH " Rodrigo Freire 2014-10-09 15:07 ` Rodrigo Freire 2014-11-01 13:33 ` Rodrigo Freire 2014-11-01 13:33 ` Rodrigo Freire 2014-11-07 9:44 ` Artem Bityutskiy 2014-11-07 9:44 ` Artem Bityutskiy 2014-11-07 20:05 ` Brian Norris 2014-11-07 20:05 ` Brian Norris 2014-11-05 20:01 ` Brian Norris 2014-11-05 20:01 ` Brian Norris 2014-11-05 20:23 ` [PATCH " Brian Norris 2014-11-05 20:23 ` Brian Norris 2014-11-07 14:59 ` Artem Bityutskiy 2014-11-07 14:59 ` Artem Bityutskiy 2014-11-07 15:20 ` Felix Fietkau 2014-11-07 15:20 ` Felix Fietkau 2014-11-07 15:30 ` Artem Bityutskiy 2014-11-07 15:30 ` Artem Bityutskiy 2014-11-09 12:18 ` Rodrigo Freire 2014-11-09 12:18 ` Rodrigo Freire 2014-11-26 3:33 ` Brian Norris 2014-11-26 3:33 ` Brian Norris 2014-11-26 13:32 ` Rodrigo Freire 2014-11-26 13:32 ` Rodrigo Freire 2015-02-11 15:09 ` Rodrigo Freire [this message] 2015-02-11 15:09 ` Rodrigo Freire 2014-11-09 12:18 ` [PATCH v3 0/3] mtd: block2mtd: wait for device enumeration, add name support Rodrigo Freire 2014-11-09 12:18 ` Rodrigo Freire 2014-11-09 12:21 ` [PATCH v3 1/3] mtd: block2mtd: Ensure that block2mtd is triggered after block devices are presented Rodrigo Freire 2014-11-09 12:21 ` Rodrigo Freire 2015-02-24 7:45 ` Brian Norris 2015-02-24 7:45 ` Brian Norris 2014-11-09 12:22 ` [PATCH v3 2/3] mtd: block2mtd: Adds a mtd name and a block device timeout option Rodrigo Freire 2014-11-09 12:22 ` Rodrigo Freire 2015-02-24 8:05 ` Brian Norris 2015-02-24 8:05 ` Brian Norris 2014-11-09 12:23 ` [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to partition size Rodrigo Freire 2014-11-09 12:23 ` Rodrigo Freire 2014-11-26 7:21 ` Brian Norris 2014-11-26 7:21 ` Brian Norris 2014-11-26 13:19 ` Rodrigo Freire 2014-11-26 13:19 ` Rodrigo Freire 2015-02-24 8:07 ` Brian Norris 2015-02-24 8:07 ` Brian Norris 2015-02-24 8:20 ` Felix Fietkau 2015-02-24 8:20 ` Felix Fietkau 2015-02-24 8:27 ` Brian Norris 2015-02-24 8:27 ` Brian Norris 2015-02-24 8:30 ` Felix Fietkau 2015-02-24 8:30 ` Felix Fietkau 2015-02-24 8:40 ` Brian Norris 2015-02-24 8:40 ` Brian Norris
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1041042635.11106996.1423667385477.JavaMail.zimbra@redhat.com \ --to=rfreire@redhat.com \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=hkrzesin@redhat.com \ --cc=joern@logfs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=nbd@openwrt.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.