From: Andrzej Hajda <a.hajda@samsung.com> To: Pankaj Dubey <pankaj.dubey@samsung.com>, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: krzk@kernel.org, arnd@arndb.de, geert+renesas@glider.be, m.szyprowski@samsung.com, javier@osg.samsung.com, kgene@kernel.org, thomas.ab@samsung.com, Grant Likely <grant.likely@linaro.org>, Rob Herring <robh+dt@kernel.org>, Linus Walleij <linus.walleij@linaro.org> Subject: Re: [PATCH v8 1/8] soc: samsung: add exynos chipid driver support Date: Wed, 21 Dec 2016 15:08:31 +0100 [thread overview] Message-ID: <10428d31-62de-a897-b566-7057b8b27933@samsung.com> (raw) In-Reply-To: <1481375323-29724-2-git-send-email-pankaj.dubey@samsung.com> On 10.12.2016 14:08, Pankaj Dubey wrote: > Exynos SoCs have Chipid, for identification of product IDs and SoC revisions. > This patch intends to provide initialization code for all these functionalities, > at the same time it provides some sysfs entries for accessing these information > to user-space. > > This driver uses existing binding for exynos-chipid. > > CC: Grant Likely <grant.likely@linaro.org> > CC: Rob Herring <robh+dt@kernel.org> > CC: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > [m.szyprowski: for suggestion and code snippet of product_id_to_soc_id] > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/soc/samsung/Kconfig | 5 ++ > drivers/soc/samsung/Makefile | 1 + > drivers/soc/samsung/exynos-chipid.c | 116 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 122 insertions(+) > create mode 100644 drivers/soc/samsung/exynos-chipid.c > > diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig > index 2455339..f9ab858 100644 > --- a/drivers/soc/samsung/Kconfig > +++ b/drivers/soc/samsung/Kconfig > @@ -14,4 +14,9 @@ config EXYNOS_PM_DOMAINS > bool "Exynos PM domains" if COMPILE_TEST > depends on PM_GENERIC_DOMAINS || COMPILE_TEST > > +config EXYNOS_CHIPID > + bool "Exynos Chipid controller driver" if COMPILE_TEST > + depends on (ARM && ARCH_EXYNOS) || ((ARM || ARM64) && COMPILE_TEST) > + select SOC_BUS > + > endif > diff --git a/drivers/soc/samsung/Makefile b/drivers/soc/samsung/Makefile > index 3619f2e..2a8a85e 100644 > --- a/drivers/soc/samsung/Makefile > +++ b/drivers/soc/samsung/Makefile > @@ -1,3 +1,4 @@ > obj-$(CONFIG_EXYNOS_PMU) += exynos-pmu.o exynos3250-pmu.o exynos4-pmu.o \ > exynos5250-pmu.o exynos5420-pmu.o > obj-$(CONFIG_EXYNOS_PM_DOMAINS) += pm_domains.o > +obj-$(CONFIG_EXYNOS_CHIPID) += exynos-chipid.o > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > new file mode 100644 > index 0000000..cf0128b > --- /dev/null > +++ b/drivers/soc/samsung/exynos-chipid.c > @@ -0,0 +1,116 @@ > +/* > + * Copyright (c) 2016 Samsung Electronics Co., Ltd. > + * http://www.samsung.com/ > + * > + * EXYNOS - CHIP ID support > + * Author: Pankaj Dubey <pankaj.dubey@samsung.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include <linux/io.h> > +#include <linux/of.h> > +#include <linux/of_address.h> > +#include <linux/of_platform.h> > +#include <linux/platform_device.h> > +#include <linux/slab.h> > +#include <linux/sys_soc.h> > + > +#define EXYNOS_SUBREV_MASK (0xF << 4) > +#define EXYNOS_MAINREV_MASK (0xF << 0) > +#define EXYNOS_REV_MASK (EXYNOS_SUBREV_MASK | EXYNOS_MAINREV_MASK) > + > +static const struct exynos_soc_id { > + const char *name; > + unsigned int id; > + unsigned int mask; > +} soc_ids[] = { > + { "EXYNOS3250", 0xE3472000, 0xFFFFF000 }, > + { "EXYNOS4210", 0x43200000, 0xFFFE0000 }, > + { "EXYNOS4212", 0x43220000, 0xFFFE0000 }, > + { "EXYNOS4412", 0xE4412000, 0xFFFE0000 }, > + { "EXYNOS5250", 0x43520000, 0xFFFFF000 }, > + { "EXYNOS5260", 0xE5260000, 0xFFFFF000 }, > + { "EXYNOS5410", 0xE5410000, 0xFFFFF000 }, > + { "EXYNOS5420", 0xE5420000, 0xFFFFF000 }, > + { "EXYNOS5440", 0xE5440000, 0xFFFFF000 }, > + { "EXYNOS5800", 0xE5422000, 0xFFFFF000 }, > + { "EXYNOS7420", 0xE7420000, 0xFFFFF000 }, > + { "EXYNOS5433", 0xE5433000, 0xFFFFF000 }, I wonder why there are different masks in case of Exynos42*? In specs I have access to mask is always 0xFFFFF000. > +}; > + > +static const char * __init product_id_to_soc_id(unsigned int product_id) > +{ > + int i; > + > + for (i = 0; i < ARRAY_SIZE(soc_ids); i++) > + if ((product_id & soc_ids[i].mask) == soc_ids[i].id) > + return soc_ids[i].name; > + return "UNKNOWN"; > +} > + > +static const struct of_device_id of_exynos_chipid_ids[] = { > + { > + .compatible = "samsung,exynos4210-chipid", > + }, > + {}, > +}; > + > +/** > + * exynos_chipid_early_init: Early chipid initialization > + */ > +int __init exynos_chipid_early_init(void) > +{ > + struct soc_device_attribute *soc_dev_attr; > + struct soc_device *soc_dev; > + struct device_node *root; > + struct device_node *np; > + void __iomem *exynos_chipid_base; > + const struct of_device_id *match; > + u32 product_id; > + u32 revision; > + > + np = of_find_matching_node_and_match(NULL, > + of_exynos_chipid_ids, &match); > + if (!np) > + return -ENODEV; > + > + exynos_chipid_base = of_iomap(np, 0); > + > + if (!exynos_chipid_base) > + return PTR_ERR(exynos_chipid_base); > + > + product_id = readl_relaxed(exynos_chipid_base); > + revision = product_id & EXYNOS_REV_MASK; > + iounmap(exynos_chipid_base); > + > + soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL); > + if (!soc_dev_attr) > + return -ENODEV; > + > + soc_dev_attr->family = "Samsung Exynos"; > + > + root = of_find_node_by_path("/"); > + of_property_read_string(root, "model", &soc_dev_attr->machine); > + of_node_put(root); > + > + soc_dev_attr->revision = kasprintf(GFP_KERNEL, "%x", revision); > + soc_dev_attr->soc_id = product_id_to_soc_id(product_id); > + > + > + pr_info("Exynos: CPU[%s] CPU_REV[0x%x] Detected\n", > + product_id_to_soc_id(product_id), revision); I wonder if it wouldn't be good to log numeric value of whole PRO_ID register, this way we will have also useful log for chips not know to soc_ids array. It will show also some missing bits: masked bits, package_information and reserved bit. Btw. package_information can be used to distinguish S5PC210 and S5PV310. And small optimization, you can reuse soc_dev_attr->soc_id instead of calling the same function again. And finally all log could be moved after soc_device_register, this way you can use: struc device *dev = soc_device_to_device(soc_dev); dev_info(dev, ...); Regards Andrzej > + > + soc_dev = soc_device_register(soc_dev_attr); > + if (IS_ERR(soc_dev)) { > + kfree(soc_dev_attr->revision); > + kfree_const(soc_dev_attr->soc_id); > + kfree(soc_dev_attr); > + return PTR_ERR(soc_dev); > + } > + > + return 0; > +} > +early_initcall(exynos_chipid_early_init);
WARNING: multiple messages have this Message-ID (diff)
From: a.hajda@samsung.com (Andrzej Hajda) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v8 1/8] soc: samsung: add exynos chipid driver support Date: Wed, 21 Dec 2016 15:08:31 +0100 [thread overview] Message-ID: <10428d31-62de-a897-b566-7057b8b27933@samsung.com> (raw) In-Reply-To: <1481375323-29724-2-git-send-email-pankaj.dubey@samsung.com> On 10.12.2016 14:08, Pankaj Dubey wrote: > Exynos SoCs have Chipid, for identification of product IDs and SoC revisions. > This patch intends to provide initialization code for all these functionalities, > at the same time it provides some sysfs entries for accessing these information > to user-space. > > This driver uses existing binding for exynos-chipid. > > CC: Grant Likely <grant.likely@linaro.org> > CC: Rob Herring <robh+dt@kernel.org> > CC: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > [m.szyprowski: for suggestion and code snippet of product_id_to_soc_id] > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/soc/samsung/Kconfig | 5 ++ > drivers/soc/samsung/Makefile | 1 + > drivers/soc/samsung/exynos-chipid.c | 116 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 122 insertions(+) > create mode 100644 drivers/soc/samsung/exynos-chipid.c > > diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig > index 2455339..f9ab858 100644 > --- a/drivers/soc/samsung/Kconfig > +++ b/drivers/soc/samsung/Kconfig > @@ -14,4 +14,9 @@ config EXYNOS_PM_DOMAINS > bool "Exynos PM domains" if COMPILE_TEST > depends on PM_GENERIC_DOMAINS || COMPILE_TEST > > +config EXYNOS_CHIPID > + bool "Exynos Chipid controller driver" if COMPILE_TEST > + depends on (ARM && ARCH_EXYNOS) || ((ARM || ARM64) && COMPILE_TEST) > + select SOC_BUS > + > endif > diff --git a/drivers/soc/samsung/Makefile b/drivers/soc/samsung/Makefile > index 3619f2e..2a8a85e 100644 > --- a/drivers/soc/samsung/Makefile > +++ b/drivers/soc/samsung/Makefile > @@ -1,3 +1,4 @@ > obj-$(CONFIG_EXYNOS_PMU) += exynos-pmu.o exynos3250-pmu.o exynos4-pmu.o \ > exynos5250-pmu.o exynos5420-pmu.o > obj-$(CONFIG_EXYNOS_PM_DOMAINS) += pm_domains.o > +obj-$(CONFIG_EXYNOS_CHIPID) += exynos-chipid.o > diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c > new file mode 100644 > index 0000000..cf0128b > --- /dev/null > +++ b/drivers/soc/samsung/exynos-chipid.c > @@ -0,0 +1,116 @@ > +/* > + * Copyright (c) 2016 Samsung Electronics Co., Ltd. > + * http://www.samsung.com/ > + * > + * EXYNOS - CHIP ID support > + * Author: Pankaj Dubey <pankaj.dubey@samsung.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include <linux/io.h> > +#include <linux/of.h> > +#include <linux/of_address.h> > +#include <linux/of_platform.h> > +#include <linux/platform_device.h> > +#include <linux/slab.h> > +#include <linux/sys_soc.h> > + > +#define EXYNOS_SUBREV_MASK (0xF << 4) > +#define EXYNOS_MAINREV_MASK (0xF << 0) > +#define EXYNOS_REV_MASK (EXYNOS_SUBREV_MASK | EXYNOS_MAINREV_MASK) > + > +static const struct exynos_soc_id { > + const char *name; > + unsigned int id; > + unsigned int mask; > +} soc_ids[] = { > + { "EXYNOS3250", 0xE3472000, 0xFFFFF000 }, > + { "EXYNOS4210", 0x43200000, 0xFFFE0000 }, > + { "EXYNOS4212", 0x43220000, 0xFFFE0000 }, > + { "EXYNOS4412", 0xE4412000, 0xFFFE0000 }, > + { "EXYNOS5250", 0x43520000, 0xFFFFF000 }, > + { "EXYNOS5260", 0xE5260000, 0xFFFFF000 }, > + { "EXYNOS5410", 0xE5410000, 0xFFFFF000 }, > + { "EXYNOS5420", 0xE5420000, 0xFFFFF000 }, > + { "EXYNOS5440", 0xE5440000, 0xFFFFF000 }, > + { "EXYNOS5800", 0xE5422000, 0xFFFFF000 }, > + { "EXYNOS7420", 0xE7420000, 0xFFFFF000 }, > + { "EXYNOS5433", 0xE5433000, 0xFFFFF000 }, I wonder why there are different masks in case of Exynos42*? In specs I have access to mask is always 0xFFFFF000. > +}; > + > +static const char * __init product_id_to_soc_id(unsigned int product_id) > +{ > + int i; > + > + for (i = 0; i < ARRAY_SIZE(soc_ids); i++) > + if ((product_id & soc_ids[i].mask) == soc_ids[i].id) > + return soc_ids[i].name; > + return "UNKNOWN"; > +} > + > +static const struct of_device_id of_exynos_chipid_ids[] = { > + { > + .compatible = "samsung,exynos4210-chipid", > + }, > + {}, > +}; > + > +/** > + * exynos_chipid_early_init: Early chipid initialization > + */ > +int __init exynos_chipid_early_init(void) > +{ > + struct soc_device_attribute *soc_dev_attr; > + struct soc_device *soc_dev; > + struct device_node *root; > + struct device_node *np; > + void __iomem *exynos_chipid_base; > + const struct of_device_id *match; > + u32 product_id; > + u32 revision; > + > + np = of_find_matching_node_and_match(NULL, > + of_exynos_chipid_ids, &match); > + if (!np) > + return -ENODEV; > + > + exynos_chipid_base = of_iomap(np, 0); > + > + if (!exynos_chipid_base) > + return PTR_ERR(exynos_chipid_base); > + > + product_id = readl_relaxed(exynos_chipid_base); > + revision = product_id & EXYNOS_REV_MASK; > + iounmap(exynos_chipid_base); > + > + soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL); > + if (!soc_dev_attr) > + return -ENODEV; > + > + soc_dev_attr->family = "Samsung Exynos"; > + > + root = of_find_node_by_path("/"); > + of_property_read_string(root, "model", &soc_dev_attr->machine); > + of_node_put(root); > + > + soc_dev_attr->revision = kasprintf(GFP_KERNEL, "%x", revision); > + soc_dev_attr->soc_id = product_id_to_soc_id(product_id); > + > + > + pr_info("Exynos: CPU[%s] CPU_REV[0x%x] Detected\n", > + product_id_to_soc_id(product_id), revision); I wonder if it wouldn't be good to log numeric value of whole PRO_ID register, this way we will have also useful log for chips not know to soc_ids array. It will show also some missing bits: masked bits, package_information and reserved bit. Btw. package_information can be used to distinguish S5PC210 and S5PV310. And small optimization, you can reuse soc_dev_attr->soc_id instead of calling the same function again. And finally all log could be moved after soc_device_register, this way you can use: struc device *dev = soc_device_to_device(soc_dev); dev_info(dev, ...); Regards Andrzej > + > + soc_dev = soc_device_register(soc_dev_attr); > + if (IS_ERR(soc_dev)) { > + kfree(soc_dev_attr->revision); > + kfree_const(soc_dev_attr->soc_id); > + kfree(soc_dev_attr); > + return PTR_ERR(soc_dev); > + } > + > + return 0; > +} > +early_initcall(exynos_chipid_early_init);
next prev parent reply other threads:[~2016-12-21 14:08 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20161210130616epcas1p2ce44d503ae03854e7b36b4d37d54900a@epcas1p2.samsung.com> 2016-12-10 13:08 ` [PATCH v8 0/8] Introducing Exynos ChipId driver Pankaj Dubey 2016-12-10 13:08 ` Pankaj Dubey 2016-12-10 13:08 ` [PATCH v8 1/8] soc: samsung: add exynos chipid driver support Pankaj Dubey 2016-12-10 13:08 ` Pankaj Dubey 2016-12-16 17:37 ` Krzysztof Kozlowski 2016-12-16 17:37 ` Krzysztof Kozlowski 2016-12-17 4:06 ` Pankaj Dubey 2016-12-17 4:06 ` Pankaj Dubey 2016-12-17 12:03 ` Krzysztof Kozlowski 2016-12-17 12:03 ` Krzysztof Kozlowski 2016-12-19 11:59 ` Markus Reichl 2016-12-19 11:59 ` Markus Reichl 2016-12-19 13:29 ` pankaj.dubey 2016-12-19 13:29 ` pankaj.dubey 2016-12-19 18:03 ` Krzysztof Kozlowski 2016-12-19 18:03 ` Krzysztof Kozlowski 2016-12-21 7:52 ` pankaj.dubey 2016-12-21 7:52 ` pankaj.dubey 2016-12-21 14:08 ` Andrzej Hajda [this message] 2016-12-21 14:08 ` Andrzej Hajda [not found] ` <CGME20161227140255epcas1p1a2c2b50ede0e9b2378c8ac052b1617f6@epcas1p1.samsung.com> 2016-12-27 14:02 ` Bartlomiej Zolnierkiewicz 2016-12-27 14:02 ` Bartlomiej Zolnierkiewicz 2016-12-28 2:38 ` Pankaj Dubey 2016-12-28 2:38 ` Pankaj Dubey 2016-12-10 13:08 ` [PATCH v8 2/8] ARM: EXYNOS: enable exynos_chipid for ARCH_EXYNOS Pankaj Dubey 2016-12-10 13:08 ` Pankaj Dubey 2016-12-16 18:04 ` Krzysztof Kozlowski 2016-12-16 18:04 ` Krzysztof Kozlowski 2016-12-17 4:15 ` Pankaj Dubey 2016-12-17 4:15 ` Pankaj Dubey 2016-12-10 13:08 ` [PATCH v8 3/8] ARM64: " Pankaj Dubey 2016-12-10 13:08 ` Pankaj Dubey 2016-12-16 17:38 ` Krzysztof Kozlowski 2016-12-16 17:38 ` Krzysztof Kozlowski 2016-12-10 13:08 ` [PATCH v8 4/8] ARM: EXYNOS: refactor firmware specific routines Pankaj Dubey 2016-12-10 13:08 ` Pankaj Dubey 2016-12-16 18:25 ` Krzysztof Kozlowski 2016-12-16 18:25 ` Krzysztof Kozlowski 2016-12-17 3:50 ` Pankaj Dubey 2016-12-17 3:50 ` Pankaj Dubey 2016-12-10 13:08 ` [PATCH v8 5/8] ARM: EXYNOS: refactor power management " Pankaj Dubey 2016-12-10 13:08 ` Pankaj Dubey 2016-12-17 14:54 ` Krzysztof Kozlowski 2016-12-17 14:54 ` Krzysztof Kozlowski 2016-12-10 13:08 ` [PATCH v8 6/8] ARM: EXYNOS: remove secondary startup initialization from smp_prepare_cpus Pankaj Dubey 2016-12-10 13:08 ` Pankaj Dubey 2016-12-17 18:48 ` Krzysztof Kozlowski 2016-12-17 18:48 ` Krzysztof Kozlowski 2016-12-17 22:06 ` Chanwoo Choi 2016-12-17 22:06 ` Chanwoo Choi 2016-12-10 13:08 ` [PATCH v8 7/8] ARM: EXYNOS: refactor smp specific code and routines Pankaj Dubey 2016-12-10 13:08 ` Pankaj Dubey 2016-12-17 18:59 ` Krzysztof Kozlowski 2016-12-17 18:59 ` Krzysztof Kozlowski 2016-12-10 13:08 ` [PATCH v8 8/8] ARM: EXYNOS: refactor of mach-exynos to use chipid information Pankaj Dubey 2016-12-10 13:08 ` Pankaj Dubey 2016-12-17 19:03 ` Krzysztof Kozlowski 2016-12-17 19:03 ` Krzysztof Kozlowski 2016-12-16 13:11 ` [PATCH v8 0/8] Introducing Exynos ChipId driver Marek Szyprowski 2016-12-16 13:11 ` Marek Szyprowski 2016-12-19 13:25 ` pankaj.dubey 2016-12-19 13:25 ` pankaj.dubey
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=10428d31-62de-a897-b566-7057b8b27933@samsung.com \ --to=a.hajda@samsung.com \ --cc=arnd@arndb.de \ --cc=geert+renesas@glider.be \ --cc=grant.likely@linaro.org \ --cc=javier@osg.samsung.com \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=pankaj.dubey@samsung.com \ --cc=robh+dt@kernel.org \ --cc=thomas.ab@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.