[PATCH] media: cxd2880: Add terminating new line to Kconfig

[PATCH] media: cxd2880: Add terminating new line to Kconfig

[Prasad Pandit]

From: Prasad Pandit <pjp@fedoraproject.org>

Add terminating new line to the Kconfig file.

Fixes: 9dbaad428d69 ("media: cxd2880: Add all Makefile, Kconfig files and
Update MAINTAINERS file for the driver")

Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>
---
 drivers/media/dvb-frontends/cxd2880/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/cxd2880/Kconfig b/drivers/media/dvb-frontends/cxd2880/Kconfig
index 9d989676e800..94a8e0b936b9 100644
--- a/drivers/media/dvb-frontends/cxd2880/Kconfig
+++ b/drivers/media/dvb-frontends/cxd2880/Kconfig
@@ -5,4 +5,4 @@ config DVB_CXD2880
 	depends on DVB_CORE && SPI
 	default m if !MEDIA_SUBDRV_AUTOSELECT
 	help
-	  Say Y when you want to support this frontend.
\ No newline at end of file
+	  Say Y when you want to support this frontend.
-- 
2.44.0

Re: [PATCH] media: cxd2880: Add terminating new line to Kconfig

[P J P]

>From: Prasad Pandit <pjp@fedoraproject.org>
>diff --git a/drivers/media/dvb-frontends/cxd2880/Kconfig b/drivers/media/dvb-frontends/cxd2880/Kconfig
>index 9d989676e800..94a8e0b936b9 100644
>--- a/drivers/media/dvb-frontends/cxd2880/Kconfig
>+++ b/drivers/media/dvb-frontends/cxd2880/Kconfig
>@@ -5,4 +5,4 @@ config DVB_CXD2880
>    depends on DVB_CORE && SPI
>    default m if !MEDIA_SUBDRV_AUTOSELECT
>    help
>-      Say Y when you want to support this frontend.
>\ No newline at end of file
>+      Say Y when you want to support this frontend.
>-- 
>2.44.0

Ping...! (just checking)
---
  -Prasad

Re: [PATCH] media: cxd2880: Add terminating new line to Kconfig

[P J P]

>On Wednesday, 20 March, 2024 at 01:09:32 pm IST, P J P <pjp@fedoraproject.org> wrote: 
>>From: Prasad Pandit <pjp@fedoraproject.org>
>>diff --git a/drivers/media/dvb-frontends/cxd2880/Kconfig b/drivers/media/dvb-frontends/cxd2880/Kconfig
>>index 9d989676e800..94a8e0b936b9 100644
>>--- a/drivers/media/dvb-frontends/cxd2880/Kconfig
>>+++ b/drivers/media/dvb-frontends/cxd2880/Kconfig
>>@@ -5,4 +5,4 @@ config DVB_CXD2880
>>    depends on DVB_CORE && SPI
>>    default m if !MEDIA_SUBDRV_AUTOSELECT
>>    help
>>-      Say Y when you want to support this frontend.
>>\ No newline at end of file
>>+      Say Y when you want to support this frontend.
>>-- 
>>2.44.0
>
>Ping...!


Ping...! (just checking)
---
  -Prasad

Re: [PATCH] media: cxd2880: Add terminating new line to Kconfig

[Prasad Pandit]

>On Thursday, 28 March, 2024 at 12:14:32 pm IST, Prasad Pandit wrote:
>>On Wednesday, 20 March, 2024 at 01:09:32 pm IST, Prasad Pandit wrote: 
>>>From: Prasad Pandit <pjp@fedoraproject.org>
>>>diff --git a/drivers/media/dvb-frontends/cxd2880/Kconfig b/drivers/media/dvb-frontends/cxd2880/Kconfig
>>>index 9d989676e800..94a8e0b936b9 100644
>>>--- a/drivers/media/dvb-frontends/cxd2880/Kconfig
>>>+++ b/drivers/media/dvb-frontends/cxd2880/Kconfig
>>>@@ -5,4 +5,4 @@ config DVB_CXD2880
>>>    depends on DVB_CORE && SPI
>>>    default m if !MEDIA_SUBDRV_AUTOSELECT
>>>    help
>>>-      Say Y when you want to support this frontend.
>>>\ No newline at end of file
>>>+      Say Y when you want to support this frontend.
>>>-- 
>>
>>Ping...!
>
>Ping...!

-> https://lore.kernel.org/linux-media/20240311100407.1271331-1-ppandit@redhat.com/

Ping...! (just checking)
---
  -Prasad

Re: [PATCH] media: cxd2880: Add terminating new line to Kconfig

[Dan Carpenter]

On Mon, Mar 11, 2024 at 03:34:07PM +0530, Prasad Pandit wrote:
> From: Prasad Pandit <pjp@fedoraproject.org>
> 
> Add terminating new line to the Kconfig file.
> 
> Fixes: 9dbaad428d69 ("media: cxd2880: Add all Makefile, Kconfig files and
> Update MAINTAINERS file for the driver")
> 
> Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>


This isn't a bug, so don't add a Fixes.  Also the format is wrong.  It
should be on one line, with no blank line afterward.

regards,
dan carpenter

Re: [PATCH] media: cxd2880: Add terminating new line to Kconfig

[Prasad Pandit]

Hello Dan,

* Thank you for the review comments, I appreciate it.

>On Monday, 8 April, 2024 at 12:25:10 pm IST, Dan Carpenter wrote:
>It should be on one line, with no blank line afterward.

-> https://lore.kernel.org/linux-media/20240311100407.1271331-1-ppandit@redhat.com/

* Blank line? There is no blank line afterward.

>
>This isn't a bug, so don't add a Fixes.

-> https://lore.kernel.org/netdev/CAE8KmOx9-BgbOxV6-wDRz2XUasEzp2krqMPbVYYZbav+8dCtBw@mail.gmail.com/T/#t

* Some say add it, some say don't add it. IMO there's no harm in having fixes tag. Will send a revised patch without fixes if you insist.

* Do we need one without fixes tag?

Thank you.
---
  -Prasad