[patch] uninitialized values in setfiles/psid.c

[patch] uninitialized values in setfiles/psid.c

[Colin Walters]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

While updating to the newer policycoreutils release, I noticed the
following gcc warnings:

psid.c: In function `chpsid':
psid.c:609: warning: `off' might be used uninitialized in this function
psid.c:610: warning: `len' might be used uninitialized in this function

I believe the patch below should fix the problem.

[-- Attachment #2: setfiles-uninit-value.patch --]
[-- Type: text/plain, Size: 490 bytes --]

--- setfiles/psid.c~	2003-06-02 16:23:07.000000000 -0400
+++ setfiles/psid.c	2003-07-13 02:10:38.000000000 -0400
@@ -658,10 +658,12 @@
 		 */
 		DPRINTF("chpsid:  adding new entry to contexts\n");
 
-		rc = lseek(t->contexts_fp, 0, SEEK_END);
-		if (rc < 0) {
+		len = strlen(context)+1;
+
+		off = lseek(t->contexts_fp, 0, SEEK_END);
+		if (off < 0) {
 			perror("lseek");
-			return rc;
+			return off;
 		}
 		rc = write(t->contexts_fp, context, len);
 		if (rc < 0) {

Re: [patch] uninitialized values in setfiles/psid.c

[Stephen Smalley]

On Sun, 2003-07-13 at 02:20, Colin Walters wrote:
> While updating to the newer policycoreutils release, I noticed the
> following gcc warnings:
> 
> psid.c: In function `chpsid':
> psid.c:609: warning: `off' might be used uninitialized in this function
> psid.c:610: warning: `len' might be used uninitialized in this function
> 
> I believe the patch below should fix the problem.

The psid code in setfiles is actually obsolete now, and can be dropped.

-- 
Stephen Smalley <sds@epoch.ncsc.mil>
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [patch] uninitialized values in setfiles/psid.c

[Stephen Smalley]

On Sun, 2003-07-13 at 02:20, Colin Walters wrote:
> While updating to the newer policycoreutils release, I noticed the
> following gcc warnings:
> 
> psid.c: In function `chpsid':
> psid.c:609: warning: `off' might be used uninitialized in this function
> psid.c:610: warning: `len' might be used uninitialized in this function
> 
> I believe the patch below should fix the problem.

A patch removing the obsolete psid code from setfiles has been committed
to the sourceforge CVS tree.

-- 
Stephen Smalley <sds@epoch.ncsc.mil>
National Security Agency


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.