[PATCH v5] PCI: hv: Make sure the bus domain is really unique

[PATCH v5] PCI: hv: Make sure the bus domain is really unique

[Sridhar Pitchai]

When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual
PCI bus to the guest, Hyper-V always provides unique PCI domain.

commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
overrode unique domain with the serial number of the first device added
to the virtual PCI bus. The reason for that patch is to have a consistent
and short name for the device. But commit 4a9b0933bdfc ("PCI: hv: Use
device serial number as PCI domain") will not guarantee unique domain id.
For example, if the serial number of the device is 0 and there exists a
PCI bus with domain 0 already, this will cause the PCI bus registration
with kernel fails.

commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
domain") need to be reverted. Also, we no longer need it as commit
4a1626dd233e ("netvsc: transparent VF management") remove the
need for it.

Revert commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
domain") so we can reliably support multiple devices being assigned to
a guest.

This revert should only be backported to kernels that contain commit
4a1626dd233e ("netvsc: transparent VF management").

Fixes: 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
Signed-off-by: Sridhar Pitchai <sridhar.pitchai@microsoft.com>
Cc: stable@vger.kernel.org

---
Changes in v5:
* fix the commit comment. [Lorenzo Pieralisi, Bjorn Helgaas]
* fixed the patch white space.
---
 drivers/pci/host/pci-hyperv.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
index 2faf38eab785..ac67e56e451a 100644
--- a/drivers/pci/host/pci-hyperv.c
+++ b/drivers/pci/host/pci-hyperv.c
@@ -1518,17 +1518,6 @@ static struct hv_pci_dev *new_pcichild_device(struct hv_pcibus_device *hbus,
 	get_pcichild(hpdev, hv_pcidev_ref_childlist);
 	spin_lock_irqsave(&hbus->device_list_lock, flags);
 
-	/*
-	 * When a device is being added to the bus, we set the PCI domain
-	 * number to be the device serial number, which is non-zero and
-	 * unique on the same VM.  The serial numbers start with 1, and
-	 * increase by 1 for each device.  So device names including this
-	 * can have shorter names than based on the bus instance UUID.
-	 * Only the first device serial number is used for domain, so the
-	 * domain number will not change after the first device is added.
-	 */
-	if (list_empty(&hbus->children))
-		hbus->sysdata.domain = desc->ser;
 	list_add_tail(&hpdev->list_entry, &hbus->children);
 	spin_unlock_irqrestore(&hbus->device_list_lock, flags);
 	return hpdev;
-- 
2.14.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v5] PCI: hv: Make sure the bus domain is really unique

[Sridhar Pitchai]

V2hlbiBMaW51eCBydW5zIGFzIGEgZ3Vlc3QgVk0gaW4gSHlwZXItViBhbmQgSHlwZXItViBhZGRz
IHRoZSB2aXJ0dWFsDQpQQ0kgYnVzIHRvIHRoZSBndWVzdCwgSHlwZXItViBhbHdheXMgcHJvdmlk
ZXMgdW5pcXVlIFBDSSBkb21haW4uDQoNCmNvbW1pdCA0YTliMDkzM2JkZmMgKCJQQ0k6IGh2OiBV
c2UgZGV2aWNlIHNlcmlhbCBudW1iZXIgYXMgUENJIGRvbWFpbiIpDQpvdmVycm9kZSB1bmlxdWUg
ZG9tYWluIHdpdGggdGhlIHNlcmlhbCBudW1iZXIgb2YgdGhlIGZpcnN0IGRldmljZSBhZGRlZA0K
dG8gdGhlIHZpcnR1YWwgUENJIGJ1cy4gVGhlIHJlYXNvbiBmb3IgdGhhdCBwYXRjaCBpcyB0byBo
YXZlIGEgY29uc2lzdGVudA0KYW5kIHNob3J0IG5hbWUgZm9yIHRoZSBkZXZpY2UuIEJ1dCBjb21t
aXQgNGE5YjA5MzNiZGZjICgiUENJOiBodjogVXNlDQpkZXZpY2Ugc2VyaWFsIG51bWJlciBhcyBQ
Q0kgZG9tYWluIikgd2lsbCBub3QgZ3VhcmFudGVlIHVuaXF1ZSBkb21haW4gaWQuDQpGb3IgZXhh
bXBsZSwgaWYgdGhlIHNlcmlhbCBudW1iZXIgb2YgdGhlIGRldmljZSBpcyAwIGFuZCB0aGVyZSBl
eGlzdHMgYQ0KUENJIGJ1cyB3aXRoIGRvbWFpbiAwIGFscmVhZHksIHRoaXMgd2lsbCBjYXVzZSB0
aGUgUENJIGJ1cyByZWdpc3RyYXRpb24NCndpdGgga2VybmVsIGZhaWxzLg0KDQpjb21taXQgNGE5
YjA5MzNiZGZjICgiUENJOiBodjogVXNlIGRldmljZSBzZXJpYWwgbnVtYmVyIGFzIFBDSQ0KZG9t
YWluIikgbmVlZCB0byBiZSByZXZlcnRlZC4gQWxzbywgd2Ugbm8gbG9uZ2VyIG5lZWQgaXQgYXMg
Y29tbWl0DQo0YTE2MjZkZDIzM2UgKCJuZXR2c2M6IHRyYW5zcGFyZW50IFZGIG1hbmFnZW1lbnQi
KSByZW1vdmUgdGhlDQpuZWVkIGZvciBpdC4NCg0KUmV2ZXJ0IGNvbW1pdCA0YTliMDkzM2JkZmMg
KCJQQ0k6IGh2OiBVc2UgZGV2aWNlIHNlcmlhbCBudW1iZXIgYXMgUENJDQpkb21haW4iKSBzbyB3
ZSBjYW4gcmVsaWFibHkgc3VwcG9ydCBtdWx0aXBsZSBkZXZpY2VzIGJlaW5nIGFzc2lnbmVkIHRv
DQphIGd1ZXN0Lg0KDQpUaGlzIHJldmVydCBzaG91bGQgb25seSBiZSBiYWNrcG9ydGVkIHRvIGtl
cm5lbHMgdGhhdCBjb250YWluIGNvbW1pdA0KNGExNjI2ZGQyMzNlICgibmV0dnNjOiB0cmFuc3Bh
cmVudCBWRiBtYW5hZ2VtZW50IikuDQoNCkZpeGVzOiA0YTliMDkzM2JkZmMgKCJQQ0k6IGh2OiBV
c2UgZGV2aWNlIHNlcmlhbCBudW1iZXIgYXMgUENJIGRvbWFpbiIpDQpTaWduZWQtb2ZmLWJ5OiBT
cmlkaGFyIFBpdGNoYWkgPHNyaWRoYXIucGl0Y2hhaUBtaWNyb3NvZnQuY29tPg0KQ2M6IHN0YWJs
ZUB2Z2VyLmtlcm5lbC5vcmcNCg0KLS0tDQpDaGFuZ2VzIGluIHY1Og0KKiBmaXggdGhlIGNvbW1p
dCBjb21tZW50LiBbTG9yZW56byBQaWVyYWxpc2ksIEJqb3JuIEhlbGdhYXNdDQoqIGZpeGVkIHRo
ZSBwYXRjaCB3aGl0ZSBzcGFjZS4NCi0tLQ0KIGRyaXZlcnMvcGNpL2hvc3QvcGNpLWh5cGVydi5j
IHwgMTEgLS0tLS0tLS0tLS0NCiAxIGZpbGUgY2hhbmdlZCwgMTEgZGVsZXRpb25zKC0pDQoNCmRp
ZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9ob3N0L3BjaS1oeXBlcnYuYyBiL2RyaXZlcnMvcGNpL2hv
c3QvcGNpLWh5cGVydi5jDQppbmRleCAyZmFmMzhlYWI3ODUuLmFjNjdlNTZlNDUxYSAxMDA2NDQN
Ci0tLSBhL2RyaXZlcnMvcGNpL2hvc3QvcGNpLWh5cGVydi5jDQorKysgYi9kcml2ZXJzL3BjaS9o
b3N0L3BjaS1oeXBlcnYuYw0KQEAgLTE1MTgsMTcgKzE1MTgsNiBAQCBzdGF0aWMgc3RydWN0IGh2
X3BjaV9kZXYgKm5ld19wY2ljaGlsZF9kZXZpY2Uoc3RydWN0IGh2X3BjaWJ1c19kZXZpY2UgKmhi
dXMsDQogCWdldF9wY2ljaGlsZChocGRldiwgaHZfcGNpZGV2X3JlZl9jaGlsZGxpc3QpOw0KIAlz
cGluX2xvY2tfaXJxc2F2ZSgmaGJ1cy0+ZGV2aWNlX2xpc3RfbG9jaywgZmxhZ3MpOw0KIA0KLQkv
Kg0KLQkgKiBXaGVuIGEgZGV2aWNlIGlzIGJlaW5nIGFkZGVkIHRvIHRoZSBidXMsIHdlIHNldCB0
aGUgUENJIGRvbWFpbg0KLQkgKiBudW1iZXIgdG8gYmUgdGhlIGRldmljZSBzZXJpYWwgbnVtYmVy
LCB3aGljaCBpcyBub24temVybyBhbmQNCi0JICogdW5pcXVlIG9uIHRoZSBzYW1lIFZNLiAgVGhl
IHNlcmlhbCBudW1iZXJzIHN0YXJ0IHdpdGggMSwgYW5kDQotCSAqIGluY3JlYXNlIGJ5IDEgZm9y
IGVhY2ggZGV2aWNlLiAgU28gZGV2aWNlIG5hbWVzIGluY2x1ZGluZyB0aGlzDQotCSAqIGNhbiBo
YXZlIHNob3J0ZXIgbmFtZXMgdGhhbiBiYXNlZCBvbiB0aGUgYnVzIGluc3RhbmNlIFVVSUQuDQot
CSAqIE9ubHkgdGhlIGZpcnN0IGRldmljZSBzZXJpYWwgbnVtYmVyIGlzIHVzZWQgZm9yIGRvbWFp
biwgc28gdGhlDQotCSAqIGRvbWFpbiBudW1iZXIgd2lsbCBub3QgY2hhbmdlIGFmdGVyIHRoZSBm
aXJzdCBkZXZpY2UgaXMgYWRkZWQuDQotCSAqLw0KLQlpZiAobGlzdF9lbXB0eSgmaGJ1cy0+Y2hp
bGRyZW4pKQ0KLQkJaGJ1cy0+c3lzZGF0YS5kb21haW4gPSBkZXNjLT5zZXI7DQogCWxpc3RfYWRk
X3RhaWwoJmhwZGV2LT5saXN0X2VudHJ5LCAmaGJ1cy0+Y2hpbGRyZW4pOw0KIAlzcGluX3VubG9j
a19pcnFyZXN0b3JlKCZoYnVzLT5kZXZpY2VfbGlzdF9sb2NrLCBmbGFncyk7DQogCXJldHVybiBo
cGRldjsNCi0tIA0KMi4xNC4xDQoNCg==

Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

[Sridhar Pitchai]

  >When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual
  >PCI bus to the guest, Hyper-V always provides unique PCI domain.
  >
  >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
  >overrode unique domain with the serial number of the first device added
  >to the virtual PCI bus. The reason for that patch is to have a consistent
  >and short name for the device. But commit 4a9b0933bdfc ("PCI: hv: Use
  >device serial number as PCI domain") will not guarantee unique domain id.
  >For example, if the serial number of the device is 0 and there exists a
  >PCI bus with domain 0 already, this will cause the PCI bus registration
  >with kernel fails.
  >
  >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
  >domain") need to be reverted. Also, we no longer need it as commit
  >4a1626dd233e ("netvsc: transparent VF management") remove the
  >need for it.
  >
  >Revert commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
  >domain") so we can reliably support multiple devices being assigned to
  >a guest.
  >
  >This revert should only be backported to kernels that contain commit
  >4a1626dd233e ("netvsc: transparent VF management").
  >
  >Fixes: 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
  >Signed-off-by: Sridhar Pitchai <sridhar.pitchai@microsoft.com>
  >Cc: stable@vger.kernel.org
  >
  >---
  >Changes in v5:
  >* fix the commit comment. [Lorenzo Pieralisi, Bjorn Helgaas]
  >* fixed the patch white space.
  >---
  > drivers/pci/host/pci-hyperv.c | 11 -----------
  > 1 file changed, 11 deletions(-)
  >
  >diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
  >index 2faf38eab785..ac67e56e451a 100644
  >--- a/drivers/pci/host/pci-hyperv.c
  >+++ b/drivers/pci/host/pci-hyperv.c
  >@@ -1518,17 +1518,6 @@ static struct hv_pci_dev *new_pcichild_device(struct hv_pcibus_device *hbus,
  > 	get_pcichild(hpdev, hv_pcidev_ref_childlist);
  > 	spin_lock_irqsave(&hbus->device_list_lock, flags);
  > 
  >-	/*
  >-	 * When a device is being added to the bus, we set the PCI domain
  >-	 * number to be the device serial number, which is non-zero and
  >-	 * unique on the same VM.  The serial numbers start with 1, and
  >-	 * increase by 1 for each device.  So device names including this
  >-	 * can have shorter names than based on the bus instance UUID.
  >-	 * Only the first device serial number is used for domain, so the
  >-	 * domain number will not change after the first device is added.
  >-	 */
  >-	if (list_empty(&hbus->children))
  >-		hbus->sysdata.domain = desc->ser;
  > 	list_add_tail(&hpdev->list_entry, &hbus->children);
  > 	spin_unlock_irqrestore(&hbus->device_list_lock, flags);
  > 	return hpdev;
  >-- 
>2.14.1

Hi Lorenzo,
Did you get a chance to look at the patch v5. Please let me know if
anything I need to address further.

Thanks
Sridhar 

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

[Sridhar Pitchai]

ICA+V2hlbiBMaW51eCBydW5zIGFzIGEgZ3Vlc3QgVk0gaW4gSHlwZXItViBhbmQgSHlwZXItViBh
ZGRzIHRoZSB2aXJ0dWFsDQogID5QQ0kgYnVzIHRvIHRoZSBndWVzdCwgSHlwZXItViBhbHdheXMg
cHJvdmlkZXMgdW5pcXVlIFBDSSBkb21haW4uDQogID4NCiAgPmNvbW1pdCA0YTliMDkzM2JkZmMg
KCJQQ0k6IGh2OiBVc2UgZGV2aWNlIHNlcmlhbCBudW1iZXIgYXMgUENJIGRvbWFpbiIpDQogID5v
dmVycm9kZSB1bmlxdWUgZG9tYWluIHdpdGggdGhlIHNlcmlhbCBudW1iZXIgb2YgdGhlIGZpcnN0
IGRldmljZSBhZGRlZA0KICA+dG8gdGhlIHZpcnR1YWwgUENJIGJ1cy4gVGhlIHJlYXNvbiBmb3Ig
dGhhdCBwYXRjaCBpcyB0byBoYXZlIGEgY29uc2lzdGVudA0KICA+YW5kIHNob3J0IG5hbWUgZm9y
IHRoZSBkZXZpY2UuIEJ1dCBjb21taXQgNGE5YjA5MzNiZGZjICgiUENJOiBodjogVXNlDQogID5k
ZXZpY2Ugc2VyaWFsIG51bWJlciBhcyBQQ0kgZG9tYWluIikgd2lsbCBub3QgZ3VhcmFudGVlIHVu
aXF1ZSBkb21haW4gaWQuDQogID5Gb3IgZXhhbXBsZSwgaWYgdGhlIHNlcmlhbCBudW1iZXIgb2Yg
dGhlIGRldmljZSBpcyAwIGFuZCB0aGVyZSBleGlzdHMgYQ0KICA+UENJIGJ1cyB3aXRoIGRvbWFp
biAwIGFscmVhZHksIHRoaXMgd2lsbCBjYXVzZSB0aGUgUENJIGJ1cyByZWdpc3RyYXRpb24NCiAg
PndpdGgga2VybmVsIGZhaWxzLg0KICA+DQogID5jb21taXQgNGE5YjA5MzNiZGZjICgiUENJOiBo
djogVXNlIGRldmljZSBzZXJpYWwgbnVtYmVyIGFzIFBDSQ0KICA+ZG9tYWluIikgbmVlZCB0byBi
ZSByZXZlcnRlZC4gQWxzbywgd2Ugbm8gbG9uZ2VyIG5lZWQgaXQgYXMgY29tbWl0DQogID40YTE2
MjZkZDIzM2UgKCJuZXR2c2M6IHRyYW5zcGFyZW50IFZGIG1hbmFnZW1lbnQiKSByZW1vdmUgdGhl
DQogID5uZWVkIGZvciBpdC4NCiAgPg0KICA+UmV2ZXJ0IGNvbW1pdCA0YTliMDkzM2JkZmMgKCJQ
Q0k6IGh2OiBVc2UgZGV2aWNlIHNlcmlhbCBudW1iZXIgYXMgUENJDQogID5kb21haW4iKSBzbyB3
ZSBjYW4gcmVsaWFibHkgc3VwcG9ydCBtdWx0aXBsZSBkZXZpY2VzIGJlaW5nIGFzc2lnbmVkIHRv
DQogID5hIGd1ZXN0Lg0KICA+DQogID5UaGlzIHJldmVydCBzaG91bGQgb25seSBiZSBiYWNrcG9y
dGVkIHRvIGtlcm5lbHMgdGhhdCBjb250YWluIGNvbW1pdA0KICA+NGExNjI2ZGQyMzNlICgibmV0
dnNjOiB0cmFuc3BhcmVudCBWRiBtYW5hZ2VtZW50IikuDQogID4NCiAgPkZpeGVzOiA0YTliMDkz
M2JkZmMgKCJQQ0k6IGh2OiBVc2UgZGV2aWNlIHNlcmlhbCBudW1iZXIgYXMgUENJIGRvbWFpbiIp
DQogID5TaWduZWQtb2ZmLWJ5OiBTcmlkaGFyIFBpdGNoYWkgPHNyaWRoYXIucGl0Y2hhaUBtaWNy
b3NvZnQuY29tPg0KICA+Q2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcNCiAgPg0KICA+LS0tDQog
ID5DaGFuZ2VzIGluIHY1Og0KICA+KiBmaXggdGhlIGNvbW1pdCBjb21tZW50LiBbTG9yZW56byBQ
aWVyYWxpc2ksIEJqb3JuIEhlbGdhYXNdDQogID4qIGZpeGVkIHRoZSBwYXRjaCB3aGl0ZSBzcGFj
ZS4NCiAgPi0tLQ0KICA+IGRyaXZlcnMvcGNpL2hvc3QvcGNpLWh5cGVydi5jIHwgMTEgLS0tLS0t
LS0tLS0NCiAgPiAxIGZpbGUgY2hhbmdlZCwgMTEgZGVsZXRpb25zKC0pDQogID4NCiAgPmRpZmYg
LS1naXQgYS9kcml2ZXJzL3BjaS9ob3N0L3BjaS1oeXBlcnYuYyBiL2RyaXZlcnMvcGNpL2hvc3Qv
cGNpLWh5cGVydi5jDQogID5pbmRleCAyZmFmMzhlYWI3ODUuLmFjNjdlNTZlNDUxYSAxMDA2NDQN
CiAgPi0tLSBhL2RyaXZlcnMvcGNpL2hvc3QvcGNpLWh5cGVydi5jDQogID4rKysgYi9kcml2ZXJz
L3BjaS9ob3N0L3BjaS1oeXBlcnYuYw0KICA+QEAgLTE1MTgsMTcgKzE1MTgsNiBAQCBzdGF0aWMg
c3RydWN0IGh2X3BjaV9kZXYgKm5ld19wY2ljaGlsZF9kZXZpY2Uoc3RydWN0IGh2X3BjaWJ1c19k
ZXZpY2UgKmhidXMsDQogID4gCWdldF9wY2ljaGlsZChocGRldiwgaHZfcGNpZGV2X3JlZl9jaGls
ZGxpc3QpOw0KICA+IAlzcGluX2xvY2tfaXJxc2F2ZSgmaGJ1cy0+ZGV2aWNlX2xpc3RfbG9jaywg
ZmxhZ3MpOw0KICA+IA0KICA+LQkvKg0KICA+LQkgKiBXaGVuIGEgZGV2aWNlIGlzIGJlaW5nIGFk
ZGVkIHRvIHRoZSBidXMsIHdlIHNldCB0aGUgUENJIGRvbWFpbg0KICA+LQkgKiBudW1iZXIgdG8g
YmUgdGhlIGRldmljZSBzZXJpYWwgbnVtYmVyLCB3aGljaCBpcyBub24temVybyBhbmQNCiAgPi0J
ICogdW5pcXVlIG9uIHRoZSBzYW1lIFZNLiAgVGhlIHNlcmlhbCBudW1iZXJzIHN0YXJ0IHdpdGgg
MSwgYW5kDQogID4tCSAqIGluY3JlYXNlIGJ5IDEgZm9yIGVhY2ggZGV2aWNlLiAgU28gZGV2aWNl
IG5hbWVzIGluY2x1ZGluZyB0aGlzDQogID4tCSAqIGNhbiBoYXZlIHNob3J0ZXIgbmFtZXMgdGhh
biBiYXNlZCBvbiB0aGUgYnVzIGluc3RhbmNlIFVVSUQuDQogID4tCSAqIE9ubHkgdGhlIGZpcnN0
IGRldmljZSBzZXJpYWwgbnVtYmVyIGlzIHVzZWQgZm9yIGRvbWFpbiwgc28gdGhlDQogID4tCSAq
IGRvbWFpbiBudW1iZXIgd2lsbCBub3QgY2hhbmdlIGFmdGVyIHRoZSBmaXJzdCBkZXZpY2UgaXMg
YWRkZWQuDQogID4tCSAqLw0KICA+LQlpZiAobGlzdF9lbXB0eSgmaGJ1cy0+Y2hpbGRyZW4pKQ0K
ICA+LQkJaGJ1cy0+c3lzZGF0YS5kb21haW4gPSBkZXNjLT5zZXI7DQogID4gCWxpc3RfYWRkX3Rh
aWwoJmhwZGV2LT5saXN0X2VudHJ5LCAmaGJ1cy0+Y2hpbGRyZW4pOw0KICA+IAlzcGluX3VubG9j
a19pcnFyZXN0b3JlKCZoYnVzLT5kZXZpY2VfbGlzdF9sb2NrLCBmbGFncyk7DQogID4gCXJldHVy
biBocGRldjsNCiAgPi0tIA0KPjIuMTQuMQ0KDQpIaSBMb3JlbnpvLA0KRGlkIHlvdSBnZXQgYSBj
aGFuY2UgdG8gbG9vayBhdCB0aGUgcGF0Y2ggdjUuIFBsZWFzZSBsZXQgbWUga25vdyBpZg0KYW55
dGhpbmcgSSBuZWVkIHRvIGFkZHJlc3MgZnVydGhlci4NCg0KVGhhbmtzDQpTcmlkaGFyIA0KDQo=

Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

[Bjorn Helgaas]

On Fri, Mar 30, 2018 at 07:35:04PM +0000, Sridhar Pitchai wrote:
>   >When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual
>   >PCI bus to the guest, Hyper-V always provides unique PCI domain.
>   >
>   >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
>   >overrode unique domain with the serial number of the first device added
>   >to the virtual PCI bus. The reason for that patch is to have a consistent
>   >and short name for the device. But commit 4a9b0933bdfc ("PCI: hv: Use
>   >device serial number as PCI domain") will not guarantee unique domain id.
>   >For example, if the serial number of the device is 0 and there exists a
>   >PCI bus with domain 0 already, this will cause the PCI bus registration
>   >with kernel fails.
>   >
>   >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
>   >domain") need to be reverted. Also, we no longer need it as commit
>   >4a1626dd233e ("netvsc: transparent VF management") remove the
>   >need for it.

Do you mean 0c195567a8f6 ("netvsc: transparent VF management")?

I don't see a 4a1626dd233e commit in Linus' tree.

The connection between 0c195567a8f6 ("netvsc: transparent VF
management") and this Hyper-V domain ID issue is not clear to me at
all.  But obviously I'm not a networking or a Hyper-V person.

A hint in the changelog about what that connection is would be nice.

>   >Revert commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
>   >domain") so we can reliably support multiple devices being assigned to
>   >a guest.
>   >
>   >This revert should only be backported to kernels that contain commit
>   >4a1626dd233e ("netvsc: transparent VF management").
>   >
>   >Fixes: 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
>   >Signed-off-by: Sridhar Pitchai <sridhar.pitchai@microsoft.com>
>   >Cc: stable@vger.kernel.org

This backporting guidance is very confusing.

4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
appeared in v4.11.

0c195567a8f6 ("netvsc: transparent VF management") appeared in v4.14.

The changelog and the "Fixes" tag both suggest that 4a9b0933bdfc was
flat-out buggy and should be reverted unconditionally.  That would
mean this patch should be applied to v4.11 and later stable kernels.

But the changelog also says "only revert 4a9b0933bdfc if you have
0c195567a8f6".  That would mean this patch should only be applied to
v4.14 and later stable kernels.

Which is it?  You can answer in this thread if you want, but Lorenzo
will ultimately be looking for a v6 patch with a corrected changelog.

>   >---
>   >Changes in v5:
>   >* fix the commit comment. [Lorenzo Pieralisi, Bjorn Helgaas]
>   >* fixed the patch white space.
>   >---
>   > drivers/pci/host/pci-hyperv.c | 11 -----------
>   > 1 file changed, 11 deletions(-)
>   >
>   >diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
>   >index 2faf38eab785..ac67e56e451a 100644
>   >--- a/drivers/pci/host/pci-hyperv.c
>   >+++ b/drivers/pci/host/pci-hyperv.c
>   >@@ -1518,17 +1518,6 @@ static struct hv_pci_dev *new_pcichild_device(struct hv_pcibus_device *hbus,
>   > 	get_pcichild(hpdev, hv_pcidev_ref_childlist);
>   > 	spin_lock_irqsave(&hbus->device_list_lock, flags);
>   > 
>   >-	/*
>   >-	 * When a device is being added to the bus, we set the PCI domain
>   >-	 * number to be the device serial number, which is non-zero and
>   >-	 * unique on the same VM.  The serial numbers start with 1, and
>   >-	 * increase by 1 for each device.  So device names including this
>   >-	 * can have shorter names than based on the bus instance UUID.
>   >-	 * Only the first device serial number is used for domain, so the
>   >-	 * domain number will not change after the first device is added.
>   >-	 */
>   >-	if (list_empty(&hbus->children))
>   >-		hbus->sysdata.domain = desc->ser;
>   > 	list_add_tail(&hpdev->list_entry, &hbus->children);
>   > 	spin_unlock_irqrestore(&hbus->device_list_lock, flags);
>   > 	return hpdev;
>   >-- 
> >2.14.1
> 
> Hi Lorenzo,
> Did you get a chance to look at the patch v5. Please let me know if
> anything I need to address further.

I think Lorenzo is out this week, but I suspect he'll look at it next
week.

Bjorn
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

[Bjorn Helgaas]

On Fri, Mar 30, 2018 at 07:35:04PM +0000, Sridhar Pitchai wrote:
>   >When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual
>   >PCI bus to the guest, Hyper-V always provides unique PCI domain.
>   >
>   >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
>   >overrode unique domain with the serial number of the first device added
>   >to the virtual PCI bus. The reason for that patch is to have a consistent
>   >and short name for the device. But commit 4a9b0933bdfc ("PCI: hv: Use
>   >device serial number as PCI domain") will not guarantee unique domain id.
>   >For example, if the serial number of the device is 0 and there exists a
>   >PCI bus with domain 0 already, this will cause the PCI bus registration
>   >with kernel fails.
>   >
>   >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
>   >domain") need to be reverted. Also, we no longer need it as commit
>   >4a1626dd233e ("netvsc: transparent VF management") remove the
>   >need for it.

Do you mean 0c195567a8f6 ("netvsc: transparent VF management")?

I don't see a 4a1626dd233e commit in Linus' tree.

The connection between 0c195567a8f6 ("netvsc: transparent VF
management") and this Hyper-V domain ID issue is not clear to me at
all.  But obviously I'm not a networking or a Hyper-V person.

A hint in the changelog about what that connection is would be nice.

>   >Revert commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
>   >domain") so we can reliably support multiple devices being assigned to
>   >a guest.
>   >
>   >This revert should only be backported to kernels that contain commit
>   >4a1626dd233e ("netvsc: transparent VF management").
>   >
>   >Fixes: 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
>   >Signed-off-by: Sridhar Pitchai <sridhar.pitchai@microsoft.com>
>   >Cc: stable@vger.kernel.org

This backporting guidance is very confusing.

4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
appeared in v4.11.

0c195567a8f6 ("netvsc: transparent VF management") appeared in v4.14.

The changelog and the "Fixes" tag both suggest that 4a9b0933bdfc was
flat-out buggy and should be reverted unconditionally.  That would
mean this patch should be applied to v4.11 and later stable kernels.

But the changelog also says "only revert 4a9b0933bdfc if you have
0c195567a8f6".  That would mean this patch should only be applied to
v4.14 and later stable kernels.

Which is it?  You can answer in this thread if you want, but Lorenzo
will ultimately be looking for a v6 patch with a corrected changelog.

>   >---
>   >Changes in v5:
>   >* fix the commit comment. [Lorenzo Pieralisi, Bjorn Helgaas]
>   >* fixed the patch white space.
>   >---
>   > drivers/pci/host/pci-hyperv.c | 11 -----------
>   > 1 file changed, 11 deletions(-)
>   >
>   >diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
>   >index 2faf38eab785..ac67e56e451a 100644
>   >--- a/drivers/pci/host/pci-hyperv.c
>   >+++ b/drivers/pci/host/pci-hyperv.c
>   >@@ -1518,17 +1518,6 @@ static struct hv_pci_dev *new_pcichild_device(struct hv_pcibus_device *hbus,
>   > 	get_pcichild(hpdev, hv_pcidev_ref_childlist);
>   > 	spin_lock_irqsave(&hbus->device_list_lock, flags);
>   > 
>   >-	/*
>   >-	 * When a device is being added to the bus, we set the PCI domain
>   >-	 * number to be the device serial number, which is non-zero and
>   >-	 * unique on the same VM.  The serial numbers start with 1, and
>   >-	 * increase by 1 for each device.  So device names including this
>   >-	 * can have shorter names than based on the bus instance UUID.
>   >-	 * Only the first device serial number is used for domain, so the
>   >-	 * domain number will not change after the first device is added.
>   >-	 */
>   >-	if (list_empty(&hbus->children))
>   >-		hbus->sysdata.domain = desc->ser;
>   > 	list_add_tail(&hpdev->list_entry, &hbus->children);
>   > 	spin_unlock_irqrestore(&hbus->device_list_lock, flags);
>   > 	return hpdev;
>   >-- 
> >2.14.1
> 
> Hi Lorenzo,
> Did you get a chance to look at the patch v5. Please let me know if
> anything I need to address further.

I think Lorenzo is out this week, but I suspect he'll look at it next
week.

Bjorn

Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

[Sridhar Pitchai]

	>On 3/30/18, 2:23 PM, "Bjorn Helgaas" <helgaas@kernel.org> wrote:
	>   >On Fri, Mar 30, 2018 at 07:35:04PM +0000, Sridhar Pitchai wrote:
	>   >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
	>   >domain") need to be reverted. Also, we no longer need it as commit
	>   >4a1626dd233e ("netvsc: transparent VF management") remove the
	>   >need for it.
	>
	>Do you mean 0c195567a8f6 ("netvsc: transparent VF management")?
	>
	>I don't see a 4a1626dd233e commit in Linus' tree.
	>

That is right. sha should be 4a1626dd233e.

	>The connection between 0c195567a8f6 ("netvsc: transparent VF
	>management") and this Hyper-V domain ID issue is not clear to me at
	>all.  But obviously I'm not a networking or a Hyper-V person.
	>
	>A hint in the changelog about what that connection is would be nice.
	>
	>   >Revert commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
	>   >domain") so we can reliably support multiple devices being assigned to
	>   >a guest.
	>   >
	>   >This revert should only be backported to kernels that contain commit
	>   >4a1626dd233e ("netvsc: transparent VF management").
	>   >
	>   >Fixes: 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
	>   >Signed-off-by: Sridhar Pitchai <sridhar.pitchai@microsoft.com>
	>   >Cc: stable@vger.kernel.org
	>
	>This backporting guidance is very confusing.
	>
	>4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
	>appeared in v4.11.
	>
	>0c195567a8f6 ("netvsc: transparent VF management") appeared in v4.14.
	>
	>The changelog and the "Fixes" tag both suggest that 4a9b0933bdfc was
	>flat-out buggy and should be reverted unconditionally.  That would
	>mean this patch should be applied to v4.11 and later stable kernels.
	>
	>But the changelog also says "only revert 4a9b0933bdfc if you have
	>0c195567a8f6".  That would mean this patch should only be applied to
	>v4.14 and later stable kernels.
	>
	>Which is it?  You can answer in this thread if you want, but Lorenzo
	>will ultimately be looking for a v6 patch with a corrected changelog.

It is the Case 1. We just need to revert 4a9b0933bdfc. I will remove the
reference to 0c195567a8f6 altogether in the commit message.

	>
	>I think Lorenzo is out this week, but I suspect he'll look at it next
	>week.
	>
	>Bjorn

I will send out the update patch version 6.

Thanks,
Sridhar Pitchai 

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

[Sridhar Pitchai]

CT5PbiAzLzMwLzE4LCAyOjIzIFBNLCAiQmpvcm4gSGVsZ2FhcyIgPGhlbGdhYXNAa2VybmVsLm9y
Zz4gd3JvdGU6DQoJPiAgID5PbiBGcmksIE1hciAzMCwgMjAxOCBhdCAwNzozNTowNFBNICswMDAw
LCBTcmlkaGFyIFBpdGNoYWkgd3JvdGU6DQoJPiAgID5jb21taXQgNGE5YjA5MzNiZGZjICgiUENJ
OiBodjogVXNlIGRldmljZSBzZXJpYWwgbnVtYmVyIGFzIFBDSQ0KCT4gICA+ZG9tYWluIikgbmVl
ZCB0byBiZSByZXZlcnRlZC4gQWxzbywgd2Ugbm8gbG9uZ2VyIG5lZWQgaXQgYXMgY29tbWl0DQoJ
PiAgID40YTE2MjZkZDIzM2UgKCJuZXR2c2M6IHRyYW5zcGFyZW50IFZGIG1hbmFnZW1lbnQiKSBy
ZW1vdmUgdGhlDQoJPiAgID5uZWVkIGZvciBpdC4NCgk+DQoJPkRvIHlvdSBtZWFuIDBjMTk1NTY3
YThmNiAoIm5ldHZzYzogdHJhbnNwYXJlbnQgVkYgbWFuYWdlbWVudCIpPw0KCT4NCgk+SSBkb24n
dCBzZWUgYSA0YTE2MjZkZDIzM2UgY29tbWl0IGluIExpbnVzJyB0cmVlLg0KCT4NCg0KVGhhdCBp
cyByaWdodC4gc2hhIHNob3VsZCBiZSA0YTE2MjZkZDIzM2UuDQoNCgk+VGhlIGNvbm5lY3Rpb24g
YmV0d2VlbiAwYzE5NTU2N2E4ZjYgKCJuZXR2c2M6IHRyYW5zcGFyZW50IFZGDQoJPm1hbmFnZW1l
bnQiKSBhbmQgdGhpcyBIeXBlci1WIGRvbWFpbiBJRCBpc3N1ZSBpcyBub3QgY2xlYXIgdG8gbWUg
YXQNCgk+YWxsLiAgQnV0IG9idmlvdXNseSBJJ20gbm90IGEgbmV0d29ya2luZyBvciBhIEh5cGVy
LVYgcGVyc29uLg0KCT4NCgk+QSBoaW50IGluIHRoZSBjaGFuZ2Vsb2cgYWJvdXQgd2hhdCB0aGF0
IGNvbm5lY3Rpb24gaXMgd291bGQgYmUgbmljZS4NCgk+DQoJPiAgID5SZXZlcnQgY29tbWl0IDRh
OWIwOTMzYmRmYyAoIlBDSTogaHY6IFVzZSBkZXZpY2Ugc2VyaWFsIG51bWJlciBhcyBQQ0kNCgk+
ICAgPmRvbWFpbiIpIHNvIHdlIGNhbiByZWxpYWJseSBzdXBwb3J0IG11bHRpcGxlIGRldmljZXMg
YmVpbmcgYXNzaWduZWQgdG8NCgk+ICAgPmEgZ3Vlc3QuDQoJPiAgID4NCgk+ICAgPlRoaXMgcmV2
ZXJ0IHNob3VsZCBvbmx5IGJlIGJhY2twb3J0ZWQgdG8ga2VybmVscyB0aGF0IGNvbnRhaW4gY29t
bWl0DQoJPiAgID40YTE2MjZkZDIzM2UgKCJuZXR2c2M6IHRyYW5zcGFyZW50IFZGIG1hbmFnZW1l
bnQiKS4NCgk+ICAgPg0KCT4gICA+Rml4ZXM6IDRhOWIwOTMzYmRmYyAoIlBDSTogaHY6IFVzZSBk
ZXZpY2Ugc2VyaWFsIG51bWJlciBhcyBQQ0kgZG9tYWluIikNCgk+ICAgPlNpZ25lZC1vZmYtYnk6
IFNyaWRoYXIgUGl0Y2hhaSA8c3JpZGhhci5waXRjaGFpQG1pY3Jvc29mdC5jb20+DQoJPiAgID5D
Yzogc3RhYmxlQHZnZXIua2VybmVsLm9yZw0KCT4NCgk+VGhpcyBiYWNrcG9ydGluZyBndWlkYW5j
ZSBpcyB2ZXJ5IGNvbmZ1c2luZy4NCgk+DQoJPjRhOWIwOTMzYmRmYyAoIlBDSTogaHY6IFVzZSBk
ZXZpY2Ugc2VyaWFsIG51bWJlciBhcyBQQ0kgZG9tYWluIikNCgk+YXBwZWFyZWQgaW4gdjQuMTEu
DQoJPg0KCT4wYzE5NTU2N2E4ZjYgKCJuZXR2c2M6IHRyYW5zcGFyZW50IFZGIG1hbmFnZW1lbnQi
KSBhcHBlYXJlZCBpbiB2NC4xNC4NCgk+DQoJPlRoZSBjaGFuZ2Vsb2cgYW5kIHRoZSAiRml4ZXMi
IHRhZyBib3RoIHN1Z2dlc3QgdGhhdCA0YTliMDkzM2JkZmMgd2FzDQoJPmZsYXQtb3V0IGJ1Z2d5
IGFuZCBzaG91bGQgYmUgcmV2ZXJ0ZWQgdW5jb25kaXRpb25hbGx5LiAgVGhhdCB3b3VsZA0KCT5t
ZWFuIHRoaXMgcGF0Y2ggc2hvdWxkIGJlIGFwcGxpZWQgdG8gdjQuMTEgYW5kIGxhdGVyIHN0YWJs
ZSBrZXJuZWxzLg0KCT4NCgk+QnV0IHRoZSBjaGFuZ2Vsb2cgYWxzbyBzYXlzICJvbmx5IHJldmVy
dCA0YTliMDkzM2JkZmMgaWYgeW91IGhhdmUNCgk+MGMxOTU1NjdhOGY2Ii4gIFRoYXQgd291bGQg
bWVhbiB0aGlzIHBhdGNoIHNob3VsZCBvbmx5IGJlIGFwcGxpZWQgdG8NCgk+djQuMTQgYW5kIGxh
dGVyIHN0YWJsZSBrZXJuZWxzLg0KCT4NCgk+V2hpY2ggaXMgaXQ/ICBZb3UgY2FuIGFuc3dlciBp
biB0aGlzIHRocmVhZCBpZiB5b3Ugd2FudCwgYnV0IExvcmVuem8NCgk+d2lsbCB1bHRpbWF0ZWx5
IGJlIGxvb2tpbmcgZm9yIGEgdjYgcGF0Y2ggd2l0aCBhIGNvcnJlY3RlZCBjaGFuZ2Vsb2cuDQoN
Ckl0IGlzIHRoZSBDYXNlIDEuIFdlIGp1c3QgbmVlZCB0byByZXZlcnQgNGE5YjA5MzNiZGZjLiBJ
IHdpbGwgcmVtb3ZlIHRoZQ0KcmVmZXJlbmNlIHRvIDBjMTk1NTY3YThmNiBhbHRvZ2V0aGVyIGlu
IHRoZSBjb21taXQgbWVzc2FnZS4NCg0KCT4NCgk+SSB0aGluayBMb3JlbnpvIGlzIG91dCB0aGlz
IHdlZWssIGJ1dCBJIHN1c3BlY3QgaGUnbGwgbG9vayBhdCBpdCBuZXh0DQoJPndlZWsuDQoJPg0K
CT5Cam9ybg0KDQpJIHdpbGwgc2VuZCBvdXQgdGhlIHVwZGF0ZSBwYXRjaCB2ZXJzaW9uIDYuDQoN
ClRoYW5rcywNClNyaWRoYXIgUGl0Y2hhaSANCg0K