* [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency
@ 2016-09-15 15:44 Arnd Bergmann
2016-09-16 12:26 ` Chanwoo Choi
[not found] ` <CGME20160916122625epcas1p445869955222826c9500302bed51644f9@epcas1p4.samsung.com>
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-09-15 15:44 UTC (permalink / raw)
To: MyungJoo Ham, Kyungmin Park
Cc: Lin Huang, Arnd Bergmann, Chanwoo Choi, Krzysztof Kozlowski,
Rafael J. Wysocki, linux-pm, linux-kernel
The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
a 'select' statement, and that in turn has a dependency on
PM_DEVFREQ_EVENT, which may be disabled here:
warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)
We probably want a 'depends on' here, but other drivers use 'select'
too, so for consistency I'm doing the same.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")
---
drivers/devfreq/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index 93b6ada06676..41254e702f1e 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -105,6 +105,7 @@ config ARM_RK3399_DMC_DEVFREQ
depends on ARCH_ROCKCHIP
select DEVFREQ_EVENT_ROCKCHIP_DFI
select DEVFREQ_GOV_SIMPLE_ONDEMAND
+ select PM_DEVFREQ_EVENT
select PM_OPP
help
This adds the DEVFREQ driver for the RK3399 DMC(Dynamic Memory Controller).
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency
2016-09-15 15:44 [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency Arnd Bergmann
@ 2016-09-16 12:26 ` Chanwoo Choi
[not found] ` <CGME20160916122625epcas1p445869955222826c9500302bed51644f9@epcas1p4.samsung.com>
1 sibling, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2016-09-16 12:26 UTC (permalink / raw)
To: Arnd Bergmann
Cc: MyungJoo Ham, Kyungmin Park, Lin Huang, Chanwoo Choi,
Krzysztof Kozlowski, Rafael J. Wysocki, linux-pm, linux-kernel
Hi Arnd,
Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Best Regards,
Chanwoo Choi
2016-09-16 0:44 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
> DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
> a 'select' statement, and that in turn has a dependency on
> PM_DEVFREQ_EVENT, which may be disabled here:
>
> warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)
>
> We probably want a 'depends on' here, but other drivers use 'select'
> too, so for consistency I'm doing the same.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")
> ---
> drivers/devfreq/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 93b6ada06676..41254e702f1e 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -105,6 +105,7 @@ config ARM_RK3399_DMC_DEVFREQ
> depends on ARCH_ROCKCHIP
> select DEVFREQ_EVENT_ROCKCHIP_DFI
> select DEVFREQ_GOV_SIMPLE_ONDEMAND
> + select PM_DEVFREQ_EVENT
> select PM_OPP
> help
> This adds the DEVFREQ driver for the RK3399 DMC(Dynamic Memory Controller).
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: Re: [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency
[not found] ` <CGME20160916122625epcas1p445869955222826c9500302bed51644f9@epcas1p4.samsung.com>
@ 2016-09-19 7:46 ` MyungJoo Ham
2016-09-19 11:09 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: MyungJoo Ham @ 2016-09-19 7:46 UTC (permalink / raw)
To: Chanwoo Choi, Arnd Bergmann
Cc: Kyungmin Park, Lin Huang, Chanwoo Choi, Krzysztof Kozlowski,
Rafael J. Wysocki, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]
2016-09-16 0:44 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
> DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
> a 'select' statement, and that in turn has a dependency on
> PM_DEVFREQ_EVENT, which may be disabled here:
>
> warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)
>
> We probably want a 'depends on' here, but other drivers use 'select'
> too, so for consistency I'm doing the same.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")
Thank you.
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Being tested at: https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/log/?h=for-4.9-rc
@ The branch above requires additional patches to be tested
(other rockchip support drivers to be merged for 4.9 and COMPILE_TEST retraction for TEGRA)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Re: [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency
2016-09-19 7:46 ` MyungJoo Ham
@ 2016-09-19 11:09 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2016-09-19 11:09 UTC (permalink / raw)
To: Myungjoo Ham
Cc: Chanwoo Choi, Arnd Bergmann, Kyungmin Park, Lin Huang,
Chanwoo Choi, Krzysztof Kozlowski, Rafael J. Wysocki, linux-pm,
linux-kernel
On Mon, Sep 19, 2016 at 9:46 AM, MyungJoo Ham <myungjoo.ham@samsung.com> wrote:
> 2016-09-16 0:44 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
>> The newly added ARM_RK3399_DMC_DEVFREQ driver requires the
>> DEVFREQ_EVENT_ROCKCHIP_DFI driver and tries to turn that on through
>> a 'select' statement, and that in turn has a dependency on
>> PM_DEVFREQ_EVENT, which may be disabled here:
>>
>> warning: (ARM_RK3399_DMC_DEVFREQ) selects DEVFREQ_EVENT_ROCKCHIP_DFI which has unmet direct dependencies (PM_DEVFREQ && PM_DEVFREQ_EVENT && ARCH_ROCKCHIP)
>>
>> We probably want a 'depends on' here, but other drivers use 'select'
>> too, so for consistency I'm doing the same.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 5a893e31a636 ("PM / devfreq: rockchip: add devfreq driver for rk3399 dmc")
>
>
> Thank you.
>
>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
I've applied this one directly.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-19 11:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-15 15:44 [PATCH] PM / devfreq: rockchip: add PM_DEVFREQ_EVENT dependency Arnd Bergmann
2016-09-16 12:26 ` Chanwoo Choi
[not found] ` <CGME20160916122625epcas1p445869955222826c9500302bed51644f9@epcas1p4.samsung.com>
2016-09-19 7:46 ` MyungJoo Ham
2016-09-19 11:09 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.