* [PATCH][2.4] fix "pci=noacpi" boot option
@ 2003-10-14 21:28 Thomas Schlichter
2003-10-21 3:32 ` Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Schlichter @ 2003-10-14 21:28 UTC (permalink / raw)
To: len.brown; +Cc: linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 539 bytes --]
Hi Len,
some time ago I sent a patch which fixed problems with the "pci=noacpi" boot
option of the 2.5.xx linux-kernel. It got applied to the 2.5 kernel tree but
I missed to create a similar fix for the 2.4 tree which seems to have the
same issue.
Now I've seen reports of people having problems with the "pci=noacpi" boot
option with current 2.4.xx kernel versions, too. So I ported my old patch to
2.4.22-bk34, tested it and attached it to this mail. You may consider pushing
it to Marcelo.
Kind regards,
Thomas
[-- Attachment #1.2: fix_pci_noacpi.diff --]
[-- Type: text/x-diff, Size: 1176 bytes --]
--- linux-2.4.22-bk34/arch/i386/kernel/acpi.c.orig Tue Oct 14 20:50:18 2003
+++ linux-2.4.22-bk34/arch/i386/kernel/acpi.c Tue Oct 14 20:53:45 2003
@@ -58,6 +58,7 @@
#ifdef CONFIG_ACPI_BOOT
extern int acpi_disabled;
+extern int acpi_irq;
extern int acpi_ht;
enum acpi_irq_model_id acpi_irq_model;
@@ -415,7 +416,7 @@
* If MPS is present, it will handle them,
* otherwise the system will stay in PIC mode
*/
- if (acpi_disabled) {
+ if (acpi_disabled || !acpi_irq) {
return 1;
}
--- linux-2.4.22-bk34/arch/i386/kernel/setup.c.orig Tue Oct 14 20:50:25 2003
+++ linux-2.4.22-bk34/arch/i386/kernel/setup.c Tue Oct 14 20:57:34 2003
@@ -184,6 +184,7 @@
EXPORT_SYMBOL(acpi_disabled);
#ifdef CONFIG_ACPI_BOOT
+ int acpi_irq __initdata = 1; /* enable IRQ */
int acpi_ht __initdata = 1; /* enable HT */
#endif
@@ -848,6 +849,11 @@
else if (!memcmp(from, "acpi=ht", 7)) {
acpi_ht = 1;
if (!acpi_force) acpi_disabled = 1;
+ }
+
+ /* "pci=noacpi" disables ACPI interrupt routing */
+ else if (!memcmp(from, "pci=noacpi", 10)) {
+ acpi_irq = 0;
}
/* disable IO-APIC */
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][2.4] fix "pci=noacpi" boot option
2003-10-14 21:28 [PATCH][2.4] fix "pci=noacpi" boot option Thomas Schlichter
@ 2003-10-21 3:32 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2003-10-21 3:32 UTC (permalink / raw)
To: Thomas Schlichter; +Cc: linux-kernel
On Tue, 2003-10-14 at 17:28, Thomas Schlichter wrote:
> Hi Len,
>
> some time ago I sent a patch which fixed problems with the "pci=noacpi" boot
> option of the 2.5.xx linux-kernel. It got applied to the 2.5 kernel tree but
> I missed to create a similar fix for the 2.4 tree which seems to have the
> same issue.
>
> Now I've seen reports of people having problems with the "pci=noacpi" boot
> option with current 2.4.xx kernel versions, too. So I ported my old patch to
> 2.4.22-bk34, tested it and attached it to this mail. You may consider pushing
> it to Marcelo.
>
> Kind regards,
> Thomas
Thanks for the reminder Thomas, you're correct that pci=noacpi is
broken, see http://bugzilla.kernel.org/show_bug.cgi?id=1219
Note that pci=noacpi is a bug workaround.
It is a bug when a platform requires it. The bug should be filed, root
caused, and fixed. If you know of such platforms, please be encouraged
to file bugs with the details so we can get to the bottom of it.
thanks,
-Len
ps. #include std-acpi-interrupt-bug-info-reqeust.h
Please file a bug at http://bugzilla.kernel.org/
Category: Power Management
Component: ACPI
Please attach the output from dmidecode, available in /usr/sbin/, or
here:
http://www.nongnu.org/dmidecode/
Please attach the output from acpidmp, available in /usr/sbin/, or in
here
http://www.intel.com/technology/iapc/acpi/downloads/pmtools-20010730.tar.gz
Please attach /proc/interrupts and the dmesg output showing the failure,
if possible.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-10-21 3:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-14 21:28 [PATCH][2.4] fix "pci=noacpi" boot option Thomas Schlichter
2003-10-21 3:32 ` Len Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.