* [LTP] [PATCH] cgroups/cpuacct_setup: fix task_kill() search for process
[not found] <508695279.28083.1303217546129.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
@ 2011-04-19 13:16 ` Jan Stancek
2011-04-20 6:14 ` Garrett Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Jan Stancek @ 2011-04-19 13:16 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
1. "i* in "grep cpuacct_taski*" seems pointless as
its target is cpuacct_task01
2. using cut fails when ps indents the output as following:
99 cpuacct_task01
112 cpuacct_task01
1111 cpuacct_task01
Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
.../kernel/controllers/cpuacct/cpuacct_setup.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-cgroups-cpuacct_setup-fix-task_kill.patch --]
[-- Type: text/x-patch; name=0001-cgroups-cpuacct_setup-fix-task_kill.patch, Size: 482 bytes --]
diff --git a/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh b/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh
index 47cd1da..2443a28 100755
--- a/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh
+++ b/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh
@@ -58,7 +58,7 @@ cleanup ()
}
task_kill ()
{
- for i in `ps -e | grep cpuacct_taski* | cut -d" " -f1`
+ for i in `ps -e | grep cpuacct_task | awk '{print $1}'`
do
kill -SIGUSR1 $i
done
[-- Attachment #3: Type: text/plain, Size: 438 bytes --]
------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] cgroups/cpuacct_setup: fix task_kill() search for process
2011-04-19 13:16 ` [LTP] [PATCH] cgroups/cpuacct_setup: fix task_kill() search for process Jan Stancek
@ 2011-04-20 6:14 ` Garrett Cooper
2011-04-20 13:59 ` Jan Stancek
0 siblings, 1 reply; 3+ messages in thread
From: Garrett Cooper @ 2011-04-20 6:14 UTC (permalink / raw)
To: Jan Stancek; +Cc: ltp-list
On Tue, Apr 19, 2011 at 6:16 AM, Jan Stancek <jstancek@redhat.com> wrote:
>
> 1. "i* in "grep cpuacct_taski*" seems pointless as
> its target is cpuacct_task01
>
> 2. using cut fails when ps indents the output as following:
> 99 cpuacct_task01
> 112 cpuacct_task01
> 1111 cpuacct_task01
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
Patch doesn't apply.
Thanks,
-Garrett
------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] cgroups/cpuacct_setup: fix task_kill() search for process
2011-04-20 6:14 ` Garrett Cooper
@ 2011-04-20 13:59 ` Jan Stancek
0 siblings, 0 replies; 3+ messages in thread
From: Jan Stancek @ 2011-04-20 13:59 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list
----- Original Message -----
> From: "Garrett Cooper" <yanegomi@gmail.com>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp-list@lists.sourceforge.net
> Sent: Wednesday, April 20, 2011 8:14:46 AM
> Subject: Re: [LTP] [PATCH] cgroups/cpuacct_setup: fix task_kill() search for process
> On Tue, Apr 19, 2011 at 6:16 AM, Jan Stancek <jstancek@redhat.com>
> wrote:
> >
> > 1. "i* in "grep cpuacct_taski*" seems pointless as
> > its target is cpuacct_task01
> >
> > 2. using cut fails when ps indents the output as following:
> > 99 cpuacct_task01
> > 112 cpuacct_task01
> > 1111 cpuacct_task01
> >
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
>
> Patch doesn't apply.
I guess I found another bad behaving client: Zimbra webmail
It converted all LF to CR/LF.
I'm going to try something else for v2 (fingers crossed).
> Thanks,
> -Garrett
------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-20 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <508695279.28083.1303217546129.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2011-04-19 13:16 ` [LTP] [PATCH] cgroups/cpuacct_setup: fix task_kill() search for process Jan Stancek
2011-04-20 6:14 ` Garrett Cooper
2011-04-20 13:59 ` Jan Stancek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.