All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurence Oberman <loberman@redhat.com>
To: Andy Grover <agrover@redhat.com>,
	linux-scsi@vger.kernel.org, nab@daterainc.com
Cc: Laurence Oberman <oberman.l@gmail.com>
Subject: [PATCH ] tcm_qla2xxx  Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module
Date: Sat, 7 Mar 2015 22:26:15 -0500 (EST)	[thread overview]
Message-ID: <1069288785.13490592.1425785175883.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <588344732.13485469.1425769450275.JavaMail.zimbra@redhat.com>

Hello

I use target LIO for all my storage array test targets and customer problem resolution here at Red Hat.
This patch resulted from a requirement to mimic behaviour of an expensive hardware jammer for a customer.
I have used this for some time with good success to simulate and reproduce latency and slow drain fabric issues and
for testing and validating error handling behaviour in the Emulex, Qlogic and other F/C drivers.

Works by checking jammer_flag==1 and host # and discards SCSI command, controlled using echo to sys parameter.

I decided to share the patch, in the hope it may be useful for others but I do understand this is a special use case.
If this is useful and Nab wants to include it I will create a proper documentation patch as well.

filename:       /lib/modules/3.17.7-200.jammer.fc20.x86_64/kernel/drivers/scsi/qla2xxx/tcm_qla2xxx.ko
license:        GPL
description:    TCM QLA2XXX series NPIV enabled fabric driver
depends:        target_core_mod,qla2xxx,scsi_transport_fc
intree:         Y
vermagic:       3.17.7-200.jammer.fc20.x86_64 SMP mod_unload 
parm:           jammer_flag:Set to 1: Enable jammer (int)
parm:           host_flag:host number to match on (int)


Enable host 6 to be jammed
echo 6 > /sys/module/tcm_qla2xxx/parameters/host_flag

Usage example script:

#!/bin/bash
host=`cat /sys/module/tcm_qla2xxx/parameters/host_flag`
sleep_time=120  ### Time to jam for
echo "We start to discard commands on SCSI host $host"
logger "Jammer started"
echo 1 >  /sys/module/tcm_qla2xxx/parameters/jammer_flag
sleep $sleep_time
echo 0 >  /sys/module/tcm_qla2xxx/parameters/jammer_flag
echo "We stopped the jammer"
logger "Jammer stopped"

This Patch diff against 3.19.1

Tested by: Laurence Oberman <loberman@redhat.com>
Signed-off-by: Laurence Oberman <loberman@redhat.com>

diff -Nurp a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
--- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c	2015-03-07 18:35:15.246737589 -0500
+++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c	2015-03-07 18:35:40.168599630 -0500
@@ -50,6 +50,14 @@
 #include "qla_target.h"
 #include "tcm_qla2xxx.h"
 
+int message_flag=0;
+int jammer_flag = 0;
+module_param(jammer_flag, int,0644);
+MODULE_PARM_DESC(jammer_flag, "If set to 1: Enable jammer");
+int host_flag=0;
+module_param(host_flag, int,0644);
+MODULE_PARM_DESC(host_flag, "host number to match on");
+
 static struct workqueue_struct *tcm_qla2xxx_free_wq;
 static struct workqueue_struct *tcm_qla2xxx_cmd_wq;
 
@@ -570,6 +578,22 @@ static int tcm_qla2xxx_handle_cmd(scsi_q
 		pr_err("Unable to locate active struct se_session\n");
 		return -EINVAL;
 	}
+	
+ 	// Control messaging here
+	message_flag += jammer_flag;
+	if(message_flag == 1)
+		printk("tcm_qla2xx:SCSI Jammer enabled on host %d\n",host_flag);
+	if((jammer_flag == 0) && (message_flag >=0)) {
+		printk("tcm_qla2xx:SCSI Jammer stopped, %d SCSI commands discarded for host %d\n",message_flag,host_flag);
+		message_flag=-1;
+	}
+		
+	if ((vha->host_no == host_flag) && (jammer_flag == 1))
+	{
+		// return, and don't run target_submit_cmd, effectively discarding command
+		return 0;
+	}
+
 
 	return target_submit_cmd(se_cmd, se_sess, cdb, &cmd->sense_buffer[0],
 				cmd->unpacked_lun, data_length, fcp_task_attr,
@@ -2165,6 +2189,7 @@ static void tcm_qla2xxx_deregister_confi
 static int __init tcm_qla2xxx_init(void)
 {
 	int ret;
+	jammer_flag = 0;
 
 	ret = tcm_qla2xxx_register_configfs();
 	if (ret < 0)



       reply	other threads:[~2015-03-08  3:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <588344732.13485469.1425769450275.JavaMail.zimbra@redhat.com>
2015-03-08  3:26 ` Laurence Oberman [this message]
2015-03-08  8:10   ` [PATCH ] tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module Bart Van Assche
2015-03-08 15:38     ` [PATCH ] tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision2 Laurence Oberman
2015-03-12 13:13       ` Bart Van Assche
2015-03-13  2:13         ` [PATCH ] qla2xxx Add SCSI command jammer/discard capabilty to the qla2xxx target module - revision3 Laurence Oberman
2015-03-30 14:36           ` Resend: " Laurence Oberman
2015-05-18 12:50             ` Laurence Oberman
2015-03-12 22:07   ` [PATCH ] tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module Quinn Tran
2015-03-12 23:55     ` Laurence Oberman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1069288785.13490592.1425785175883.JavaMail.zimbra@redhat.com \
    --to=loberman@redhat.com \
    --cc=agrover@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@daterainc.com \
    --cc=oberman.l@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.