Re: [PATCH ] tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision2

[Bart Van Assche <Bart.VanAssche@sandisk.com>]

On 03/08/2015 11:38 AM, Laurence Oberman wrote:
> Here is revision2
>
> I added unlikely and removed messaging control as it not necessary and adds overhead.
>
> I use target LIO for all my storage array test targets and customer problem resolution here at Red Hat.
> This patch resulted from a requirement to mimic behaviour of an expensive hardware jammer for a customer.
> I have used this for some time with good success to simulate and reproduce latency and slow drain fabric issues and
> for testing and validating error handling behaviour in the Emulex, Qlogic and other F/C drivers.
>
> Works by checking new parameter jam_host if its >= 0 and matches vha->host_no , jamming is enabled when jam_host >=0
> If parameter set to -1 (default) no jamming is enabled.
> I decided to share the patch, in the hope it may be useful for others but I do understand this is a special use case.

Hello Laurence,

Thanks for reworking this patch quickly. This patch looks fine to me. 
The only remaining concern I have is that I'm wondering what the best 
place would be to add this functionality - the qla2xxx driver or the LIO 
core ?

Bart.