[U-Boot] [PATCH] gpio: xilinx: Return 0 from xilinx_gpio_set_value

[U-Boot] [PATCH] gpio: xilinx: Return 0 from xilinx_gpio_set_value

[Michal Simek]

.set_value functions have no specified return value and gpio_uclass is
not working with it too. But this patch is returning 0 to be in sync
with others DM gpio drivers.

Reported-by: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/gpio/xilinx_gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/xilinx_gpio.c b/drivers/gpio/xilinx_gpio.c
index 2584b4b3e648..2389abee3777 100644
--- a/drivers/gpio/xilinx_gpio.c
+++ b/drivers/gpio/xilinx_gpio.c
@@ -81,7 +81,7 @@ static int xilinx_gpio_set_value(struct udevice *dev, unsigned offset,
 
 	priv->output_val[bank] = val;
 
-	return val;
+	return 0;
 };
 
 static int xilinx_gpio_get_value(struct udevice *dev, unsigned offset)
-- 
1.9.1

[U-Boot] [PATCH] gpio: xilinx: Return 0 from xilinx_gpio_set_value

[Stefan Herbrechtsmeier]

Am 06.08.2018 um 08:36 schrieb Michal Simek:
> .set_value functions have no specified return value and gpio_uclass is
> not working with it too. But this patch is returning 0 to be in sync
> with others DM gpio drivers.
>
> Reported-by: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>   drivers/gpio/xilinx_gpio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/xilinx_gpio.c b/drivers/gpio/xilinx_gpio.c
> index 2584b4b3e648..2389abee3777 100644
> --- a/drivers/gpio/xilinx_gpio.c
> +++ b/drivers/gpio/xilinx_gpio.c
> @@ -81,7 +81,7 @@ static int xilinx_gpio_set_value(struct udevice *dev, unsigned offset,
>   
>   	priv->output_val[bank] = val;
>   
> -	return val;
> +	return 0;
>   };
>   
>   static int xilinx_gpio_get_value(struct udevice *dev, unsigned offset)

Reviewed-by: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>