Re: Chris: mason/patches/data-logging/experimental/2.6.1 upside down?

Re: Chris: mason/patches/data-logging/experimental/2.6.1 upside down?

[Dieter Nützel]

Am Dienstag, 13. Januar 2004 22:32 schrieb Jens Benecke:
> Hi,
>
> the "journal-writer.gz" in the above dir starts with
>
> diff -Nur --exclude=RCS --exclude=CVS --exclude=SCCS --exclude=BitKeeper
> --exclude=ChangeSet linux.dammit/fs/reiserfs/do_balan.c linux.25.1/fs
> reiserfs/do_balan.c
> --- linux.dammit/fs/reiserfs/do_balan.c Fri Jan  9 15:18:17 2004
> +++ linux.25.1/fs/reiserfs/do_balan.c   Thu Dec  4 14:20:19 2003
>
> and only REMOVES code, doesn't add anything.
>
> Any chance you patched the wrong way round? ;-)
>
>
>
> oh yes... and is the "data-logging.gz" on the state of the 2.4.23 patches
> that are also in your directory (ie. can I mount with journal=ordered etc)?

See this, too.

Re: v3 logging speedups for 2.6

It's (SuSE 9.0 2.6.1) is running fine with reiserfs-journal-writer.

Greetings,
	Dieter

-- 
Dieter Nützel
@home: <Dieter.Nuetzel () hamburg ! de>

Re: Chris: mason/patches/data-logging/experimental/2.6.1 upside down?

[Chris Mason]

On Tue, 2004-01-13 at 16:32, Jens Benecke wrote:
> Hi,
> 
> the "journal-writer.gz" in the above dir starts with
> 
> diff -Nur --exclude=RCS --exclude=CVS --exclude=SCCS --exclude=BitKeeper
> --exclude=ChangeSet linux.dammit/fs/reiserfs/do_balan.c linux.25.1/fs
> reiserfs/do_balan.c
> --- linux.dammit/fs/reiserfs/do_balan.c Fri Jan  9 15:18:17 2004
> +++ linux.25.1/fs/reiserfs/do_balan.c   Thu Dec  4 14:20:19 2003
> 
> and only REMOVES code, doesn't add anything.
> 
> Any chance you patched the wrong way round? ;-)

No, it's supposed to remove code ;-)  It's getting rid of some old
debugging cruft that should have been shot long ago.

> oh yes... and is the "data-logging.gz" on the state of the 2.4.23 patches
> that are also in your directory (ie. can I mount with journal=ordered etc)?

Full data=ordered/logging patches are still only in use privately, where
they happily hose filesystems.  I'm getting there ;-)

-chris

Re: Chris: mason/patches/data-logging/experimental/2.6.1 upside down?

[Chris Mason]

On Tue, 2004-01-13 at 17:13, Jens Benecke wrote:
> Dieter Nützel wrote:
> 
> > See this, too.
> > Re: v3 logging speedups for 2.6
> > It's (SuSE 9.0 2.6.1) is running fine with reiserfs-journal-writer.
> 
> I'll have a look.
> 
> What exactly do experimental/2.6.1/journal-writer and logging.gz do /
> change / update? How experimental are they?
> 

journal-writer isn't experimental at all, it just removes old debugging
code.  reiserfs-logging.gz is the first half of the 2.4.x data logging
code.  Basically the 2.4.x data logging patch had two parts, the first
part made small transactions significantly more efficient, and the
second part implemented data=ordered/data=journal.

So, reiserfs-logging.gz has the small transaction performance
improvements, along with some other rewrites of how log blocks and
metadata get to disk.  In 2.4.x and vanilla 2.6, reiserfs keeps log
blocks and metadata pinned and then writes them out at very specific
times.  The new code keeps them pinned until they are safe to write, but
lets the system pdflush daemons do some of the writeback.

This makes for smoother io overall, since things aren't done in bursts.

-chris