All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL FOR v5.5 (v2)] vivid: add metadata capture/output support
@ 2019-10-17  6:53 Hans Verkuil
  2019-10-17  7:22 ` Jenkins
  0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2019-10-17  6:53 UTC (permalink / raw)
  To: Linux Media Mailing List; +Cc: Vandana B N

This series adds vivid metadata capture and output support. While working on
that it was discovered that the v4l2 core didn't correctly validate the ioctls
in the case of the vivid driver that has a complex mix of V4L2 devices and
various video inputs, each with different properties.

Some other cleanups were also done in that code to simplify the logic and
the ioctl validation for touch devices was also improved.

Many thanks to Vandana for working on this as part of the Linux Kernel
Mentorship Program.

Note: the v4l2-compliance test will fail for the metadata output. To make that
work this patch is needed: https://patchwork.linuxtv.org/patch/59480/

Once this series is merged I'll apply that patch as well to v4l-utils.

Changes in v2:

- Updated the "v4l2:Add vivid metadata doc" patch with new dual license

Regards,

	Hans

The following changes since commit 503e59365dd134b2c63864f14e2de0476284b003:

  media: i2c: ov2659: Switch to SPDX Licensing (2019-10-01 17:39:16 -0300)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.5f

for you to fetch changes up to d1c35b1d11a00b4794a7f0fbce50d754bc72ed36:

  vivid: Add metadata output support (2019-10-17 08:50:14 +0200)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Hans Verkuil (3):
      v4l2-dev: simplify the SDR checks
      v4l2-dev: fix is_tch checks
      v4l2-dev: disable frequency and tuner ioctls for touch

Vandana BN (5):
      v4l2-core: correctly validate video and metadata ioctls
      vivid: Add metadata capture support
      Documentation:media:v4l2:Add vivid metadata doc
      v4l2-core: Add new metadata format
      vivid: Add metadata output support

 Documentation/media/uapi/v4l/meta-formats.rst      |   1 +
 Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst |  60 +++++++++++++++
 drivers/media/platform/vivid/Makefile              |   2 +-
 drivers/media/platform/vivid/vivid-core.c          | 197 ++++++++++++++++++++++++++++++++++++++++++++++--
 drivers/media/platform/vivid/vivid-core.h          |  24 ++++++
 drivers/media/platform/vivid/vivid-ctrls.c         |  75 ++++++++++++++++++
 drivers/media/platform/vivid/vivid-kthread-cap.c   |  54 +++++++++++--
 drivers/media/platform/vivid/vivid-kthread-out.c   |  49 +++++++++++-
 drivers/media/platform/vivid/vivid-meta-cap.c      | 201 +++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/media/platform/vivid/vivid-meta-cap.h      |  29 +++++++
 drivers/media/platform/vivid/vivid-meta-out.c      | 174 ++++++++++++++++++++++++++++++++++++++++++
 drivers/media/platform/vivid/vivid-meta-out.h      |  25 ++++++
 drivers/media/platform/vivid/vivid-vid-cap.c       |   5 +-
 drivers/media/platform/vivid/vivid-vid-out.c       |   5 +-
 drivers/media/v4l2-core/v4l2-dev.c                 | 112 ++++++++++++++++-----------
 drivers/media/v4l2-core/v4l2-ioctl.c               |  17 ++++-
 include/uapi/linux/videodev2.h                     |   1 +
 17 files changed, 965 insertions(+), 66 deletions(-)
 create mode 100644 Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst
 create mode 100644 drivers/media/platform/vivid/vivid-meta-cap.c
 create mode 100644 drivers/media/platform/vivid/vivid-meta-cap.h
 create mode 100644 drivers/media/platform/vivid/vivid-meta-out.c
 create mode 100644 drivers/media/platform/vivid/vivid-meta-out.h

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [GIT PULL FOR v5.5 (v2)] vivid: add metadata capture/output support
  2019-10-17  6:53 [GIT PULL FOR v5.5 (v2)] vivid: add metadata capture/output support Hans Verkuil
@ 2019-10-17  7:22 ` Jenkins
  0 siblings, 0 replies; 2+ messages in thread
From: Jenkins @ 2019-10-17  7:22 UTC (permalink / raw)
  To: mchehab+samsung, linux-media; +Cc: builder

From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/patch/59516/
Build log: https://builder.linuxtv.org/job/patchwork/20785/
Build time: 00:21:46
Link: https://lore.kernel.org/linux-media/1074d944-de6e-7483-3337-ca9acd1b1c55@xs4all.nl

gpg: Signature made Thu 17 Oct 2019 06:51:01 AM UTC
gpg:                using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg:                 aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]

Summary: 5 patches and/or PDF generation with issues, being 0 at build time

Error/warnings:


Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-v4l2-dev-fix-is_tch-checks.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-v4l2-dev-fix-is_tch-checks.patch
patches/0003-v4l2-dev-fix-is_tch-checks.patch:40: WARNING: line over 80 characters
patches/0003-v4l2-dev-fix-is_tch-checks.patch:41: WARNING: line over 80 characters

Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0005-vivid-Add-metadata-capture-support.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0005-vivid-Add-metadata-capture-support.patch
patches/0005-vivid-Add-metadata-capture-support.patch:530: WARNING: line over 80 characters
patches/0005-vivid-Add-metadata-capture-support.patch:539: WARNING: line over 80 characters
patches/0005-vivid-Add-metadata-capture-support.patch:552: WARNING: line over 80 characters
patches/0005-vivid-Add-metadata-capture-support.patch:562: WARNING: line over 80 characters
patches/0005-vivid-Add-metadata-capture-support.patch:612: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
patches/0005-vivid-Add-metadata-capture-support.patch:791: WARNING: line over 80 characters

Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0006-Documentation-media-v4l2-Add-vivid-metadata-doc.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0006-Documentation-media-v4l2-Add-vivid-metadata-doc.patch
patches/0006-Documentation-media-v4l2-Add-vivid-metadata-doc.patch:6: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
patches/0006-Documentation-media-v4l2-Add-vivid-metadata-doc.patch:26: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
patches/0006-Documentation-media-v4l2-Add-vivid-metadata-doc.patch:31: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0007-v4l2-core-Add-new-metadata-format.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0007-v4l2-core-Add-new-metadata-format.patch
patches/0007-v4l2-core-Add-new-metadata-format.patch:23: ERROR: trailing statements should be on next line
patches/0007-v4l2-core-Add-new-metadata-format.patch:35: WARNING: line over 80 characters

Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0008-vivid-Add-metadata-output-support.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0008-vivid-Add-metadata-output-support.patch
patches/0008-vivid-Add-metadata-output-support.patch:435: WARNING: line over 80 characters
patches/0008-vivid-Add-metadata-output-support.patch:485: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-17  7:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17  6:53 [GIT PULL FOR v5.5 (v2)] vivid: add metadata capture/output support Hans Verkuil
2019-10-17  7:22 ` Jenkins

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.