* [Bluez-devel] [PATCH] Fix to enable bluez SCO USB urbs.
@ 2004-02-27 23:57 James Courtier-Dutton
2004-02-28 12:52 ` Marcel Holtmann
0 siblings, 1 reply; 4+ messages in thread
From: James Courtier-Dutton @ 2004-02-27 23:57 UTC (permalink / raw)
To: bluez-devel
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
Here is a patch for /usr/src/linux-2.6.3/drivers/bluetooth/hci_usb.c
Without the interval set, the latest kernel 2.6.3 usb code will reject
the usb_submit_urb().
Without this patch no ISOC urbs are submitted, and thus no SCO data is
passed.
The proper fix would really be to only enable these when a SCO
connection is actually open.
Cheers
James
[-- Attachment #2: sco-patch.diff --]
[-- Type: text/x-patch, Size: 657 bytes --]
--- hci_usb.c.org 2004-02-26 20:36:06.000000000 +0000
+++ hci_usb.c 2004-02-27 23:49:08.273537136 +0000
@@ -263,6 +263,7 @@
urb->context = husb;
urb->dev = husb->udev;
+ urb->interval = husb->isoc_in_ep->desc.bInterval;
urb->pipe = usb_rcvisocpipe(husb->udev, husb->isoc_in_ep->desc.bEndpointAddress);
urb->complete = hci_usb_rx_complete;
@@ -490,6 +491,7 @@
urb->context = husb;
urb->dev = husb->udev;
+ urb->interval = husb->isoc_out_ep->desc.bInterval;
urb->pipe = usb_sndisocpipe(husb->udev, husb->isoc_out_ep->desc.bEndpointAddress);
urb->complete = hci_usb_tx_complete;
urb->transfer_flags = URB_ISO_ASAP;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bluez-devel] [PATCH] Fix to enable bluez SCO USB urbs.
2004-02-27 23:57 [Bluez-devel] [PATCH] Fix to enable bluez SCO USB urbs James Courtier-Dutton
@ 2004-02-28 12:52 ` Marcel Holtmann
2004-02-29 2:40 ` James Courtier-Dutton
0 siblings, 1 reply; 4+ messages in thread
From: Marcel Holtmann @ 2004-02-28 12:52 UTC (permalink / raw)
To: James Courtier-Dutton; +Cc: BlueZ Mailing List
Hi James,
> Here is a patch for /usr/src/linux-2.6.3/drivers/bluetooth/hci_usb.c
>
> Without the interval set, the latest kernel 2.6.3 usb code will reject
> the usb_submit_urb().
>
> Without this patch no ISOC urbs are submitted, and thus no SCO data is
> passed.
the same patch is already in 2.6.4-rc1.
> The proper fix would really be to only enable these when a SCO
> connection is actually open.
Of course. Send me patches for it.
Regards
Marcel
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bluez-devel] [PATCH] Fix to enable bluez SCO USB urbs.
2004-02-29 2:40 ` James Courtier-Dutton
@ 2004-02-29 2:39 ` Marcel Holtmann
0 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2004-02-29 2:39 UTC (permalink / raw)
To: James Courtier-Dutton; +Cc: BlueZ Mailing List
Hi James,
> Where do I get the most up to date bluetooth kernel modules?
> I cannot find them in the sf.net CVS.
> I also cannot find any info on where to get them on the www.bluez.org
> web site.
as soon as I have a set of three or more full tested patches, I push
them for inclusion into 2.6 and I update the latest 2.6 -mh patch at
http://www.bluez.org/patches.html
Regards
Marcel
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bluez-devel] [PATCH] Fix to enable bluez SCO USB urbs.
2004-02-28 12:52 ` Marcel Holtmann
@ 2004-02-29 2:40 ` James Courtier-Dutton
2004-02-29 2:39 ` Marcel Holtmann
0 siblings, 1 reply; 4+ messages in thread
From: James Courtier-Dutton @ 2004-02-29 2:40 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: BlueZ Mailing List
Marcel Holtmann wrote:
> Hi James,
>
>
>>Here is a patch for /usr/src/linux-2.6.3/drivers/bluetooth/hci_usb.c
>>
>>Without the interval set, the latest kernel 2.6.3 usb code will reject
>>the usb_submit_urb().
>>
>>Without this patch no ISOC urbs are submitted, and thus no SCO data is
>>passed.
>
>
> the same patch is already in 2.6.4-rc1.
>
>
>>The proper fix would really be to only enable these when a SCO
>>connection is actually open.
>
>
> Of course. Send me patches for it.
>
> Regards
>
> Marcel
>
>
>
>
Where do I get the most up to date bluetooth kernel modules?
I cannot find them in the sf.net CVS.
I also cannot find any info on where to get them on the www.bluez.org
web site.
Cheers
James
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-02-29 2:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-27 23:57 [Bluez-devel] [PATCH] Fix to enable bluez SCO USB urbs James Courtier-Dutton
2004-02-28 12:52 ` Marcel Holtmann
2004-02-29 2:40 ` James Courtier-Dutton
2004-02-29 2:39 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.