From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: Tony Lindgren <tony@atomide.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>
Cc: tomba@kernel.org, airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, merlijn@wizzup.org
Subject: Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER
Date: Mon, 31 Oct 2022 13:14:30 +0200 [thread overview]
Message-ID: <108e96f7-d86a-2c1e-1a6a-c0ed02667719@gmail.com> (raw)
In-Reply-To: <Y1+f0zG50ZR4aWGX@atomide.com>
On 31.10.22 г. 12:13 ч., Tony Lindgren wrote:
> * Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [221031 06:55]:
>> On 31.10.22 г. 0:08 ч., H. Nikolaus Schaller wrote:
>>> [ 39.419846] WARNING: CPU: 0 PID: 3673 at drivers/bus/omap_l3_noc.c:139 l3_interrupt_handler+0x23c/0x330
>>> [ 39.429914] 44000000.l3-noc:L3 Custom Error: MASTER MPU TARGET GPMC (Idle): Data Access in Supervisor mode during Functional access
>>> ...
>>>
>>
>> I have no idea what that error is supposed to mean. @Tony?
>
> The error above is GPMC related. It means GPMC is not properly clocked or powered
> while trying to access it's IO range.
>
> Maybe DSS is somehow trying to access GPMC address space registers with DMA? The
> GPMC address space starts at 0. Maybe the DSS DMA address is 0 somwhere?
I think I have an idea:
omap_framebuffer_pin() calls omap_gem_pin() without verifying the
returned plane->dma_addr. To me it seems the assumption is that plane
BOs are scanout/linear, which most-probably isn't the case. I was unable
to find who provides those BOs though (they are passed as handles to
omap_framebuffer_create(), most-probably set by the userspace)
>
> Regards,
>
> Tony
>
WARNING: multiple messages have this Message-ID (diff)
From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: Tony Lindgren <tony@atomide.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>
Cc: tomba@kernel.org, airlied@linux.ie, merlijn@wizzup.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER
Date: Mon, 31 Oct 2022 13:14:30 +0200 [thread overview]
Message-ID: <108e96f7-d86a-2c1e-1a6a-c0ed02667719@gmail.com> (raw)
In-Reply-To: <Y1+f0zG50ZR4aWGX@atomide.com>
On 31.10.22 г. 12:13 ч., Tony Lindgren wrote:
> * Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [221031 06:55]:
>> On 31.10.22 г. 0:08 ч., H. Nikolaus Schaller wrote:
>>> [ 39.419846] WARNING: CPU: 0 PID: 3673 at drivers/bus/omap_l3_noc.c:139 l3_interrupt_handler+0x23c/0x330
>>> [ 39.429914] 44000000.l3-noc:L3 Custom Error: MASTER MPU TARGET GPMC (Idle): Data Access in Supervisor mode during Functional access
>>> ...
>>>
>>
>> I have no idea what that error is supposed to mean. @Tony?
>
> The error above is GPMC related. It means GPMC is not properly clocked or powered
> while trying to access it's IO range.
>
> Maybe DSS is somehow trying to access GPMC address space registers with DMA? The
> GPMC address space starts at 0. Maybe the DSS DMA address is 0 somwhere?
I think I have an idea:
omap_framebuffer_pin() calls omap_gem_pin() without verifying the
returned plane->dma_addr. To me it seems the assumption is that plane
BOs are scanout/linear, which most-probably isn't the case. I was unable
to find who provides those BOs though (they are passed as handles to
omap_framebuffer_create(), most-probably set by the userspace)
>
> Regards,
>
> Tony
>
next prev parent reply other threads:[~2022-10-31 11:14 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 10:23 [PATCH 0/3] drm: omapdrm: Fix excessive GEM buffers DMM/CMA usage Ivaylo Dimitrov
2022-01-19 10:23 ` Ivaylo Dimitrov
2022-01-19 10:23 ` [PATCH 1/3] drm: omapdrm: simplify omap_gem_pin Ivaylo Dimitrov
2022-01-19 10:23 ` Ivaylo Dimitrov
2022-01-19 10:23 ` [PATCH 2/3] drm: omapdrm: Support exporting of non-contiguous GEM BOs Ivaylo Dimitrov
2022-01-19 10:23 ` Ivaylo Dimitrov
2022-01-19 10:23 ` [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER Ivaylo Dimitrov
2022-01-19 10:23 ` Ivaylo Dimitrov
2022-02-17 12:46 ` Tomi Valkeinen
2022-02-17 12:46 ` Tomi Valkeinen
2022-02-17 15:29 ` Ivaylo Dimitrov
2022-02-17 15:29 ` Ivaylo Dimitrov
2022-08-12 4:35 ` Yongqin Liu
2022-08-12 4:35 ` Yongqin Liu
2022-08-13 6:58 ` Ivaylo Dimitrov
2022-08-13 6:58 ` Ivaylo Dimitrov
2022-08-14 14:27 ` Yongqin Liu
2022-08-14 14:27 ` Yongqin Liu
2022-08-15 6:23 ` Ivaylo Dimitrov
2022-08-15 6:23 ` Ivaylo Dimitrov
2022-08-17 4:52 ` Yongqin Liu
2022-08-17 4:52 ` Yongqin Liu
2022-08-18 10:23 ` Ivaylo Dimitrov
2022-08-18 10:23 ` Ivaylo Dimitrov
2022-08-29 2:51 ` Yongqin Liu
2022-08-29 2:51 ` Yongqin Liu
2022-08-29 13:24 ` Ivaylo Dimitrov
2022-08-29 13:24 ` Ivaylo Dimitrov
2022-08-29 14:36 ` Andrew Davis
2022-08-29 14:36 ` Andrew Davis
2022-08-30 15:08 ` Yongqin Liu
2022-08-30 15:08 ` Yongqin Liu
2022-08-30 18:08 ` Ivaylo Dimitrov
2022-08-30 18:08 ` Ivaylo Dimitrov
2022-08-30 18:23 ` Tomi Valkeinen
2022-08-30 18:23 ` Tomi Valkeinen
2022-09-02 14:13 ` Ivaylo Dimitrov
2022-09-02 14:13 ` Ivaylo Dimitrov
2022-10-30 22:08 ` H. Nikolaus Schaller
2022-10-30 22:08 ` H. Nikolaus Schaller
2022-10-31 7:05 ` Ivaylo Dimitrov
2022-10-31 7:05 ` Ivaylo Dimitrov
2022-10-31 7:44 ` H. Nikolaus Schaller
2022-10-31 7:44 ` H. Nikolaus Schaller
2022-10-31 7:57 ` H. Nikolaus Schaller
2022-10-31 7:57 ` H. Nikolaus Schaller
2022-10-31 9:58 ` Ivaylo Dimitrov
2022-10-31 9:58 ` Ivaylo Dimitrov
2022-10-31 10:07 ` H. Nikolaus Schaller
2022-10-31 10:07 ` H. Nikolaus Schaller
2022-10-31 10:13 ` Tony Lindgren
2022-10-31 10:13 ` Tony Lindgren
2022-10-31 10:30 ` Ivaylo Dimitrov
2022-10-31 10:30 ` Ivaylo Dimitrov
2022-10-31 11:14 ` Ivaylo Dimitrov [this message]
2022-10-31 11:14 ` Ivaylo Dimitrov
2022-02-14 7:08 ` [PATCH 0/3] drm: omapdrm: Fix excessive GEM buffers DMM/CMA usage Ivaylo Dimitrov
2022-02-14 7:08 ` Ivaylo Dimitrov
2022-02-16 8:10 ` Thomas Zimmermann
2022-02-16 8:10 ` Thomas Zimmermann
2022-02-17 13:03 ` Tomi Valkeinen
2022-02-17 13:03 ` Tomi Valkeinen
2022-02-17 16:21 ` Ivaylo Dimitrov
2022-02-17 16:21 ` Ivaylo Dimitrov
2022-03-08 8:51 ` Tomi Valkeinen
2022-03-08 8:51 ` Tomi Valkeinen
2022-03-28 9:46 ` Tomi Valkeinen
2022-03-28 9:46 ` Tomi Valkeinen
2022-03-28 15:30 ` Ivaylo Dimitrov
2022-03-28 15:30 ` Ivaylo Dimitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=108e96f7-d86a-2c1e-1a6a-c0ed02667719@gmail.com \
--to=ivo.g.dimitrov.75@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=tomba@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.