[Kernel-janitors] [PATCH -mm 6/9] pci_find_device to pci_get_device

[Kernel-janitors] [PATCH -mm 6/9] pci_find_device to pci_get_device

[Scott Feldman]

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

Use pci_get_device instead of pci_find_device as pci device returned
from pci_find_device can disappear at any momemt in time.

Signed-off-by: Scott Feldman <sfeldma@pobox.com>

diff -Naurp linux-2.6.9-rc2-mm1/drivers/net/sunhme.c linux-2.6.9-rc2-mm1-dsf/drivers/net/sunhme.c
--- linux-2.6.9-rc2-mm1/drivers/net/sunhme.c	2004-08-14 03:55:10.000000000 -0700
+++ linux-2.6.9-rc2-mm1-dsf/drivers/net/sunhme.c	2004-09-20 22:51:59.709768488 -0700
@@ -3311,7 +3311,7 @@ static int __init happy_meal_pci_probe(v
 	struct pci_dev *pdev = NULL;
 	int cards = 0;
 
-	while ((pdev = pci_find_device(PCI_VENDOR_ID_SUN,
+	while ((pdev = pci_get_device(PCI_VENDOR_ID_SUN,
 				       PCI_DEVICE_ID_SUN_HAPPYMEAL, pdev)) != NULL) {
 		if (pci_enable_device(pdev))
 			continue;



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH -mm 6/9] pci_find_device to

[Christoph Hellwig]

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

On Mon, Sep 20, 2004 at 11:53:03PM -0700, Scott Feldman wrote:
> Use pci_get_device instead of pci_find_device as pci device returned
> from pci_find_device can disappear at any momemt in time.

Should be converted to the pci_driver infrastructure instead.

> 
> Signed-off-by: Scott Feldman <sfeldma@pobox.com>
> 
> diff -Naurp linux-2.6.9-rc2-mm1/drivers/net/sunhme.c linux-2.6.9-rc2-mm1-dsf/drivers/net/sunhme.c
> --- linux-2.6.9-rc2-mm1/drivers/net/sunhme.c	2004-08-14 03:55:10.000000000 -0700
> +++ linux-2.6.9-rc2-mm1-dsf/drivers/net/sunhme.c	2004-09-20 22:51:59.709768488 -0700
> @@ -3311,7 +3311,7 @@ static int __init happy_meal_pci_probe(v
>  	struct pci_dev *pdev = NULL;
>  	int cards = 0;
>  
> -	while ((pdev = pci_find_device(PCI_VENDOR_ID_SUN,
> +	while ((pdev = pci_get_device(PCI_VENDOR_ID_SUN,
>  				       PCI_DEVICE_ID_SUN_HAPPYMEAL, pdev)) != NULL) {
>  		if (pci_enable_device(pdev))
>  			continue;
> 
> 

> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors

---end quoted text---

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors