* [PATCH i-g-t] benchmarks/gem_wsim: Tidy manual sizeof VLA calculations
@ 2019-05-27 9:46 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-05-27 9:46 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
We can use offsetof for the same effect, much tidier with no dummy
locals.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
benchmarks/gem_wsim.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
index db19925b1..a76fdbfe2 100644
--- a/benchmarks/gem_wsim.c
+++ b/benchmarks/gem_wsim.c
@@ -1443,23 +1443,20 @@ set_ctx_sseu(struct ctx *ctx, uint64_t slice_mask)
static size_t sizeof_load_balance(int count)
{
- struct i915_context_engines_load_balance *ptr;
-
- return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
+ return offsetof(struct i915_context_engines_load_balance,
+ engines[count]);
}
static size_t sizeof_param_engines(int count)
{
- struct i915_context_param_engines *ptr;
-
- return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
+ return offsetof(struct i915_context_param_engines,
+ engines[count]);
}
static size_t sizeof_engines_bond(int count)
{
- struct i915_context_engines_bond *ptr;
-
- return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
+ return offsetof(struct i915_context_engines_bond,
+ engines[count]);
}
#define alloca0(sz) ({ size_t sz__ = (sz); memset(alloca(sz__), 0, sz__); })
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] [PATCH i-g-t] benchmarks/gem_wsim: Tidy manual sizeof VLA calculations
@ 2019-05-27 9:46 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-05-27 9:46 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Tvrtko Ursulin
We can use offsetof for the same effect, much tidier with no dummy
locals.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
benchmarks/gem_wsim.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
index db19925b1..a76fdbfe2 100644
--- a/benchmarks/gem_wsim.c
+++ b/benchmarks/gem_wsim.c
@@ -1443,23 +1443,20 @@ set_ctx_sseu(struct ctx *ctx, uint64_t slice_mask)
static size_t sizeof_load_balance(int count)
{
- struct i915_context_engines_load_balance *ptr;
-
- return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
+ return offsetof(struct i915_context_engines_load_balance,
+ engines[count]);
}
static size_t sizeof_param_engines(int count)
{
- struct i915_context_param_engines *ptr;
-
- return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
+ return offsetof(struct i915_context_param_engines,
+ engines[count]);
}
static size_t sizeof_engines_bond(int count)
{
- struct i915_context_engines_bond *ptr;
-
- return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
+ return offsetof(struct i915_context_engines_bond,
+ engines[count]);
}
#define alloca0(sz) ({ size_t sz__ = (sz); memset(alloca(sz__), 0, sz__); })
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for benchmarks/gem_wsim: Tidy manual sizeof VLA calculations
2019-05-27 9:46 ` [igt-dev] " Chris Wilson
(?)
@ 2019-05-27 11:33 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-05-27 11:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: benchmarks/gem_wsim: Tidy manual sizeof VLA calculations
URL : https://patchwork.freedesktop.org/series/61178/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6147 -> IGTPW_3062
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/61178/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3062 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_auth@basic-auth:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/fi-icl-u3/igt@core_auth@basic-auth.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/fi-icl-u3/igt@core_auth@basic-auth.html
* igt@gem_ctx_create@basic-files:
- fi-icl-u3: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#109100])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/fi-icl-u3/igt@gem_ctx_create@basic-files.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/fi-icl-u3/igt@gem_ctx_create@basic-files.html
* igt@gem_ctx_exec@basic:
- fi-icl-u2: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/fi-icl-u2/igt@gem_ctx_exec@basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/fi-icl-u2/igt@gem_ctx_exec@basic.html
* igt@i915_selftest@live_hangcheck:
- fi-icl-y: [PASS][7] -> [INCOMPLETE][8] ([fdo#107713] / [fdo#108569])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/fi-icl-y/igt@i915_selftest@live_hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/fi-icl-y/igt@i915_selftest@live_hangcheck.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [INCOMPLETE][9] ([fdo#107718]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [FAIL][11] ([fdo#108511]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: [INCOMPLETE][13] ([fdo#108602] / [fdo#108744]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: [SKIP][15] ([fdo#109271] / [fdo#109278]) -> [PASS][16] +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-apl-guc: [DMESG-WARN][17] ([fdo#110512]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/fi-apl-guc/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/fi-apl-guc/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-apl-guc: [FAIL][19] ([fdo#110512]) -> [DMESG-WARN][20] ([fdo#110512])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/fi-apl-guc/igt@gem_exec_suspend@basic-s3.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/fi-apl-guc/igt@gem_exec_suspend@basic-s3.html
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110512]: https://bugs.freedesktop.org/show_bug.cgi?id=110512
Participating hosts (51 -> 45)
------------------------------
Additional (2): fi-bsw-n3050 fi-pnv-d510
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus fi-cml-u
Build changes
-------------
* IGT: IGT_5016 -> IGTPW_3062
CI_DRM_6147: 12a8ed2d762a29845da42f16a175579896f58dea @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3062: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/
IGT_5016: 5e583caf38c04c9312e28510b754b2b54da31d56 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for benchmarks/gem_wsim: Tidy manual sizeof VLA calculations
2019-05-27 9:46 ` [igt-dev] " Chris Wilson
(?)
(?)
@ 2019-05-27 21:24 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-05-27 21:24 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: benchmarks/gem_wsim: Tidy manual sizeof VLA calculations
URL : https://patchwork.freedesktop.org/series/61178/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6147_full -> IGTPW_3062_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/61178/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3062_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_tiled_swapping@non-threaded:
- shard-iclb: [PASS][1] -> [FAIL][2] ([fdo#108686])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-iclb6/igt@gem_tiled_swapping@non-threaded.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-iclb8/igt@gem_tiled_swapping@non-threaded.html
- shard-glk: [PASS][3] -> [DMESG-WARN][4] ([fdo#108686])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-glk6/igt@gem_tiled_swapping@non-threaded.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-glk5/igt@gem_tiled_swapping@non-threaded.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-hsw: [PASS][7] -> [FAIL][8] ([fdo#103355])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-hsw2/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-hsw: [PASS][9] -> [SKIP][10] ([fdo#109271]) +11 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-hsw2/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-hsw1/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103166])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([fdo#108566]) +6 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-apl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-apl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@perf@blocking:
- shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#110728])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-iclb5/igt@perf@blocking.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-iclb8/igt@perf@blocking.html
* igt@perf_pmu@rc6:
- shard-kbl: [PASS][19] -> [SKIP][20] ([fdo#109271])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-kbl2/igt@perf_pmu@rc6.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-kbl2/igt@perf_pmu@rc6.html
#### Possible fixes ####
* igt@gem_tiled_swapping@non-threaded:
- shard-kbl: [DMESG-WARN][21] -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-kbl3/igt@gem_tiled_swapping@non-threaded.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-kbl3/igt@gem_tiled_swapping@non-threaded.html
* igt@i915_selftest@mock_fence:
- shard-iclb: [INCOMPLETE][23] ([fdo#107713]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-iclb7/igt@i915_selftest@mock_fence.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-iclb2/igt@i915_selftest@mock_fence.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][25] ([fdo#108566]) -> [PASS][26] +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-apl5/igt@i915_suspend@fence-restore-untiled.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-apl5/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_cursor_crc@pipe-b-cursor-128x128-offscreen:
- shard-apl: [INCOMPLETE][27] ([fdo#103927]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-128x128-offscreen.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-apl7/igt@kms_cursor_crc@pipe-b-cursor-128x128-offscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-64x64-onscreen:
- shard-apl: [FAIL][29] ([fdo#103232]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-apl3/igt@kms_cursor_crc@pipe-b-cursor-64x64-onscreen.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-apl2/igt@kms_cursor_crc@pipe-b-cursor-64x64-onscreen.html
- shard-kbl: [FAIL][31] ([fdo#103232]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-kbl2/igt@kms_cursor_crc@pipe-b-cursor-64x64-onscreen.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-kbl2/igt@kms_cursor_crc@pipe-b-cursor-64x64-onscreen.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [FAIL][33] ([fdo#103355]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_cursor_legacy@pipe-a-forked-move:
- shard-hsw: [INCOMPLETE][35] ([fdo#103540]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-hsw5/igt@kms_cursor_legacy@pipe-a-forked-move.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-hsw8/igt@kms_cursor_legacy@pipe-a-forked-move.html
* igt@kms_flip@blocking-wf_vblank:
- shard-glk: [INCOMPLETE][37] ([fdo#103359] / [k.org#198133]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-glk6/igt@kms_flip@blocking-wf_vblank.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-glk1/igt@kms_flip@blocking-wf_vblank.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [DMESG-WARN][39] ([fdo#108566]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render:
- shard-hsw: [SKIP][41] ([fdo#109271]) -> [PASS][42] +8 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][43] ([fdo#103167]) -> [PASS][44] +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][45] ([fdo#109441]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
#### Warnings ####
* igt@gem_mmap_gtt@forked-big-copy-odd:
- shard-iclb: [INCOMPLETE][47] ([fdo#107713] / [fdo#109100]) -> [TIMEOUT][48] ([fdo#109673])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6147/shard-iclb1/igt@gem_mmap_gtt@forked-big-copy-odd.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/shard-iclb7/igt@gem_mmap_gtt@forked-big-copy-odd.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_5016 -> IGTPW_3062
* Piglit: piglit_4509 -> None
CI_DRM_6147: 12a8ed2d762a29845da42f16a175579896f58dea @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3062: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/
IGT_5016: 5e583caf38c04c9312e28510b754b2b54da31d56 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3062/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] benchmarks/gem_wsim: Tidy manual sizeof VLA calculations
2019-05-27 9:46 ` [igt-dev] " Chris Wilson
@ 2019-06-03 12:53 ` Tvrtko Ursulin
-1 siblings, 0 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2019-06-03 12:53 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 27/05/2019 10:46, Chris Wilson wrote:
> We can use offsetof for the same effect, much tidier with no dummy
> locals.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> benchmarks/gem_wsim.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
> index db19925b1..a76fdbfe2 100644
> --- a/benchmarks/gem_wsim.c
> +++ b/benchmarks/gem_wsim.c
> @@ -1443,23 +1443,20 @@ set_ctx_sseu(struct ctx *ctx, uint64_t slice_mask)
>
> static size_t sizeof_load_balance(int count)
> {
> - struct i915_context_engines_load_balance *ptr;
> -
> - return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
> + return offsetof(struct i915_context_engines_load_balance,
> + engines[count]);
> }
>
> static size_t sizeof_param_engines(int count)
> {
> - struct i915_context_param_engines *ptr;
> -
> - return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
> + return offsetof(struct i915_context_param_engines,
> + engines[count]);
> }
>
> static size_t sizeof_engines_bond(int count)
> {
> - struct i915_context_engines_bond *ptr;
> -
> - return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
> + return offsetof(struct i915_context_engines_bond,
> + engines[count]);
> }
>
> #define alloca0(sz) ({ size_t sz__ = (sz); memset(alloca(sz__), 0, sz__); })
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] benchmarks/gem_wsim: Tidy manual sizeof VLA calculations
@ 2019-06-03 12:53 ` Tvrtko Ursulin
0 siblings, 0 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2019-06-03 12:53 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 27/05/2019 10:46, Chris Wilson wrote:
> We can use offsetof for the same effect, much tidier with no dummy
> locals.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> benchmarks/gem_wsim.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
> index db19925b1..a76fdbfe2 100644
> --- a/benchmarks/gem_wsim.c
> +++ b/benchmarks/gem_wsim.c
> @@ -1443,23 +1443,20 @@ set_ctx_sseu(struct ctx *ctx, uint64_t slice_mask)
>
> static size_t sizeof_load_balance(int count)
> {
> - struct i915_context_engines_load_balance *ptr;
> -
> - return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
> + return offsetof(struct i915_context_engines_load_balance,
> + engines[count]);
> }
>
> static size_t sizeof_param_engines(int count)
> {
> - struct i915_context_param_engines *ptr;
> -
> - return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
> + return offsetof(struct i915_context_param_engines,
> + engines[count]);
> }
>
> static size_t sizeof_engines_bond(int count)
> {
> - struct i915_context_engines_bond *ptr;
> -
> - return sizeof(*ptr) + count * sizeof(ptr->engines[0]);
> + return offsetof(struct i915_context_engines_bond,
> + engines[count]);
> }
>
> #define alloca0(sz) ({ size_t sz__ = (sz); memset(alloca(sz__), 0, sz__); })
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-03 12:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-27 9:46 [PATCH i-g-t] benchmarks/gem_wsim: Tidy manual sizeof VLA calculations Chris Wilson
2019-05-27 9:46 ` [igt-dev] " Chris Wilson
2019-05-27 11:33 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-27 21:24 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-06-03 12:53 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
2019-06-03 12:53 ` [Intel-gfx] " Tvrtko Ursulin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.