* Re: v6.0-rc6 - arm64 / rock960 : kernel panic
@ 2022-09-24 18:01 ` Michael Nazzareno Trimarchi
0 siblings, 0 replies; 20+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-09-24 18:01 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Heiko St??bner, Greg Kroah-Hartman, Linux Kernel Mailing List,
open list:ARM/Rockchip SoC...
On Sat, Sep 24, 2022 at 7:58 PM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi Daniel
>
> On Sat, Sep 24, 2022 at 7:43 PM Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
> >
> > Hi,
> >
> > there is a kernel panic on a rock960 board:
> >
> > After git bisecting, I have:
> >
> > commit 14facbc1871ae15404666747b5319c08e04b875a
> > Merge: f5c97da8037b 32346491ddf2
> > Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Date: Mon Jul 11 08:32:58 2022 +0200
> >
> > Merge 5.19-rc6 into char-misc-next
> >
> > We need the misc driver fixes in here as well.
> >
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > Any clue?
>
> That code receive 3-4 commits for one fix
>
> diff --git a/sound/soc/rockchip/rockchip_i2s.c
> b/sound/soc/rockchip/rockchip_i2s.c
> index f5f3540a9e18..a32a45b09b03 100644
> --- a/sound/soc/rockchip/rockchip_i2s.c
> +++ b/sound/soc/rockchip/rockchip_i2s.c
> @@ -803,7 +803,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
>
> i2s->bclk_ratio = 64;
> i2s->pinctrl = devm_pinctrl_get(&pdev->dev);
> - if (!IS_ERR(i2s->pinctrl)) {
> + if (!IS_ERR_OR_NULL(i2s->pinctrl)) {
> i2s->bclk_on = pinctrl_lookup_state(i2s->pinctrl, "bclk_on");
> if (!IS_ERR_OR_NULL(i2s->bclk_on)) {
> i2s->bclk_off =
> pinctrl_lookup_state(i2s->pinctrl, "bclk_off");
I don't sure if you can get null from there, but you have two
lookup_state on that function
Michael
>
> Michael
>
> >
> >
> > [ 2.377386] Unable to handle kernel NULL pointer dereference at
> > virtual address 0000000000000005
> > [ 2.377390] Mem abort info:
> > [ 2.377392] ESR = 0x0000000096000004
> > [ 2.379529] EC = 0x25: DABT (current EL), IL = 32 bits
> > [ 2.379994] SET = 0, FnV = 0
> > [ 2.380263] EA = 0, S1PTW = 0
> > [ 2.380538] FSC = 0x04: level 0 translation fault
> > [ 2.380964] Data abort info:
> > [ 2.381217] ISV = 0, ISS = 0x00000004
> > [ 2.381343] mmc2: SDHCI controller on fe330000.mmc [fe330000.mmc]
> > using ADMA
> > [ 2.381558] CM = 0, WnR = 0
> > [ 2.382426] [0000000000000005] user address but active_mm is swapper
> > [ 2.382981] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> > [ 2.383468] Modules linked in:
> > [ 2.383740] CPU: 4 PID: 1 Comm: swapper/0 Not tainted 5.19.0-rc6+ #728
> > [ 2.384311] Hardware name: 96boards Rock960 (DT)
> > [ 2.384715] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS
> > BTYPE=--)
> > [ 2.385323] pc : pinctrl_lookup_state+0x20/0xc0
> > [ 2.385729] lr : rockchip_i2s_probe+0x1a8/0x54c
> > [ 2.386130] sp : ffff80000804bb30
> > [ 2.386420] x29: ffff80000804bb30 x28: 0000000000000000 x27:
> > ffff800009f204c8
> > [ 2.387048] x26: ffff800009fc1060 x25: ffff800009fc1078 x24:
> > ffff000002691b68
> > [ 2.387673] x23: ffff800009967938 x22: ffffffffffffffed x21:
> > ffff800009e1e0e8
> > [ 2.388299] x20: ffffffffffffffed x19: ffff000002597480 x18:
> > ffffffffffffffff
> > [ 2.388924] x17: 000000040044ffff x16: 00400034b5503510 x15:
> > ffff80008804b787
> > [ 2.389550] x14: 0000000000000000 x13: 6c7274636e697020 x12:
> > 73326920646e6966
> > [ 2.390176] x11: 206f742064656c69 x10: 6166203a7332692e x9 :
> > 656c696166203a73
> > [ 2.390801] x8 : 32692e3030303061 x7 : 205d363238363733 x6 :
> > ffff000001657880
> > [ 2.391425] x5 : 0000000000000000 x4 : 0000000000000000 x3 :
> > 0000000000000000
> > [ 2.392051] x2 : 0000000000000000 x1 : ffff800009e1e0e8 x0 :
> > ffffffffffffffed
> > [ 2.392677] Call trace:
> > [ 2.392892] pinctrl_lookup_state+0x20/0xc0
> > [ 2.393261] rockchip_i2s_probe+0x1a8/0x54c
> > [ 2.393629] platform_probe+0x68/0xe0
> > [ 2.393954] really_probe.part.0+0x9c/0x2ac
> > [ 2.394321] __driver_probe_device+0x98/0x144
> > [ 2.394703] driver_probe_device+0xac/0x140
> > [ 2.395070] __driver_attach+0xf8/0x1a0
> > [ 2.395407] bus_for_each_dev+0x70/0xd0
> > [ 2.395746] driver_attach+0x24/0x30
> > [ 2.396063] bus_add_driver+0x150/0x200
> > [ 2.396401] driver_register+0x78/0x130
> > [ 2.396737] __platform_driver_register+0x28/0x34
> > [ 2.397150] rockchip_i2s_driver_init+0x1c/0x28
> > [ 2.397550] do_one_initcall+0x50/0x1c0
> > [ 2.397890] kernel_init_freeable+0x208/0x28c
> > [ 2.398274] kernel_init+0x28/0x13c
> > [ 2.398583] ret_from_fork+0x10/0x20
> > [ 2.398901] Code: aa0003f4 a9025bf5 aa0003f6 aa0103f5 (f8418e93)
> > [ 2.399435] ---[ end trace 0000000000000000 ]---
> > [ 2.399887] Kernel panic - not syncing: Attempted to kill init!
> > exitcode=0x0000000b
> > [ 2.400555] SMP: stopping secondary CPUs
> > [ 2.400984] Kernel Offset: 0x80000 from 0xffff800008000000
> > [ 2.401463] PHYS_OFFSET: 0x0
> > [ 2.401716] CPU features: 0x800,00127811,00001082
> > [ 2.402128] Memory Limit: none
> > [ 2.402406] ---[ end Kernel panic - not syncing: Attempted to kill
> > init! exitcode=0x0000000b ]---
> >
> >
> > --
> > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> >
> > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> > <http://twitter.com/#!/linaroorg> Twitter |
> > <http://www.linaro.org/linaro-blog/> Blog
> >
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
>
>
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> michael@amarulasolutions.com
> __________________________________
>
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> info@amarulasolutions.com
> www.amarulasolutions.com
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: v6.0-rc6 - arm64 / rock960 : kernel panic
2022-09-24 18:01 ` Michael Nazzareno Trimarchi
@ 2022-09-24 18:48 ` Daniel Lezcano
-1 siblings, 0 replies; 20+ messages in thread
From: Daniel Lezcano @ 2022-09-24 18:48 UTC (permalink / raw)
To: Michael Nazzareno Trimarchi
Cc: Heiko St??bner, Greg Kroah-Hartman, Linux Kernel Mailing List,
open list:ARM/Rockchip SoC...,
Thomas Gleixner
On 24/09/2022 20:01, Michael Nazzareno Trimarchi wrote:
> On Sat, Sep 24, 2022 at 7:58 PM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
>>
>> Hi Daniel
>>
>> On Sat, Sep 24, 2022 at 7:43 PM Daniel Lezcano
>> <daniel.lezcano@linaro.org> wrote:
>>>
>>> Hi,
>>>
>>> there is a kernel panic on a rock960 board:
>>>
>>> After git bisecting, I have:
>>>
>>> commit 14facbc1871ae15404666747b5319c08e04b875a
>>> Merge: f5c97da8037b 32346491ddf2
>>> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> Date: Mon Jul 11 08:32:58 2022 +0200
>>>
>>> Merge 5.19-rc6 into char-misc-next
>>>
>>> We need the misc driver fixes in here as well.
>>>
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>
>>> Any clue?
>>
>> That code receive 3-4 commits for one fix
>>
>> diff --git a/sound/soc/rockchip/rockchip_i2s.c
>> b/sound/soc/rockchip/rockchip_i2s.c
>> index f5f3540a9e18..a32a45b09b03 100644
>> --- a/sound/soc/rockchip/rockchip_i2s.c
>> +++ b/sound/soc/rockchip/rockchip_i2s.c
>> @@ -803,7 +803,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
>>
>> i2s->bclk_ratio = 64;
>> i2s->pinctrl = devm_pinctrl_get(&pdev->dev);
>> - if (!IS_ERR(i2s->pinctrl)) {
>> + if (!IS_ERR_OR_NULL(i2s->pinctrl)) {
>> i2s->bclk_on = pinctrl_lookup_state(i2s->pinctrl, "bclk_on");
>> if (!IS_ERR_OR_NULL(i2s->bclk_on)) {
>> i2s->bclk_off =
>> pinctrl_lookup_state(i2s->pinctrl, "bclk_off");
>
> I don't sure if you can get null from there, but you have two
> lookup_state on that function
Hmm, actually, I think it is not the same kernel panic I'm observing on
v6.0-rc6.
I've been puzzled by different kernel panics from different issues when
git bisecting.
The one happening is:
[ 2.471037] rk808-rtc rk808-rtc: setting system clock to
2022-09-24T18:41:07 UTC (1664044867)
[ 2.485859] usbcore: registered new interface driver uvcvideo
[ 3.726846] Unable to handle kernel execute from non-executable
memory at virtual address ffff80000a516530
[ 3.728032] Mem abort info:
[ 3.728308] ESR = 0x000000008600000f
[ 3.728667] EC = 0x21: IABT (current EL), IL = 32 bits
[ 3.729169] SET = 0, FnV = 0
[ 3.729466] EA = 0, S1PTW = 0
[ 3.729770] FSC = 0x0f: level 3 permission fault
[ 3.730223] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000005f42000
[ 3.730846] [ffff80000a516530] pgd=10000000f7fff003,
p4d=10000000f7fff003, pud=10000000f7ffe003, pmd=10000000f7ff9003,
pte=0078000006516f03
[ 3.732063] Internal error: Oops: 8600000f [#1] PREEMPT SMP
[ 3.732588] Modules linked in:
[ 3.732918] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.0.0-rc1+ #730
[ 3.733532] Hardware name: 96boards Rock960 (DT)
[ 3.733971] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS
BTYPE=--)
[ 3.734635] pc : extcon_dev_list+0x0/0x10
[ 3.735056] lr : call_timer_fn.constprop.0+0x24/0x80
[ 3.735551] sp : ffff80000a733ab0
[ 3.735869] x29: ffff80000a733ab0 x28: 0000000000000005 x27:
ffff80000a516530
[ 3.736574] x26: ffff80000a3779c0 x25: ffff0000f776dde8 x24:
ffff80000a733b40
[ 3.737277] x23: 0000000000000000 x22: dead000000000122 x21:
0000000000000101
[ 3.737977] x20: ffff000000644600 x19: ffff80000a516530 x18:
ffffffffffffffff
[ 3.738677] x17: ffff8000ed713000 x16: ffff80000800c000 x15:
0000000000004000
[ 3.739377] x14: 0000000000000000 x13: 0000000000000000 x12:
0000000000000000
[ 3.740073] x11: 00000000000000b7 x10: ffff8000ed713000 x9 :
ffff0000f776de30
[ 3.740771] x8 : 0000000000000001 x7 : ffffffffffffffff x6 :
0000000000000000
[ 3.741469] x5 : 0000000000000000 x4 : 0000000000000000 x3 :
0000000000000200
[ 3.742164] x2 : 0000000000000200 x1 : ffff80000a516530 x0 :
ffff0000007e7310
[ 3.742865] Call trace:
[ 3.743107] extcon_dev_list+0x0/0x10
[ 3.743477] __run_timers.part.0+0x1f0/0x234
[ 3.743908] run_timer_softirq+0x3c/0x7c
[ 3.744306] _stext+0x124/0x2a4
[ 3.744627] __irq_exit_rcu+0xcc/0xfc
[ 3.745008] irq_exit_rcu+0x10/0x20
[ 3.745372] el1_interrupt+0x38/0x70
[ 3.745733] el1h_64_irq_handler+0x18/0x24
[ 3.746140] el1h_64_irq+0x64/0x68
[ 3.746484] arch_cpu_idle+0x18/0x2c
[ 3.746843] default_idle_call+0x34/0x70
[ 3.747243] do_idle+0x240/0x2bc
[ 3.747576] cpu_startup_entry+0x24/0x30
[ 3.747969] secondary_start_kernel+0x12c/0x140
[ 3.748421] __secondary_switched+0xb0/0xb4
[ 3.748879] Code: 0a516520 ffff8000 0a516520 ffff8000 (007e7320)
[ 3.749461] ---[ end trace 0000000000000000 ]---
[ 3.749911] Kernel panic - not syncing: Oops: Fatal exception in
interrupt
[ 3.750548] SMP: stopping secondary CPUs
[ 3.751094] Kernel Offset: 0x80000 from 0xffff800008000000
[ 3.751609] PHYS_OFFSET: 0x0
[ 3.751889] CPU features: 0x2000,0824f021,00001082
[ 3.752354] Memory Limit: none
[ 3.752655] ---[ end Kernel panic - not syncing: Oops: Fatal
exception in interrupt ]---
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: v6.0-rc6 - arm64 / rock960 : kernel panic
@ 2022-09-24 18:48 ` Daniel Lezcano
0 siblings, 0 replies; 20+ messages in thread
From: Daniel Lezcano @ 2022-09-24 18:48 UTC (permalink / raw)
To: Michael Nazzareno Trimarchi
Cc: Heiko St??bner, Greg Kroah-Hartman, Linux Kernel Mailing List,
open list:ARM/Rockchip SoC...,
Thomas Gleixner
On 24/09/2022 20:01, Michael Nazzareno Trimarchi wrote:
> On Sat, Sep 24, 2022 at 7:58 PM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
>>
>> Hi Daniel
>>
>> On Sat, Sep 24, 2022 at 7:43 PM Daniel Lezcano
>> <daniel.lezcano@linaro.org> wrote:
>>>
>>> Hi,
>>>
>>> there is a kernel panic on a rock960 board:
>>>
>>> After git bisecting, I have:
>>>
>>> commit 14facbc1871ae15404666747b5319c08e04b875a
>>> Merge: f5c97da8037b 32346491ddf2
>>> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> Date: Mon Jul 11 08:32:58 2022 +0200
>>>
>>> Merge 5.19-rc6 into char-misc-next
>>>
>>> We need the misc driver fixes in here as well.
>>>
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>
>>> Any clue?
>>
>> That code receive 3-4 commits for one fix
>>
>> diff --git a/sound/soc/rockchip/rockchip_i2s.c
>> b/sound/soc/rockchip/rockchip_i2s.c
>> index f5f3540a9e18..a32a45b09b03 100644
>> --- a/sound/soc/rockchip/rockchip_i2s.c
>> +++ b/sound/soc/rockchip/rockchip_i2s.c
>> @@ -803,7 +803,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
>>
>> i2s->bclk_ratio = 64;
>> i2s->pinctrl = devm_pinctrl_get(&pdev->dev);
>> - if (!IS_ERR(i2s->pinctrl)) {
>> + if (!IS_ERR_OR_NULL(i2s->pinctrl)) {
>> i2s->bclk_on = pinctrl_lookup_state(i2s->pinctrl, "bclk_on");
>> if (!IS_ERR_OR_NULL(i2s->bclk_on)) {
>> i2s->bclk_off =
>> pinctrl_lookup_state(i2s->pinctrl, "bclk_off");
>
> I don't sure if you can get null from there, but you have two
> lookup_state on that function
Hmm, actually, I think it is not the same kernel panic I'm observing on
v6.0-rc6.
I've been puzzled by different kernel panics from different issues when
git bisecting.
The one happening is:
[ 2.471037] rk808-rtc rk808-rtc: setting system clock to
2022-09-24T18:41:07 UTC (1664044867)
[ 2.485859] usbcore: registered new interface driver uvcvideo
[ 3.726846] Unable to handle kernel execute from non-executable
memory at virtual address ffff80000a516530
[ 3.728032] Mem abort info:
[ 3.728308] ESR = 0x000000008600000f
[ 3.728667] EC = 0x21: IABT (current EL), IL = 32 bits
[ 3.729169] SET = 0, FnV = 0
[ 3.729466] EA = 0, S1PTW = 0
[ 3.729770] FSC = 0x0f: level 3 permission fault
[ 3.730223] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000005f42000
[ 3.730846] [ffff80000a516530] pgd=10000000f7fff003,
p4d=10000000f7fff003, pud=10000000f7ffe003, pmd=10000000f7ff9003,
pte=0078000006516f03
[ 3.732063] Internal error: Oops: 8600000f [#1] PREEMPT SMP
[ 3.732588] Modules linked in:
[ 3.732918] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.0.0-rc1+ #730
[ 3.733532] Hardware name: 96boards Rock960 (DT)
[ 3.733971] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS
BTYPE=--)
[ 3.734635] pc : extcon_dev_list+0x0/0x10
[ 3.735056] lr : call_timer_fn.constprop.0+0x24/0x80
[ 3.735551] sp : ffff80000a733ab0
[ 3.735869] x29: ffff80000a733ab0 x28: 0000000000000005 x27:
ffff80000a516530
[ 3.736574] x26: ffff80000a3779c0 x25: ffff0000f776dde8 x24:
ffff80000a733b40
[ 3.737277] x23: 0000000000000000 x22: dead000000000122 x21:
0000000000000101
[ 3.737977] x20: ffff000000644600 x19: ffff80000a516530 x18:
ffffffffffffffff
[ 3.738677] x17: ffff8000ed713000 x16: ffff80000800c000 x15:
0000000000004000
[ 3.739377] x14: 0000000000000000 x13: 0000000000000000 x12:
0000000000000000
[ 3.740073] x11: 00000000000000b7 x10: ffff8000ed713000 x9 :
ffff0000f776de30
[ 3.740771] x8 : 0000000000000001 x7 : ffffffffffffffff x6 :
0000000000000000
[ 3.741469] x5 : 0000000000000000 x4 : 0000000000000000 x3 :
0000000000000200
[ 3.742164] x2 : 0000000000000200 x1 : ffff80000a516530 x0 :
ffff0000007e7310
[ 3.742865] Call trace:
[ 3.743107] extcon_dev_list+0x0/0x10
[ 3.743477] __run_timers.part.0+0x1f0/0x234
[ 3.743908] run_timer_softirq+0x3c/0x7c
[ 3.744306] _stext+0x124/0x2a4
[ 3.744627] __irq_exit_rcu+0xcc/0xfc
[ 3.745008] irq_exit_rcu+0x10/0x20
[ 3.745372] el1_interrupt+0x38/0x70
[ 3.745733] el1h_64_irq_handler+0x18/0x24
[ 3.746140] el1h_64_irq+0x64/0x68
[ 3.746484] arch_cpu_idle+0x18/0x2c
[ 3.746843] default_idle_call+0x34/0x70
[ 3.747243] do_idle+0x240/0x2bc
[ 3.747576] cpu_startup_entry+0x24/0x30
[ 3.747969] secondary_start_kernel+0x12c/0x140
[ 3.748421] __secondary_switched+0xb0/0xb4
[ 3.748879] Code: 0a516520 ffff8000 0a516520 ffff8000 (007e7320)
[ 3.749461] ---[ end trace 0000000000000000 ]---
[ 3.749911] Kernel panic - not syncing: Oops: Fatal exception in
interrupt
[ 3.750548] SMP: stopping secondary CPUs
[ 3.751094] Kernel Offset: 0x80000 from 0xffff800008000000
[ 3.751609] PHYS_OFFSET: 0x0
[ 3.751889] CPU features: 0x2000,0824f021,00001082
[ 3.752354] Memory Limit: none
[ 3.752655] ---[ end Kernel panic - not syncing: Oops: Fatal
exception in interrupt ]---
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: v6.0-rc6 - arm64 / rock960 : kernel panic
2022-09-24 18:48 ` Daniel Lezcano
@ 2022-09-24 19:33 ` Michael Nazzareno Trimarchi
-1 siblings, 0 replies; 20+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-09-24 19:33 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Heiko St??bner, Greg Kroah-Hartman, Linux Kernel Mailing List,
open list:ARM/Rockchip SoC...,
Thomas Gleixner
On Sat, Sep 24, 2022 at 8:48 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 24/09/2022 20:01, Michael Nazzareno Trimarchi wrote:
> > On Sat, Sep 24, 2022 at 7:58 PM Michael Nazzareno Trimarchi
> > <michael@amarulasolutions.com> wrote:
> >>
> >> Hi Daniel
> >>
> >> On Sat, Sep 24, 2022 at 7:43 PM Daniel Lezcano
> >> <daniel.lezcano@linaro.org> wrote:
> >>>
> >>> Hi,
> >>>
> >>> there is a kernel panic on a rock960 board:
> >>>
> >>> After git bisecting, I have:
> >>>
> >>> commit 14facbc1871ae15404666747b5319c08e04b875a
> >>> Merge: f5c97da8037b 32346491ddf2
> >>> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >>> Date: Mon Jul 11 08:32:58 2022 +0200
> >>>
> >>> Merge 5.19-rc6 into char-misc-next
> >>>
> >>> We need the misc driver fixes in here as well.
> >>>
> >>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >>>
> >>> Any clue?
> >>
> >> That code receive 3-4 commits for one fix
> >>
> >> diff --git a/sound/soc/rockchip/rockchip_i2s.c
> >> b/sound/soc/rockchip/rockchip_i2s.c
> >> index f5f3540a9e18..a32a45b09b03 100644
> >> --- a/sound/soc/rockchip/rockchip_i2s.c
> >> +++ b/sound/soc/rockchip/rockchip_i2s.c
> >> @@ -803,7 +803,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
> >>
> >> i2s->bclk_ratio = 64;
> >> i2s->pinctrl = devm_pinctrl_get(&pdev->dev);
> >> - if (!IS_ERR(i2s->pinctrl)) {
> >> + if (!IS_ERR_OR_NULL(i2s->pinctrl)) {
> >> i2s->bclk_on = pinctrl_lookup_state(i2s->pinctrl, "bclk_on");
> >> if (!IS_ERR_OR_NULL(i2s->bclk_on)) {
> >> i2s->bclk_off =
> >> pinctrl_lookup_state(i2s->pinctrl, "bclk_off");
> >
> > I don't sure if you can get null from there, but you have two
> > lookup_state on that function
>
>
> Hmm, actually, I think it is not the same kernel panic I'm observing on
> v6.0-rc6.
>
> I've been puzzled by different kernel panics from different issues when
> git bisecting.
>
> The one happening is:
>
> [ 2.471037] rk808-rtc rk808-rtc: setting system clock to
> 2022-09-24T18:41:07 UTC (1664044867)
> [ 2.485859] usbcore: registered new interface driver uvcvideo
> [ 3.726846] Unable to handle kernel execute from non-executable
> memory at virtual address ffff80000a516530
> [ 3.728032] Mem abort info:
> [ 3.728308] ESR = 0x000000008600000f
> [ 3.728667] EC = 0x21: IABT (current EL), IL = 32 bits
> [ 3.729169] SET = 0, FnV = 0
> [ 3.729466] EA = 0, S1PTW = 0
> [ 3.729770] FSC = 0x0f: level 3 permission fault
> [ 3.730223] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000005f42000
> [ 3.730846] [ffff80000a516530] pgd=10000000f7fff003,
> p4d=10000000f7fff003, pud=10000000f7ffe003, pmd=10000000f7ff9003,
> pte=0078000006516f03
> [ 3.732063] Internal error: Oops: 8600000f [#1] PREEMPT SMP
> [ 3.732588] Modules linked in:
> [ 3.732918] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.0.0-rc1+ #730
> [ 3.733532] Hardware name: 96boards Rock960 (DT)
> [ 3.733971] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS
> BTYPE=--)
> [ 3.734635] pc : extcon_dev_list+0x0/0x10
> [ 3.735056] lr : call_timer_fn.constprop.0+0x24/0x80
> [ 3.735551] sp : ffff80000a733ab0
> [ 3.735869] x29: ffff80000a733ab0 x28: 0000000000000005 x27:
> ffff80000a516530
> [ 3.736574] x26: ffff80000a3779c0 x25: ffff0000f776dde8 x24:
> ffff80000a733b40
> [ 3.737277] x23: 0000000000000000 x22: dead000000000122 x21:
> 0000000000000101
> [ 3.737977] x20: ffff000000644600 x19: ffff80000a516530 x18:
> ffffffffffffffff
> [ 3.738677] x17: ffff8000ed713000 x16: ffff80000800c000 x15:
> 0000000000004000
> [ 3.739377] x14: 0000000000000000 x13: 0000000000000000 x12:
> 0000000000000000
> [ 3.740073] x11: 00000000000000b7 x10: ffff8000ed713000 x9 :
> ffff0000f776de30
> [ 3.740771] x8 : 0000000000000001 x7 : ffffffffffffffff x6 :
> 0000000000000000
> [ 3.741469] x5 : 0000000000000000 x4 : 0000000000000000 x3 :
> 0000000000000200
> [ 3.742164] x2 : 0000000000000200 x1 : ffff80000a516530 x0 :
> ffff0000007e7310
> [ 3.742865] Call trace:
> [ 3.743107] extcon_dev_list+0x0/0x10
> [ 3.743477] __run_timers.part.0+0x1f0/0x234
> [ 3.743908] run_timer_softirq+0x3c/0x7c
> [ 3.744306] _stext+0x124/0x2a4
> [ 3.744627] __irq_exit_rcu+0xcc/0xfc
> [ 3.745008] irq_exit_rcu+0x10/0x20
> [ 3.745372] el1_interrupt+0x38/0x70
> [ 3.745733] el1h_64_irq_handler+0x18/0x24
> [ 3.746140] el1h_64_irq+0x64/0x68
> [ 3.746484] arch_cpu_idle+0x18/0x2c
> [ 3.746843] default_idle_call+0x34/0x70
> [ 3.747243] do_idle+0x240/0x2bc
> [ 3.747576] cpu_startup_entry+0x24/0x30
> [ 3.747969] secondary_start_kernel+0x12c/0x140
> [ 3.748421] __secondary_switched+0xb0/0xb4
> [ 3.748879] Code: 0a516520 ffff8000 0a516520 ffff8000 (007e7320)
> [ 3.749461] ---[ end trace 0000000000000000 ]---
> [ 3.749911] Kernel panic - not syncing: Oops: Fatal exception in
> interrupt
Now it's totally different. Anyway, my last comment was wrong totally
Michael
> [ 3.750548] SMP: stopping secondary CPUs
> [ 3.751094] Kernel Offset: 0x80000 from 0xffff800008000000
> [ 3.751609] PHYS_OFFSET: 0x0
> [ 3.751889] CPU features: 0x2000,0824f021,00001082
> [ 3.752354] Memory Limit: none
> [ 3.752655] ---[ end Kernel panic - not syncing: Oops: Fatal
> exception in interrupt ]---
>
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: v6.0-rc6 - arm64 / rock960 : kernel panic
@ 2022-09-24 19:33 ` Michael Nazzareno Trimarchi
0 siblings, 0 replies; 20+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-09-24 19:33 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Heiko St??bner, Greg Kroah-Hartman, Linux Kernel Mailing List,
open list:ARM/Rockchip SoC...,
Thomas Gleixner
On Sat, Sep 24, 2022 at 8:48 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 24/09/2022 20:01, Michael Nazzareno Trimarchi wrote:
> > On Sat, Sep 24, 2022 at 7:58 PM Michael Nazzareno Trimarchi
> > <michael@amarulasolutions.com> wrote:
> >>
> >> Hi Daniel
> >>
> >> On Sat, Sep 24, 2022 at 7:43 PM Daniel Lezcano
> >> <daniel.lezcano@linaro.org> wrote:
> >>>
> >>> Hi,
> >>>
> >>> there is a kernel panic on a rock960 board:
> >>>
> >>> After git bisecting, I have:
> >>>
> >>> commit 14facbc1871ae15404666747b5319c08e04b875a
> >>> Merge: f5c97da8037b 32346491ddf2
> >>> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >>> Date: Mon Jul 11 08:32:58 2022 +0200
> >>>
> >>> Merge 5.19-rc6 into char-misc-next
> >>>
> >>> We need the misc driver fixes in here as well.
> >>>
> >>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >>>
> >>> Any clue?
> >>
> >> That code receive 3-4 commits for one fix
> >>
> >> diff --git a/sound/soc/rockchip/rockchip_i2s.c
> >> b/sound/soc/rockchip/rockchip_i2s.c
> >> index f5f3540a9e18..a32a45b09b03 100644
> >> --- a/sound/soc/rockchip/rockchip_i2s.c
> >> +++ b/sound/soc/rockchip/rockchip_i2s.c
> >> @@ -803,7 +803,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
> >>
> >> i2s->bclk_ratio = 64;
> >> i2s->pinctrl = devm_pinctrl_get(&pdev->dev);
> >> - if (!IS_ERR(i2s->pinctrl)) {
> >> + if (!IS_ERR_OR_NULL(i2s->pinctrl)) {
> >> i2s->bclk_on = pinctrl_lookup_state(i2s->pinctrl, "bclk_on");
> >> if (!IS_ERR_OR_NULL(i2s->bclk_on)) {
> >> i2s->bclk_off =
> >> pinctrl_lookup_state(i2s->pinctrl, "bclk_off");
> >
> > I don't sure if you can get null from there, but you have two
> > lookup_state on that function
>
>
> Hmm, actually, I think it is not the same kernel panic I'm observing on
> v6.0-rc6.
>
> I've been puzzled by different kernel panics from different issues when
> git bisecting.
>
> The one happening is:
>
> [ 2.471037] rk808-rtc rk808-rtc: setting system clock to
> 2022-09-24T18:41:07 UTC (1664044867)
> [ 2.485859] usbcore: registered new interface driver uvcvideo
> [ 3.726846] Unable to handle kernel execute from non-executable
> memory at virtual address ffff80000a516530
> [ 3.728032] Mem abort info:
> [ 3.728308] ESR = 0x000000008600000f
> [ 3.728667] EC = 0x21: IABT (current EL), IL = 32 bits
> [ 3.729169] SET = 0, FnV = 0
> [ 3.729466] EA = 0, S1PTW = 0
> [ 3.729770] FSC = 0x0f: level 3 permission fault
> [ 3.730223] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000005f42000
> [ 3.730846] [ffff80000a516530] pgd=10000000f7fff003,
> p4d=10000000f7fff003, pud=10000000f7ffe003, pmd=10000000f7ff9003,
> pte=0078000006516f03
> [ 3.732063] Internal error: Oops: 8600000f [#1] PREEMPT SMP
> [ 3.732588] Modules linked in:
> [ 3.732918] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 6.0.0-rc1+ #730
> [ 3.733532] Hardware name: 96boards Rock960 (DT)
> [ 3.733971] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS
> BTYPE=--)
> [ 3.734635] pc : extcon_dev_list+0x0/0x10
> [ 3.735056] lr : call_timer_fn.constprop.0+0x24/0x80
> [ 3.735551] sp : ffff80000a733ab0
> [ 3.735869] x29: ffff80000a733ab0 x28: 0000000000000005 x27:
> ffff80000a516530
> [ 3.736574] x26: ffff80000a3779c0 x25: ffff0000f776dde8 x24:
> ffff80000a733b40
> [ 3.737277] x23: 0000000000000000 x22: dead000000000122 x21:
> 0000000000000101
> [ 3.737977] x20: ffff000000644600 x19: ffff80000a516530 x18:
> ffffffffffffffff
> [ 3.738677] x17: ffff8000ed713000 x16: ffff80000800c000 x15:
> 0000000000004000
> [ 3.739377] x14: 0000000000000000 x13: 0000000000000000 x12:
> 0000000000000000
> [ 3.740073] x11: 00000000000000b7 x10: ffff8000ed713000 x9 :
> ffff0000f776de30
> [ 3.740771] x8 : 0000000000000001 x7 : ffffffffffffffff x6 :
> 0000000000000000
> [ 3.741469] x5 : 0000000000000000 x4 : 0000000000000000 x3 :
> 0000000000000200
> [ 3.742164] x2 : 0000000000000200 x1 : ffff80000a516530 x0 :
> ffff0000007e7310
> [ 3.742865] Call trace:
> [ 3.743107] extcon_dev_list+0x0/0x10
> [ 3.743477] __run_timers.part.0+0x1f0/0x234
> [ 3.743908] run_timer_softirq+0x3c/0x7c
> [ 3.744306] _stext+0x124/0x2a4
> [ 3.744627] __irq_exit_rcu+0xcc/0xfc
> [ 3.745008] irq_exit_rcu+0x10/0x20
> [ 3.745372] el1_interrupt+0x38/0x70
> [ 3.745733] el1h_64_irq_handler+0x18/0x24
> [ 3.746140] el1h_64_irq+0x64/0x68
> [ 3.746484] arch_cpu_idle+0x18/0x2c
> [ 3.746843] default_idle_call+0x34/0x70
> [ 3.747243] do_idle+0x240/0x2bc
> [ 3.747576] cpu_startup_entry+0x24/0x30
> [ 3.747969] secondary_start_kernel+0x12c/0x140
> [ 3.748421] __secondary_switched+0xb0/0xb4
> [ 3.748879] Code: 0a516520 ffff8000 0a516520 ffff8000 (007e7320)
> [ 3.749461] ---[ end trace 0000000000000000 ]---
> [ 3.749911] Kernel panic - not syncing: Oops: Fatal exception in
> interrupt
Now it's totally different. Anyway, my last comment was wrong totally
Michael
> [ 3.750548] SMP: stopping secondary CPUs
> [ 3.751094] Kernel Offset: 0x80000 from 0xffff800008000000
> [ 3.751609] PHYS_OFFSET: 0x0
> [ 3.751889] CPU features: 0x2000,0824f021,00001082
> [ 3.752354] Memory Limit: none
> [ 3.752655] ---[ end Kernel panic - not syncing: Oops: Fatal
> exception in interrupt ]---
>
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: v6.0-rc6 - arm64 / rock960 : kernel panic
2022-09-24 19:33 ` Michael Nazzareno Trimarchi
@ 2022-09-25 21:51 ` Daniel Lezcano
-1 siblings, 0 replies; 20+ messages in thread
From: Daniel Lezcano @ 2022-09-25 21:51 UTC (permalink / raw)
To: Peter Geis, Heiko St??bner, Samuel Holland, Vinod Koul
Cc: Linux Kernel Mailing List, open list:ARM/Rockchip SoC...,
Michael Nazzareno Trimarchi
Hi,
after a painful git bisect, the kernel panic happens with:
commit 8dc60f8da22fdbaa1fafcfb5ff6d24bc9eff56aa (refs/bisect/bad)
Author: Peter Geis <pgwipeout@gmail.com>
Date: Tue Jun 21 20:31:40 2022 -0400
phy: rockchip-inno-usb2: Sync initial otg state
The initial otg state for the phy defaults to device mode. The actual
state isn't detected until an ID IRQ fires. Fix this by syncing the ID
state during initialization.
Fixes: 51a9b2c03dd3 ("phy: rockchip-inno-usb2: Handle ID IRQ")
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
Reviewed-by: Samuel Holland <samuel@sholland.org>
Link:
https://lore.kernel.org/r/20220622003140.30365-1-pgwipeout@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reverting it fixes the issue
=======================================================================
@@@@`0` @`@@ @@@@@@@[ 3.566365] Unable to handle kernel NULL pointer
dereference at virtual address 0000000000000000
[ 3.567182] Mem abort info:
[ 3.567440] ESR = 0x0000000086000006
[ 3.567783] EC = 0x21: IABT (current EL), IL = 32 bits
[ 3.568264] SET = 0, FnV = 0
[ 3.568544] EA = 0, S1PTW = 0
[ 3.568833] FSC = 0x06: level 2 translation fault
[ 3.569275] user pgtable: 4k pages, 48-bit VAs, pgdp=00000000024be000
[ 3.569854] [0000000000000000] pgd=0800000001725003,
p4d=0800000001725003, pud=0800000000f11003, pmd=0000000000000000
[ 3.570912] Internal error: Oops: 86000006 [#1] PREEMPT SMP
[ 3.571421] Modules linked in:
[ 3.571712] CPU: 3 PID: 0 Comm: swapper/3 Not tainted 5.19.0-rc1+ #795
[ 3.572303] Hardware name: 96boards Rock960 (DT)
[ 3.572722] pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS
BTYPE=--)
[ 3.573354] pc : 0x0
[ 3.573567] lr : call_timer_fn.constprop.0+0x24/0x80
[ 3.574037] sp : ffff80000a703a50
[ 3.574339] x29: ffff80000a703a50 x28: 0000000000000005 x27:
0000000000000000
[ 3.575002] x26: ffff80000a3379c0 x25: ffff0000f7798de8 x24:
ffff80000a703ae0
[ 3.575664] x23: 0000000000000000 x22: dead000000000122 x21:
0000000000000101
[ 3.576325] x20: ffff0000006b6200 x19: 0000000000000000 x18:
0000000000000000
[ 3.576986] x17: ffff8000ed773000 x16: ffff80000801c000 x15:
00003d0900007d00
[ 3.577648] x14: 0000000000000000 x13: 0000000000000000 x12:
0000000000000000
[ 3.578308] x11: 0000000000000004 x10: ffff8000ed773000 x9 :
ffff0000f7798e30
[ 3.578970] x8 : 0000000000000001 x7 : ffffffffffffffff x6 :
0000000000000000
[ 3.579630] x5 : 0000000000000000 x4 : 0000000000000000 x3 :
0000000000000200
[ 3.580290] x2 : 0000000000000200 x1 : 0000000000000000 x0 :
ffff000001025310
[ 3.580951] Call trace:
[ 3.581178] 0x0
[ 3.581359] __run_timers.part.0+0x1f0/0x234
[ 3.581759] run_timer_softirq+0x3c/0x7c
[ 3.582130] _stext+0x124/0x2a0
[ 3.582430] __irq_exit_rcu+0xe4/0x100
[ 3.582790] irq_exit_rcu+0x10/0x1c
[ 3.583117] el1_interrupt+0x38/0x70
[ 3.583454] el1h_64_irq_handler+0x18/0x24
[ 3.583835] el1h_64_irq+0x64/0x68
[ 3.584156] cpuidle_enter_state+0x130/0x2f0
[ 3.584560] cpuidle_enter+0x38/0x50
[ 3.584901] do_idle+0x214/0x29c
[ 3.585210] cpu_startup_entry+0x28/0x30
[ 3.585578] secondary_start_kernel+0x13c/0x150
[ 3.586002] __secondary_switched+0xa0/0xa4
[ 3.586408] Code: bad PC value
[ 3.586699] ---[ end trace 0000000000000000 ]---
[ 3.587119] Kernel panic - not syncing: Oops: Fatal exception in
interrupt
[ 3.587732] SMP: stopping secondary CPUs
[ 3.588230] Kernel Offset: 0x80000 from 0xffff800008000000
[ 3.588725] PHYS_OFFSET: 0x0
[ 3.588991] CPU features: 0x800,00127811,00001082
[ 3.589420] Memory Limit: none
[ 3.589724] ---[ end Kernel panic - not syncing: Oops: Fatal
exception in interrupt ]---
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: v6.0-rc6 - arm64 / rock960 : kernel panic
@ 2022-09-25 21:51 ` Daniel Lezcano
0 siblings, 0 replies; 20+ messages in thread
From: Daniel Lezcano @ 2022-09-25 21:51 UTC (permalink / raw)
To: Peter Geis, Heiko St??bner, Samuel Holland, Vinod Koul
Cc: Linux Kernel Mailing List, open list:ARM/Rockchip SoC...,
Michael Nazzareno Trimarchi
Hi,
after a painful git bisect, the kernel panic happens with:
commit 8dc60f8da22fdbaa1fafcfb5ff6d24bc9eff56aa (refs/bisect/bad)
Author: Peter Geis <pgwipeout@gmail.com>
Date: Tue Jun 21 20:31:40 2022 -0400
phy: rockchip-inno-usb2: Sync initial otg state
The initial otg state for the phy defaults to device mode. The actual
state isn't detected until an ID IRQ fires. Fix this by syncing the ID
state during initialization.
Fixes: 51a9b2c03dd3 ("phy: rockchip-inno-usb2: Handle ID IRQ")
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
Reviewed-by: Samuel Holland <samuel@sholland.org>
Link:
https://lore.kernel.org/r/20220622003140.30365-1-pgwipeout@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reverting it fixes the issue
=======================================================================
@@@@`0` @`@@ @@@@@@@[ 3.566365] Unable to handle kernel NULL pointer
dereference at virtual address 0000000000000000
[ 3.567182] Mem abort info:
[ 3.567440] ESR = 0x0000000086000006
[ 3.567783] EC = 0x21: IABT (current EL), IL = 32 bits
[ 3.568264] SET = 0, FnV = 0
[ 3.568544] EA = 0, S1PTW = 0
[ 3.568833] FSC = 0x06: level 2 translation fault
[ 3.569275] user pgtable: 4k pages, 48-bit VAs, pgdp=00000000024be000
[ 3.569854] [0000000000000000] pgd=0800000001725003,
p4d=0800000001725003, pud=0800000000f11003, pmd=0000000000000000
[ 3.570912] Internal error: Oops: 86000006 [#1] PREEMPT SMP
[ 3.571421] Modules linked in:
[ 3.571712] CPU: 3 PID: 0 Comm: swapper/3 Not tainted 5.19.0-rc1+ #795
[ 3.572303] Hardware name: 96boards Rock960 (DT)
[ 3.572722] pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS
BTYPE=--)
[ 3.573354] pc : 0x0
[ 3.573567] lr : call_timer_fn.constprop.0+0x24/0x80
[ 3.574037] sp : ffff80000a703a50
[ 3.574339] x29: ffff80000a703a50 x28: 0000000000000005 x27:
0000000000000000
[ 3.575002] x26: ffff80000a3379c0 x25: ffff0000f7798de8 x24:
ffff80000a703ae0
[ 3.575664] x23: 0000000000000000 x22: dead000000000122 x21:
0000000000000101
[ 3.576325] x20: ffff0000006b6200 x19: 0000000000000000 x18:
0000000000000000
[ 3.576986] x17: ffff8000ed773000 x16: ffff80000801c000 x15:
00003d0900007d00
[ 3.577648] x14: 0000000000000000 x13: 0000000000000000 x12:
0000000000000000
[ 3.578308] x11: 0000000000000004 x10: ffff8000ed773000 x9 :
ffff0000f7798e30
[ 3.578970] x8 : 0000000000000001 x7 : ffffffffffffffff x6 :
0000000000000000
[ 3.579630] x5 : 0000000000000000 x4 : 0000000000000000 x3 :
0000000000000200
[ 3.580290] x2 : 0000000000000200 x1 : 0000000000000000 x0 :
ffff000001025310
[ 3.580951] Call trace:
[ 3.581178] 0x0
[ 3.581359] __run_timers.part.0+0x1f0/0x234
[ 3.581759] run_timer_softirq+0x3c/0x7c
[ 3.582130] _stext+0x124/0x2a0
[ 3.582430] __irq_exit_rcu+0xe4/0x100
[ 3.582790] irq_exit_rcu+0x10/0x1c
[ 3.583117] el1_interrupt+0x38/0x70
[ 3.583454] el1h_64_irq_handler+0x18/0x24
[ 3.583835] el1h_64_irq+0x64/0x68
[ 3.584156] cpuidle_enter_state+0x130/0x2f0
[ 3.584560] cpuidle_enter+0x38/0x50
[ 3.584901] do_idle+0x214/0x29c
[ 3.585210] cpu_startup_entry+0x28/0x30
[ 3.585578] secondary_start_kernel+0x13c/0x150
[ 3.586002] __secondary_switched+0xa0/0xa4
[ 3.586408] Code: bad PC value
[ 3.586699] ---[ end trace 0000000000000000 ]---
[ 3.587119] Kernel panic - not syncing: Oops: Fatal exception in
interrupt
[ 3.587732] SMP: stopping secondary CPUs
[ 3.588230] Kernel Offset: 0x80000 from 0xffff800008000000
[ 3.588725] PHYS_OFFSET: 0x0
[ 3.588991] CPU features: 0x800,00127811,00001082
[ 3.589420] Memory Limit: none
[ 3.589724] ---[ end Kernel panic - not syncing: Oops: Fatal
exception in interrupt ]---
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: v6.0-rc6 - arm64 / rock960 : kernel panic
2022-09-25 21:51 ` Daniel Lezcano
@ 2022-09-26 1:43 ` Peter Geis
-1 siblings, 0 replies; 20+ messages in thread
From: Peter Geis @ 2022-09-26 1:43 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Heiko St??bner, Samuel Holland, Vinod Koul,
Linux Kernel Mailing List, open list:ARM/Rockchip SoC...,
Michael Nazzareno Trimarchi
On Sun, Sep 25, 2022 at 5:51 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
>
> Hi,
>
> after a painful git bisect, the kernel panic happens with:
>
> commit 8dc60f8da22fdbaa1fafcfb5ff6d24bc9eff56aa (refs/bisect/bad)
> Author: Peter Geis <pgwipeout@gmail.com>
> Date: Tue Jun 21 20:31:40 2022 -0400
>
> phy: rockchip-inno-usb2: Sync initial otg state
>
> The initial otg state for the phy defaults to device mode. The actual
> state isn't detected until an ID IRQ fires. Fix this by syncing the ID
> state during initialization.
>
> Fixes: 51a9b2c03dd3 ("phy: rockchip-inno-usb2: Handle ID IRQ")
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> Reviewed-by: Samuel Holland <samuel@sholland.org>
> Link:
> https://lore.kernel.org/r/20220622003140.30365-1-pgwipeout@gmail.com
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
>
> Reverting it fixes the issue
Good Evening,
A fix has been submitted and accepted, it is currently sitting in -next:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/patch/drivers/phy/rockchip/phy-rockchip-inno-usb2.c?id=f340ed8664a55a467850ec1689996e63d9ee971a
Very Respectfully,
Peter
>
> =======================================================================
>
> @@@@`0` @`@@ @@@@@@@[ 3.566365] Unable to handle kernel NULL pointer
> dereference at virtual address 0000000000000000
> [ 3.567182] Mem abort info:
> [ 3.567440] ESR = 0x0000000086000006
> [ 3.567783] EC = 0x21: IABT (current EL), IL = 32 bits
> [ 3.568264] SET = 0, FnV = 0
> [ 3.568544] EA = 0, S1PTW = 0
> [ 3.568833] FSC = 0x06: level 2 translation fault
> [ 3.569275] user pgtable: 4k pages, 48-bit VAs, pgdp=00000000024be000
> [ 3.569854] [0000000000000000] pgd=0800000001725003,
> p4d=0800000001725003, pud=0800000000f11003, pmd=0000000000000000
> [ 3.570912] Internal error: Oops: 86000006 [#1] PREEMPT SMP
> [ 3.571421] Modules linked in:
> [ 3.571712] CPU: 3 PID: 0 Comm: swapper/3 Not tainted 5.19.0-rc1+ #795
> [ 3.572303] Hardware name: 96boards Rock960 (DT)
> [ 3.572722] pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS
> BTYPE=--)
> [ 3.573354] pc : 0x0
> [ 3.573567] lr : call_timer_fn.constprop.0+0x24/0x80
> [ 3.574037] sp : ffff80000a703a50
> [ 3.574339] x29: ffff80000a703a50 x28: 0000000000000005 x27:
> 0000000000000000
> [ 3.575002] x26: ffff80000a3379c0 x25: ffff0000f7798de8 x24:
> ffff80000a703ae0
> [ 3.575664] x23: 0000000000000000 x22: dead000000000122 x21:
> 0000000000000101
> [ 3.576325] x20: ffff0000006b6200 x19: 0000000000000000 x18:
> 0000000000000000
> [ 3.576986] x17: ffff8000ed773000 x16: ffff80000801c000 x15:
> 00003d0900007d00
> [ 3.577648] x14: 0000000000000000 x13: 0000000000000000 x12:
> 0000000000000000
> [ 3.578308] x11: 0000000000000004 x10: ffff8000ed773000 x9 :
> ffff0000f7798e30
> [ 3.578970] x8 : 0000000000000001 x7 : ffffffffffffffff x6 :
> 0000000000000000
> [ 3.579630] x5 : 0000000000000000 x4 : 0000000000000000 x3 :
> 0000000000000200
> [ 3.580290] x2 : 0000000000000200 x1 : 0000000000000000 x0 :
> ffff000001025310
> [ 3.580951] Call trace:
> [ 3.581178] 0x0
> [ 3.581359] __run_timers.part.0+0x1f0/0x234
> [ 3.581759] run_timer_softirq+0x3c/0x7c
> [ 3.582130] _stext+0x124/0x2a0
> [ 3.582430] __irq_exit_rcu+0xe4/0x100
> [ 3.582790] irq_exit_rcu+0x10/0x1c
> [ 3.583117] el1_interrupt+0x38/0x70
> [ 3.583454] el1h_64_irq_handler+0x18/0x24
> [ 3.583835] el1h_64_irq+0x64/0x68
> [ 3.584156] cpuidle_enter_state+0x130/0x2f0
> [ 3.584560] cpuidle_enter+0x38/0x50
> [ 3.584901] do_idle+0x214/0x29c
> [ 3.585210] cpu_startup_entry+0x28/0x30
> [ 3.585578] secondary_start_kernel+0x13c/0x150
> [ 3.586002] __secondary_switched+0xa0/0xa4
> [ 3.586408] Code: bad PC value
> [ 3.586699] ---[ end trace 0000000000000000 ]---
> [ 3.587119] Kernel panic - not syncing: Oops: Fatal exception in
> interrupt
> [ 3.587732] SMP: stopping secondary CPUs
> [ 3.588230] Kernel Offset: 0x80000 from 0xffff800008000000
> [ 3.588725] PHYS_OFFSET: 0x0
> [ 3.588991] CPU features: 0x800,00127811,00001082
> [ 3.589420] Memory Limit: none
> [ 3.589724] ---[ end Kernel panic - not syncing: Oops: Fatal
> exception in interrupt ]---
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: v6.0-rc6 - arm64 / rock960 : kernel panic
@ 2022-09-26 1:43 ` Peter Geis
0 siblings, 0 replies; 20+ messages in thread
From: Peter Geis @ 2022-09-26 1:43 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Heiko St??bner, Samuel Holland, Vinod Koul,
Linux Kernel Mailing List, open list:ARM/Rockchip SoC...,
Michael Nazzareno Trimarchi
On Sun, Sep 25, 2022 at 5:51 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
>
> Hi,
>
> after a painful git bisect, the kernel panic happens with:
>
> commit 8dc60f8da22fdbaa1fafcfb5ff6d24bc9eff56aa (refs/bisect/bad)
> Author: Peter Geis <pgwipeout@gmail.com>
> Date: Tue Jun 21 20:31:40 2022 -0400
>
> phy: rockchip-inno-usb2: Sync initial otg state
>
> The initial otg state for the phy defaults to device mode. The actual
> state isn't detected until an ID IRQ fires. Fix this by syncing the ID
> state during initialization.
>
> Fixes: 51a9b2c03dd3 ("phy: rockchip-inno-usb2: Handle ID IRQ")
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> Reviewed-by: Samuel Holland <samuel@sholland.org>
> Link:
> https://lore.kernel.org/r/20220622003140.30365-1-pgwipeout@gmail.com
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
>
> Reverting it fixes the issue
Good Evening,
A fix has been submitted and accepted, it is currently sitting in -next:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/patch/drivers/phy/rockchip/phy-rockchip-inno-usb2.c?id=f340ed8664a55a467850ec1689996e63d9ee971a
Very Respectfully,
Peter
>
> =======================================================================
>
> @@@@`0` @`@@ @@@@@@@[ 3.566365] Unable to handle kernel NULL pointer
> dereference at virtual address 0000000000000000
> [ 3.567182] Mem abort info:
> [ 3.567440] ESR = 0x0000000086000006
> [ 3.567783] EC = 0x21: IABT (current EL), IL = 32 bits
> [ 3.568264] SET = 0, FnV = 0
> [ 3.568544] EA = 0, S1PTW = 0
> [ 3.568833] FSC = 0x06: level 2 translation fault
> [ 3.569275] user pgtable: 4k pages, 48-bit VAs, pgdp=00000000024be000
> [ 3.569854] [0000000000000000] pgd=0800000001725003,
> p4d=0800000001725003, pud=0800000000f11003, pmd=0000000000000000
> [ 3.570912] Internal error: Oops: 86000006 [#1] PREEMPT SMP
> [ 3.571421] Modules linked in:
> [ 3.571712] CPU: 3 PID: 0 Comm: swapper/3 Not tainted 5.19.0-rc1+ #795
> [ 3.572303] Hardware name: 96boards Rock960 (DT)
> [ 3.572722] pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS
> BTYPE=--)
> [ 3.573354] pc : 0x0
> [ 3.573567] lr : call_timer_fn.constprop.0+0x24/0x80
> [ 3.574037] sp : ffff80000a703a50
> [ 3.574339] x29: ffff80000a703a50 x28: 0000000000000005 x27:
> 0000000000000000
> [ 3.575002] x26: ffff80000a3379c0 x25: ffff0000f7798de8 x24:
> ffff80000a703ae0
> [ 3.575664] x23: 0000000000000000 x22: dead000000000122 x21:
> 0000000000000101
> [ 3.576325] x20: ffff0000006b6200 x19: 0000000000000000 x18:
> 0000000000000000
> [ 3.576986] x17: ffff8000ed773000 x16: ffff80000801c000 x15:
> 00003d0900007d00
> [ 3.577648] x14: 0000000000000000 x13: 0000000000000000 x12:
> 0000000000000000
> [ 3.578308] x11: 0000000000000004 x10: ffff8000ed773000 x9 :
> ffff0000f7798e30
> [ 3.578970] x8 : 0000000000000001 x7 : ffffffffffffffff x6 :
> 0000000000000000
> [ 3.579630] x5 : 0000000000000000 x4 : 0000000000000000 x3 :
> 0000000000000200
> [ 3.580290] x2 : 0000000000000200 x1 : 0000000000000000 x0 :
> ffff000001025310
> [ 3.580951] Call trace:
> [ 3.581178] 0x0
> [ 3.581359] __run_timers.part.0+0x1f0/0x234
> [ 3.581759] run_timer_softirq+0x3c/0x7c
> [ 3.582130] _stext+0x124/0x2a0
> [ 3.582430] __irq_exit_rcu+0xe4/0x100
> [ 3.582790] irq_exit_rcu+0x10/0x1c
> [ 3.583117] el1_interrupt+0x38/0x70
> [ 3.583454] el1h_64_irq_handler+0x18/0x24
> [ 3.583835] el1h_64_irq+0x64/0x68
> [ 3.584156] cpuidle_enter_state+0x130/0x2f0
> [ 3.584560] cpuidle_enter+0x38/0x50
> [ 3.584901] do_idle+0x214/0x29c
> [ 3.585210] cpu_startup_entry+0x28/0x30
> [ 3.585578] secondary_start_kernel+0x13c/0x150
> [ 3.586002] __secondary_switched+0xa0/0xa4
> [ 3.586408] Code: bad PC value
> [ 3.586699] ---[ end trace 0000000000000000 ]---
> [ 3.587119] Kernel panic - not syncing: Oops: Fatal exception in
> interrupt
> [ 3.587732] SMP: stopping secondary CPUs
> [ 3.588230] Kernel Offset: 0x80000 from 0xffff800008000000
> [ 3.588725] PHYS_OFFSET: 0x0
> [ 3.588991] CPU features: 0x800,00127811,00001082
> [ 3.589420] Memory Limit: none
> [ 3.589724] ---[ end Kernel panic - not syncing: Oops: Fatal
> exception in interrupt ]---
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: v6.0-rc6 - arm64 / rock960 : kernel panic
2022-09-24 18:01 ` Michael Nazzareno Trimarchi
@ 2022-09-24 18:49 ` Michael Nazzareno Trimarchi
-1 siblings, 0 replies; 20+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-09-24 18:49 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Heiko St??bner, Greg Kroah-Hartman, Linux Kernel Mailing List,
open list:ARM/Rockchip SoC...
Hi
On Sat, Sep 24, 2022 at 8:01 PM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> On Sat, Sep 24, 2022 at 7:58 PM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Hi Daniel
> >
> > On Sat, Sep 24, 2022 at 7:43 PM Daniel Lezcano
> > <daniel.lezcano@linaro.org> wrote:
> > >
> > > Hi,
> > >
> > > there is a kernel panic on a rock960 board:
> > >
> > > After git bisecting, I have:
> > >
> > > commit 14facbc1871ae15404666747b5319c08e04b875a
> > > Merge: f5c97da8037b 32346491ddf2
> > > Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Date: Mon Jul 11 08:32:58 2022 +0200
> > >
> > > Merge 5.19-rc6 into char-misc-next
> > >
> > > We need the misc driver fixes in here as well.
> > >
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >
> > > Any clue?
> >
> > That code receive 3-4 commits for one fix
> >
> > diff --git a/sound/soc/rockchip/rockchip_i2s.c
> > b/sound/soc/rockchip/rockchip_i2s.c
> > index f5f3540a9e18..a32a45b09b03 100644
> > --- a/sound/soc/rockchip/rockchip_i2s.c
> > +++ b/sound/soc/rockchip/rockchip_i2s.c
> > @@ -803,7 +803,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
> >
> > i2s->bclk_ratio = 64;
> > i2s->pinctrl = devm_pinctrl_get(&pdev->dev);
> > - if (!IS_ERR(i2s->pinctrl)) {
> > + if (!IS_ERR_OR_NULL(i2s->pinctrl)) {
> > i2s->bclk_on = pinctrl_lookup_state(i2s->pinctrl, "bclk_on");
> > if (!IS_ERR_OR_NULL(i2s->bclk_on)) {
> > i2s->bclk_off =
> > pinctrl_lookup_state(i2s->pinctrl, "bclk_off");
>
> I don't sure if you can get null from there, but you have two
> lookup_state on that function
>
I navigated a bit the code and states->name of pinctrl->state should
be the offset five where you have the panic.
What is not clear is. If we iterate the map and we don't find the node
ret = pinctrl_dt_to_map(p, pctldev);
if (ret < 0) {
kfree(p);
return ERR_PTR(ret);
}
devname = dev_name(dev);
mutex_lock(&pinctrl_maps_mutex);
/* Iterate over the pin control maps to locate the right ones */
for_each_maps(maps_node, i, map) {
Then add_setting is not called and name is not assigned
Michael
> Michael
> >
> > Michael
> >
> > >
> > >
> > > [ 2.377386] Unable to handle kernel NULL pointer dereference at
> > > virtual address 0000000000000005
> > > [ 2.377390] Mem abort info:
> > > [ 2.377392] ESR = 0x0000000096000004
> > > [ 2.379529] EC = 0x25: DABT (current EL), IL = 32 bits
> > > [ 2.379994] SET = 0, FnV = 0
> > > [ 2.380263] EA = 0, S1PTW = 0
> > > [ 2.380538] FSC = 0x04: level 0 translation fault
> > > [ 2.380964] Data abort info:
> > > [ 2.381217] ISV = 0, ISS = 0x00000004
> > > [ 2.381343] mmc2: SDHCI controller on fe330000.mmc [fe330000.mmc]
> > > using ADMA
> > > [ 2.381558] CM = 0, WnR = 0
> > > [ 2.382426] [0000000000000005] user address but active_mm is swapper
> > > [ 2.382981] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> > > [ 2.383468] Modules linked in:
> > > [ 2.383740] CPU: 4 PID: 1 Comm: swapper/0 Not tainted 5.19.0-rc6+ #728
> > > [ 2.384311] Hardware name: 96boards Rock960 (DT)
> > > [ 2.384715] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS
> > > BTYPE=--)
> > > [ 2.385323] pc : pinctrl_lookup_state+0x20/0xc0
> > > [ 2.385729] lr : rockchip_i2s_probe+0x1a8/0x54c
> > > [ 2.386130] sp : ffff80000804bb30
> > > [ 2.386420] x29: ffff80000804bb30 x28: 0000000000000000 x27:
> > > ffff800009f204c8
> > > [ 2.387048] x26: ffff800009fc1060 x25: ffff800009fc1078 x24:
> > > ffff000002691b68
> > > [ 2.387673] x23: ffff800009967938 x22: ffffffffffffffed x21:
> > > ffff800009e1e0e8
> > > [ 2.388299] x20: ffffffffffffffed x19: ffff000002597480 x18:
> > > ffffffffffffffff
> > > [ 2.388924] x17: 000000040044ffff x16: 00400034b5503510 x15:
> > > ffff80008804b787
> > > [ 2.389550] x14: 0000000000000000 x13: 6c7274636e697020 x12:
> > > 73326920646e6966
> > > [ 2.390176] x11: 206f742064656c69 x10: 6166203a7332692e x9 :
> > > 656c696166203a73
> > > [ 2.390801] x8 : 32692e3030303061 x7 : 205d363238363733 x6 :
> > > ffff000001657880
> > > [ 2.391425] x5 : 0000000000000000 x4 : 0000000000000000 x3 :
> > > 0000000000000000
> > > [ 2.392051] x2 : 0000000000000000 x1 : ffff800009e1e0e8 x0 :
> > > ffffffffffffffed
> > > [ 2.392677] Call trace:
> > > [ 2.392892] pinctrl_lookup_state+0x20/0xc0
> > > [ 2.393261] rockchip_i2s_probe+0x1a8/0x54c
> > > [ 2.393629] platform_probe+0x68/0xe0
> > > [ 2.393954] really_probe.part.0+0x9c/0x2ac
> > > [ 2.394321] __driver_probe_device+0x98/0x144
> > > [ 2.394703] driver_probe_device+0xac/0x140
> > > [ 2.395070] __driver_attach+0xf8/0x1a0
> > > [ 2.395407] bus_for_each_dev+0x70/0xd0
> > > [ 2.395746] driver_attach+0x24/0x30
> > > [ 2.396063] bus_add_driver+0x150/0x200
> > > [ 2.396401] driver_register+0x78/0x130
> > > [ 2.396737] __platform_driver_register+0x28/0x34
> > > [ 2.397150] rockchip_i2s_driver_init+0x1c/0x28
> > > [ 2.397550] do_one_initcall+0x50/0x1c0
> > > [ 2.397890] kernel_init_freeable+0x208/0x28c
> > > [ 2.398274] kernel_init+0x28/0x13c
> > > [ 2.398583] ret_from_fork+0x10/0x20
> > > [ 2.398901] Code: aa0003f4 a9025bf5 aa0003f6 aa0103f5 (f8418e93)
> > > [ 2.399435] ---[ end trace 0000000000000000 ]---
> > > [ 2.399887] Kernel panic - not syncing: Attempted to kill init!
> > > exitcode=0x0000000b
> > > [ 2.400555] SMP: stopping secondary CPUs
> > > [ 2.400984] Kernel Offset: 0x80000 from 0xffff800008000000
> > > [ 2.401463] PHYS_OFFSET: 0x0
> > > [ 2.401716] CPU features: 0x800,00127811,00001082
> > > [ 2.402128] Memory Limit: none
> > > [ 2.402406] ---[ end Kernel panic - not syncing: Attempted to kill
> > > init! exitcode=0x0000000b ]---
> > >
> > >
> > > --
> > > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> > >
> > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> > > <http://twitter.com/#!/linaroorg> Twitter |
> > > <http://www.linaro.org/linaro-blog/> Blog
> > >
> > > _______________________________________________
> > > Linux-rockchip mailing list
> > > Linux-rockchip@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-rockchip
> >
> >
> >
> > --
> > Michael Nazzareno Trimarchi
> > Co-Founder & Chief Executive Officer
> > M. +39 347 913 2170
> > michael@amarulasolutions.com
> > __________________________________
> >
> > Amarula Solutions BV
> > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > T. +31 (0)85 111 9172
> > info@amarulasolutions.com
> > www.amarulasolutions.com
>
>
>
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> michael@amarulasolutions.com
> __________________________________
>
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> info@amarulasolutions.com
> www.amarulasolutions.com
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: v6.0-rc6 - arm64 / rock960 : kernel panic
@ 2022-09-24 18:49 ` Michael Nazzareno Trimarchi
0 siblings, 0 replies; 20+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-09-24 18:49 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Heiko St??bner, Greg Kroah-Hartman, Linux Kernel Mailing List,
open list:ARM/Rockchip SoC...
Hi
On Sat, Sep 24, 2022 at 8:01 PM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> On Sat, Sep 24, 2022 at 7:58 PM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
> >
> > Hi Daniel
> >
> > On Sat, Sep 24, 2022 at 7:43 PM Daniel Lezcano
> > <daniel.lezcano@linaro.org> wrote:
> > >
> > > Hi,
> > >
> > > there is a kernel panic on a rock960 board:
> > >
> > > After git bisecting, I have:
> > >
> > > commit 14facbc1871ae15404666747b5319c08e04b875a
> > > Merge: f5c97da8037b 32346491ddf2
> > > Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Date: Mon Jul 11 08:32:58 2022 +0200
> > >
> > > Merge 5.19-rc6 into char-misc-next
> > >
> > > We need the misc driver fixes in here as well.
> > >
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >
> > > Any clue?
> >
> > That code receive 3-4 commits for one fix
> >
> > diff --git a/sound/soc/rockchip/rockchip_i2s.c
> > b/sound/soc/rockchip/rockchip_i2s.c
> > index f5f3540a9e18..a32a45b09b03 100644
> > --- a/sound/soc/rockchip/rockchip_i2s.c
> > +++ b/sound/soc/rockchip/rockchip_i2s.c
> > @@ -803,7 +803,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
> >
> > i2s->bclk_ratio = 64;
> > i2s->pinctrl = devm_pinctrl_get(&pdev->dev);
> > - if (!IS_ERR(i2s->pinctrl)) {
> > + if (!IS_ERR_OR_NULL(i2s->pinctrl)) {
> > i2s->bclk_on = pinctrl_lookup_state(i2s->pinctrl, "bclk_on");
> > if (!IS_ERR_OR_NULL(i2s->bclk_on)) {
> > i2s->bclk_off =
> > pinctrl_lookup_state(i2s->pinctrl, "bclk_off");
>
> I don't sure if you can get null from there, but you have two
> lookup_state on that function
>
I navigated a bit the code and states->name of pinctrl->state should
be the offset five where you have the panic.
What is not clear is. If we iterate the map and we don't find the node
ret = pinctrl_dt_to_map(p, pctldev);
if (ret < 0) {
kfree(p);
return ERR_PTR(ret);
}
devname = dev_name(dev);
mutex_lock(&pinctrl_maps_mutex);
/* Iterate over the pin control maps to locate the right ones */
for_each_maps(maps_node, i, map) {
Then add_setting is not called and name is not assigned
Michael
> Michael
> >
> > Michael
> >
> > >
> > >
> > > [ 2.377386] Unable to handle kernel NULL pointer dereference at
> > > virtual address 0000000000000005
> > > [ 2.377390] Mem abort info:
> > > [ 2.377392] ESR = 0x0000000096000004
> > > [ 2.379529] EC = 0x25: DABT (current EL), IL = 32 bits
> > > [ 2.379994] SET = 0, FnV = 0
> > > [ 2.380263] EA = 0, S1PTW = 0
> > > [ 2.380538] FSC = 0x04: level 0 translation fault
> > > [ 2.380964] Data abort info:
> > > [ 2.381217] ISV = 0, ISS = 0x00000004
> > > [ 2.381343] mmc2: SDHCI controller on fe330000.mmc [fe330000.mmc]
> > > using ADMA
> > > [ 2.381558] CM = 0, WnR = 0
> > > [ 2.382426] [0000000000000005] user address but active_mm is swapper
> > > [ 2.382981] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> > > [ 2.383468] Modules linked in:
> > > [ 2.383740] CPU: 4 PID: 1 Comm: swapper/0 Not tainted 5.19.0-rc6+ #728
> > > [ 2.384311] Hardware name: 96boards Rock960 (DT)
> > > [ 2.384715] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS
> > > BTYPE=--)
> > > [ 2.385323] pc : pinctrl_lookup_state+0x20/0xc0
> > > [ 2.385729] lr : rockchip_i2s_probe+0x1a8/0x54c
> > > [ 2.386130] sp : ffff80000804bb30
> > > [ 2.386420] x29: ffff80000804bb30 x28: 0000000000000000 x27:
> > > ffff800009f204c8
> > > [ 2.387048] x26: ffff800009fc1060 x25: ffff800009fc1078 x24:
> > > ffff000002691b68
> > > [ 2.387673] x23: ffff800009967938 x22: ffffffffffffffed x21:
> > > ffff800009e1e0e8
> > > [ 2.388299] x20: ffffffffffffffed x19: ffff000002597480 x18:
> > > ffffffffffffffff
> > > [ 2.388924] x17: 000000040044ffff x16: 00400034b5503510 x15:
> > > ffff80008804b787
> > > [ 2.389550] x14: 0000000000000000 x13: 6c7274636e697020 x12:
> > > 73326920646e6966
> > > [ 2.390176] x11: 206f742064656c69 x10: 6166203a7332692e x9 :
> > > 656c696166203a73
> > > [ 2.390801] x8 : 32692e3030303061 x7 : 205d363238363733 x6 :
> > > ffff000001657880
> > > [ 2.391425] x5 : 0000000000000000 x4 : 0000000000000000 x3 :
> > > 0000000000000000
> > > [ 2.392051] x2 : 0000000000000000 x1 : ffff800009e1e0e8 x0 :
> > > ffffffffffffffed
> > > [ 2.392677] Call trace:
> > > [ 2.392892] pinctrl_lookup_state+0x20/0xc0
> > > [ 2.393261] rockchip_i2s_probe+0x1a8/0x54c
> > > [ 2.393629] platform_probe+0x68/0xe0
> > > [ 2.393954] really_probe.part.0+0x9c/0x2ac
> > > [ 2.394321] __driver_probe_device+0x98/0x144
> > > [ 2.394703] driver_probe_device+0xac/0x140
> > > [ 2.395070] __driver_attach+0xf8/0x1a0
> > > [ 2.395407] bus_for_each_dev+0x70/0xd0
> > > [ 2.395746] driver_attach+0x24/0x30
> > > [ 2.396063] bus_add_driver+0x150/0x200
> > > [ 2.396401] driver_register+0x78/0x130
> > > [ 2.396737] __platform_driver_register+0x28/0x34
> > > [ 2.397150] rockchip_i2s_driver_init+0x1c/0x28
> > > [ 2.397550] do_one_initcall+0x50/0x1c0
> > > [ 2.397890] kernel_init_freeable+0x208/0x28c
> > > [ 2.398274] kernel_init+0x28/0x13c
> > > [ 2.398583] ret_from_fork+0x10/0x20
> > > [ 2.398901] Code: aa0003f4 a9025bf5 aa0003f6 aa0103f5 (f8418e93)
> > > [ 2.399435] ---[ end trace 0000000000000000 ]---
> > > [ 2.399887] Kernel panic - not syncing: Attempted to kill init!
> > > exitcode=0x0000000b
> > > [ 2.400555] SMP: stopping secondary CPUs
> > > [ 2.400984] Kernel Offset: 0x80000 from 0xffff800008000000
> > > [ 2.401463] PHYS_OFFSET: 0x0
> > > [ 2.401716] CPU features: 0x800,00127811,00001082
> > > [ 2.402128] Memory Limit: none
> > > [ 2.402406] ---[ end Kernel panic - not syncing: Attempted to kill
> > > init! exitcode=0x0000000b ]---
> > >
> > >
> > > --
> > > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> > >
> > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> > > <http://twitter.com/#!/linaroorg> Twitter |
> > > <http://www.linaro.org/linaro-blog/> Blog
> > >
> > > _______________________________________________
> > > Linux-rockchip mailing list
> > > Linux-rockchip@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-rockchip
> >
> >
> >
> > --
> > Michael Nazzareno Trimarchi
> > Co-Founder & Chief Executive Officer
> > M. +39 347 913 2170
> > michael@amarulasolutions.com
> > __________________________________
> >
> > Amarula Solutions BV
> > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> > T. +31 (0)85 111 9172
> > info@amarulasolutions.com
> > www.amarulasolutions.com
>
>
>
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> michael@amarulasolutions.com
> __________________________________
>
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> info@amarulasolutions.com
> www.amarulasolutions.com
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
^ permalink raw reply [flat|nested] 20+ messages in thread