From: Steffen Maier <maier@linux.ibm.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>
Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Igor Rybak <igor@media-clone.com>,
Andrey Grodzovsky <andrey2805@gmail.com>,
Ezra Kohavi <ezra@media-clone.com>,
PDL-MPT-FUSIONLINUX <MPT-FusionLinux.pdl@broadcom.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v2)
Date: Tue, 24 Apr 2018 11:09:03 +0200 [thread overview]
Message-ID: <10db11e2-1e15-2b16-f5e6-81fbf2581683@linux.ibm.com> (raw)
In-Reply-To: <yq1k2cjw6dn.fsf@sermon.lab.mkp.net>
On 11/04/2016 05:35 PM, Martin K. Petersen wrote:
>>>>>> "Hannes" == Hannes Reinecke <hare@suse.de> writes:
>
> Hannes> Checking with SAT-3 (section 6.2.4: Commands the SATL queues
> Hannes> internally) the implemented behaviour is standards conformant,
> Hannes> although the standard also allows for returning 'TASK SET FULL'
> Hannes> or 'BUSY' in these cases. Doing so would nicely solve this
> Hannes> issue.
>
> I agree with Hannes that it would be appropriate for the SATL to report
> busy when it makes an non-queued command queueable.
Wouldn't this potentially still cause problems if the secure erase takes
longer than max_retries * scmd_tmo. I.e. the command timing out by
default after 180 seconds as in
https://www.spinics.net/lists/linux-block/msg24837.html ?
The fix approach here seems to also handle this gracefully.
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2018-04-24 9:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 12:43 [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination Andrey Grodzovsky
2016-10-30 12:43 ` Andrey Grodzovsky
2016-10-30 18:43 ` Hannes Reinecke
2016-10-30 18:43 ` Hannes Reinecke
2016-11-02 0:09 ` [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v2) Andrey Grodzovsky
2016-11-02 0:09 ` Andrey Grodzovsky
2016-11-02 2:07 ` Hannes Reinecke
2016-11-02 2:07 ` Hannes Reinecke
2016-11-02 10:05 ` Sreekanth Reddy
[not found] ` <CAJphD_qrQftfCOn_uzXCfdX=Xv9BYvVQ60AZ4DR2rc3gfXQa_Q@mail.gmail.com>
[not found] ` <30w645ulbhlofxrk1h4a9q3s.1478144944778@email.android.com>
2016-11-04 12:45 ` Sreekanth Reddy
2016-11-04 14:51 ` Hannes Reinecke
2016-11-04 16:35 ` Martin K. Petersen
2016-11-04 16:35 ` Martin K. Petersen
2018-04-24 9:09 ` Steffen Maier [this message]
2018-04-24 12:33 ` Hannes Reinecke
2016-11-05 13:17 ` Andrey Grodzovsky
2016-11-10 12:07 ` Sreekanth Reddy
2016-11-10 13:42 ` [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v3) Andrey Grodzovsky
2016-11-10 13:42 ` Andrey Grodzovsky
2016-11-10 13:54 ` Greg KH
2016-11-10 14:35 ` [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v4) Andrey Grodzovsky
2016-11-10 14:35 ` Andrey Grodzovsky
2016-11-11 4:38 ` Sreekanth Reddy
2018-04-23 18:28 ` Igor Rybak
2018-04-24 7:25 ` Greg KH
2016-11-12 15:29 ` Martin K. Petersen
2016-11-12 15:29 ` Martin K. Petersen
2016-11-12 16:36 ` Andrey Grodzovsky
2016-11-14 23:30 ` Martin K. Petersen
2016-11-17 1:15 ` [PATCH] [SCSI] mpt2sas: Fix secure erase premature termination Andrey Grodzovsky
2016-11-17 7:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10db11e2-1e15-2b16-f5e6-81fbf2581683@linux.ibm.com \
--to=maier@linux.ibm.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=andrey2805@gmail.com \
--cc=chaitra.basappa@broadcom.com \
--cc=ezra@media-clone.com \
--cc=hare@suse.de \
--cc=igor@media-clone.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=stable@vger.kernel.org \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.