All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hook, Gary" <ghook@amd.com>
To: "Mehta, Sohil" <sohil.mehta@intel.com>,
	"gary.hook@amd.com" <gary.hook@amd.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU
Date: Tue, 17 Apr 2018 13:36:33 -0400	[thread overview]
Message-ID: <10e422dd-a3ca-8ecb-50fa-e7f131a55a12@amd.com> (raw)
In-Reply-To: <1523663790.2747.4.camel@intel.com>

On 4/13/2018 7:55 PM, Mehta, Sohil wrote:
> On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote:
>>   
>>   
>> +struct dentry *iommu_debugfs_setup(void)
>> +{
>> +	if (!debugfs_initialized())
> 
> This check is probably not needed.

Ah, so it isn't. Thank you.

> 
>> +		return NULL;
>> +
>> +	if (!iommu_debugfs_dir)
>> +		iommu_debugfs_dir = debugfs_create_dir("iommu",
>> NULL);
>> +
>> +	if (iommu_debugfs_dir)
>> +		pr_warn("WARNING: IOMMU DEBUGFS SUPPORT HAS BEEN
>> ENABLED IN THIS KERNEL\n");
>> +
> 
> As this gets called for each IOMMU, do you want to use pr_warn_once?

That works, yes.

> 
>> +	return iommu_debugfs_dir;
>> +}
>> +EXPORT_SYMBOL_GPL(iommu_debugfs_setup);
> 
> -Sohil
> 

WARNING: multiple messages have this Message-ID (diff)
From: "Hook, Gary" <ghook-5C7GfCeVMHo@public.gmane.org>
To: "Mehta,
	Sohil" <sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"gary.hook-5C7GfCeVMHo@public.gmane.org"
	<gary.hook-5C7GfCeVMHo@public.gmane.org>,
	"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU
Date: Tue, 17 Apr 2018 13:36:33 -0400	[thread overview]
Message-ID: <10e422dd-a3ca-8ecb-50fa-e7f131a55a12@amd.com> (raw)
In-Reply-To: <1523663790.2747.4.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On 4/13/2018 7:55 PM, Mehta, Sohil wrote:
> On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote:
>>   
>>   
>> +struct dentry *iommu_debugfs_setup(void)
>> +{
>> +	if (!debugfs_initialized())
> 
> This check is probably not needed.

Ah, so it isn't. Thank you.

> 
>> +		return NULL;
>> +
>> +	if (!iommu_debugfs_dir)
>> +		iommu_debugfs_dir = debugfs_create_dir("iommu",
>> NULL);
>> +
>> +	if (iommu_debugfs_dir)
>> +		pr_warn("WARNING: IOMMU DEBUGFS SUPPORT HAS BEEN
>> ENABLED IN THIS KERNEL\n");
>> +
> 
> As this gets called for each IOMMU, do you want to use pr_warn_once?

That works, yes.

> 
>> +	return iommu_debugfs_dir;
>> +}
>> +EXPORT_SYMBOL_GPL(iommu_debugfs_setup);
> 
> -Sohil
> 

  reply	other threads:[~2018-04-17 17:36 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 13:17 [PATCH v3 0/2] Base enablement of IOMMU debugfs support Gary R Hook
2018-04-06 13:17 ` Gary R Hook
2018-04-06 13:17 ` [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU Gary R Hook
2018-04-06 13:17   ` Gary R Hook
2018-04-13 23:55   ` Mehta, Sohil
2018-04-13 23:55     ` Mehta, Sohil
2018-04-17 17:36     ` Hook, Gary [this message]
2018-04-17 17:36       ` Hook, Gary
2018-04-17 17:55       ` Robin Murphy
2018-04-17 17:55         ` Robin Murphy
2018-04-17 18:06         ` Hook, Gary
2018-04-17 17:46   ` Hook, Gary
2018-04-17 17:46     ` Hook, Gary
2018-04-17 18:13     ` Robin Murphy
2018-04-17 18:13       ` Robin Murphy
2018-04-06 13:17 ` [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Gary R Hook
2018-04-06 13:17   ` Gary R Hook
2018-04-14  0:08   ` Mehta, Sohil
2018-04-14  0:08     ` Mehta, Sohil
2018-04-17 17:38     ` Hook, Gary
2018-04-18  5:58       ` Yang, Shunyong
2018-04-18  5:58         ` Yang, Shunyong
2018-04-18  7:27         ` Mehta, Sohil
2018-04-18  7:27           ` Mehta, Sohil
2018-04-18  8:31           ` Yang, Shunyong
2018-04-18 20:16             ` Mehta, Sohil
2018-04-18 20:51               ` Hook, Gary
2018-04-18 20:51                 ` Hook, Gary
2018-04-19  1:52                 ` Yang, Shunyong
2018-04-30 19:57       ` Gary R Hook
2018-04-30 19:57         ` Gary R Hook
2018-04-17  0:52   ` Mehta, Sohil
2018-04-17  0:52     ` Mehta, Sohil
2018-04-17 17:42     ` Hook, Gary
2018-04-17 17:42       ` Hook, Gary
2018-04-17 18:05       ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10e422dd-a3ca-8ecb-50fa-e7f131a55a12@amd.com \
    --to=ghook@amd.com \
    --cc=gary.hook@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sohil.mehta@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.