* [PATCH BlueZ] unit: Fixed Mesh Crypto unit test build for LTO
@ 2019-11-05 22:58 Brian Gix
2019-11-07 17:23 ` Gix, Brian
0 siblings, 1 reply; 2+ messages in thread
From: Brian Gix @ 2019-11-05 22:58 UTC (permalink / raw)
To: linux-bluetooth; +Cc: brian.gix, inga.stotland
Was erroneously compiling and linking explicit unit test versions of the
ELL source dependancies while also linking with the library made from
same sources. The created Link Time Optimization (LTO) problems when
calling exit(), as there were two copies of the constructors and
destructors from ell/log.c.
---
Makefile.am | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 84c9712c9..8d419fb30 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -524,10 +524,8 @@ if MESH
unit_tests += unit/test-mesh-crypto
unit_test_mesh_crypto_CPPFLAGS = $(ell_cflags)
unit_test_mesh_crypto_SOURCES = unit/test-mesh-crypto.c \
- mesh/crypto.h ell/internal ell/ell.h \
- $(ell_sources)
-unit_test_mesh_crypto_LDADD = src/libshared-ell.la \
- $(ell_ldadd)
+ mesh/crypto.h ell/internal ell/ell.h
+unit_test_mesh_crypto_LDADD = $(ell_ldadd)
endif
if MAINTAINER_MODE
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH BlueZ] unit: Fixed Mesh Crypto unit test build for LTO
2019-11-05 22:58 [PATCH BlueZ] unit: Fixed Mesh Crypto unit test build for LTO Brian Gix
@ 2019-11-07 17:23 ` Gix, Brian
0 siblings, 0 replies; 2+ messages in thread
From: Gix, Brian @ 2019-11-07 17:23 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Stotland, Inga
Applied
On Tue, 2019-11-05 at 14:58 -0800, Brian Gix wrote:
> Was erroneously compiling and linking explicit unit test versions of the
> ELL source dependancies while also linking with the library made from
> same sources. This created Link Time Optimization (LTO) problems when
> calling exit(), as there were two copies of the constructors and
> destructors from ell/log.c.
> ---
> Makefile.am | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 84c9712c9..8d419fb30 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -524,10 +524,8 @@ if MESH
> unit_tests += unit/test-mesh-crypto
> unit_test_mesh_crypto_CPPFLAGS = $(ell_cflags)
> unit_test_mesh_crypto_SOURCES = unit/test-mesh-crypto.c \
> - mesh/crypto.h ell/internal ell/ell.h \
> - $(ell_sources)
> -unit_test_mesh_crypto_LDADD = src/libshared-ell.la \
> - $(ell_ldadd)
> + mesh/crypto.h ell/internal ell/ell.h
> +unit_test_mesh_crypto_LDADD = $(ell_ldadd)
> endif
>
> if MAINTAINER_MODE
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-07 17:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 22:58 [PATCH BlueZ] unit: Fixed Mesh Crypto unit test build for LTO Brian Gix
2019-11-07 17:23 ` Gix, Brian
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.