All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: dhowells@redhat.com, linux-integrity@vger.kernel.org,
	Mimi Zohar <zohar@linux.ibm.com>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	David Woodhouse <dwmw2@infradead.org>,
	keyrings@vger.kernel.org
Subject: Re: [PATCH v14 1/5] lib: add ASN.1 encoder
Date: Fri, 04 Dec 2020 13:40:18 +0000	[thread overview]
Message-ID: <111394.1607089218@warthog.procyon.org.uk> (raw)
In-Reply-To: <20201129222004.4428-2-James.Bottomley@HansenPartnership.com>

James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> +	*(data++) = _tagn(CONT, CONS, tag);

You might want to move the _tag() and _tagn() macros into linux/asn1.h so that
you don't need to include asn1_ber_bytecode.h.

But apart from that:

Reviewed-by: David Howells <dhowells@redhat.com>


  parent reply	other threads:[~2020-12-04 13:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-29 22:19 [PATCH v14 0/5] TPM 2.0 trusted key rework James Bottomley
2020-11-29 22:20 ` [PATCH v14 1/5] lib: add ASN.1 encoder James Bottomley
2020-12-04  4:43   ` Jarkko Sakkinen
2020-12-04  4:44     ` Jarkko Sakkinen
2020-11-29 22:20 ` [PATCH v14 2/5] oid_registry: Add TCG defined OIDS for TPM keys James Bottomley
2020-11-29 22:20 ` [PATCH v14 3/5] security: keys: trusted: fix TPM2 authorizations James Bottomley
2020-12-22 23:01   ` Ken Goldman
2020-12-23 19:58     ` James Bottomley
2021-01-04 21:56       ` Jarkko Sakkinen
2020-11-29 22:20 ` [PATCH v14 4/5] security: keys: trusted: use ASN.1 TPM2 key format for the blobs James Bottomley
2020-11-30  2:10   ` kernel test robot
2020-11-30  2:10     ` kernel test robot
2020-11-30 19:58     ` James Bottomley
2020-11-30 19:58       ` James Bottomley
2020-12-04  4:49       ` Jarkko Sakkinen
2020-12-04  4:49         ` Jarkko Sakkinen
2020-12-04  4:50         ` Jarkko Sakkinen
2020-12-04  4:50           ` Jarkko Sakkinen
2020-12-07 16:23           ` James Bottomley
2020-12-07 16:23             ` James Bottomley
2020-12-08 11:02             ` Jarkko Sakkinen
2020-12-08 11:02               ` Jarkko Sakkinen
2020-11-29 22:20 ` [PATCH v14 5/5] security: keys: trusted: Make sealed key properly interoperable James Bottomley
2020-12-04 13:40 ` David Howells [this message]
2020-12-04 13:44 ` [PATCH v14 2/5] oid_registry: Add TCG defined OIDS for TPM keys David Howells
2020-12-04 16:01   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=111394.1607089218@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dwmw2@infradead.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.