All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
	David Woodhouse <dwmw2@infradead.org>,
	keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v14 1/5] lib: add ASN.1 encoder
Date: Fri, 4 Dec 2020 06:44:20 +0200	[thread overview]
Message-ID: <20201204044420.GC84413@linux.intel.com> (raw)
In-Reply-To: <20201204044307.GB84413@linux.intel.com>

On Fri, Dec 04, 2020 at 06:43:14AM +0200, Jarkko Sakkinen wrote:
> On Sun, Nov 29, 2020 at 02:20:00PM -0800, James Bottomley wrote:
> > We have a need in the TPM2 trusted keys to return the ASN.1 form of
> > the TPM key blob so it can be operated on by tools outside of the
> > kernel.  The specific tools are the openssl_tpm2_engine, openconnect
> > and the Intel tpm2-tss-engine.  To do that, we have to be able to read
> > and write the same binary key format the tools use.  The current ASN.1
> > decoder does fine for reading, but we need pieces of an ASN.1 encoder
> > to write the key blob in binary compatible form.
> > 
> > For backwards compatibility, the trusted key reader code will still
> > accept the two TPM2B quantities that it uses today, but the writer
> > will only output the ASN.1 form.
> > 
> > The current implementation only encodes the ASN.1 bits we actually need.
> > 
> > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> Also:
> 
> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> I've successfully used this multiple times already.

Hmm... Does this need ack from anyone outside of TPM space?

/Jarkko

  reply	other threads:[~2020-12-04  4:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-29 22:19 [PATCH v14 0/5] TPM 2.0 trusted key rework James Bottomley
2020-11-29 22:20 ` [PATCH v14 1/5] lib: add ASN.1 encoder James Bottomley
2020-12-04  4:43   ` Jarkko Sakkinen
2020-12-04  4:44     ` Jarkko Sakkinen [this message]
2020-11-29 22:20 ` [PATCH v14 2/5] oid_registry: Add TCG defined OIDS for TPM keys James Bottomley
2020-11-29 22:20 ` [PATCH v14 3/5] security: keys: trusted: fix TPM2 authorizations James Bottomley
2020-12-22 23:01   ` Ken Goldman
2020-12-23 19:58     ` James Bottomley
2021-01-04 21:56       ` Jarkko Sakkinen
2020-11-29 22:20 ` [PATCH v14 4/5] security: keys: trusted: use ASN.1 TPM2 key format for the blobs James Bottomley
2020-11-30  2:10   ` kernel test robot
2020-11-30  2:10     ` kernel test robot
2020-11-30 19:58     ` James Bottomley
2020-11-30 19:58       ` James Bottomley
2020-12-04  4:49       ` Jarkko Sakkinen
2020-12-04  4:49         ` Jarkko Sakkinen
2020-12-04  4:50         ` Jarkko Sakkinen
2020-12-04  4:50           ` Jarkko Sakkinen
2020-12-07 16:23           ` James Bottomley
2020-12-07 16:23             ` James Bottomley
2020-12-08 11:02             ` Jarkko Sakkinen
2020-12-08 11:02               ` Jarkko Sakkinen
2020-11-29 22:20 ` [PATCH v14 5/5] security: keys: trusted: Make sealed key properly interoperable James Bottomley
2020-12-04 13:40 ` [PATCH v14 1/5] lib: add ASN.1 encoder David Howells
2020-12-04 13:44 ` [PATCH v14 2/5] oid_registry: Add TCG defined OIDS for TPM keys David Howells
2020-12-04 16:01   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201204044420.GC84413@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=dhowells@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.